5243 Commits

Author SHA1 Message Date
Dan Field
5c07e6dff7
fix analyzer (#22273) 2018-09-25 14:29:09 -04:00
Dan Field
ea5435c2ef
Widgets app refactor (#22269)
* Refactor of cupertino/material/widgets app

* update docs 

* Update tests for const
2018-09-25 13:57:12 -04:00
Hans Muller
582f35dfb1
PageTransitionsTheme, new MountainView page transition (#21715)
MaterialPageRoute transitions are now defined by the Theme. Added (optional) support for Android P style page transitions.
2018-09-25 10:56:29 -07:00
Dan Field
a52bd81560
Revert "Refactor of cupertino/material/widgets app (#22161)" (#22249)
This reverts commit 61cf946ba8c55c73c9119a203d07b8c025b6aa92.
2018-09-25 00:25:50 -04:00
Dan Field
61cf946ba8
Refactor of cupertino/material/widgets app (#22161)
* Make CupertinoApp and MaterialApp both use WidgetsApp for Navigator

* Make CupertinoApp and MaterialApp const constructors

* Make WidgetsApp routes aware

* Update tests
2018-09-24 23:55:03 -04:00
Jacob Richman
6776352f64 Only register WidgetInspectorService extension in debug builds. (#22238) 2018-09-24 17:24:33 -07:00
creativecreatorormaybenot
27d9004506 Added multiple Cupertino icons (#21656) 2018-09-24 16:48:20 -07:00
Michael Klimushyn
efbd6f604f
Update docs on various platform APIs (#22060) 2018-09-24 15:17:54 -07:00
Ian Hickson
6d134e0c86
Animation API improvements (#21540) 2018-09-23 00:43:05 -07:00
Devon Carew
762c86995d
expose the debugProfileBuildsEnabled flag as a service extension (#21492)
* expose the debugProfileBuildsEnabled flag as a service extension

* fix tests

* review comments

* remove a new keyword

* test fixes

* review comments
2018-09-22 14:44:09 -07:00
Ian Hickson
989cf18b0d
[H] Cleanup (#21542)
* Improve documentation and clean up code.

* Remove "Note that".

The phrase "note that" is basically meaningless as a prefix to an
otherwise fine sentence.
2018-09-22 02:02:56 -07:00
Gary Qian
449e3c2a0a
Roll engine 2e8e96fad1..a8890fdccd667 and fix paragraph tests (#22111) 2018-09-20 19:46:50 -07:00
Yegor
833540972f
add a test for single- and multi-line paragraph layout (#22047)
* add a test for single- and multi-line paragraph layout

* use flutter_test

* use closeTo for double comparison
2018-09-20 16:44:19 -07:00
Michael Klimushyn
36b735eeb2
Fix WidgetApp.title documentation (#22011)
Closes #16031
2018-09-19 15:39:02 -07:00
Jonah Williams
85b4670b2a
Revert "Implement Double Tap Handling in TextField and Editable" (#22051)
* Revert "Revert "Add RichText support to find.text" (#22046)"

This reverts commit 8e704219138147bc0a46e9547cbe6519cf0bb6c7.

* Revert "Implement Double Tap Handling in TextField and Editable (#21264)"

This reverts commit 02e87334ddb9f64a2ff12c0dc201f3e410e74be7.
2018-09-19 14:59:23 -07:00
Niko Yuwono
02e87334dd Implement Double Tap Handling in TextField and Editable (#21264)
Thanks @NikoYuwono for getting this working! We appreciate your help!

* Implement Double Tap Handling in TextField and Editable

* Fix test broken by the change and add test for double tap

* Fix affected tests

* Remove unnecessary new

* Fix test
2018-09-19 13:35:33 -07:00
Renan
74e93e4c5c Make ScaleGestureRecognizer detect pointer rotation (#17345) 2018-09-19 11:48:41 -07:00
sir-boformer
3c22d7b025 clarify how to display an image with a specific density (#21152)
Closes #18679
2018-09-18 16:29:52 -07:00
Jonah Williams
bf7c27095c
Make helper and error text separate widgets, make error and counter live region (#21752) 2018-09-18 13:39:21 -07:00
Jacob Richman
ccd070a5b4
Add back screenshot extension that was temporarily disabled. (#21828)
Add back screenshot extension that was temporarily disabled.

Add matchesReferenceImage matcher to test that the screenshot extension
generates equivalent images to InspectorService.instance.screenshot.
2018-09-18 09:32:39 -04:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors (#21934) 2018-09-18 05:54:03 +02:00
Jason Simmons
6f435b286e
Stop the animation controller if a CircularProgressIndicator is determinate (#21832)
Fixes https://github.com/flutter/flutter/issues/21445
2018-09-17 10:08:27 -07:00
liyuqian
1ad538e454
Fix the @macro link in doc (#21890)
Is it possible to add a unit test to make sure that all links in our
Dart doc are valid?
2018-09-14 16:47:28 -07:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Michael Goderbauer
dda7382e49
Fix the the (#21732) 2018-09-14 12:42:20 +02:00
Mehmet Fidanboylu
2895d71b79
Make Flutter repo Dart SDK 2.1-dev3.1 compatible (#21853)
This is a blocker for Google roll since we are not at dev4.0:
- Future is not yet part of dart:core.
- Future.sync().then<dynamic>... causes failure without the new keyword.
2018-09-13 18:50:21 -07:00
liyuqian
069cddaa67
Missing default hardEdge clip for ClipRectLayer (#21826)
In my local tests, this should finally fix https://github.com/flutter/flutter/issues/21617
2018-09-13 11:42:49 -07:00
Jonah Williams
9bf8502fef
Add debug check for localization parent (#20787) 2018-09-13 10:47:31 -07:00
Hans Muller
d107ff9d48
Make TabBar's tab label padding configurable (#21758) 2018-09-13 08:59:00 -07:00
Gary Qian
28ba95abb1
Default clipBehavior of ClipRect to hardEdge. (#21703)
Previously, the engine did not properly pass the AA flag on ClipRect.clipBehavior. flutter/engine#6199 fixes this and enables AA. However, default AA on clipRects has caused severe regressions in benchmark performance.

To maintain expected performance, we should now default the clipBehavior to hardEdge to disable default AA. This is consistent with any flutter projects that did not previously explicitly set the clipBehavior and should not change app appearance.
2018-09-13 00:32:12 -07:00
Jonah Williams
23499f4004
Fix typo in MediaQuery.fromWindow and add invertColors flag to images for smart invert. (#21457) 2018-09-12 14:50:49 -07:00
Jonah Williams
5ea987db1d
Adjust floating label height when font size is larrrrgeee (#21248) 2018-09-12 14:17:43 -07:00
Jonah Williams
dd1c22e389
fix_some_padding (#20967) 2018-09-12 14:07:02 -07:00
Jacob Richman
29fae06f48
Temporarily remove screenshot service extension that is causing code size issues (#21749)
* Revert "Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648)"

This reverts commit eeebd8332a5f4f5c79a9c77877781d7f1132d57b.

* Remove inspector screenshot service extension.
2018-09-12 13:30:16 -07:00
Ben Hagen
07dd80712e Call setState() (#21642) 2018-09-12 14:31:50 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Alexandre Ardhuin
387948a239
remove an avoid_void_async lint (#21672) 2018-09-11 08:51:42 +02:00
Alexandre Ardhuin
774ca2f197
enable lint avoid_void_async (#21652) 2018-09-11 07:14:04 +02:00
Dan Field
98ad574d9b
Fix keepalive for large jumps on tabs and lists. (#21350)
* Ensure that the _childElements map is properly traversed as a sparse list and not inflated with garbage collected children.

* Add tests to ensure Lists/Tabs with KeepAlive children can make large jumps, don't lose children (including after rebuild).
2018-09-10 21:01:10 -04:00
Jacob Richman
eeebd8332a
Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648) 2018-09-10 15:20:22 -07:00
jslavitz
9dce4b8259
Shortcuts (#21558)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes

* random change

* changed function to void

* one more

* removed line

* dis betta work

* final change

* actual final chnge
2018-09-10 13:47:04 -07:00
Michael Klimushyn
8ebd352511
Add semantic routing to CupertinoAlertDialog (#21583)
Fixes #21250
2018-09-10 13:15:55 -07:00
Gary Qian
d3e36807fe
Update goldens, and new Golden test for ClipRect (#21575) 2018-09-10 10:46:52 -07:00
Will Larche
c8ecae6935
[Material] Corrects default inactive switch track color (#21405)
* [Material] Corrects default switch color.

* [Switch] Making black32 a local const.

* [Switch] Tests for default colors.

* [Switch] Correcting number for being over 255.
2018-09-10 12:00:16 -04:00
Hans Muller
ed698b8165
Remove inheritFromElement assert, it can fail during deactivation (#21570) 2018-09-07 16:46:44 -07:00
Jonah Williams
3821c35d04
Ensure that textDirection is always passed to ShapeBorder.getOuterPath (#21532) 2018-09-07 14:38:14 -07:00
Michael Klimushyn
9a290c174a
Expand DropdownButton width based on isExpanded flag (#21515)
* Fix Dropdown where icon not set to end of button

* Expand DropdownButton based on isExpanded flag

* Add dropdown golden tests

Fixes #13135, #16606
2018-09-07 14:01:21 -07:00
Jonah Williams
11943ce7e7
Revert "Shortcuts (#21083)" (#21556)
This reverts commit 6e7f3e6f5a11341edd5c2519cbe1c7bc178cb8e9.
2018-09-07 10:36:52 -07:00
jslavitz
6e7f3e6f5a
Shortcuts (#21083)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes
2018-09-07 10:28:35 -07:00
Jacob Richman
a2acc6a3e5
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)" (#21448)
This reverts commit 5b5a5b82286923f52225320f5e9fc9f558838c05.
2018-09-07 10:02:05 -07:00