4305 Commits

Author SHA1 Message Date
Kaushik Iska
916f9bcab5 Fix layer tree snapshot values (flutter/engine#33753) 2022-06-01 10:18:05 -07:00
moko256
601e178945 [Windows] Google Japanese Input, composing text doesn't rendered after commit text partially (flutter/engine#33605)
Reproducible steps is in flutter/flutter#102021.

Fixes flutter/flutter#102021.

No changes in [flutter/tests] repo.
2022-05-31 18:01:55 -07:00
Chris Yang
d303a310a6 PlatformView to set the correct overlay view frame, merge thread at the endFrame (flutter/engine#33262) 2022-05-31 14:42:34 -07:00
Tong Mu
78adf103bf Reland No.2 "Hardware Keyboard: Android" (flutter/engine#33686)
* Original code

* Changes

* Fix and test

Better formatted tests
2022-05-31 13:00:39 -07:00
Shivesh Ganju
3cfb7658cc [fuchsia] Fix precision errors occuring in layer tree frame size. (flutter/engine#33669)
This PR fixes the precision error which occurs when casting a double to int32, causing an incorrect physical display size to be propagated in
the layer tree ultimately causing input events on the left edge of the
display to be dropped.
2022-05-31 09:42:25 -07:00
Naud Ghebre
a84b408f8d Dart test runner: Pass name of the test dart component to test_manager via tast_case (flutter/engine#33665) 2022-05-29 01:20:23 -04:00
hellohuanlin
5bbb2437e2 Add focus support for platform view (flutter/engine#33093) 2022-05-27 23:33:02 -07:00
Chris Bracken
56fbdd0232 [lint] Enforce k prefix for global constants (flutter/engine#33666)
Enforces that all global constants are prefixed with a 'k' as per the
style guide and updates the codebase into conformance where necessary.

This does not change any public API.

Additional testing provided by the addition of the lint rule.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-27 18:33:38 -07:00
J-P Nurmi
f35001f852 [Linux] fix typos in FlAccessibleNode docs (flutter/engine#32651) 2022-05-27 13:28:31 -07:00
Chris Bracken
2b84fdf8cb [macOS] Document onKeyboardLayoutChanged (flutter/engine#33663)
Replaces a TODO with documentation. No tests changed, since this change
simply adds a missing doc comment.
2022-05-27 12:48:10 -07:00
Shivesh Ganju
61a5c8873c [fuchsia] remove Fuchsia-specific kVsyncTraceName from VsyncWaiter. (flutter/engine#33519)
This CL changes the vsync trace name to "VsyncProcessCallback". The
benchmarks in fuchsia currently support "VsyncProcessCallback" and "vsync callback". After this change, support for "vsync callback" can be safely removed from fuchsia benchmarks.

Test: fx test host_x64/knowledge_card_test

Bug: 73367
2022-05-27 12:04:12 -07:00
Michael Goderbauer
782679ce66 Move platform-specific stuff from macOS FVC to FlutterEngine (flutter/engine#33234) 2022-05-27 09:56:28 -07:00
moko256
94fa5033bf [Windows] Pass a function which returns ScopedClipboardInterface instead of ScopedClipboardInterface to PlatformHandlerWin32 (flutter/engine#33609) 2022-05-27 04:33:04 -07:00
Chris Yang
bf761b4c12 Fix test: make sure end_frame_latch is signaled after accessing the used_this_frame flag (flutter/engine#33649) 2022-05-26 20:02:20 -07:00
Emmanuel Garcia
f4887a67d3 Fix Android platform view resize and direction in nested layouts. (flutter/engine#33645) 2022-05-26 19:50:04 -07:00
Chris Bracken
19696ceb2e [macOS] Fix some incorrectly-named string constants (flutter/engine#33647)
Renames from `FooBarBaz` to `kFooBarBaz` in line with style guide.

No tests since no functional changes are being made.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-26 18:37:58 -07:00
Chris Yang
190118f789 Set UsedThisFrame before EndFrame (flutter/engine#33627) 2022-05-26 14:10:04 -07:00
J-P Nurmi
12ac248051 [Linux] FlTextInputPlugin: use FlView as GTK IM client window (flutter/engine#33111)
GTK IM operates in [coordinates relative to its client window](https://docs.gtk.org/gtk3/method.IMContext.set_cursor_location.html#:~:text=The%20location%20is%20relative%20to%20the%20client%C2%A0window.). Let GTK
IM use the native window that backs FlView, which is the same native
window that is used for key event processing - see GDK_KEY_XXX_MASK in
fl_view_realize().

This is an important step towards testable FlTextInputPlugin because it
eliminates the depency to GtkWidget's coordinate translation API and
that way paves the road for replacing FlTextInputPlugin's FlView
instance with a plain GdkWindow. In tests, that window can be an
instance of GdkOffscreenWindow.

There are no tests included yet but after a few more refactoring steps
it will be possible to execute tests like this: [fl_text_input_plugin_test.cc](f2e0d91b59/shell/platform/linux/fl_text_input_plugin_test.cc).
The other refactoring steps are visible at [jpnurmi/engine/commits/text-input-plugin](https://github.com/jpnurmi/engine/commits/text-input-plugin).
2022-05-26 13:08:06 -07:00
Sophie Winter
86379d5cb3 Force GTK IM context to initialize at start (flutter/engine#32118)
Fixes https://github.com/flutter/flutter/issues/100385
2022-05-26 13:07:34 -07:00
Zachary Anderson
8e85a8d270 Fixes a few asan errors (flutter/engine#33632) 2022-05-26 07:29:50 -07:00
Kaushik Iska
796e65f687 Layer snapshots also contain bounds information (flutter/engine#33615) 2022-05-25 11:43:04 -07:00
Jason Simmons
6714554f40 Pass the --enable-skparagraph=false flag if the EnableSkParagraph manifest metadata value is false (flutter/engine#33597) 2022-05-25 10:38:02 -07:00
Alexander Biggs
c99c1e532d [fuchsia] Fix bad DCHECKs. (flutter/engine#33593)
We didn't catch these because the --unopt build was broken for about
a year and not well-tested.

The --unopt build was recently repaired in https://github.com/flutter/engine/pull/32502.
2022-05-24 13:56:21 -07:00
Tong Mu
861b51a5a1 Revert "Reland "Hardware Keyboard: Android" (#33567)" (flutter/engine#33589)
This reverts commit 8cb40595dc05cd094a1cc27ede4ab59d19365070.
2022-05-24 11:02:28 -07:00
Tong Mu
8cb40595dc Reland "Hardware Keyboard: Android" (flutter/engine#33567) 2022-05-24 09:49:23 -07:00
Chinmay Garde
a35efe4636 [impeller] OpenGL: Add support for threads and contexts. (flutter/engine#33575) 2022-05-23 20:38:01 -07:00
Chris Yang
3720c4dff0 Revert "iOS spell-checker ObjC" (flutter/engine#33570) 2022-05-23 19:08:05 -07:00
Callum Moffat
bef8075011 Linux trackpad gestures (flutter/engine#31592) 2022-05-23 16:53:06 -07:00
Nils Reichardt
3600d3c97e Fix typo "SetTestFluttterStub", "FluttterActivity" and "implementantions" (flutter/engine#33551)
As recommended in https://github.com/flutter/engine/pull/33547#issuecomment-1134077565, I fixed all typos in one PR.

Fixes https://github.com/flutter/flutter/issues/104366
Fixes https://github.com/flutter/flutter/issues/104367
Fixes https://github.com/flutter/flutter/issues/104368
Fixes https://github.com/flutter/flutter/issues/104369
Fixes https://github.com/flutter/flutter/issues/104370
2022-05-23 13:24:48 -07:00
Dacian Florea
222b241e26 Update "unregistered_view_type" error message (flutter/engine#33450) 2022-05-23 13:08:05 -07:00
moko256
5bf7ff5530 [Windows] Add textScaleFactor support (flutter/engine#33316) 2022-05-23 18:10:15 +02:00
Dan Field
a73d5b5fbe Reland Enable MSAA behind a flag for iOS (flutter/engine#33505) 2022-05-19 23:58:05 -07:00
Tong Mu
a8696c0ef2 Revert "Hardware Keyboard: Android (#33113)" (flutter/engine#33507)
This reverts commit 2555d53f05a058bd20c290ab44eaaf11f02afc73.
2022-05-19 23:28:33 -07:00
Callum Moffat
9e131c3069 Win32 trackpad gestures (flutter/engine#31594) 2022-05-19 20:53:04 -07:00
Tong Mu
2555d53f05 Hardware Keyboard: Android (flutter/engine#33113)
* Impl

* First test passed

* Runnable and more tests

* Use constants

* static import

* modifier keys

* nonUsKeys

* order test, duplicate/abrupt test

* Synthesize pressing keys

* WIP

* New sync algorithm

* Sync with synonym

* Add all pressing goals and mask constants

* Test all modifiers

* Add tests for capslock

* Gen

* Docs

* mutable

* Extract CharacterCombiner, docs

* doc

* License

* Doc for keydata

* Apply suggestions from code review

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

* Use &

* Format

* Fix tests

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2022-05-19 15:03:42 -07:00
Chris Yang
8bbe46106a iOS spell-checker ObjC (flutter/engine#32941) 2022-05-19 12:28:06 -07:00
Dan Field
ad60da5e59 Guard impeller references in platform_view_android.cc for google build (flutter/engine#33487) 2022-05-19 12:10:42 -07:00
Dan Field
fd6330c745 Revert "Enable MSAA behind a command line flag for iOS (#33461)" (flutter/engine#33481)
This reverts commit ce9f6b2e43e2d88934345ac96bcb366a144b3408.
2022-05-19 09:23:58 -07:00
moko256
ca8a710c6c Win32: Send mouse leave event with last position (flutter/engine#32147)
* Win32: Send mouse leave event with last position

* reformat code
2022-05-19 15:26:54 +02:00
Alex
c7abd6a8a8 Windows: Prevent platform thread from deadlocking during window resize (flutter/engine#33478) 2022-05-19 13:32:55 +02:00
Chase Latta
6a1def3db7 [revert] Convert Gfx PlatformView to use modern TouchSource API (flutter/engine#33471) 2022-05-18 18:52:04 -07:00
Dan Field
ce9f6b2e43 Enable MSAA behind a command line flag for iOS (flutter/engine#33461) 2022-05-18 17:07:05 -07:00
Chris Bracken
e4908e796f [Windows] Unused include cleanup in ViewController (flutter/engine#33466)
Eliminates two unused includes in the client wrapper view controller
header. These were introduced in a382232 and c66d5e6, usage was
deprecated in e297b7d and removed in 1cb8585.

No test changes since no semantic changes; just the removal of
header #includes that are no longer used in this file.
2022-05-18 14:34:06 -07:00
Naud Ghebre
d11e96acfe [dart_component][hello_world] Add a hello world dart component. Following PRs will incorporate this in an integration test (flutter/engine#33465) 2022-05-18 17:30:57 -04:00
Camille Simon
bdca9fb447 Correct SpellCheckChannel Javadoc (flutter/engine#33398) 2022-05-18 10:37:05 -07:00
Zachary Anderson
79bb017c96 Parse impeller setting from the bundle on Android (flutter/engine#33442) 2022-05-18 08:33:50 -07:00
Chinmay Garde
7df5e81ea8 [impeller] Wire up the OpenGL ES Backend. (flutter/engine#33405) 2022-05-17 13:16:25 -07:00
Camille Simon
37b70b4abf Remove annotation for getLocaleFromString() (flutter/engine#33409) 2022-05-17 12:52:04 -07:00
Chase Latta
aa8e5200a1 fix missing forward of defines in dart_runner build (flutter/engine#33412) 2022-05-17 09:34:28 -07:00
Jaeheon Yi
365acedc40 Set error handler (flutter/engine#33402) 2022-05-16 20:22:04 -07:00