3060 Commits

Author SHA1 Message Date
Hans Muller
187c89b69d
Remove accentTextTheme from sliders and chips, tests and docs (#46801) 2019-12-12 15:14:01 -08:00
Dan Field
948e2b0101 Avoid exceptions for control flow (#46897) 2019-12-12 13:53:01 -08:00
Lau Ching Jun
be53bc14aa
Reset the global variable before running a test. (#46203)
The variable debugDisableShadows wasn't reset before each test, so the
output of the test is different depending on whether the previous test
has passed.
2019-12-12 10:37:42 -08:00
Lau Ching Jun
535526b03c
Enable web for some of the golden tests (#46820)
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
2019-12-12 10:36:41 -08:00
Taufiq Rahman
c5f61ac3e8 Feature: ExpandIcon should use the size parameter (#45712)
* ExpandIcon should use the size parameter
2019-12-10 15:18:56 -05:00
Sebastian Döll
645c32311e Set modal bottom sheet barrier color (#45067) 2019-12-10 10:07:32 -08:00
Anthony
8a205f8194
Revert "Made the behavior for caching large images modular. (#46010)" (#46629)
This reverts commit 86dd664feffa1dc32d51845f1dbe82c3b15093bf.
2019-12-10 11:44:52 -05:00
Jonah Williams
81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Tong Mu
ad20d368ff Fix null event crash in TapGestureRecognizer (#45943) 2019-12-05 19:33:01 -08:00
Greg Spencer
bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Greg Spencer
e3005e6962
Fixes Focus and FocusScope's assignment of canRequestFocus. (#46168)
This fixes an issue where lines like this:

    focusNode.canRequestFocus = widget.canRequestFocus ?? focusNode.canRequestFocus;

Were causing the canRequestFocus bit to copy the status of the enclosing scope, since canRequestFocus also looks to the enclosing scope to decide if it can focus.
2019-12-05 15:33:05 -08:00
Chris Bracken
fa0c49d775
Dispatch hover events to PlatformViewController (#46124)
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
2019-12-05 13:31:50 -08:00
gaaclarke
86dd664fef
Made the behavior for caching large images modular. (#46010)
Introduced LargeImageHandler to ImageCache class.
2019-12-05 12:46:59 -08:00
Greg Spencer
c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Tong Mu
f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Greg Spencer
f7d1616173
Overridable default platform key bindings (#45102)
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
2019-12-04 16:07:01 -08:00
Greg Spencer
09927b94c3
Add a VisualDensity manual test (#46083)
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
2019-12-04 10:48:06 -08:00
Alexandre Ardhuin
166d422b05
implicit-casts:false in flutter/lib/src/widgets (#45728)
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
2019-12-04 09:43:54 +01:00
Alexandre Ardhuin
1c7a1c3873
implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
Sebastian Döll
417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Greg Spencer
185da9b0af
Add Density API to ThemeData, implement for buttons. (#43547)
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
2019-12-03 19:49:56 -08:00
Michael Goderbauer
1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Greg Spencer
37f86c3195
Clean up some things I noticed while doing another change (#45658)
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Kate Lovett
cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cdb70c77368c04aaed39ca4791cad539.
2019-12-02 15:08:35 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Tong Mu
afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Gary Qian
d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d794360bb7d3ff7bf2f6dfbcbd58516c3f20.
2019-11-28 19:42:06 +09:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
liyuqian
264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
LongCatIsLooong
37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Dan Field
2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00
Albertus Angga Raharja
e1512b4dd7
Add additional properties callback in Inspector Serialization Delegate (#45531)
* Add additional properties callback in Inspector Serialization Delegate

* Rename _SerializationDelegate to InspectorSerializationDelegate and add test

* Fix indentation

* Remove trailing whitespace

* Handle case when addAdditionalPropertiesCallback returns null

* Improve docs and minor renames

* Improve docs

* Improve documentation
2019-11-26 13:57:41 -08:00
Greg Spencer
0190e40457
Keyboard scrolling of Scrollable (#45019)
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
2019-11-26 09:56:25 -08:00
Kate Lovett
8a48a27847
Performance Improvement for SliverFillRemaining (#44471) 2019-11-26 08:04:22 -08:00
Kate Lovett
cd94cd886a
SliverOffstage Fix (#45580) 2019-11-26 08:01:03 -08:00
Dan Field
e766ae740e
Automatically caching viewport (#45327) 2019-11-25 21:05:46 -08:00
Greg Spencer
46632f9edc
Handle bare modifier flags on macOS (#45438)
This fixes an unreported bug in the macOS key handling where for some remote access situations, the modifier mask is set to the "any modifier" mask without any side specified (e.g. modifierShift bit is specified and not modifierLeftShift bit).
2019-11-25 17:06:16 -08:00
Kate Lovett
d0ea9ed244
SliverOffstage (#45128) 2019-11-25 12:49:10 -08:00
Kate Lovett
1160c8fd29
Re-Staged: Fixing ContinuousRectangleBorder bottom radius (#45304) 2019-11-25 12:43:58 -08:00
Jonah Williams
cf37c2cd07
Add assert for negative child count in ListView.builder (#45506) 2019-11-25 12:04:30 -08:00
Takeshi Tsukamoto
a3eeb51a1b Fix draggable scrollable sheet scroll notification (#45083) 2019-11-22 21:48:38 -08:00
chunhtai
f15f69a8b8
Drops detached message until we can handle it properly (#45430) 2019-11-22 16:10:46 -08:00
Kate Lovett
e2cf2f0fa2
SliverOpacity (#44289) 2019-11-22 11:12:09 -08:00
Kate Lovett
9f17a43ebe
SliverIgnorePointer (#45127) 2019-11-22 09:54:09 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00