DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,700 Commits 882 Branches 1,069 Tags
Commit Graph

22748 Commits

Author SHA1 Message Date
Brandon DeRosier
c85223dc95 [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152) 
Similar to Metal, have the DL cull entities early that lie entirely
outside the surface texture.
 2023-06-24 15:46:14 -07:00
Brandon DeRosier
03816b412c [Impeller] Disable blending for Source blend mode (flutter/engine#43162) 
All of the backends already respect this property for the first color
attachment in the pipeline. ~~Our Vulkan backend disables blending for a
whole pipeline if the first color attachment has blending turned off.~~
This has been under our nose but I haven't checked it until now.

HSR might not be working on some Vulkan & OpenGLES drivers because of
this.
 2023-06-24 10:30:12 -07:00
skia-flutter-autoroll
050b692717 Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178) 
https://skia.googlesource.com/skia.git/+log/1826cbacd4da..18a947ed2253

2023-06-24 johnstiles@google.com Fix assertion discovered by fuzzer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 17:23:56 +00:00
skia-flutter-autoroll
66279d4f41 Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 13:21:04 +00:00
skia-flutter-autoroll
290ae5bafd Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175) 
https://skia.googlesource.com/skia.git/+log/050d2ad6dda3..1826cbacd4da

2023-06-24 johnstiles@google.com Revert "Add `applyRoundingHack` to `ParagraphStyle`"
2023-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 74755bf0105b to 64063dd24912

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 08:08:11 +00:00
skia-flutter-autoroll
81596dbe20 Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171) 
https://skia.googlesource.com/skia.git/+log/ef64a8c132c4..050d2ad6dda3

2023-06-24 johnstiles@google.com Add _Pragma("unroll") to SkRP ops.
2023-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 994861071dc5 to 725a2de9da00 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 03:16:15 +00:00
skia-flutter-autoroll
31c68022dc Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170) 
https://skia.googlesource.com/skia.git/+log/3d9732b86456..ef64a8c132c4

2023-06-24 armansito@google.com [graphite] AtlasShapeRenderStep
2023-06-24 johnstiles@google.com Push single slots from an immutable variable as constants.
2023-06-24 johnstiles@google.com Store immutable data as scalars in memory.
2023-06-24 johnstiles@google.com Allow immutable variables to reuse preexisting data.
2023-06-24 johnstiles@google.com Segregate immutable values into a separate slot group.
2023-06-24 johnstiles@google.com Introduce new SkRP op for direct immutable copies.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 02:03:32 +00:00
godofredoc
f802b94048 Add docs for magic variables. (flutter/engine#43121) 
Adds documentation for env variable substitution in test execution.

Bug: https://github.com/flutter/flutter/issues/129280

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-24 02:01:58 +00:00
skia-flutter-autoroll
cd0e7efa06 Roll Skia from 8818761fbc84 to 3d9732b86456 (4 revisions) (flutter/engine#43167) 
https://skia.googlesource.com/skia.git/+log/8818761fbc84..3d9732b86456

2023-06-23 johnstiles@google.com Introduce a new SkRP builder op for indirect immutable copies.
2023-06-23 johnstiles@google.com Add an ImmutableLValue class to SkRP.
2023-06-23 jvanverth@google.com [graphite] Set up transfers for asyncReadPixelsYUV420.
2023-06-23 armansito@google.com [graphite] AtlasShape Geometry type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-24 00:44:50 +00:00
Brandon DeRosier
85b2589b20 [Impeller] Label present waiter command buffer in SurfaceMTL (flutter/engine#43165) 
Just to curb confusion and make it searchable. I double-take this lingering command buffer in frame captures quite a bit.
 2023-06-23 23:59:33 +00:00
Tamir Duberstein
f7d1aada2e Add tmp storage capability to flutter runner (flutter/engine#43157) 
Missed in fd56ab9e4475893d94e3a45ea5d5b3374bd74447.
 2023-06-23 16:33:42 -07:00
skia-flutter-autoroll
119589b5f6 Roll Skia from c53a952a2dab to 8818761fbc84 (5 revisions) (flutter/engine#43164) 
https://skia.googlesource.com/skia.git/+log/c53a952a2dab..8818761fbc84

2023-06-23 johnstiles@google.com Add new SkRP builder op `push_immutable`.
2023-06-23 brianosman@google.com Fix compilation when SK_ENABLE_SKSL_IN_RASTER_PIPELINE is undefined
2023-06-23 armansito@google.com [viewer] Support scroll-wheel zoom
2023-06-23 robertphillips@google.com Add Graphite support to tiled image drawing unit test
2023-06-23 robertphillips@google.com Add SkCanvasPriv::DeviceClipBounds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 23:33:19 +00:00
skia-flutter-autoroll
a973aed560 Roll Skia from d53ea1557b35 to c53a952a2dab (1 revision) (flutter/engine#43156) 
https://skia.googlesource.com/skia.git/+log/d53ea1557b35..c53a952a2dab

2023-06-23 johnstiles@google.com Fix line wrapping past 100 columns.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 21:09:55 +00:00
skia-flutter-autoroll
6e735951b9 Roll Fuchsia Linux SDK from VSKvLPB4DCIDvXzOA... to b5PDBUm8Hfx-y9Hsp... (flutter/engine#43155) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 20:52:50 +00:00
Hassan
d4889c682d [web] - Fix for Safari partially autofilling form (flutter/engine#43058) 
We have an issue where autofill in Safari Desktop is only partially autofilling the form.  The only input that gets filled is the currently focused one. 

This is happening for a couple of reasons:
- We hide non-focused inputs that are part of the autofill form by sizing them to 0px height and width, among other styles.
- This doesn't cause issues in most browsers.  However, Safari does not respect offscreen or 0-sized inputs, and this leads to the partial form autofill issue. 

The solution is to make sure we hide the inputs in the rest of the form from the users, without hiding it from Safari. 

Fixes https://github.com/flutter/flutter/issues/71275
 2023-06-23 20:19:37 +00:00
skia-flutter-autoroll
27385264f6 Roll Skia from 7b6aae68a11f to d53ea1557b35 (1 revision) (flutter/engine#43153) 
https://skia.googlesource.com/skia.git/+log/7b6aae68a11f..d53ea1557b35

2023-06-23 brianosman@google.com Remove all code from SkOpts_skx

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 19:58:47 +00:00
Chinmay Garde
ff388bde50 [Impeller] FenceWaiterVK: Move potentially slow calls out of wait set mutex critical section. (flutter/engine#43131) 
Moves signaled checks and callbacks out of the wait set mutex critical section.

The signaled checked can apparently be super slow on Qualcomm devices and the callback may hit allocators that could be slow as well.
 2023-06-23 18:40:39 +00:00
godofredoc
6182c0b680 Remove master mirroring workflow. (flutter/engine#42681) 
All the uses of master in the engine have been removed. We are removing mirroring in preparation to archive the master branch.

Bug: https://github.com/flutter/flutter/issues/90476

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-23 18:27:49 +00:00
skia-flutter-autoroll
d6ea0f6b72 Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147) 
https://skia.googlesource.com/skia.git/+log/9635d54210dc..7b6aae68a11f

2023-06-23 brianosman@google.com Add kBGR_888x_SkColorType
2023-06-23 jvanverth@google.com [graphite] Stub in interface for asyncRescaleAndReadPixelsYUV420
2023-06-23 ust@google.com [fix-swo-violations] Fix sort comparison function
2023-06-23 jmbetancourt@google.com plumb image slot support into FootageLayer
2023-06-23 scroggo@google.com Revert "Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 17:33:07 +00:00
Casey Hillers
5623336fce [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139) 
Next version of the crosstool will start warning about this (see: https://github.com/llvm/llvm-project/issues/38717)
 2023-06-23 16:49:01 +00:00
keyonghan
80ab2c54ca Add osx_sdk context to mac_clang_tidy (flutter/engine#43115) 
With context, recipes logic should be simplified without checking corresponding platform/property conditions.

With the `osx_sdk` context, it will install xcode accordingly.
 2023-06-23 16:41:56 +00:00
Jonah Williams
07e900baf6 [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129) 
I was missing the VMA flush.

Because skia is writing directly to the exposed ptr, we don't go through the OnSetContents which makes a flush call. Add a flush API and implement it for Vk DeviceBuffers.
 2023-06-23 16:27:51 +00:00
skia-flutter-autoroll
85e29db9d4 Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145) 
https://skia.googlesource.com/skia.git/+log/04fa1c1ef69c..9635d54210dc

2023-06-23 robertphillips@google.com [graphite] Add SrcConstraint support
2023-06-23 michaelludwig@google.com Reland "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 16:19:00 +00:00
gmackall
805cd4816d Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109) 
Solely documentation change to explain the reasoning behind the change in https://github.com/flutter/engine/pull/42700.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-23 14:21:55 +00:00
skia-flutter-autoroll
cee6554538 Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 07:38:20 +00:00
skia-flutter-autoroll
73ed54d95e Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132) 
https://skia.googlesource.com/skia.git/+log/450bc21cc836..a94abf80dd2f

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7fe8d8d9b147 to 74755bf0105b (7 revisions)
2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6dfc38b8a59d to 8278361fbbef (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 06:39:05 +00:00
Dan Field
682e06b5fc Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112) 
This no longer applies.
 2023-06-23 04:29:19 +00:00
skia-flutter-autoroll
3d40f7724e Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120) 
https://skia.googlesource.com/skia.git/+log/6595192c8352..a989b6f1aec5

2023-06-23 nicolettep@google.com [graphite] Add binding field to descriptor struct and rename appropriately; utilize in Vulkan

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 02:13:11 +00:00
Brandon DeRosier
e88246ebb4 [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117) 
Part of https://github.com/flutter/flutter/issues/128606.

- Adds blend imagery that matches the Flutter BlendMode documentation:
https://api.flutter.dev/flutter/dart-ui/BlendMode.html
- Adds a clear side-by-side comparison of SaveLayer blending vs CPU
blending to make verifying correctness possible.
  - Top squares are SaveLayer-applied blends.
  - Bottom squares are CPU blends.
 2023-06-22 17:57:13 -07:00
gaaclarke
3604e9b519 [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097) 
Collapses DrawPaint calls into clear colors when possible.

issue https://github.com/flutter/flutter/issues/129292
relands https://github.com/flutter/engine/pull/41711

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-22 17:40:49 -07:00
skia-flutter-autoroll
e20c352bf0 Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114) 
https://skia.googlesource.com/skia.git/+log/cb44fca83da0..5265b5ee1afc

2023-06-22 kjlubick@google.com Preserve SkNWayCanvas::onFlush
2023-06-22 bsalomon@google.com Fold SkMatrixProvider into SkBaseDevice and remove it.
2023-06-22 weiyuhuang@google.com Add `applyRoundingHack` to `ParagraphStyle`
2023-06-22 brianosman@google.com Remove all usage of SkMatrixProvider outside of SkDevice.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:28:29 +00:00
godofredoc
51e1adf23c Add missing android lint to linux_unopt. (flutter/engine#43099) 
The test was not migrated to v2.

Bug: https://github.com/flutter/flutter/issues/127759

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 22:25:10 +00:00
skia-flutter-autoroll
784eaf4e31 Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107) 
https://skia.googlesource.com/skia.git/+log/273f4cf92b7e..cb44fca83da0

2023-06-22 nicolettep@google.com [graphite] Batch of Vulkan fixes for running dm
2023-06-22 jvanverth@google.com [graphite] Add Vulkan Linux bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 22:20:47 +00:00
utzcoz
23d3ca2e2b [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965) 
Make Robolectric tests work with SDK 33. The Robolectric doesn't support create presentation window now, so this CL also adds a custom presentation shadow to hook showing state to make related tests work.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 20:33:57 +00:00
skia-flutter-autoroll
5a20ffdb0a Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106) 
https://skia.googlesource.com/skia.git/+log/09b36b8ce0db..273f4cf92b7e

2023-06-22 michaelludwig@google.com Revert "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 20:30:10 +00:00
Lau Ching Jun
574191ed36 Workaround a release blocker after libc++ change (flutter/engine#43091) 
The code breaks in C++20 mode after libc++ removes comparisons for `std::vector` and replaces them with 'operator <=>'.

See cl/542541552 for context.
 2023-06-22 19:33:44 +00:00
skia-flutter-autoroll
bb015ab8c5 Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102) 
https://skia.googlesource.com/skia.git/+log/8168c802c391..09b36b8ce0db

2023-06-22 brianosman@google.com Avoid division by zero in emboss mask filter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 19:21:06 +00:00
Brandon DeRosier
05d4a13865 [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093) 
Resolves https://github.com/flutter/flutter/issues/128353.
Reverts https://github.com/flutter/engine/pull/43087.

Reland without the kDecal usage -- we don't need it after the last
iteration of fixes.
 2023-06-22 11:38:19 -07:00
Brandon DeRosier
034f5e4edf [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094) 
Fixes uncontrolled crash when kDecal is used (as seen on
https://github.com/flutter/engine/pull/43087).
 2023-06-22 11:35:15 -07:00
Jesse Seales
baef7fd849 Use minor version, ignore patches for CodeQL (flutter/engine#43088) 
The patches of CodeQL updated by dependabot were causing too many engine PRs. This change updates to allow for dependabot to just use minor versions.

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses https://github.com/flutter/flutter/issues/112911

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 18:22:49 +00:00
Dan Field
b6fa0a20a5 Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928) 
Fixes https://github.com/flutter/flutter/issues/128746

Prints a warning the first time a platform channel sends a message from the wrong thread with instructions/link to the site about how to fix this.
 2023-06-22 18:16:40 +00:00
skia-flutter-autoroll
97c396add6 Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096) 
https://skia.googlesource.com/skia.git/+log/3f3e1da4b7eb..8168c802c391

2023-06-22 michaelludwig@google.com [skif] Update lighting image filters to use FilterResult
2023-06-22 jacksongardner@google.com Fix assert logic.
2023-06-22 johnstiles@google.com Eliminate remaining vestiges of SkVM.
2023-06-22 johnstiles@google.com Remove SkVM codegen support from SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 18:08:03 +00:00
Jonah Williams
5c56768c14 [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089) 
Also forces the creation of a stencil attachment always on Android to reduce the number of PSO variants.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 17:51:49 +00:00
Mouad Debbar
907fcd3245 [web] Don't get break type from v8BreakIterator (flutter/engine#43053) 
In some languages, when the text contains a new line "\n", the `v8BreakIterator` starts returning different values from `breakType()`. This caused our code to think that those line breaks were hard line breaks when in fact they were soft line breaks. Still unclear if this is a `v8BreakIterator` bug or a wrong expectation on our side regarding how `breakType()` is supposed to work.

Instead of using `v8BreakIterator.breakType()`, let's do the `soft` vs `hard` detection ourselves (we already have all the necessary pieces).

Fixes https://github.com/flutter/flutter/issues/127379
 2023-06-22 17:35:44 +00:00
Jonah Williams
0b17d31261 Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061) 
Reverts flutter/engine#42944

This didn't improve any of the benchmarks, which I think at least disproves my theory on overloading. Lets go back to the prior strategy and look for improvements elsewhere.
 2023-06-22 17:19:42 +00:00
Jonah Williams
635a109a6d [Impeller] Add fence waiter trace event. (flutter/engine#43092) 
I suspect that some of the worst frame times are caused by submission blocking on adding a fence. Add a trace event that would make that obvious.

![unnamed](https://github.com/flutter/engine/assets/8975114/93650ac8-4451-49d7-b8fa-00fc9f7f4277)
 2023-06-22 17:17:48 +00:00
Jonah Williams
aa890e3d65 [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085) 
At least from what I've found online, this API is already safe to call from multiple threads. From testing, at startup the presence of the mutex is adding ~100ms to shader creation time, as all compilations across N threads are fighting for the same lock.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 16:23:44 +00:00
Zachary Anderson
85aa1a0f7c Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087) 
Reverts flutter/engine#43028

An engine roll containing only this commit turned the framework tree red with a crasher on Android. I'm a bit concerned because it looked like one of the benchmarks that crashed should not have been using Impeller see https://github.com/flutter/flutter/pull/129353 and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview
 2023-06-22 15:41:24 +00:00
skia-flutter-autoroll
f62f444425 Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:37:50 +00:00
skia-flutter-autoroll
db6192d93c Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080) 
https://skia.googlesource.com/skia.git/+log/117f57a53215..3f3e1da4b7eb

2023-06-22 johnstiles@google.com Remove `transformT` SkVM helpers from gradient code.
2023-06-22 kjlubick@google.com Completely remove graphite #ifdefs from subruncontainer
2023-06-22 kjlubick@google.com Move VertexFiller::boundsAndDeviceMatrix impl to src/graphite
2023-06-22 kjlubick@google.com Move VertexFiller::fillInstanceData to src/graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:21:57 +00:00