11 Commits

Author SHA1 Message Date
Chinmay Garde
cac04c4cfa
Add FML_UNREACHABLE to declare points in code that should never be reached. (#21941)
A version of this macro is present in most code-bases. The use of this macro
must satisfy two requirements:

1: If reached, the process must be terminated in all runtime modes and at all
   optimization levels.
2: If the compiler requires a value to be returned from the function,
   encountering this macro should not make the compiler insist on a return value
  (since the process is about to die anyway).

We used to have a version of this macro that wasn't widely used and didn't
satisfy the two requirements. I have removed the same and another unused macro
in fml/logging.h

Fixes https://github.com/flutter/flutter/issues/68164.
2020-10-16 20:47:43 -07:00
Zachary Anderson
d986b8d606
Enable linting in several files (#20134) 2020-07-31 21:28:36 -07:00
Greg Spencer
e23e4775ae
Lint fixes for fml, tools subdirs (#19990)
This does lint fixes for the fml and tools subdirs.
2020-07-30 12:40:31 -07:00
gaaclarke
21efd7325e
Made the linter print out more information in its output and fixed bugs (#19895) 2020-07-22 15:38:09 -07:00
Francisco Magdaleno
e0ebaea590
Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (#16558)
This reverts commit 6aacf5e76755feb8e0f791fa619cbd99a3bd5885.
2020-02-12 12:40:31 -08:00
Chris Bracken
6aacf5e767
Re-land: Use os_log instead of syslog on Apple platforms (#16549)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.

This re-lands commit 78a8909725bbaeec80870f498d01ea6e56932a3a with a fix.
That commit was reverted in a61dbf2f66b97e85f4d8bf0cfb29a8b3c2640c09.
2020-02-11 15:11:46 -08:00
Chris Bracken
a61dbf2f66
Revert "Use os_log instead of syslog on Apple platforms (#13487)" (#16546)
Looks like somehow the fix to move to static_cast didn't get merged.

This reverts commit 78a8909725bbaeec80870f498d01ea6e56932a3a.
2020-02-11 13:20:52 -08:00
Jenn Magder
78a8909725
Use os_log instead of syslog on Apple platforms (#13487)
Migrates to using os_log for app logging on iOS 13 and above, macOS
10.11 and above. On older platform, fall back to syslog(), which is what
we used previously.
2020-02-11 10:23:44 -08:00
Michael Goderbauer
09ef73ff6e
Fix code smells reported by chrome's clang plugin (#6833) 2018-11-12 19:59:29 -08:00
Michael Goderbauer
70a1106b50
Unify copyright lines (#6757) 2018-11-07 12:24:35 -08:00
Chinmay Garde
fbf07dc332
Import logging utilities from FXL. (#5310) 2018-05-18 15:43:49 -07:00