1011 Commits

Author SHA1 Message Date
Ferhat
74f48cd554
Fix devicepixel ratio reset problem when replaying clip stack (#15327)
* Fix devicepixel ratio reset problem when replaying clip stack
* Simplify setTransform
2020-01-08 17:52:29 -08:00
Ferhat
a669095fce
Enable BackdropFilter for most browsers (#15321) 2020-01-08 17:12:13 -08:00
Nurhan Turgut
9d8a985680 add warning message for clipboard api (#15304) 2020-01-08 16:23:02 -08:00
Mouad Debbar
91a37d8799
Reland "[web] Calculate align offset for each paragraph line (LineMetrics.left)" (#14537) (#15151) 2020-01-08 15:08:12 -08:00
Ferhat
8df69a7e58
Move html window.devicePixelRatio access to EngineWindow and fix WebOS issue (#15315) 2020-01-08 12:52:41 -08:00
Ferhat
4979039ffe
Fix Path.from. (#15268)
* Fix Path.from to deep copy. Add regression test.
2020-01-08 12:48:35 -08:00
Harry Terkelsen
dba9cce137
Throw an exception in Image.toByteData rather than hang forever. (#15152) 2020-01-08 11:20:27 -08:00
Harry Terkelsen
155ee3cb7c
Implement Path.from in the CanvasKit backend (#14468) 2020-01-08 11:19:39 -08:00
Nurhan Turgut
f001ea29f1
adding windows platform to felt. fixing signal (#15111) 2020-01-08 06:30:57 -08:00
Ferhat
27a221d6d0
Refactor BitmapCanvas, lazily allocate canvas, fix image composition bug. (#15153)
* Refactor BitmapCanvas. Fix image compositing bug. Allocate canvas lazily
* Fix recording canvas test by restoring context save
* Update recording canvas test for drawColor to show multiply blend
2020-01-07 15:36:48 -08:00
Ferhat
45bbbd780c
Recover when browser throws on ImageElement.decode due to too many images (#15160) 2020-01-07 12:30:33 -08:00
Mouad Debbar
eb139936eb
[web] Fix right click issues (#15103) 2020-01-03 09:21:04 -08:00
Nurhan Turgut
c2f44be47d
fix selection issue (#14604) 2019-12-23 12:36:10 -08:00
Nurhan Turgut
42bb7c9eea
[web] fix leaking problem in tests for text editing. (#14582)
* fix leaking problem in tests for text editing. removing skips for firefox

* addressing pr comments
2019-12-20 15:27:40 -08:00
Yegor
33813929e3
[web] implement pushImageFilter (#14599)
implement pushImageFilter in the HTML and CanvasKit backends
2019-12-20 12:10:56 -08:00
Yegor
9b299f2c23
fix editable placement in a11y mode (#14581) 2019-12-20 12:09:54 -08:00
Nurhan Turgut
fac66c28d6
[web] Long press fix on Safari on IOS (#14588)
* fixing long press by listening click

* documenting the code. creating a new method

* addressing reviewer comments
2019-12-20 09:25:00 -08:00
Ferhat
40b84fc193
Fix lint warnings across web_ui, add missing browserEngine case in text field. (#14535)
* Fix lint warnings across web_ui

* add textureCoordinates/indices getters for Vertices

* fix compositor indices
2019-12-19 17:39:33 -08:00
Jim Graham
929b1edff5
Engine support for ImageFiltered widget (#14491)
web_ui support coming in https://github.com/flutter/flutter/issues/47163
2019-12-19 16:47:08 -08:00
Jim Graham
22413efc48
Update formatting in web_ui scene bulder to match flutter style and dartfmt. (#14539) 2019-12-19 12:50:39 -08:00
Chiung-Ming Huang
68d919670f Fix DOM-based ParagraphRuler.hitTest() (#14504)
* [web] Fix ParagraphRuler.hitTest

* [web] Add a test-case for paragraph.getPositionForOffset and nested TextSpans

* [web] Add a test-case for paragraph.getPositionForOffset and nested TextSpans

* [web] remove trailing spaces

* [web] avoid differences of overflow-wrap between chrome and firefox
2019-12-19 12:36:43 -05:00
Nurhan Turgut
f5b877af9a
[web] Run engine tests on Safari locally by launching safari installed on MacOS (#14555)
* Launch safari browser

* Adding safari tests to supported browsers

* changing the directrory for redirect file. This works without opening a permision pop-up. Note: there is no headless mode in safari

* addressing reviewer comments
2019-12-19 08:05:16 -08:00
Nurhan Turgut
2ba5633369
instructions for running firefox/safari tests (#14562)
* instructions for running firefox/safari tests

* addressing reviewer comments.
2019-12-19 07:33:51 -08:00
Lau Ching Jun
0f90e6546b
Revert "[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537)" (#14569)
This reverts commit 1ecfdcb94ccf8a3c9d59b9e2c1ca7c8aa8d3a2d6.
2019-12-18 22:06:00 -08:00
Kaushik Iska
f2dbeb8aa7
Reland Wire up Opacity on Fuchsia (#14559)
This reverts commit 6ea69a0d4339dd153899bb6c299689f1dd43329d.

On top of the revert, it reverted a commit in the PR:
https://github.com/flutter/engine/pull/14024

This reverts commit ea67e5b0b930ebf552bc7dbd678a35ee6a129c39.
2019-12-18 16:05:38 -08:00
Mouad Debbar
1ecfdcb94c
[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537) 2019-12-18 14:29:51 -08:00
Tong Mu
f2e841d50a
[Web] Fix pointer binding (#14378)
Refactors pointer_binding, fixes a few issues related to the pointer data converter in Web, and adds a number of tests for all three adapters.
2019-12-18 13:33:16 -08:00
chunhtai
988b8f149d Fix FontLoader does not remove the cache in web engine (#14536) 2019-12-18 10:58:01 -08:00
Kaushik Iska
6ea69a0d43
Revert "Wire up Opacity on Fuchsia, round 2 (#14024)" (#14543)
This reverts commit d117ac979c28363a0a6b02d4a54945212a88b6f9.
2019-12-18 10:29:47 -08:00
Lau Ching Jun
c327cae7ab
Revert "Fix off-by-one fromRGBO alpha value calculation (#13777)" (#14548)
This reverts commit 9f2daad6488ce5e7f3ca3f9a6a38b199b3791120.
2019-12-18 00:22:50 -08:00
Nurhan Turgut
c216ba42b2
Calling onConnectionClosed when the input element is blurred (#14484)
* close connection call

* closing connection on blur

* remove the timer and check the window focus directly. address reviewer comments.

* addressing reviewer comments
2019-12-17 16:18:54 -08:00
Tomás Arias
9f2daad648 Fix off-by-one fromRGBO alpha value calculation (#13777)
Constructing colors using `fromRGBO` should return the same values as the CSS
`rgba()` notation.  rgba(0, 0, 255, 0.5) is the same as `#0000ff80`

However `fromRGBO` sometimes creates a color with an off-by-one alpha value:

    expect(Color.fromRGBO(0, 0, 255, 0.5), Color(0x800000ff));

Expected: Color:<Color(0x800000ff)>
  Actual: Color:<Color(0x7f0000ff)>

If we use `withOpacity` to create the same color, it returns the correct color:

    expect(Color.fromRGBO(0, 0, 255, 1).withOpacity(0.5), Color(0x800000ff));

This should also be changed in lib/web_ui/lib/src/ui/painting.dart in a
followup change.
2019-12-17 09:34:30 -08:00
Yegor
6c71f89fb5
Introduce an auto-deletable SkiaObject; make SkPaint a SkiaObject (#14486)
* Introduce `SkiaObject` an object that's backed by Skia C++ objects that need to be explicitly deleted.
* Automatically delete `SkiaObject`s at the end of frame.
* Make `SkPaint` a `SkiaObject`.

Because `SkiaObject`s are deleted at the end of the frame, the object can be reused as many times as necessary within the frame. `SkPaint` in particular is a fairly expensive object. Reusing this object, for example, on `drawRRect` drops the canvas paint time by 30%.
2019-12-13 15:42:04 -08:00
Nurhan Turgut
19124783ce
adding firefox unit tests to font loading (#14487) 2019-12-13 15:26:19 -08:00
Mouad Debbar
00cbfd3f70
[web] Remove Paragraph._lines which isn't necessary anymore (#14485) 2019-12-13 15:08:17 -08:00
Mouad Debbar
35adf37ce1
[web] Implement Paragraph.getLineBoundary (#14479) 2019-12-13 13:53:55 -08:00
Jason Simmons
bdd4e4d948
Do not assume that createTypeface is called before getStyle in the AssetManagerFontStyleSet (#14343) 2019-12-13 09:23:08 -08:00
Nurhan Turgut
7922bc80e9
[web] adding firefox unit tests to font loading (#14467)
* adding firefox unit tests to font loading

* reviewer suggestions
2019-12-13 07:28:27 -08:00
Yegor
18c89f1cf6
[web][refactor] Split html and canvaskit classes more (#14320)
* Split surface and canvaskit classes more

* fix licenses

* address comments
2019-12-12 13:20:49 -08:00
Nurhan Turgut
f650bcaf77
Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behavior. (#14131)
* adding the default text editing strategy

* [DRAFT] Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behaviour. Unit tests are missing. Documentation needs updating.

* addressing PR comments

* addressing PR comments. Fixing documentation

* fixing persistenttextediting element which is used in a11y mode

* removing texteditingelement and using texteditingstrategy from hybridtextediting. fixing the unit tests. fixing comments

* fix unit tests

* add todos for firefox tests

* fixing chrome/android a11y issue
2019-12-12 11:18:02 -08:00
Alexander Aprelev
0081e8c516
Remove unused _TypeNone enum field. (#14440)
* Remove unused field
* Similarly remove _TypeNone from web_ui
2019-12-12 09:43:44 -08:00
Dwayne Slater
80d80ff6e6
Add ability to control dithering on Paint (#13868) 2019-12-11 14:53:50 -08:00
Chinmay Garde
49d6552e76
Verify accounting for loop counts in Gif and WebP assets is consistent. (#14321)
Asserts that the Skia fix is pulled into Flutter Engine https://skia-review.googlesource.com/c/skia/+/259161. This should have happened in https://github.com/flutter/engine/pull/14315.

Fixes https://github.com/flutter/flutter/issues/46289
Fixes https://github.com/flutter/flutter/issues/45246
2019-12-10 20:04:15 -08:00
Kaushik Iska
3e55f64c4f
[web] Update build_web_compilers to 2.7.1 (#14305)
* [web] Update build_web_compilers to 2.7.1

This was causing problems with the dart compiler location
for web.

The compiler seems to be present in out/host_debug_unopt/dart-sdk/lib/dev_compiler/kernel/amd/dart_sdk.js as opposed to out/host_debug_unopt/dart-sdk/lib/dev_compiler/amd/dart_sdk.js

* also update build_runner
2019-12-10 16:12:53 -08:00
Nurhan Turgut
deb8e57135
Fix for tab not working (#14165)
* some logs

* Masking moddifier state for lock keys if the key code is not the same as the modifier. this fixes tab issue happening when numlock/capslock is on.

* removing modifier state for locks

* addresing pr comments'
2019-12-10 14:55:46 -08:00
Harry Terkelsen
434f6f9c87
Add support for platform views in the CanvasKit backend (#14263)
* Add support for platform views in the CanvasKit backend

* Respond to comments

* Update license file
2019-12-09 17:59:50 -08:00
Nurhan Turgut
2805da9e5d
Enable web engine unit tests on Firefox (#14267)
* Enable web engine unit tests on Firefox

* addressing PR comments

* addressing PR comments

* fix the version name on the lock file
2019-12-09 16:27:14 -08:00
Harry Terkelsen
3a2ec830ed
Use the versioned canvaskit from unpkg. (#14264)
The one from particles.skia.org is not intended for production use.
2019-12-09 14:28:13 -08:00
Harry Terkelsen
a614c0a2d4
Convert radians to degrees in canvaskit backend for drawArc (#14163) 2019-12-09 11:00:44 -08:00
Nurhan Turgut
91ef612ee0
[web] [tests] Changing configurations for firefox (#14148)
* Changing configurations for firefox

* remove headless

* change comments on configurations files

* remove unused boolean
2019-12-05 15:17:34 -08:00