9386 Commits

Author SHA1 Message Date
George Wright
56bdcec5ae Enable Vulkan validation layers for shell_test (flutter/engine#17684) 2020-04-17 13:00:02 -07:00
Jason Simmons
6e05478105 Remove unused parameter from GetLineXOffset (flutter/engine#17745) 2020-04-17 12:24:58 -07:00
skia-flutter-autoroll
82fea43dc3 Roll src/third_party/skia efebaa2a1152..f49debf07dc6 (24 commits) (flutter/engine#17786)
https://skia.googlesource.com/skia.git/+log/efebaa2a1152..f49debf07dc6

git log efebaa2a1152..f49debf07dc6 --date=short --first-parent --format='%ad %ae %s'
2020-04-17 bsalomon@google.com Fix two GrProcessor names that are not valid idenitfiers
2020-04-17 robertphillips@google.com Update DDL test harness to use backendTextures to back tiles (take 2)
2020-04-17 egdaniel@google.com Fix spirv rtheight set.
2020-04-17 kjlubick@google.com Reland "Revert "GrDisplacementEffect uses GrTextureEffect.""
2020-04-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 59d223304f3c..41c6b825e65f (406 commits)
2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2430d665d3f2..d25ce8725224 (18 commits)
2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 0721c1cf2a52..53f694b34a8d (8 commits)
2020-04-17 reed@google.com remove legacy deserialization of overdrawcolorfilter
2020-04-17 bsalomon@google.com Revert "Revert "GrDisplacementEffect uses GrTextureEffect.""
2020-04-16 sgilhuly@chromium.org Remove non-renderable formats in Dawn backend
2020-04-16 brianosman@google.com SkM44: Remove unused determinant & redundant checks in invert
2020-04-16 robertphillips@google.com Fix up GPUDDLSink for Vulkan
2020-04-16 mtklein@google.com GP64 Operand conversion
2020-04-16 senorblanco@chromium.org Reland "Refactor GL and Metal FinishCallback into a helper object."
2020-04-16 bsalomon@google.com Revert "GrDisplacementEffect uses GrTextureEffect."
2020-04-16 reed@google.com change Overdraw colorfilter to be pure sksl
2020-04-16 jlavrova@google.com getRectForRange with HeightStyle == kTight should ignore strut metrics
2020-04-16 westont@google.com Remove Debian10 Flutter_Android, change BuildStats to use Debian9 Docker
2020-04-16 bsalomon@google.com GrDisplacementEffect uses GrTextureEffect.
2020-04-16 michaelludwig@google.com Rename GrShape to GrStyledShape
2020-04-16 michaelludwig@google.com Respect wrap mode when decimating for blur
2020-04-16 mtklein@google.com lots more refactoring
2020-04-16 westont@google.com Dockerize Flutter Android job.

Created with:
  gclient setdep -r src/third_party/skia@f49debf07dc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: kjlubick@google.com
2020-04-17 11:17:47 -07:00
Chris Yang
6bb1dd885a Pipeline: complete method returns a bool to indicate if complete is successful (flutter/engine#17687) 2020-04-17 10:39:16 -07:00
Nurhan Turgut
ee7c61cb96 web engine should not give an error for the new text editing method. (flutter/engine#17771) 2020-04-17 10:27:33 -07:00
godofredoc
3d775a40b5 Remove android unopt build and test from cirrus. (flutter/engine#17762)
These tests and build are getting migrated to LUCI:

  https://chromium-review.googlesource.com/c/chromium/tools/build/+/2152285

Bug:
  https://github.com/flutter/flutter/issues/54412
2020-04-17 10:21:56 -07:00
Nurhan Turgut
dc6c44ec83 [web] remove the web_engine_integration tests from cirrus ci (flutter/engine#17765)
* remove the web_engine_integration tests from cirrus ci, since felt test already runs all these tests in the build_and_test_linux_unopt task

* fix typo in the end of task
2020-04-17 10:14:46 -07:00
liyuqian
c72ff4abc5 Revert "Remove layer integral offset snapping (#17712)" (flutter/engine#17785)
This reverts commit 5449a14ac2f3056e31ed8679ee8bf004a354dea6.

I found some problems. Will revise and reland later, and put more details about the problems in the new PR.

TBR: @chinmaygarde @flar
2020-04-17 08:26:22 -07:00
Brian Osman
948065c3a7 Convert semantics_node from SkMatrix44 to SkM44 (flutter/engine#17763)
* Convert semantics_node from SkMatrix44 to SkM44
2020-04-17 07:24:40 -04:00
liyuqian
5449a14ac2 Remove layer integral offset snapping (flutter/engine#17712)
This fixes https://github.com/flutter/flutter/issues/53288 and https://github.com/flutter/flutter/issues/41654. It removes the problematic `GetIntegralTransCTM`, but preserves the rect round-out in `RasterCacheResult::draw` for performance considerations: the average frame raster time doesn't change much but the worst frame raster time significantly regressed if rect round-out is removed. That's probably because a new shader needs to be compiled to draw raster cache with fractional offsets.
2020-04-16 15:41:07 -07:00
Michael Goderbauer
e60051f0b3 Clear focus if a platform view goes away (flutter/engine#17381) 2020-04-16 13:23:05 -07:00
Brian Osman
adf41d060b Convert MatrixDecomposition from SkMatrix44 to SkM44 (flutter/engine#17760)
* Convert MatrixDecomposition from SkMatrix44 to SkM44

SkMatrix44 is deprecated and being removed.
2020-04-16 15:27:41 -04:00
skia-flutter-autoroll
7427075fea Roll src/third_party/skia 7a9c9d66f12c..efebaa2a1152 (7 commits) (flutter/engine#17761) 2020-04-16 11:10:01 -07:00
Brian Osman
4b424c1296 Guard canvas virtuals so we can remove legacy didConcat44 (flutter/engine#17756)
* Guard canvas virtuals so we can remove legacy didConcat44

SkMatrix44 is also deprecated, so start transitioning to SkM44.

* Fix formatting
2020-04-16 13:40:22 -04:00
skia-flutter-autoroll
d601c1542b Roll src/third_party/skia 938b4532b48f..7a9c9d66f12c (2 commits) (flutter/engine#17758) 2020-04-16 08:15:02 -07:00
skia-flutter-autoroll
bf04d396a4 Roll fuchsia/sdk/core/linux-amd64 from Udupa... to Pgthi... (flutter/engine#17754) 2020-04-16 05:50:02 -07:00
skia-flutter-autoroll
aa6c55811a Roll src/third_party/skia 9ff1d841f6cc..938b4532b48f (20 commits) (flutter/engine#17752) 2020-04-16 05:00:02 -07:00
LongCatIsLooong
1afb95d156 Android text input autofill (flutter/engine#17465) 2020-04-16 03:41:23 -07:00
LongCatIsLooong
fd18ae6aeb Add autofill support to ios text input plugin (flutter/engine#17493) 2020-04-16 02:47:53 -07:00
skia-flutter-autoroll
f4f6f01729 Roll src/third_party/dart d5c38cd35486..983f882180cd (8 commits) (flutter/engine#17747) 2020-04-16 02:30:02 -07:00
Ali Mahdiyar
28c34245cf Fix RTL handling in delete key event for android (flutter/engine#17393) 2020-04-16 01:48:21 -07:00
Jonah Williams
152ae6b486 [a11y] Support TalkBack reading by word, character, and paragraph (flutter/engine#17626) 2020-04-15 19:07:12 -07:00
Francisco Magdaleno
bdb2c5800d Remove franciscojma86 from autoassign (flutter/engine#17717) 2020-04-15 17:52:43 -07:00
godofredoc
e278899d53 Remove fuchsia build from cirrus. (flutter/engine#17736)
Building fuchsia is covered already by LUCI.

Link to luci execution:
  https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia

Bug:
  https://github.com/flutter/flutter/issues/54412
2020-04-15 14:58:44 -07:00
stuartmorgan
6dbd05214c Use the right constant for macOS event timestamps (flutter/engine#17713)
The NSEvent->Flutter event conversion code for pointer events was
multiplying seconds by nanoseconds per milliseconds. While this does end
up giving the right number of microseconds, it's a very confusing way to
write it.
2020-04-15 14:33:00 -07:00
skia-flutter-autoroll
093c4a0c3f Roll fuchsia/sdk/core/linux-amd64 from M1a9q... to Udupa... (flutter/engine#17732) 2020-04-15 14:00:02 -07:00
gaaclarke
43dffbd739 Added some tests after the fact for #17499 (flutter/engine#17714) 2020-04-15 11:52:52 -07:00
skia-flutter-autoroll
dbf344f2e5 Roll src/third_party/skia d276e3f0099a..9ff1d841f6cc (4 commits) (flutter/engine#17733) 2020-04-15 11:25:01 -07:00
Vyacheslav Egorov
2eb118495b Release acquired typed data before calling Dart_SetReturnValue. (flutter/engine#17729) 2020-04-15 10:35:04 -07:00
skia-flutter-autoroll
226725f132 Roll src/third_party/skia e6995c74cdfa..d276e3f0099a (2 commits) (flutter/engine#17730) 2020-04-15 08:25:02 -07:00
stuartmorgan
cb13b1198f Fix Windows clipboard handling (flutter/engine#17706)
Fixes several bugs in the clipboard code, and makes some structural
improvements:
- Adds scoped wrappers for clipboard open/close and global lock/unlock,
  to prevent missing cleanup, fixing at least one case where the lock
  was not released.
- Adds the relevant window handle to the clipboard calls, since the docs
  suggest that some operations won't work without one.
- Adds a missing clear step to setting the clipboard data.
- Switches from TEXT to UNICODETEXT to handle non-ASCII text correctly.
  - To enable that, adds UTF-16/-8 conversion utilities built on the
    Win32 APIs (rather than the deprecated std::codecvt functions, as
    have been previously used in the engine).
- Fixes handling of getting data when the clipboard is empty, correctly
  returning null.
- Passes more errors back through the method channel, with details, for
  easier debugging of future issues.

Fixes https://github.com/flutter/flutter/issues/54226
2020-04-15 07:02:58 -07:00
skia-flutter-autoroll
1198ca4af6 Roll src/third_party/skia 44e2c5f0babc..e6995c74cdfa (12 commits) (flutter/engine#17727) 2020-04-15 05:20:03 -07:00
Yegor
079058b7d3 reduce web shard count from 8 to 4 (flutter/engine#17635)
reduce web shard count from 8 to 4 by using WEB_SHARD_COUNT
2020-04-14 20:10:10 -07:00
Yegor
d8b5667fb2 Optimize static content scrolling (flutter/engine#17621)
* store paint command bounds
* do not apply commands outside the clip region
* better cull rect prediction
* enforce RecordingCanvas.endRecording
2020-04-14 20:08:10 -07:00
skia-flutter-autoroll
169b3b4521 Roll fuchsia/sdk/core/linux-amd64 from LnaL2... to M1a9q... (flutter/engine#17715)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-04-14 19:29:48 -07:00
godofredoc
b07a6e8e0b Updates to use predefined keys. (flutter/engine#17716)
* Updates to use predefined keys.

It starts using:
  * timeouts for paving.
  * timeouts for ssh commands.
  * timeouts for tests.

https://github.com/flutter/flutter/issues/54416

* Update key location and autogenerate public key.

* Use ssh-keygen instead of openssl.

* Fix typo on test name.
2020-04-14 18:29:13 -07:00
stuartmorgan
a530cb9082 Add a gn flag to disable desktop embeddings (flutter/engine#17708)
Desktop embedding dependencies can trigger gn-generation-time
requiremenets; e.g., the Linux embeddings have pkg-config dependencies.
This can be problematic in some build environments, such as building
flutter_engine.so with a custom sysroot where those higher-level
dependencies aren't available.

This flag allows generating build files that don't have those
dependencies.
2020-04-14 17:48:18 -07:00
Ferhat
fa263a7197 [web] Fix extra canvas generation due to context access (flutter/engine#17710)
* Fix extra canvas generation due to context access
* add comment
* address review comment
2020-04-14 15:40:16 -07:00
gaaclarke
f29e60bff1 switched to using the ocmock build file in //build (flutter/engine#17707) 2020-04-14 14:43:29 -07:00
skia-flutter-autoroll
2ae2dabef3 Roll src/third_party/skia ad653d8378d7..44e2c5f0babc (9 commits) (flutter/engine#17709) 2020-04-14 14:20:01 -07:00
stuartmorgan
fb6e9d1c6f Adjust the GLFW build options (flutter/engine#17704)
- Adds an explicit option for not building the GLFW embedding.
- Disables GLFW by default on Windows, where it's no longer the
  uploaded embedding.
- Moves the X11 pkg-config, which is only used by the GLFW embedding,
  behind the GLFW build flag.
2020-04-14 12:45:21 -07:00
skia-flutter-autoroll
f38aeb493e Roll src/third_party/skia f50063625a0c..ad653d8378d7 (3 commits) (flutter/engine#17697) 2020-04-14 02:40:02 -07:00
skia-flutter-autoroll
7953062741 Roll src/third_party/skia 4f17b60208fa..f50063625a0c (1 commits) (flutter/engine#17696) 2020-04-13 23:45:02 -07:00
Robert Ancell
971f86d844 Move Linux shell docstrings to headers (flutter/engine#17410)
Update docstrings for typos and grammar style specified in the style guide.
2020-04-14 15:41:23 +12:00
skia-flutter-autoroll
ee266812bc Roll src/third_party/skia f3953d04a0b8..4f17b60208fa (9 commits) (flutter/engine#17693) 2020-04-13 20:35:02 -07:00
Alexander Aprelev
d58d893dec In tests run dart code on ui(rather than on platform) thread. (flutter/engine#17686) 2020-04-13 16:50:11 -07:00
skia-flutter-autoroll
5386ac8b70 Roll src/third_party/skia d468a1619a2f..f3953d04a0b8 (11 commits) (flutter/engine#17685) 2020-04-13 16:50:08 -07:00
George Wright
3e1e1b342d Use VK_LAYER_KHRONOS_validation only on Fuchsia (flutter/engine#17683) 2020-04-13 16:45:03 -07:00
Ferhat
1e6e25c4da [web] Fix compositing order when adding paragraph tags (flutter/engine#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
gaaclarke
3849b114d4 Made it so unit tests can be written against all ios engine code. (flutter/engine#17624) 2020-04-13 12:34:54 -07:00