3338 Commits

Author SHA1 Message Date
Vyacheslav Egorov
553bb9da9d Make Paragraph methods really return List<int> if they are declared as such. (flutter/engine#4676)
Changed methods _getPositionForOffset and getWordBoundary to use
Dart_NewListOf(Dart_CoreType_Int, ...).
2018-02-14 19:07:05 +01:00
Jason Simmons
10b44c539f libtxt: specifically request the Roboto font in tests and benchmarks (flutter/engine#4675) 2018-02-14 10:01:01 -08:00
Chris Bracken
080d8c2f78 Roll Skia to f802e757646f424b563fdc1f5b5ee3c677659e98 (#4670) (flutter/engine#4677)
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768e5aaf8efdd112f38295a35de83a0f9a55 in order to pick up a fix for
multitexturing on iOS. Originally disabled in flutter/engine#4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
2018-02-14 08:41:55 -08:00
Alexander Aprelev
c5feb1bb10 Remove workaround for handling of relative paths (flutter/engine#4673) 2018-02-13 18:46:00 -08:00
Chris Bracken
7db76a8e25 Revert "Roll Skia to f802e757646f424b563fdc1f5b5ee3c677659e98 (#4670)" (flutter/engine#4672)
This didn't break anything that we know of, but the engine is not
currently rollable to the framework due to a Dart bug. I'm reverting
this so we can get a fix landed for the Dart SDK, then roll, then
re-land this, then roll, to allow us to measure the performance impact
of the Dart SDK roll and the Skia roll independently.

This reverts commit 55b5f7dca6db3d00705061f60f810b23d2b2e51c.
2018-02-13 16:30:32 -08:00
Chris Bracken
55b5f7dca6 Roll Skia to f802e757646f424b563fdc1f5b5ee3c677659e98 (flutter/engine#4670)
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768e5aaf8efdd112f38295a35de83a0f9a55 in order to pick up a fix for
multitexturing on iOS. Originally disabled in flutter/engine#4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
2018-02-13 16:01:14 -08:00
Jason Simmons
d4ee3a405d Restore minikin code that had been disabled due to older versions of ICU and HarfBuzz (flutter/engine#4671) 2018-02-13 15:47:36 -08:00
Jason Simmons
2c2cd2c9a5 Roll Topaz/Tonic and call Dart_NewListOfType for TextBox lists (flutter/engine#4667)
Fixes https://github.com/flutter/flutter/issues/14555
2018-02-13 15:02:57 -08:00
Michael Goderbauer
2adfbd3202 Add nextId to traversal order (flutter/engine#4666) 2018-02-13 14:27:23 -08:00
Alexander Aprelev
c69188ad9f Add output path option (flutter/engine#4663) 2018-02-13 14:00:34 -08:00
Jacob Richman
a98c9a16a6 Track widget creation locations. (flutter/engine#4529)
* Track widget creation locations.
2018-02-13 12:33:23 -08:00
Chris Bracken
a6f0be9844 Fix unguarded availability warnings for iOS (flutter/engine#4664)
Place all iOS code that relies on APIs introduced in iOS versions later
than our base SDK version (iOS 8) behind @available checks. This allows
us to enable the -Wunguarded-availability compiler flag for iOS builds
in the buildroot repo.
2018-02-13 11:49:43 -08:00
Jason Simmons
cee642fc13 libtxt: disable font fallback when test font mode is enabled (flutter/engine#4661) 2018-02-13 09:37:48 -08:00
Alexander Aprelev
69c776b209 Switch to accept/reject-friendly incremental compiler (flutter/engine#4601)
* Switch to accept/reject-friendly incremental compiler

* Merge
2018-02-13 06:58:04 -08:00
Alexander Aprelev
952f395ae5 Use fallback root certificates on Windows host builds (flutter/engine#4662)
* Use fallback root certificats on Windows, Linux host builds

* Use fallback only on Windows
2018-02-12 22:37:34 -08:00
Ryan Macnak
7b61378b7e [fuchsia] Decouple common packages from the core snapshot. (flutter/engine#4660) 2018-02-12 14:55:11 -08:00
Alexander Markov
1aac5e6ed4 Roll Dart to 223eeb2ebe112aaaddca206aab55cd54b4e54391 (flutter/engine#4659)
* Roll Dart to 223eeb2ebe112aaaddca206aab55cd54b4e54391
* Update licenses
* Make analyzer happy, fix test for change in mockito
2018-02-12 14:47:18 -08:00
Greg Spencer
8566625bfa Swap setTraversalBefore to setTraversalAfter, since setTraversalBefore is broken. (flutter/engine#4656)
It seems that setTraversalBefore doesn't work as well as setTraversalAfter for some reason, although I'm using them the same way. Some apps would lock up TalkBack when traversing if setTraversalBefore was set, but not with the equivalent setTraversalAfter.

It's not entirely clear why this is, but I'm going with this to at least get it fixed for apps we know about.

Addresses flutter/flutter#14600

See also flutter/flutter#14607
2018-02-12 10:02:25 -08:00
Michael Goderbauer
be8089ba88 Add accessibilityFocus and loseAccessibilityFocus as a11y actions (flutter/engine#4655) 2018-02-09 17:47:52 -08:00
Michael Goderbauer
27a581d213 Encode scrolling status into tree (flutter/engine#4647) 2018-02-09 15:39:58 -08:00
Alexander Markov
210eb79918 Make native wrapper classes non-abstract (flutter/engine#4607)
* Make native wrapper classes non-abstract as they are instantiated from native code
* Make constructors of native wrapper classes private
2018-02-09 12:17:36 -08:00
Jason Simmons
adb1cc1d0f Exclude frontend_server from the license crawl (flutter/engine#4645) 2018-02-09 12:17:00 -08:00
Ryan Macnak
a1f23bf8fc [fuchsia] Add missing AOT entry points for FromFileResult and MapResult. (flutter/engine#4649) 2018-02-08 09:34:19 -08:00
Alexander Aprelev
3e577d6940 Remove xibs (flutter/engine#4648) 2018-02-07 16:20:06 -08:00
Alexander Aprelev
d8718d5feb Use Uri.file expecting filepath (flutter/engine#4646) 2018-02-07 15:24:44 -08:00
Alexander Aprelev
9d28fa26bb Roll dart deps (flutter/engine#4644)
* Roll dart deps

* Remove pin

* Roll buildroot to dart dev.20
2018-02-07 15:22:59 -08:00
Jason Simmons
b930272f2d libtxt: change the host default font family to something more widely available (flutter/engine#4631) 2018-02-07 14:10:07 -08:00
jensjoha
b7a3eb583d Let frontend_server bootstrap the incremental compiler from a previou… (flutter/engine#4642)
* Let frontend_server bootstrap the incremental compiler from a previously build dill file

* Wrap 'invalidateIfBootstrapping' in try and don't bootstrap if getting an exception
2018-02-07 14:03:05 -08:00
Brian Salomon
53b3c06c97 Modernize GrContext creation (flutter/engine#4640) 2018-02-06 13:45:31 -08:00
Zachary Anderson
cc7a67da96 Reland: [fuchsia] Enable running from source packages (flutter/engine#4634)
This relands https://github.com/flutter/engine/pull/4629 with a
tonic roll to fix the build.
2018-02-06 10:08:24 -08:00
Devon Carew
d9fcfb35c1 add padding around the perf overlay (flutter/engine#4638) 2018-02-06 07:18:45 -08:00
Jason Simmons
c3ef874a23 Fix an improper deletion of DirectoryAssetBundle when creating isolates (flutter/engine#4637) 2018-02-05 17:33:59 -08:00
Jason Simmons
e75747c907 Update PlatformViewAndroid for the new definition of SemanticsNodeUpdates (flutter/engine#4636) 2018-02-05 16:11:51 -08:00
Ryan Macnak
d7e1cd0ba2 Some cleanups for building platform.dill. (flutter/engine#4635) 2018-02-05 15:33:55 -08:00
Yegor
7df584d855 iOS a11y text entry (~70% of it) (flutter/engine#4575)
* implement iOS text field editing in a11y mode

* address Chinmay's comments

* replace node in child list when changing type
2018-02-05 15:14:13 -08:00
Alexander Aprelev
bf7f436e36 Roll dart, remove patched_sdk from flutter now that frontend handles patching (flutter/engine#4633)
* Fixes to make https://dart-review.googlesource.com/c/sdk/+/36641 work with Flutter

* Roll dart

* Update license

* Roll dart

* Update license

* Add libraries.json to dependencies
2018-02-05 13:44:16 -08:00
Zachary Anderson
f6af67a850 Revert "[fuchsia] Enable running from source packages (#4629)" (flutter/engine#4632)
This reverts commit a8da87e0af3fe3d46d34ee9f908069d98f3236d9.
2018-02-02 22:38:49 -08:00
Zachary Anderson
a8da87e0af [fuchsia] Enable running from source packages (flutter/engine#4629) 2018-02-02 15:43:21 -08:00
Zachary Anderson
558f686c8b [fuchsia] Set up the namespace in dart:zircon (flutter/engine#4628) 2018-02-01 22:47:01 -08:00
P.Y. Laligand
996feda91d Adjust to thinner Fuchsia sysroot. (flutter/engine#4624) 2018-02-01 13:33:22 -08:00
Jason Simmons
2869e7929d libtxt: extend Minikin to find a fallback font if its font collection can not match a given character (flutter/engine#4623)
Minikin layout uses a FontCollection containing a list of pre-selected fonts
for a particular font family.  This patch extends the FontCollection to invoke
a hook provided by libtxt if layout sees a character that can not be rendered
by any font in the collection.

* Change the Minikin lock to a recursive mutex.  This is required because the
  fallback font provider may create new fonts during a layout operation that
  already holds the lock.
* Implement a fallback font provider hook that queries Skia for fonts matching
  an unrecognized character.
* Maintain a cache of fallback fonts.  Prepopulate the cache with fonts
  covering some commonly used character classes.
* Add a last resort font list for cases where Skia's font manager can not
  find any font for a character (similar to Blink's FontCache::getLastResortFallbackFont)
2018-01-31 13:56:44 -08:00
Jason Simmons
dd0c2a273d Fix some errors in Javadoc annotations (flutter/engine#4622) 2018-01-31 13:56:32 -08:00
Greg Spencer
394c11e33f Adding semantics traversal order support (flutter/engine#4540)
This adds support for semantics traversal ordering.

It is a companion to flutter/flutter#14060, adding support for a sortIndex in the semantics data passed to the engine.

Addresses flutter/flutter#12187
2018-01-30 13:42:12 -08:00
Jason Simmons
c1827995b1 libtxt: update some unit tests (flutter/engine#4603)
* GetGlyphPositionAtCoordinate maps points within the right half of a
  glyph to the next position
* The second pass in RepeatLayoutParagraph was at the borderline between 5
  and 6 lines in the Minikin line breaker.  Add text to ensure that the text
  fills 12 lines at half width and 6 lines at full width.
2018-01-30 13:30:47 -08:00
Jason Simmons
405a30aca6 libtxt: track the range of code units represented by the current glyph (flutter/engine#4598)
This simplifies iteration over graphemes and fixes an off-by-one error seen
when handling RTL runs.
2018-01-30 13:30:06 -08:00
Chris Bracken
65ceaf57f4 Use @available checks for iOS 11 features (flutter/engine#4619)
Use @available checks for iOS 11 features
2018-01-30 09:36:21 -08:00
Coder256
1680d3f3da Only implement application:performActionForShortcutItem:completionHandler: on iOS 9.0+. And fix some tests. (flutter/engine#4600) 2018-01-30 08:00:39 -08:00
Michael Goderbauer
90723f13fd Remove unnecessary trim (flutter/engine#4616)
... which caused trouble for a11y "select all".
2018-01-29 18:12:29 -08:00
Chris Bracken
ee4f722023 Revert "libtxt: extend Minikin to find a fallback font if its font collection can not match a given character (#4595)" (flutter/engine#4609)
This reverts commit ea84dd9118374eef15a92add3a3fd28a94165fb0.
2018-01-29 15:23:24 -08:00
Chris Bracken
c709e56e78 Run clang-format checks before other phases (flutter/engine#4608)
We now run clang-format checks before running licenses and other tests.
Since clang-format runs quickly, this allows these diffs to be caught
first, without much real delay to other checks.
2018-01-29 14:59:10 -08:00