DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,513 Commits 882 Branches 1,069 Tags
Commit Graph

4220 Commits

Author SHA1 Message Date
liyuqian
54d47ebc1d Change log level from ERROR to WARNING (flutter/engine#6361) 
So tool_tests-windows won't fail.
 2018-09-27 11:28:58 -07:00
skia-flutter-autoroll
1f0c086a58 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 
https://skia.googlesource.com/skia.git/+log/227d4e10276c..ab3144c3abb9


Created with:
  gclient setdep -r src/third_party/skia@ab3144c3abb9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-27 12:45:17 -04:00
Michael Goderbauer
fc8c5df800 Do not export libdart symbols (flutter/engine#6337) 2018-09-27 18:19:22 +02:00
Dan Field
db97bea01f SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 
* SystemNavigator.pop can pop w/o UINavigationController
 2018-09-27 08:57:30 -07:00
skia-flutter-autoroll
74f279e6ad Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) 
https://skia.googlesource.com/skia.git/+log/b3e48afc936d..227d4e10276c


Created with:
  gclient setdep -r src/third_party/skia@227d4e10276c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-27 09:27:18 -04:00
skia-flutter-autoroll
10ac9806e7 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) 
https://skia.googlesource.com/skia.git/+log/cfe1264d7465..b3e48afc936d


Created with:
  gclient setdep -r src/third_party/skia@b3e48afc936d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-27 02:38:17 -04:00
Dan Field
045a313d33 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 2018-09-26 22:14:04 -07:00
skia-flutter-autoroll
d4182cc993 Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 
https://skia.googlesource.com/skia.git/+log/5ea41fc89b26..cfe1264d7465


Created with:
  gclient setdep -r src/third_party/skia@cfe1264d7465

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 23:13:35 -04:00
Chinmay Garde
b755091371 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 2018-09-26 18:15:30 -07:00
KyleWong
716cb093b5 V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 
* Fix a compilation problem when  using iPhoneOS12.0sdk(Xcode10).
 2018-09-26 17:00:28 -07:00
skia-flutter-autoroll
c5c7ddab53 Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) 
https://skia.googlesource.com/skia.git/+log/5767fc042834..5ea41fc89b26


Created with:
  gclient setdep -r src/third_party/skia@5ea41fc89b26

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 19:48:17 -04:00
Chinmay Garde
bbce11388f Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) 2018-09-26 16:33:30 -07:00
Chinmay Garde
74c44fa72a Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 
Also teaches FML to create files and directories.
 2018-09-26 14:54:09 -07:00
skia-flutter-autoroll
e02ba7472a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) 
https://skia.googlesource.com/skia.git/+log/17282da3aa94..5767fc042834


Created with:
  gclient setdep -r src/third_party/skia@5767fc042834

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 16:29:58 -04:00
Chinmay Garde
b1b2a1cc3f Add support for counter timeline traces from the engine. (flutter/engine#6315) 2018-09-26 13:26:23 -07:00
Ben Konyi
1adb13ee86 Fixed IsolateNameServer documentation (flutter/engine#6344) 
We were using `//` instead of `///` so docs were not being generated.
 2018-09-26 10:11:06 -07:00
skia-flutter-autoroll
18bd6f5b2a Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) 
https://skia.googlesource.com/skia.git/+log/bdf1431686c2..17282da3aa94


Created with:
  gclient setdep -r src/third_party/skia@17282da3aa94

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 13:05:17 -04:00
skia-flutter-autoroll
d893448de5 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) 
https://skia.googlesource.com/skia.git/+log/c05302bc84da..bdf1431686c2


Created with:
  gclient setdep -r src/third_party/skia@bdf1431686c2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 09:44:18 -04:00
skia-flutter-autoroll
8a17178f42 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) 
https://skia.googlesource.com/skia.git/+log/5457141b011e..c05302bc84da


Created with:
  gclient setdep -r src/third_party/skia@c05302bc84da

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 06:20:18 -04:00
jensjoha
a854ed8780 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 2018-09-26 08:34:49 +02:00
skia-flutter-autoroll
ccc6f2a66f Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 
https://skia.googlesource.com/skia.git/+log/bd03b54cb98d..5457141b011e


Created with:
  gclient setdep -r src/third_party/skia@5457141b011e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-26 00:08:17 -04:00
skia-flutter-autoroll
991b330bbf Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) 
https://skia.googlesource.com/skia.git/+log/f18c297cfb74..bd03b54cb98d


Created with:
  gclient setdep -r src/third_party/skia@bd03b54cb98d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-25 20:44:36 -04:00
skia-flutter-autoroll
7a2829e5f8 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 
https://skia.googlesource.com/skia.git/+log/7ffa40cedbc4..f18c297cfb74


Created with:
  gclient setdep -r src/third_party/skia@f18c297cfb74

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-25 17:26:18 -04:00
Gary Qian
c9592ddb8c Implement restore functions on Android and iOS (flutter/engine#6322) 
This will not be active on the Framework until https://github.com/flutter/flutter/pull/22221 lands.
 2018-09-25 13:46:38 -07:00
skia-flutter-autoroll
de504c819f Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) 
https://skia.googlesource.com/skia.git/+log/4ef464cd3c2e..7ffa40cedbc4


Created with:
  gclient setdep -r src/third_party/skia@7ffa40cedbc4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-25 14:00:18 -04:00
skia-flutter-autoroll
29a0d137d2 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329) 
https://skia.googlesource.com/skia.git/+log/e514fa0f1a6c..4ef464cd3c2e


Created with:
  gclient setdep -r src/third_party/skia@4ef464cd3c2e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-25 01:34:18 -04:00
skia-flutter-autoroll
d5069b3bc7 Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328) 
https://skia.googlesource.com/skia.git/+log/a85f3a138cbc..e514fa0f1a6c


Created with:
  gclient setdep -r src/third_party/skia@e514fa0f1a6c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 22:07:17 -04:00
skia-flutter-autoroll
c10d829cb2 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327) 
https://skia.googlesource.com/skia.git/+log/45239cb84d1d..a85f3a138cbc


Created with:
  gclient setdep -r src/third_party/skia@a85f3a138cbc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 18:43:35 -04:00
Dan Field
1df2685196 Format for #6324 (flutter/engine#6326) 
Format code from previous patch
 2018-09-24 18:42:04 -04:00
Dan Field
89eeaf461e Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324) 
* If isolate is already running, return true

* Use shell::Engine::RunStatus as result of Engine::Run
 2018-09-24 18:01:22 -04:00
skia-flutter-autoroll
0a87cbc84b Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323) 
https://skia.googlesource.com/skia.git/+log/a9adb6f03525..45239cb84d1d


Created with:
  gclient setdep -r src/third_party/skia@45239cb84d1d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 15:18:55 -04:00
Gary Qian
633695dadf Keyboard padding detection heuristic to distringuish when to include bottom inset. (flutter/engine#6288) 
Use a screen height ratio to determine if the keyboard is onscreen or not. This is used because Android does not provide a deterministic API to detect this.

We remove the padding when the keyboard is closed and the inset is due to the hidden navigation bar, otherwise, we apply the full keyboard inset.
 2018-09-24 11:38:13 -07:00
Rafael Ring
f74596d2b3 Change FlutterDartProject to keep precedence when looking for the ass… (flutter/engine#6305) 
* Change FlutterDartProject to keep precedence when looking for the assets bundle

* Change assetsPath to fallback to mainBundle when the defined bundle does not contain assets
 2018-09-24 09:26:43 -07:00
skia-flutter-autoroll
68476cc445 Roll src/third_party/skia 0a3864651457..a9adb6f03525 (2 commits) (flutter/engine#6320) 
https://skia.googlesource.com/skia.git/+log/0a3864651457..a9adb6f03525


Created with:
  gclient setdep -r src/third_party/skia@a9adb6f03525

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 11:54:17 -04:00
skia-flutter-autoroll
97a18c5191 Roll src/third_party/skia c955a1645148..0a3864651457 (1 commits) (flutter/engine#6319) 
https://skia.googlesource.com/skia.git/+log/c955a1645148..0a3864651457


Created with:
  gclient setdep -r src/third_party/skia@0a3864651457

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 08:30:17 -04:00
skia-flutter-autoroll
7b95cbdf85 Roll src/third_party/skia bdb32d17999e..c955a1645148 (2 commits) (flutter/engine#6318) 
https://skia.googlesource.com/skia.git/+log/bdb32d17999e..c955a1645148


Created with:
  gclient setdep -r src/third_party/skia@c955a1645148

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-24 01:07:17 -04:00
skia-flutter-autoroll
c0389de480 Roll src/third_party/skia 937348d4d442..bdb32d17999e (1 commits) (flutter/engine#6317) 
https://skia.googlesource.com/skia.git/+log/937348d4d442..bdb32d17999e


Created with:
  gclient setdep -r src/third_party/skia@bdb32d17999e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-23 21:43:34 -04:00
skia-flutter-autoroll
6eb676301f Roll src/third_party/skia 175b587a634d..937348d4d442 (1 commits) (flutter/engine#6316) 
https://skia.googlesource.com/skia.git/+log/175b587a634d..937348d4d442


Created with:
  gclient setdep -r src/third_party/skia@937348d4d442

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-23 04:58:34 -04:00
Chinmay Garde
0745ce5fa9 Remove the unused Mac Desktop shell. (flutter/engine#6314) 
This shell used to serve the dual purpose of running Flutter tests as
well as optionally being able to run Flutter applications on a Mac
desktop. After all the test runner targets were consolidated
(flutter_tester), this target was no longer used to run the tests. This
target is currently only used by engine developers to test changes
quickly on the host. Even for this purpose, the Desktop embedders are
more full featured and use the stable embedder API. The presence of a
cross-platform tester target, alternatives for Desktop targets that use
the stable embedder API and the fact that this target is no longer
tested, makes having this code in the source entirely redundant.
 2018-09-22 15:56:50 -07:00
Chinmay Garde
7cebfdf58e Ensure that objects on stack that close traces have unique variable names. (flutter/engine#6298) 2018-09-22 14:46:29 -07:00
skia-flutter-autoroll
c6a27001b8 Roll src/third_party/skia 11f4994b84e1..175b587a634d (1 commits) (flutter/engine#6313) 
https://skia.googlesource.com/skia.git/+log/11f4994b84e1..175b587a634d


Created with:
  gclient setdep -r src/third_party/skia@175b587a634d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-22 02:30:18 -04:00
skia-flutter-autoroll
fb01e41576 Roll src/third_party/skia 358558a4cecc..11f4994b84e1 (2 commits) (flutter/engine#6312) 
https://skia.googlesource.com/skia.git/+log/358558a4cecc..11f4994b84e1


Created with:
  gclient setdep -r src/third_party/skia@11f4994b84e1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-21 21:16:17 -04:00
James D. Lin
af03555a34 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 
* Make FlutterStandardCodec handle writing NSData

iOS developers can accidentally pass an `NSData` object directly to
`FlutterStandardCodec` and forget to wrap it in
`FlutterStandardTypedData`.  This failure won't be caught until
runtime.

Let's make `FlutterStandardCodec` more tolerant by making it assume
that `NSData` should be treated as a binary blob and by wrapping it
automatically.

Fixes https://github.com/flutter/flutter/issues/17449

Testing Done:
* Made a sample Flutter iOS application that created a
  `FlutterMethodChannel` and invoked a method using an `NSData*`
  argument.  Verified that the Flutter method handler received the
  message and that the `MethodCall.arguments` was a `UInt8Array` that
  preserved the original byte order.
* Verified that without this change, the same sample application
  crashed when run in debug mode.

* Add a unit test for encoding raw NSData

* Formatting adjustments
 2018-09-21 15:46:40 -07:00
Amir Hardon
881edf98a4 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) 
Decouple PlatformViewsController from FlutterView.

Instead of getting a FlutterView instance, depend on the specific interfaces required by
PlatformViewsController (BinaryMessenger, TextureRegistry, and Context).

This allows using PlatformViewsControlling in the flutter/embedding
code.
 2018-09-21 15:40:17 -07:00
Amir Hardon
4fabc88cc2 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307) 
* Revert "Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)"

This reverts commit 18ec58629e7d90c89ea98a82f669eaccd5f82bb3.

* Revert "Update deprecated subtags from language subtag registry. (#6280)"

This reverts commit 6e159af6f2875f517aa8734538652fe9c20f1f21.

* Revert "Add Xib splashscreen support (#6289)"

This reverts commit 9c2a3826c70f726c2fbfb2ca6a51aa8826cece30.

* Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)"

This reverts commit 911b381f71ebeab7c1099b9aacf7f1dec3022229.
 2018-09-21 15:17:45 -07:00
skia-flutter-autoroll
2f4a321b41 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308) 
https://skia.googlesource.com/skia.git/+log/c25f440d537e..358558a4cecc


Created with:
  gclient setdep -r src/third_party/skia@358558a4cecc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-09-21 17:52:17 -04:00
James D. Lin
18ec58629e Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 
To make "Engine run configuration was invalid." failures (e.g.
https://github.com/flutter/flutter/issues/20777) a bit easier to
diagnose, add some more logging to `FlutterDartProject` to verify
that snapshot assets were properly bundled.
 2018-09-21 14:05:30 -07:00
hugovdm
6e159af6f2 Update deprecated subtags from language subtag registry. (flutter/engine#6280) 2018-09-21 12:29:45 -07:00
kzietek
9c2a3826c7 Add Xib splashscreen support (flutter/engine#6289) 2018-09-21 12:20:18 -07:00
KyleWong
911b381f71 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) 2018-09-21 12:17:00 -07:00