John "codefu" McDole
|
e068a3e6c4
|
chore: move engine docs out of engine/ and into docs/ (#175195)
Moving docs to be co-located with other docs + updating links. This has
the benefit of not including docs in engine content hash semantics.
|
2025-09-16 18:19:50 +00:00 |
|
Jenn Magder
|
f290249795
|
Set Gemini Code Assist include_drafts to false (#175098)
Set `include_drafts` to false so Gemini Code Assist doesn't comment on
draft PRs.
"Enables agent functionality on draft pull requests. Default: true."
https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#default-configuration
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-09-15 19:05:27 +00:00 |
|
Justin McCandless
|
a4cb00ae15
|
Clarify how Gemini should handle conflicting guidelines (#174294)
I ran into a case where [Gemini gave me bad code style
advice](https://github.com/flutter/flutter/pull/174291#pullrequestreview-3145289916)
that it got from Effective Dart even though it conflicted with the
Flutter styleguide. This is my attempt to remedy that.
Fixes https://github.com/flutter/flutter/issues/174293
|
2025-08-25 16:20:37 +00:00 |
|
Matan Lurey
|
f79602d6f9
|
Update .gemini/styleguide.md to encourage master-only (#174065)
No idea if this will work.
|
2025-08-21 22:26:03 +00:00 |
|
Jenn Magder
|
91bc77d790
|
Add review agent style guidelines to .gemini/styleguide.md (#174000)
A copy of @stuartmorgan-g change at
https://github.com/flutter/packages/pull/9805
> Initial attempt at adding guidance for GCAfGH to try cut down on the
behavior observed so far that it:
> - Almost always includes generic praise for the PR, which is unhelpful
since the agent has no context for evaluating what PRs we actually want
(see [this particularly problematic
example](https://github.com/flutter/packages/pull/9795#pullrequestreview-3113026764))
> - Appears to trust PR descriptions. E.g., recently praising a PR that
was missing tests of most of the PR, but had a PR description saying it
included extensive testing, as being extremely well tested.
Here are examples of summaries from the packages repo before and after
this change:
Before (praise like "great refactoring effort", "significantly improves
the modularity and maintainability", "extensive documentation updates
are also a major improvement"):
> This pull request is a great refactoring effort. Moving the ProxyAPI
generation logic into a dedicated helper file
(`proxy_api_generator_helper.dart`) significantly improves the
modularity and maintainability of the Dart generator. The extensive
documentation updates are also a major improvement, making the concepts
around ProxyAPIs much clearer for developers.
https://github.com/flutter/packages/pull/9756
After (drier, describing the actual change without making normative
evaluation):
> This pull request introduces a new `clearAuthorizationToken` method
across all layers of the `google_sign_in` plugin. This allows developers
to manually clear a cached authorization token if it becomes invalid.
The implementation is handled natively on Android, is a no-op on iOS (as
the SDK handles it), and clears a local cache on the web. The changes
include updates to the platform interface, implementations for each
platform, and corresponding tests and documentation.
https://github.com/flutter/packages/pull/9846#pullrequestreview-3129402056
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-08-21 00:27:09 +00:00 |
|
Kate Lovett
|
b588b3b46f
|
Update GCA instructions (#173001)
Based on
https://github.com/flutter/flutter/pull/172986/files#r2243517637
Let's see if this tweak helps!
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-08-01 16:23:36 +00:00 |
|
Jenn Magder
|
6a8969ceca
|
Avoid negatives in the styleguide.md (#172917)
Tell Gemini styleguide.md reference what to do instead of what not to
do.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-07-31 21:19:05 +00:00 |
|
Jenn Magder
|
30ae030c62
|
Fix Gemini Code Assist for GitHub config yaml (#172887)
Gemini Code Assist for GitHub config seems incorrect, though the comment
doesn't tell us what's wrong.
https://github.com/flutter/flutter/pull/172886#issuecomment-3130134128
<img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM"
src="https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358"
/>
Speculating the yaml doesn't like the `**`.
Introduced in https://github.com/flutter/flutter/pull/172785
---------
Co-authored-by: John "codefu" McDole <john@mcdole.org>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: John "codefu" McDole <codefu@google.com>
|
2025-07-29 16:02:08 +00:00 |
|
Jenn Magder
|
b2cc192a31
|
Add Gemini Code Assist review config and style guide (#172785)
- Initial config files for [Gemini Code Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
These config files are modified versions of the one already added to the
flutter/packages repo: https://github.com/flutter/packages/pull/9632
based on [the official
docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
- Style guide has links to various contributing docs and style guides.
- Ignore paths associated with version pins and third_party to avoid
reviews on rolls and code that doesn't need modification. See
https://github.com/flutter/packages/pull/9647.
- Add a note to the PR template to provide some notice/guidance to
contributors about how to use automated feedback, to clarify the role of
the automated reviews and hopefully minimize potential issues in case
the bot leaves incorrect feedback. This is a direct copy of the comment
introduced in https://github.com/flutter/packages/pull/9632.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-07-28 18:05:22 +00:00 |
|