Pierre-Louis
52299fa34f
Cache floating cursor location on start event instead of update ( #62415 )
2020-08-03 10:26:07 -07:00
chunhtai
8663b3c4bf
Reland "remove usage to applyTextScaleFactorToWidgetSpan" ( #62587 )
...
This reverts commit 561735ad89a14c63597f9acb77d447c7e0ed4fec.
2020-07-31 10:18:20 -07:00
Nolan Scobie
19f8fb1cac
Fix SemanticsNode.rect position for nested scrollables with useTwoPaneSemantics ( #62359 )
2020-07-31 09:46:06 -07:00
xubaolin
aa1acd8e54
Ignore unmounted parent when _debugVerifyGlobalKeyReservation for GlobalKey check ( #62323 )
...
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055 )
2020-07-30 10:07:18 -07:00
Tong Mu
5398f5c566
Add tests for platform views' hover behavior ( #61667 )
2020-07-29 14:47:06 -07:00
Hans Muller
6139708eaf
Added OverflowBar widget ( #62350 )
2020-07-29 13:41:04 -07:00
Justin McCandless
a4d570f0dd
SelectableText handles after Select All ( #62072 )
2020-07-29 08:26:05 -07:00
Rami
0a69e810b1
[Material] Add support for high contrast theming to Material apps ( #62337 )
2020-07-29 08:06:06 -07:00
Darren Austin
2856d663d5
Updated the framework tests to use the new button API. ( #62220 )
2020-07-28 15:21:06 -07:00
Kate Lovett
9bf1793a10
Fix crossSize for baseline ( #62074 )
2020-07-28 10:36:15 -07:00
LongCatIsLooong
fe88a88a5a
Autofill save ( #58731 )
2020-07-28 10:23:17 -07:00
Yuqian Li
7c942e390f
Add a test for 3D transform with needsCompositing ( #61779 )
2020-07-28 10:21:08 -07:00
Michael Goderbauer
175e5c9aca
Restoration Framework ( #60375 )
...
* state restoration
* added example
* typos and analyzer
* whitespace
* more typos
* remove unnecessary import
* whitespace
* fix sample code
* tests for restorationmanager and restorationid
* ++
* typo
* tests for bucket, part1
* rename tests
* more tests
* finished tests for service layer
* remove wrong todo
* ++
* review comments
* tests for Unmanaged and regular scope
* RootRestorationScope tests
* typo
* whitespace
* testing framework
* tests for properties
* last set of tests
* analyzer
* typo
* dan review
* whitespace
* ++
* refactor finalizers
* ++
* ++
* dispose guard
* ++
* ++
* dan review
* add manager assert
* ++
* analyzer
* greg review
* fix typo
* Ian & John review
* ian review
* RestorationID -> String
* revert comment
* Make primitives non-nullable in prep for NNBD
2020-07-28 10:16:36 -07:00
chunhtai
734782f5d7
clean up hero controller scope ( #60655 )
2020-07-28 10:11:09 -07:00
Daniel Iglesia
0fdb21f31f
Adds an onMove callback on a DragTarget. ( #60174 )
2020-07-28 09:56:09 -07:00
Todd Volkert
6e252772d1
Add support for system alert sound ( #62086 )
...
* Add SystemSoundType.alert (supported in the engine in flutter/engine#19970 )
* Play system alert sound when user tries to dismiss a non-dismissable modal
barrier
2020-07-24 15:49:41 -07:00
Kate Lovett
d1411a1626
Remove unused FlutterErrorDetails subclasses ( #61579 )
2020-07-24 15:36:08 -07:00
chunhtai
561735ad89
Revert "remove usage to applyTextScaleFactorToWidgetSpan ( #61636 )" ( #62144 )
...
This reverts commit c816fabd0af48a861afdeb78bb6ebe4b7cbd3707.
2020-07-23 10:35:21 -07:00
LongCatIsLooong
64173f75c3
Check if a double is NaN before converting to it int ( #61940 )
2020-07-23 08:31:08 -07:00
Michael Goderbauer
8e58c51d1a
Update viewport dimensions when scrollDirection changes ( #61973 )
2020-07-23 08:30:26 -07:00
Greg Spencer
cac22cdb08
Fix ExcludeFocus so it won't refocus a sibling of the focused node. ( #61756 )
...
This changes FocusNode.descendantsAreFocusable so that it doesn't allow the enclosing scope to re-focus a node that is a descendant of the node with descendantsAreFocusable set to false.
Because of the order in which the internal state for descendantsAreFocusable was being set, setting it to false was causing a sibling node to be focused when descendantsAreFocusable of the parent was set to false, even though it shouldn't have been focusable, because the enclosing scope would search for a candidate to be focused before the internal state was set to false.
Instead of looping over the children and telling them all to unfocus (and select the previously focused node), this unfocuses the node that has descendantsAreFocusable set to false, with the disposition UnfocusDisposition.previouslyFocusedChild, so that its enclosing scope will look for a previously focused child that isn't part of the subtree being excluded.
This affects how the ExcludeFocus widget behaves when turning on exclude.
2020-07-23 08:27:53 -07:00
Abdur Rafay Saleem
b8df8a8368
Allowed specifying reverseTransitionDuration in PageRouteBuilder class ( #61752 )
2020-07-22 18:41:09 -07:00
chunhtai
c816fabd0a
remove usage to applyTextScaleFactorToWidgetSpan ( #61636 )
2020-07-22 18:41:06 -07:00
Todd Volkert
67a9ae173b
Update Actions.invoke to return the result of invoking the action. ( #62012 )
...
The boolean value as to whether the action was found and enabled
is less useful than just returning the result of invoking the action
itself.
2020-07-22 18:27:38 -07:00
David Martos
6d303af97e
Use the correct Transform in the WidgetInspector overlay ( #59566 ) ( #60990 )
2020-07-22 18:26:07 -07:00
Pierre-Louis
5d854f63a0
Implement customizable cursor height ( #61714 )
2020-07-21 07:36:03 -07:00
Chris Yang
30e556ddc5
Add no-op callbacks to platform view gesture recognizer when necessary ( #61671 )
...
After #31935 , Some one sequence gesture recognizers requires at least one callback to be able to compete in the arena. This PR adds the a no-op callback in the gesture recognizer in the platform view when the gesture recognizer does not have any callbacks. This way, all the gesture recognizers in the platform view can compete in the arena.
2020-07-17 12:13:22 -07:00
Bogdan Lukin
9ef8192760
Fix/decoration equality ( #61551 )
2020-07-16 11:26:04 -07:00
Todd Volkert
e2cdc9f981
Allow transparent barrierColor in showDialog methods ( #61516 )
...
`showDialog()` and `showGeneralDialog()` were allowing transparent
colors but then triggering an assertion down the stack while building
the modal barrier. The assertion existed to keep from animating from
transparent to transparent, but there's no need for the assertion,
since we can just treat the transparent case as the same as the null
case -- no animation necessary.
2020-07-16 09:43:47 -07:00
Kate Lovett
16d5dd9b13
Fix NestedScrollView inner ballistic activity for 0 velocity ( #61386 )
2020-07-16 09:41:04 -07:00
Pedro Massango
5a69de8263
FormField should autovalidate only if its content was changed (fixed) ( #59766 )
2020-07-16 09:31:05 -07:00
Todd Volkert
0d2421d5df
Add defaults to showGeneralDialog() ( #61503 )
...
The function passes most of its arguments through to
`_DialogRoute`, but it wasn't providing the default
values that `_DialogRoute` was, causing it to override
the defaults will null values.
2020-07-15 11:53:55 -07:00
Alexandre Ardhuin
978a2e7bf6
migrate foundation to nullsafety ( #61188 )
...
* migrate foundation to nullsafety
* address review comments
2020-07-15 18:55:27 +02:00
Neevash Ramdial
e24cdab517
Re-land Expose height and width factor in AnimatedAlign ( #61136 )
2020-07-15 09:46:03 -07:00
Todd Volkert
3ce06efd40
Default textBaseline to alphabetic in Flex ( #61425 )
2020-07-14 22:36:02 -07:00
Todd Volkert
74f3e6dd63
Add assert to Table to check for rows with null children ( #61457 )
2020-07-14 12:20:22 -07:00
Andre
06a35b3322
Improve error reporting for RenderObject visitChildren errors ( #61455 )
...
* Improve error reporting for RenderObject visitChildren errors
* Nits and fixes
2020-07-14 14:21:14 -04:00
chunhtai
f7688c5001
issue 61346 route can be added and disposed in the same frame ( #61375 )
2020-07-13 16:11:03 -07:00
Tong Mu
da8695d389
Mouse events report correct local positions ( #61190 )
2020-07-13 13:26:03 -07:00
Dan Field
a9ea825abf
Do not cache itemBuilder calls in a GridView ( #61033 )
2020-07-08 21:26:03 -07:00
LongCatIsLooong
a6ce2d4bc7
Assert valid composing TextRange ( #60956 )
2020-07-08 21:21:02 -07:00
Kate Lovett
debb3a5d28
Skip Audit - Widgets Library ( #60936 )
2020-07-08 19:26:03 -07:00
chunhtai
496ef4f77e
prevents sliver app bar from changing semantics tree when it is not necesaary ( #61012 )
2020-07-08 18:21:08 -07:00
chunhtai
00b1903bbc
Add a flag to toggle navigator route update reporting ( #60621 )
2020-07-08 18:16:04 -07:00
Mehmet Fidanboylu
cc1af3afb6
Revert "Expose height and width factor in AnimatedAlign ( #60836 )" ( #61109 )
...
This reverts commit e8e1eb51a41d53eada80f508d5c69c908c67ea30.
2020-07-08 10:19:36 -07:00
Justin McCandless
a82005a9dc
InteractiveViewer pan axis locking ( #61019 )
2020-07-08 09:51:02 -07:00
Neevash Ramdial
e8e1eb51a4
Expose height and width factor in AnimatedAlign ( #60836 )
2020-07-07 17:44:07 -07:00
zljj0818
11ff938af5
Added a filterQuality parameter to texture ( #59966 )
2020-07-07 17:39:04 -07:00
Tong Mu
6f4c4b3cf8
Refactor mouse hit testing system: Direct mouse hit test ( #59883 )
2020-07-06 17:44:02 -07:00
Ram Navan
60deae8546
Issues/58053 - Set default textBaseline to alphabetic in the Table widget ( #60586 )
2020-07-06 12:19:02 -07:00