3744 Commits

Author SHA1 Message Date
Pierre-Louis
52299fa34f
Cache floating cursor location on start event instead of update (#62415) 2020-08-03 10:26:07 -07:00
chunhtai
8663b3c4bf
Reland "remove usage to applyTextScaleFactorToWidgetSpan" (#62587)
This reverts commit 561735ad89a14c63597f9acb77d447c7e0ed4fec.
2020-07-31 10:18:20 -07:00
Nolan Scobie
19f8fb1cac
Fix SemanticsNode.rect position for nested scrollables with useTwoPaneSemantics (#62359) 2020-07-31 09:46:06 -07:00
xubaolin
aa1acd8e54
Ignore unmounted parent when _debugVerifyGlobalKeyReservation for GlobalKey check (#62323)
* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)

* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)

* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)

* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)

* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)

* Ignore unmounted parent when _debugVerifyGlobalKeyReservation (#62055)
2020-07-30 10:07:18 -07:00
Tong Mu
5398f5c566
Add tests for platform views' hover behavior (#61667) 2020-07-29 14:47:06 -07:00
Hans Muller
6139708eaf
Added OverflowBar widget (#62350) 2020-07-29 13:41:04 -07:00
Todd Volkert
da62b6ded2
Fix Border.symmetric: phase 3 (#62471)
This removes the (now unused) `invertMeaningOfVerticalAndHorizontal`
flag.

Fixes https://github.com/flutter/flutter/issues/61470
2020-07-29 10:20:39 -07:00
Justin McCandless
a4d570f0dd
SelectableText handles after Select All (#62072) 2020-07-29 08:26:05 -07:00
Rami
0a69e810b1
[Material] Add support for high contrast theming to Material apps (#62337) 2020-07-29 08:06:06 -07:00
Darren Austin
2856d663d5
Updated the framework tests to use the new button API. (#62220) 2020-07-28 15:21:06 -07:00
Rami
064a9e5783
Ensure banner reads banner theme's leading padding property (#62195) 2020-07-28 15:11:09 -07:00
Michael Goderbauer
1d5a9ae215
Update the FlutterLogo colors and gradients (#62052) 2020-07-28 15:06:04 -07:00
Darren Austin
d169880278
Updated references to the old button classes to the new ones in comments and documentation for tests in the material and cupertino libraries. (#62164) 2020-07-28 11:01:04 -07:00
Darren Austin
76c7ca5433
Updated the About dialog to use the new button API. (#62075) 2020-07-28 10:36:19 -07:00
Kate Lovett
9bf1793a10
Fix crossSize for baseline (#62074) 2020-07-28 10:36:15 -07:00
chunhtai
b2c737547f
makes PopupMenuitem merge the semantics of its child (#62062) 2020-07-28 10:26:10 -07:00
LongCatIsLooong
fe88a88a5a
Autofill save (#58731) 2020-07-28 10:23:17 -07:00
Yuqian Li
7c942e390f
Add a test for 3D transform with needsCompositing (#61779) 2020-07-28 10:21:08 -07:00
Michael Goderbauer
175e5c9aca
Restoration Framework (#60375)
* state restoration

* added example

* typos and analyzer

* whitespace

* more typos

* remove unnecessary import

* whitespace

* fix sample code

* tests for restorationmanager and restorationid

* ++

* typo

* tests for bucket, part1

* rename tests

* more tests

* finished tests for service layer

* remove wrong todo

* ++

* review comments

* tests for Unmanaged and regular scope

* RootRestorationScope tests

* typo

* whitespace

* testing framework

* tests for properties

* last set of tests

* analyzer

* typo

* dan review

* whitespace

* ++

* refactor finalizers

* ++

* ++

* dispose guard

* ++

* ++

* dan review

* add manager assert

* ++

* analyzer

* greg review

* fix typo

* Ian & John review

* ian review

* RestorationID -> String

* revert comment

* Make primitives non-nullable in prep for NNBD
2020-07-28 10:16:36 -07:00
chunhtai
734782f5d7
clean up hero controller scope (#60655) 2020-07-28 10:11:09 -07:00
Daniel Iglesia
0fdb21f31f
Adds an onMove callback on a DragTarget. (#60174) 2020-07-28 09:56:09 -07:00
Todd Volkert
a48446f94b
Fix error handling for errors with empty stack traces (#62224)
Fixes https://github.com/flutter/flutter/issues/62223
2020-07-24 15:50:01 -07:00
Todd Volkert
6e252772d1
Add support for system alert sound (#62086)
* Add SystemSoundType.alert (supported in the engine in flutter/engine#19970)
* Play system alert sound when user tries to dismiss a non-dismissable modal
  barrier
2020-07-24 15:49:41 -07:00
Pedro Massango
5142a30434
Add minWidth and height parameter into FlatButton widget (#61664) 2020-07-24 15:41:09 -07:00
Kate Lovett
d1411a1626
Remove unused FlutterErrorDetails subclasses (#61579) 2020-07-24 15:36:08 -07:00
chunhtai
561735ad89
Revert "remove usage to applyTextScaleFactorToWidgetSpan (#61636)" (#62144)
This reverts commit c816fabd0af48a861afdeb78bb6ebe4b7cbd3707.
2020-07-23 10:35:21 -07:00
LongCatIsLooong
64173f75c3
Check if a double is NaN before converting to it int (#61940) 2020-07-23 08:31:08 -07:00
Michael Goderbauer
8e58c51d1a
Update viewport dimensions when scrollDirection changes (#61973) 2020-07-23 08:30:26 -07:00
Greg Spencer
cac22cdb08
Fix ExcludeFocus so it won't refocus a sibling of the focused node. (#61756)
This changes FocusNode.descendantsAreFocusable so that it doesn't allow the enclosing scope to re-focus a node that is a descendant of the node with descendantsAreFocusable set to false.

Because of the order in which the internal state for descendantsAreFocusable was being set, setting it to false was causing a sibling node to be focused when descendantsAreFocusable of the parent was set to false, even though it shouldn't have been focusable, because the enclosing scope would search for a candidate to be focused before the internal state was set to false.

Instead of looping over the children and telling them all to unfocus (and select the previously focused node), this unfocuses the node that has descendantsAreFocusable set to false, with the disposition UnfocusDisposition.previouslyFocusedChild, so that its enclosing scope will look for a previously focused child that isn't part of the subtree being excluded.

This affects how the ExcludeFocus widget behaves when turning on exclude.
2020-07-23 08:27:53 -07:00
Abdur Rafay Saleem
b8df8a8368
Allowed specifying reverseTransitionDuration in PageRouteBuilder class (#61752) 2020-07-22 18:41:09 -07:00
chunhtai
c816fabd0a
remove usage to applyTextScaleFactorToWidgetSpan (#61636) 2020-07-22 18:41:06 -07:00
Todd Volkert
67a9ae173b
Update Actions.invoke to return the result of invoking the action. (#62012)
The boolean value as to whether the action was found and enabled
is less useful than just returning the result of invoking the action
itself.
2020-07-22 18:27:38 -07:00
Pierre-Louis
629395f7ad
Add per thumb Range Slider semantics (#61439) 2020-07-22 18:26:11 -07:00
David Martos
6d303af97e
Use the correct Transform in the WidgetInspector overlay (#59566) (#60990) 2020-07-22 18:26:07 -07:00
chunhtai
c44e5a32b5
Revert "InkDecoration do not paint if it's part of the tree doesn't get painted (#61216)" (#61963)
This reverts commit fdf87edd2fadb3ba3219d23792f0210384533e1b.
2020-07-21 09:35:40 -07:00
Pierre-Louis
5d854f63a0
Implement customizable cursor height (#61714) 2020-07-21 07:36:03 -07:00
xubaolin
fdf87edd2f
InkDecoration do not paint if it's part of the tree doesn't get painted (#61216) 2020-07-20 18:56:04 -07:00
chunhtai
3577da53ff
Revert "fix intrinsic height and width for widget span (#61485)" (#61876)
This reverts commit fc09119d0af589ade9c7e0609777a46ed773f5d7.
2020-07-20 09:54:50 -07:00
chunhtai
09dfca6f5d
add static method to create material hero controller (#61662) 2020-07-17 14:26:03 -07:00
Jimmy Wei
14dcbb2d84
Fix overflow issue caused by a long title/subtitle for the vertical stepper (#61623) 2020-07-17 14:21:03 -07:00
Chris Yang
30e556ddc5
Add no-op callbacks to platform view gesture recognizer when necessary (#61671)
After #31935, Some one sequence gesture recognizers requires at least one callback to be able to compete in the arena. This PR adds the a no-op callback in the gesture recognizer in the platform view when the gesture recognizer does not have any callbacks. This way, all the gesture recognizers in the platform view can compete in the arena.
2020-07-17 12:13:22 -07:00
Konstantin Scheglov
741e9675e7
Remote returns for function expression inferred return type void. (#61582) 2020-07-17 09:36:03 -07:00
Todd Volkert
1840b7121a
Make scrollbar thickness and radius customizable (#61401)
* Make scrollbar thickness and radius customizable

https://github.com/flutter/flutter/issues/29576
https://github.com/flutter/flutter/issues/36412

* Add docs for constants

* No more magic numbers in test
2020-07-16 23:15:23 -07:00
Todd Volkert
7ea710c56e
Fix Border.symmetric: phase 2 (#61666)
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

https://github.com/flutter/flutter/issues/61470
2020-07-16 23:14:44 -07:00
Michael Goderbauer
1b406159f2
Give better error message for describeEnum (#61581) 2020-07-16 16:21:05 -07:00
Bogdan Lukin
9ef8192760
Fix/decoration equality (#61551) 2020-07-16 11:26:04 -07:00
Todd Volkert
e2cdc9f981
Allow transparent barrierColor in showDialog methods (#61516)
`showDialog()` and `showGeneralDialog()` were allowing transparent
colors but then triggering an assertion down the stack while building
the modal barrier. The assertion existed to keep from animating from
transparent to transparent, but there's no need for the assertion,
since we can just treat the transparent case as the same as the null
case -- no animation necessary.
2020-07-16 09:43:47 -07:00
Kate Lovett
16d5dd9b13
Fix NestedScrollView inner ballistic activity for 0 velocity (#61386) 2020-07-16 09:41:04 -07:00
Hans Muller
d90a246461
Corrected splash color for TextButton, ElevatedButton, OutlinedButton (#61576) 2020-07-16 09:40:11 -07:00
chunhtai
fc09119d0a
fix intrinsic height and width for widget span (#61485) 2020-07-16 09:36:09 -07:00