1962 Commits

Author SHA1 Message Date
Gary Qian
50c528c9aa Rename 'test_vsync_waiters' to 'vsync_waiters_test' for consistency. (flutter/engine#14519) 2019-12-18 04:32:03 +09:00
liyuqian
8dcf0235e5 Apply SmoothPointerDataDispatcher to Fuchsia (flutter/engine#14514)
Fixes https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=35050
and https://github.com/flutter/flutter/issues/38811
2019-12-16 17:14:19 -08:00
Chinmay Garde
54f9ebe7a9 Forward low memory notifications from the shell to DartVM. (flutter/engine#14517) 2019-12-16 16:55:08 -08:00
Chinmay Garde
4435ab8b04 Allow custom embedders to post low memory notifications. (flutter/engine#14506)
This is a non-breaking addition to the stable Flutter Embedder API.
2019-12-16 11:42:13 -08:00
Wu Zhong
6533879f59 Fix comments of iOS status bar height constant (flutter/engine#14496) 2019-12-15 12:34:21 -08:00
Chinmay Garde
b111a13d25 Allow embedders to post Dart objects on send ports from the native side. (flutter/engine#14477)
This is a non-breaking addition to the stable Flutter Embedder API and exposes a
subset of the functionality provided by Dart_PostCObject API in a stable and
tested manner to custom embedder implementations.

Send port acquisition can currently be done as described in the unit-test but
there may be opportunities to extend this API in the future to access ports more
easily or create ports from the native side.

The following capabilities of the the Dart_PostCObject API are explicitly NOT
exposed:
* Object arrays: This allows callers to create complex object graphs but only
  using the primitives specified in the native API. I could find no current use
  case for this and would have made the implementation a lot more complex. This
  is something we can add in the future if necessary however.
* Capabilities and ports: Again no use cases and I honestly I didn’t understand
  how to use capabilities. If needed, these can be added at a later point by
  appending to the union.

Fixes https://github.com/flutter/flutter/issues/46624
Fixes b/145982720
2019-12-13 17:28:21 -08:00
Chinmay Garde
5f6e426048 Verify embedders can convert clip rects from mutation stack into surface space. (flutter/engine#14483)
Add a test to verify behavior discussed in b/143612326
2019-12-13 15:28:01 -08:00
Kaushik Iska
4107c00949 [animator] Pass target frametime for Window.onBeginFrame (flutter/engine#14318)
This gives us a time closer to when the frame will be rendered on
screen.

Fixes: https://github.com/flutter/flutter/issues/10850
2019-12-12 15:03:27 -08:00
Miguel
c66d593a73 [fuchsia] Add diagnostics directory to the set of remote dirs (flutter/engine#14470) 2019-12-12 14:50:49 -08:00
Kaushik Iska
1150b2e5af [testing] Make vsync waiters pluggable in shell_unittests (flutter/engine#14463)
This makes it so that the platform views can be passed
an arbitraty CreateVsyncWaiter callback that lets us inject
a vsync waiter other than just the simulated monotonic vsync waiter
that currently exists.
2019-12-12 14:15:36 -08:00
Chinmay Garde
cdbdb7999d Use futures to images used for comparison with fixtures in embedder unit-tests. (flutter/engine#14465)
This earlier pattern was to use callbacks with latching.
2019-12-12 14:07:53 -08:00
Kaushik Iska
10205291d4 [testing] Move test vsync waiters to their own TUs (flutter/engine#14456)
This move makes it easier to add more vsync waiters.
2019-12-12 12:27:56 -08:00
Justin McCandless
533f607e6a Smart quote/dash configuration support in iOS (flutter/engine#13863)
Support for UITextSmartDashesType and UITextSmartQuotesType in iOS
2019-12-12 10:54:31 -05:00
Nathan Rogers
8e09f317a6 [flutter_runner] Enable Skia tracing by default on Fuchsia (flutter/engine#13457)
Since Flutter tracing is wired up to Fuchsia system level tracing (and
that includes Skia tracing within Flutter), it makes more sense to
enable Skia tracing by default on Fuchsia, and to control Flutter Skia
tracing, rely on whether Fuchsia system tracing is enabled, in progress,
and contains the "skia" category.
2019-12-11 21:03:12 -08:00
Kaushik Iska
aca6a4f55a [tests] Use distinct begin and end times (flutter/engine#14361) 2019-12-11 17:23:49 -08:00
xster
86730dee7b objcdoc fix for some ambiguity (flutter/engine#14367) 2019-12-11 16:43:22 -08:00
Wu Zhong
fd89277550 Fix CGMutablePathRef memory leaks when the path is invalid. (flutter/engine#14275) 2019-12-11 15:52:29 -08:00
Chinmay Garde
439b705342 Assert that arc end caps on canvases with root surface transformations are drawn correctly. (flutter/engine#14359)
Verifies that the Skia commit https://skia-review.googlesource.com/c/skia/+/259174 has been pulled into the engine. This should have happened in the roll https://github.com/flutter/engine/pull/14345.

Fixes https://github.com/flutter/flutter/issues/46691
Fixes b/142280381
2019-12-11 15:17:34 -08:00
Jim Graham
17e3cf8e55 Conditionally use offscreen root surface only when needed
Currently helps primarily on iOS when no BackdropFilter is present by lowering energy usage
2019-12-11 15:10:55 -08:00
Kaushik Iska
c172d3522a [fuchsia] Move async_get_default_dispatcher include to the header (flutter/engine#14351) 2019-12-11 13:40:38 -08:00
Kaushik Iska
bef91dd904 Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl... (flutter/engine#14342)
* Roll fuchsia/sdk/core/linux-amd64 from UdfLO... to 9wKTl...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

* async set dispatcher is now from async-default
2019-12-11 11:47:30 -08:00
Kaushik Iska
d140623043 [fuchsia] Do not Execute paint tasks when there is no vsync (flutter/engine#14298)
This should also reduce the number of OnSurfacesPresented calls
made.
2019-12-10 18:03:55 -08:00
liyuqian
d067c4a259 Cleanup the IO thread GrContext (flutter/engine#14265)
Fixes https://github.com/flutter/flutter/issues/19558

This is tested by the devicelab test fast_scroll_large_images__memory
2019-12-10 16:02:02 -08:00
Craig Stout
cb33e504a1 [shell][fuchsia] Add lib/async/default.h
For async_get_default_dispatcher().
2019-12-09 15:21:45 -08:00
Andy Weiss
5ee8bb73fe Add support for setting window size limits for glfw (flutter/engine#13415)
Add a function to the window which calls the glfw function for fixing
the size limits of the window. This can then be called after window
creation.
2019-12-08 13:58:58 -08:00
Kaushik Iska
ab66e5740f [fuchsia] SnapToNextPhase refactor + add tests and documentation (flutter/engine#14158) 2019-12-06 13:47:36 -08:00
Filip Filmar
47c8615577 Configures ICU to load the timezone data (flutter/engine#13952)
The timezone data in Fuchsia is at a fixed path. This will have the
flutter runner attempt to load it and log, but not fail if loading
does not work out.

Added two tests

(1) Shows that the specific TZ data version loaded takes effect after
initialization

(2) Shows that when TZ data files are absent the initialization
continues.
2019-12-05 17:32:55 -08:00
Dan Field
168f41ba44 Raise API level for reportFullyDrawn (flutter/engine#14146) 2019-12-05 14:51:55 -08:00
gaaclarke
e479d6ad89 Started setting the FlutterOverlayView's bounds when it gets added to its superview. (flutter/engine#14018) 2019-12-05 13:53:07 -08:00
Dan Field
fcab1c7433 Disable a11y on detach (flutter/engine#14142) 2019-12-05 11:16:38 -08:00
David Worsham
cb0aca7f74 Wire up Opacity on Fuchsia, round 2 (flutter/engine#14024)
* Remove erroneous ChildView opacity

* Wire frame metrics through contexts

* Maintain layer stack inside of SceneBuilder

* Remove EnsureSingleChild

* Centralize system-composite and elevation logic

* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
Chinmay Garde
ce4d1dc06f Fix platform view offsets incorrectly taking into account device pixel ratios. (flutter/engine#14135)
This issue was hidden by an incorrect test expectation that has been corrected.

Fixes b/144555069
Fixes https://github.com/flutter/flutter/issues/45991
2019-12-04 13:15:47 -08:00
David Worsham
df08c2593a Relanding: Add Flow unittests and fixtures (flutter/engine#14091) 2019-12-03 14:33:02 -08:00
Kaushik Iska
16ee373dc9 Revert "Fix fml_unittests (#14062)" (flutter/engine#14087)
This reverts commit ca9e7fc470843285b50999fa0e41ba29084ad474.
2019-12-03 12:24:19 -08:00
liyuqian
52e74298e0 Revert PRs to unblock David and Jim's work (flutter/engine#14088)
* Revert "Add flow test fixtures and tests (#13986)"

This reverts commit 32915132bacdfd0d631421b23bb6a6d5db1095ab.

* Revert "Dynamically determine whether to use offscreen surface based on need (#13976)"

This reverts commit a13401ce86b3019c39154d56644b7b9eb4a5bbe5.
2019-12-03 12:02:37 -08:00
David Worsham
32915132ba Add flow test fixtures and tests (flutter/engine#13986) 2019-12-03 09:43:02 -08:00
Dan Field
69d5294a7a Remove suprious warning (flutter/engine#14079) 2019-12-02 16:51:30 -08:00
stuartmorgan
8a11e4f2de Report backing store changes in the macOS view (flutter/engine#13933) 2019-12-02 16:33:04 -08:00
Francisco Magdaleno
3e6ba41538 Listen to keyUp event on meta modified keys (flutter/engine#13984) 2019-12-02 16:17:19 -08:00
Dan Field
f5aa0ec812 Fix live region logic (flutter/engine#14081) 2019-12-02 15:49:15 -08:00
David Worsham
ca9e7fc470 Fix fml_unittests (flutter/engine#14062) 2019-11-27 16:04:30 -08:00
Jim Graham
a13401ce86 Dynamically determine whether to use offscreen surface based on need (flutter/engine#13976)
Only use an offscreen surface on iOS if a layer which reads back from the destination surface, such as BackdropFilter, is present.
2019-11-27 15:01:25 -08:00
Gary Qian
e4ba568098 Revert "Do not default to downstream affinity on iOS insertText (#13852)" (flutter/engine#14053)
This reverts commit ffe1d3fca6199594535967cf9c05fb4a7ee7cc27.
2019-11-28 07:34:40 +09:00
神楽坂花火
d999372f50 Pass "null" when copy data is null to iOS pasteboard.string (flutter/engine#14046) 2019-11-27 23:46:30 +09:00
Gary Qian
b2a77134a6 Always set mEditable values when different in TextPlugin (flutter/engine#13951) 2019-11-27 07:51:04 +09:00
Dan Field
1d4b394228 Avoid retaining self in block (flutter/engine#14022) 2019-11-26 14:47:00 -08:00
Chinmay Garde
1405016707 Add a separate target for Dart coverter on FML types. (flutter/engine#14011)
The converters are still in a separate target that must be included manually. This allows targets that depend on FML but not Dart runtime not have to depend on the runtime.

Adds a test that includes this target and tests image decompression from assets. There is also a test for the standalone DartConvertor in shell_unittests but not in fml_unittests be cause FML uni-tests cannot yet launch a VM. I will work on adding fixtures for those.
2019-11-26 13:33:56 -08:00
gaaclarke
9442238326 Added docstring for FlutterOverlayView. (flutter/engine#14019) 2019-11-26 13:10:24 -08:00
Kaushik Iska
d6b2b657eb [vulkan] Bundle vulkan validation layer so files (flutter/engine#13930)
Enable vulkan validation for Fuchsia in debug mode as well.
2019-11-25 16:09:56 -08:00
Chinmay Garde
dee0c26a36 Don't crash but warn when the scene builder specifies no layers. (flutter/engine#14008) 2019-11-25 15:38:41 -08:00