DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,738 Commits 882 Branches 1,069 Tags
Commit Graph

23411 Commits

Author SHA1 Message Date
John McCutchan
50190fcaa6 Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) 
- Refactor AndroidExternalTextureGL into SurfaceTextureExternalTexture
base class with two specialized implementations:
- Add SurfaceTextureExternalTextureGL for legacy GL rendering.
- Add SurfaceTextureExternalTextureImpellerGL for Impeller GLES
rendering.

NOTE: There is still no support for SurfaceTextures under Vulkan
rendering.
 2023-08-15 14:25:03 -07:00
Jonah Williams
4367ca66ae [Impeller] Make porter duff blended atlas calls faster. (flutter/engine#44059) 
This implements part of https://github.com/flutter/flutter/issues/131345

---

Makes all porter-duff draw atlas blending avoid subpass creation, by tweaking the existing porter duff shader to support per-vertex colors and output opacity. This requires a small trick: What the blend shaders and what (drawAtlas/drawVertices) consider the source and destination is reversed. That is a blend mode color filter treats the color as the source whereas drawVertices/drawAtlas treat their per-vertex colors as the destination. Therefore I cannot simply make all color inputs per vertex and use the exact same shaders :(

However, for the porter duff blends we should just be able to reverse the blend mode (srcover -> dstOver, xor->xor) (I'm pretty sure I did this correctly) so that the blending is still correct. I don't think we can do this for the advanced blends, but supporting those is less important than the common atlas blending parameters like dstIn.

This PR only updates drawAtlas.
 2023-08-15 19:40:09 +00:00
skia-flutter-autoroll
015275a126 Roll Skia from 4beb6fd05f4f to c7c9e85a8657 (7 revisions) (flutter/engine#44729) 
https://skia.googlesource.com/skia.git/+log/4beb6fd05f4f..c7c9e85a8657

2023-08-15 jmbetancourt@google.com always make image asset if slotID is present
2023-08-15 johnstiles@google.com Add conditional-testing macros for Graphite unit tests.
2023-08-15 scroggo@google.com Update Android Viewer app instructions
2023-08-15 nicolettep@google.com Consider external format when determining whether YCBCR information is valid
2023-08-15 johnstiles@google.com Add nanobench entries for Graphite Metal/WGSL large shaders.
2023-08-15 bungeman@google.com Reland "[skunicode] Consolidate SkUnicode_IcuBidi"
2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from d672b19e7eab to 3590e8eac703

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 19:06:28 +00:00
skia-flutter-autoroll
3f8ae3d15b Roll Dart SDK from 19c87486f0a9 to b36934aae968 (1 revision) (flutter/engine#44728) 
https://dart.googlesource.com/sdk.git/+log/19c87486f0a9..b36934aae968

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-73.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 18:12:01 +00:00
Matej Knopp
d4607aa5cb Reset editing delta state when replacing editing state (flutter/engine#44595) 
Fixes https://github.com/flutter/flutter/issues/131023

Likely needs a test.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-15 14:26:49 +02:00
Jia Hao
1f58484e28 Namespace imports with flutter (flutter/engine#44709) 
For Google3, this makes it easier since we only need to make one source transform (from `#include "flutter` -> `#include "third_party` instead of requiring a source transform for every root directory in this repo.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-15 06:03:54 +00:00
skia-flutter-autoroll
a82b81e2db Roll Skia from d8d880c560f8 to e137aad081a3 (1 revision) (flutter/engine#44712) 
https://skia.googlesource.com/skia.git/+log/d8d880c560f8..e137aad081a3

2023-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 11084ddef4cb to 446e642885e7 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 05:41:25 +00:00
Brian Osman
829b42e044 Stop using deprecated GrBackendRenderTarget constructor (flutter/engine#44694) 
Sample count is part of GrVkImageInfo (and was already being set in both places).
 2023-08-15 03:47:09 +00:00
skia-flutter-autoroll
737340ae1d Roll Skia from 022415d74e73 to d8d880c560f8 (1 revision) (flutter/engine#44708) 
https://skia.googlesource.com/skia.git/+log/022415d74e73..d8d880c560f8

2023-08-15 pkasting@chromium.org Rename definition of VLOG.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 03:05:15 +00:00
skia-flutter-autoroll
c3a9f5bdf9 Roll Dart SDK from 8731e9796eb3 to d240bef060ed (1 revision) (flutter/engine#44707) 
https://dart.googlesource.com/sdk.git/+log/8731e9796eb3..d240bef060ed

2023-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-70.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 03:03:05 +00:00
skia-flutter-autoroll
d9b78e8a36 Roll Skia from f636188df4e2 to 022415d74e73 (2 revisions) (flutter/engine#44706) 
https://skia.googlesource.com/skia.git/+log/f636188df4e2..022415d74e73

2023-08-15 scroggo@google.com Fix typo in EncodeAnimated for NDK
2023-08-14 egdaniel@google.com Revert "Fix SurfaceAsyncReadPixels test and non-scaled colorspace transforms."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-15 01:23:21 +00:00
Caroline Liu
c49236d4c0 [fuchsia] Delete obsolete GFX-specific source files (flutter/engine#44594) 
This change removes 
- GFX source files removed from the BUILD in #44401 
- Extraneous unused Scenic includes in the same directory
(`//shell/platform/fuchsia/flutter/`)
- All remaining uses of the Scenic library from the Fuchsia SDK
- All remaining uses of fuchsia.ui.scenic.*
 2023-08-15 09:47:32 +10:00
skia-flutter-autoroll
cd26dcf508 Roll Skia from 58397bfd9ab6 to f636188df4e2 (1 revision) (flutter/engine#44700) 
https://skia.googlesource.com/skia.git/+log/58397bfd9ab6..f636188df4e2

2023-08-14 penghuang@chromium.org Device: create copy dest texture with the same fmt of src

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 22:39:26 +00:00
Zachary Anderson
f8fb1ab5ea Update android_embedding_bundle CIPD instructions (flutter/engine#44644) 
This PR updates the gradle build file for the android_embedding_bundle
cipd package to fetch license information about the dependencies listed
under `tools/androidx/files.json`. The README file for the
android_embedding_bundle now explains how to fetch the license
information and make sure it's correct in the cipd package.

This PR also pulls a new version of android_embedding_dependencies that
includes a `LICENSE` file.

It turns out that Flutter does not re-ship anything from the embedding
bundle to Flutter end-users. These dependencies are only used to create
a classpath against which we build the Android embedder and in-tree
tests. I've updated docs/comments to clarify that since I was initially
confused about how these were used.

I'm not adding a test that compares the license info fetched from maven
against a checked-in golden, yet. Still thinking about the most
effective way to do that in combination with the steps in the README.
 2023-08-14 15:15:26 -07:00
skia-flutter-autoroll
904676a45d Roll Skia from 69ea58157190 to 58397bfd9ab6 (8 revisions) (flutter/engine#44698) 
https://skia.googlesource.com/skia.git/+log/69ea58157190..58397bfd9ab6

2023-08-14 cmumford@google.com [jsfiddle] Create jsfiddle Bazel image build target
2023-08-14 jvanverth@google.com Fix SurfaceAsyncReadPixels test and non-scaled colorspace transforms.
2023-08-14 jvanverth@google.com [ganesh] Fix asyncReadPixels when running on Direct3D
2023-08-14 lovisolo@google.com [bazel] //gm/gm.h: Add method getGoldKeys().
2023-08-14 johnstiles@google.com Add flag for DawnGraphicsPipeline to use WGSL instead of SPIR-V.
2023-08-14 mattleibow@live.com Add the tvOS availability "attributes"
2023-08-14 lovisolo@google.com [bazel] Add the "zip" command to the Linux RBE toolchain container image.
2023-08-14 jmbetancourt@google.com add vec2 slot support to CanvasKit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 21:47:17 +00:00
Matan Lurey
ee235383f8 Update web_ui/** to explicitly pass --local-engine-host to the flutter tool. (flutter/engine#44613) 
Partial work towards https://github.com/flutter/flutter/issues/132245.
 2023-08-14 21:09:22 +00:00
Amir Panahandeh
4c8bde6166 Update CompositionAwareMixin to correctly compute composingBase in Web engine (flutter/engine#44139) 
It fixes an issue in `CompositionAwareMixin` causing wrong deltas being computed and reported to input clients resulting in wrong state when compositing text in rich text editors like [Fleather](https://github.com/fleather-editor/fleather) and possibly others.

Reported deltas on Mac:
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaReplacement: start: 0, end: 4, data: 今日は
```

Reported deltas on Web (Before):
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaInsertion: start: 4, end: 0, data: 今日は
```

Reported deltas on Web (After):
```console
TextEditingDeltaInsertion: start: 0, end: 0, data: k
TextEditingDeltaInsertion: start: 1, end: 0, data: y
TextEditingDeltaReplacement: start: 0, end: 2, data: きょ
TextEditingDeltaInsertion: start: 2, end: 0, data: う
TextEditingDeltaInsertion: start: 3, end: 0, data: h
TextEditingDeltaReplacement: start: 0, end: 4, data: きょうは
TextEditingDeltaReplacement: start: 0, end: 4, data: 今日は
```

* Fixes https://github.com/flutter/flutter/issues/131335
* Fixes https://github.com/fleather-editor/fleather/issues/150

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-14 19:51:19 +00:00
stuartmorgan
1df606ab9d Add application:openURLs: forwarding on macOS (flutter/engine#44689) 
Wires `application:openURLs:` into the exisiting delegation system, allowing plugins to handle URL callbacks (as on iOS).

Since there is no notification-based version of this delegate method, this adds it directly to the app delegate, restructring the helper class slightly to allow internal sharing of the delegate list.

Fixes https://github.com/flutter/flutter/issues/41471

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-14 19:38:03 +00:00
skia-flutter-autoroll
30daf6f9f2 Roll Skia from a4377099b25a to 69ea58157190 (1 revision) (flutter/engine#44692) 
https://skia.googlesource.com/skia.git/+log/a4377099b25a..69ea58157190

2023-08-14 lovisolo@google.com //gm/BazelGMRunner.cpp: Generate surface-related Gold key/value pairs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 19:22:20 +00:00
Casey Hillers
c3c5b4f7ac Update embedder_semantics_update.h imports to include flutter namespace (flutter/engine#44670) 
Without the flutter namespace, it breaks Google's build of the engine.
 2023-08-14 19:06:54 +00:00
skia-flutter-autoroll
0240df8ba9 Roll Dart SDK from 3295a353980a to d445f5a18876 (1 revision) (flutter/engine#44691) 
https://dart.googlesource.com/sdk.git/+log/3295a353980a..d445f5a18876

2023-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-68.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 18:41:52 +00:00
Dan Field
0d8aebd040 Revert "Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib" (flutter/engine#44690) 
Reverts flutter/engine#41720

Fixes https://github.com/flutter/flutter/issues/131899
 2023-08-14 18:36:02 +00:00
Jonah Williams
b180b8f66f [Impeller] Conditionally set command debug info. (flutter/engine#44274) 
If IMPELLER_DEBUG is not defined (release mode), then remove the cmd label strings and additional encoding debug info.
 2023-08-14 17:23:05 +00:00
Kevin Lubick
14ece24fcc Migrate more GL calls of GrBackend* (flutter/engine#44682) 
Follow-up to https://github.com/flutter/engine/pull/44334

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-14 13:20:23 -04:00
skia-flutter-autoroll
bc1bb1ff3d Roll Skia from a690bd1fb8b8 to 1cf6f71c8120 (1 revision) (flutter/engine#44685) 
https://skia.googlesource.com/skia.git/+log/a690bd1fb8b8..1cf6f71c8120

2023-08-14 brianosman@google.com Split out memset opts into separate cpp files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 17:19:09 +00:00
Justin McCandless
90d79a902b hasStrings for web (flutter/engine#43360) 
Support hasStrings on web, so that developers can check for clipboard content before showing the paste button, for example, if desired.
 2023-08-14 10:08:50 -07:00
skia-flutter-autoroll
6af9ea88ce Roll Skia from 8b051126be8a to a690bd1fb8b8 (1 revision) (flutter/engine#44684) 
https://skia.googlesource.com/skia.git/+log/8b051126be8a..a690bd1fb8b8

2023-08-14 johnstiles@google.com Generalize WGSL polyfilling logic to include arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 16:01:28 +00:00
skia-flutter-autoroll
f1c60a2d3b Roll Skia from f3b22eaf86bd to a4aa96331dd5 (1 revision) (flutter/engine#44678) 
https://skia.googlesource.com/skia.git/+log/f3b22eaf86bd..a4aa96331dd5

2023-08-14 drott@chromium.org Revert "Add fetch tool for retrieving Chromium's custom-built Rust toolchain"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 13:07:13 +00:00
skia-flutter-autoroll
bc5e4d8934 Roll Dart SDK from 55d7c1b35902 to 452c6617ee36 (1 revision) (flutter/engine#44675) 
https://dart.googlesource.com/sdk.git/+log/55d7c1b35902..452c6617ee36

2023-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-66.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 06:00:14 +00:00
skia-flutter-autoroll
7f05127f5c Roll Skia from a8715028bba1 to afec82ee6a10 (1 revision) (flutter/engine#44674) 
https://skia.googlesource.com/skia.git/+log/a8715028bba1..afec82ee6a10

2023-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b411e7b47eec to 11084ddef4cb (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-14 05:46:31 +00:00
skia-flutter-autoroll
fdee38e4b0 Roll Fuchsia Linux SDK from tfgOFdhH6PlJyMv3V... to UN2vSCJekPhDnlCRd... (flutter/engine#44668) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-13 13:49:22 +00:00
skia-flutter-autoroll
42c519cbb9 Roll Fuchsia Linux SDK from wSdqhvS1srhptT4ij... to 1-uqfjivXAYe2ue-4... (flutter/engine#44661) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-12 09:45:22 +00:00
skia-flutter-autoroll
3ecc497599 Roll Dart SDK from 6118ce565dc2 to 55d7c1b35902 (1 revision) (flutter/engine#44660) 
https://dart.googlesource.com/sdk.git/+log/6118ce565dc2..55d7c1b35902

2023-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-65.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-12 08:18:02 +00:00
skia-flutter-autoroll
f5d0edad73 Roll Dart SDK from e23931233ff2 to 6118ce565dc2 (1 revision) (flutter/engine#44658) 
https://dart.googlesource.com/sdk.git/+log/e23931233ff2..6118ce565dc2

2023-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-64.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-12 04:30:18 +00:00
skia-flutter-autoroll
66be45285d Roll Dart SDK from ade04f1beb2c to e23931233ff2 (1 revision) (flutter/engine#44657) 
https://dart.googlesource.com/sdk.git/+log/ade04f1beb2c..e23931233ff2

2023-08-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-63.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-12 00:44:25 +00:00
Yegor Pomortsev
62b3a0cfa7 Remove dependencies on fuchsia.sys.* FIDL protocols (flutter/engine#44614) 
The fuchsia.sys FIDL library, used to implement v1 components, is
deprecated in the Fuchsia platform and is being removed.

Flutter now implements Components v2 but still imports the old library.

Bug: https://fxbug.dev/109013
 2023-08-12 10:41:38 +10:00
LongCatIsLooong
eb3946ff27 allow ParagraphBuilder.shouldDisableRoundingHack to actually be set to false in tests (flutter/engine#44647) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-11 23:04:57 +00:00
skia-flutter-autoroll
a9978d9c83 Roll Skia from 0f0ff37af487 to dc71a424d870 (3 revisions) (flutter/engine#44654) 
https://skia.googlesource.com/skia.git/+log/0f0ff37af487..dc71a424d870

2023-08-11 jamesgk@google.com Skip TestSweepGradientZeroXGanesh on RadeonR9M470X
2023-08-11 bungeman@google.com Revert "[skunicode] Consolidate SkUnicode_IcuBidi"
2023-08-11 johnstiles@google.com Rewrite matrix polyfilling logic.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 22:56:40 +00:00
skia-flutter-autoroll
76783325ce Roll Fuchsia Linux SDK from v33NyNdr6Y1sKZDze... to wSdqhvS1srhptT4ij... (flutter/engine#44648) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 20:47:15 +00:00
skia-flutter-autoroll
6e82eed1ce Roll Skia from 7dd695d828cf to 0f0ff37af487 (6 revisions) (flutter/engine#44649) 
https://skia.googlesource.com/skia.git/+log/7dd695d828cf..0f0ff37af487

2023-08-11 robertphillips@google.com Add an SkImage::isProtected entry point
2023-08-11 bungeman@google.com [skunicode] Consolidate SkUnicode_IcuBidi
2023-08-11 lokokung@google.com [webgpu-headers] Adds macros to renames "count" fields.
2023-08-11 scroggo@google.com skia.org: Use fetch-ninja to install Ninja
2023-08-11 scroggo@google.com skia.org: Recommend against using Apple's Python
2023-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ce76478186bc to 7516bd499361 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 20:41:21 +00:00
John McCutchan
41331e0315 Rename impeller::TextureIntent to impeller::TextureCoordinateSystem (flutter/engine#44628) 2023-08-11 13:28:03 -07:00
stuartmorgan
0f08a911aa Allow macOS plugins to register as app delegates (flutter/engine#44587) 
Adds `addApplicationDelegate:` to the macOS plugin registrar, following the corresponding iOS method, and wires it up to the existing app delegation forwarding that was recently added for use at the application level. (The actual delegate is non-trivially different between iOS and macOS, but that's not resolveable without a complex migration on the iOS side, so the APIs currently diverge after the level of the `addApplicationDelegate:` method itself.)

This doesn't add any new methods to the delegation; those will be added in a follow-up PR.

Also fixes a retain cycle in the termination handler that prevented the new test from working.

Most of https://github.com/flutter/flutter/issues/41471

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-11 19:57:06 +00:00
skia-flutter-autoroll
6d9cba6043 Roll Skia from 68ea92de8f29 to 7dd695d828cf (1 revision) (flutter/engine#44643) 
https://skia.googlesource.com/skia.git/+log/68ea92de8f29..7dd695d828cf

2023-08-11 robertphillips@google.com Update GL Caps for ARM protected content and TexStorage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 18:26:17 +00:00
skia-flutter-autoroll
8e94813368 Roll Dart SDK from 83f96a990792 to ade04f1beb2c (1 revision) (flutter/engine#44642) 
https://dart.googlesource.com/sdk.git/+log/83f96a990792..ade04f1beb2c

2023-08-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-62.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 18:04:21 +00:00
skia-flutter-autoroll
60e24c795d Roll Skia from fa30af9c2b80 to 68ea92de8f29 (2 revisions) (flutter/engine#44641) 
https://skia.googlesource.com/skia.git/+log/fa30af9c2b80..68ea92de8f29

2023-08-11 johnstiles@google.com Add SkTHashMap::foreach(const Pair&).
2023-08-11 brianosman@google.com Split out Swizzler opts into separate cpp files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 17:42:20 +00:00
gaaclarke
63b74f7869 [Impeller] Added benchmark for advanced blend. (flutter/engine#44450) 
fixes: https://github.com/flutter/flutter/issues/131784

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-11 09:27:45 -07:00
Loïc Sharma
649b38752e [Embedder] Refactor how semantic updates are mapped (flutter/engine#44553) 
This refactors how engine semantic updates are mapped to embedder semantic updates. There are no behavioral changes.

Part of https://github.com/flutter/flutter/issues/119970, https://github.com/flutter/flutter/issues/98948

Next PR: https://github.com/flutter/engine/pull/44616

## Background
For https://github.com/flutter/flutter/issues/119970, we will need to update the embedder API to add string attributes to semantic nodes' text values. There are multiple kinds of string attributes, and each text value can have multiple string attributes. This requires gnarly mapping code that's best kept out of `embedder.cc`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-11 16:22:10 +00:00
skia-flutter-autoroll
bc3fc245e2 Roll Skia from cfb9844091fa to fa30af9c2b80 (1 revision) (flutter/engine#44639) 
https://skia.googlesource.com/skia.git/+log/cfb9844091fa..fa30af9c2b80

2023-08-11 johnstiles@google.com Fix ambiguous evaluation order in WGSL codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 16:12:34 +00:00
skia-flutter-autoroll
16b3abd655 Roll Skia from 416789a5e761 to cfb9844091fa (1 revision) (flutter/engine#44638) 
https://skia.googlesource.com/skia.git/+log/416789a5e761..cfb9844091fa

2023-08-11 brianosman@google.com Reland "Remove SK_GL #ifdefs from GrBackendSurface"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 15:24:33 +00:00
skia-flutter-autoroll
4ea5095e82 Roll Skia from 723df2275d7b to 416789a5e761 (1 revision) (flutter/engine#44637) 
https://skia.googlesource.com/skia.git/+log/723df2275d7b..416789a5e761

2023-08-11 brianosman@google.com SkAnySubclass: Holds any subclass of a given type that fits in a given size

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-11 14:28:23 +00:00