Polina Cherkasova
219efce7f1
Cover more tests with leak tracking. ( #134363 )
2023-09-11 09:42:27 -07:00
LongCatIsLooong
7f3abea35a
Reland "Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec ( #132679 ) (reverted in #133482 ) ( #133605 )
...
Relanding the commit per
https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-30 11:28:10 -07:00
Zachary Anderson
7772f6b05a
Revert "Remove ImageProvider.load, DecoderCallback and `PaintingB… ( #133482 )
...
…inding.instantiateImageCodec` (#132679 )"
This reverts commit b4f4ece40d956ad86efa340ff7fe9d0fa6deea07.
Trial revert for https://github.com/flutter/flutter/issues/133398
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2023-08-28 15:39:10 -07:00
LongCatIsLooong
b4f4ece40d
Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec ( #132679 )
...
~The failing plugin tests should pass once
https://github.com/flutter/packages/pull/4725 lands and rolls into
flutter/flutter~
google tests are migrated.
Part of https://github.com/flutter/flutter/issues/133171
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-24 12:38:27 -07:00
Polina Cherkasova
a7b69b069f
Unpin leak_tracker and handle breaking changes in API. ( #132352 )
2023-08-14 10:05:20 -07:00
Zachary Anderson
f4c25bbb35
Revert "Handle breaking changes in leak_tracker." ( #132223 )
...
Reverts flutter/flutter#131998
Reverting for https://github.com/flutter/flutter/issues/132222
2023-08-09 08:14:39 -07:00
Polina Cherkasova
acd636f7ba
Handle breaking changes in leak_tracker. ( #131998 )
2023-08-08 09:39:19 -07:00
Kate Lovett
f054f5aa09
Move mock canvas to flutter_test ( #131631 )
...
Fixes https://github.com/flutter/flutter/issues/59413
This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`.
The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :)
mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
2023-08-07 23:43:03 +00:00
Polina Cherkasova
e8b397caca
Setup leak tracking regression for material. ( #130169 )
2023-07-22 06:45:27 -07:00
Qun Cheng
0bb9409fd0
Update Switch tests for M2/M3 ( #129810 )
...
Updated and reorganized unit tests for `Switch` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-06-30 18:06:23 +00:00
Qun Cheng
cea728afa6
Update tests in material library for Material 3 by default ( #128300 )
2023-06-13 08:58:11 -07:00
LongCatIsLooong
1b800fd496
Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation ( #119199 )
...
Fixes https://github.com/flutter/flutter/issues/117627
### Behavior changes:
1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`.
2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones.
3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.
2023-05-25 07:24:45 +00:00
Taha Tesser
160618b103
Add missing Switch.onFocusChange test ( #126685 )
2023-05-17 08:36:24 -07:00
Taha Tesser
96dae5e1e3
Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of Switch.adaptive ( #126688 )
...
fixes https://github.com/flutter/flutter/issues/126637
fixes https://github.com/flutter/flutter/issues/126669
## ~~To be merged after https://github.com/flutter/flutter/pull/126684~~
### Description
1. Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2. Fix `thumbColor` & `focusColor` aren't applied.
### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.
https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a
### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.
https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
2023-05-12 18:48:10 +00:00
Qun Cheng
4e7e4512b6
Reorder materialStateProperty defaults ( #125905 )
...
Fixes #122250 . This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states.
* When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`.
* When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`.
* There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`.
the order should be disabled, (error), pressed, hovered, focused.
2023-05-11 00:03:09 +00:00
Qun Cheng
c1c2513ac9
Add Switch.trackOutlineWidth property ( #125848 )
2023-05-05 13:34:08 -07:00
Qun Cheng
3f98c0f8f9
Add trackOutlineColor for Switch and SwitchListTile ( #120140 )
...
* Add trackOutlineColor for Switch and SwitchListTile
* Update tests
* Update test
* Clean up unnecessary StatefulBUilder in tests
* Fix failed test
---------
Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-08 07:55:24 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Qun Cheng
244990775a
Fixed the color curve issue ( #115188 )
2022-11-14 11:31:03 -08:00
Qun Cheng
91d88336dd
Added Switch Animation for Material 3 ( #113090 )
2022-10-12 11:02:08 -04:00
Qun Cheng
75fac6ae4d
Migrated Switch to Material 3 ( #110095 )
2022-09-09 11:53:48 -07:00
Qun Cheng
4b91b220b8
Fix Tooltip Issue on Switch ( #110830 )
2022-09-02 12:54:53 -07:00
Taha Tesser
52829523d6
Deprecate toggleableActiveColor ( #97972 )
2022-08-02 19:09:06 +00:00
Qun Cheng
8a8ed75d3e
Change default value of effectiveInactivePressedOverlayColor in Switch to refer to effectiveInactiveThumbColor ( #108477 )
2022-07-28 09:07:09 -07:00
Tong Mu
23bc3d64eb
[Mouse] Remove all pointers at the end of tests ( #102694 )
2022-05-19 17:48:10 -07:00
Darren Austin
17e2fce1cf
Add const MaterialStatePropertyAll class. ( #104127 )
2022-05-19 09:35:33 -07:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Ian Hickson
5ddc00cc03
Use EnumName.name where possible. ( #94496 )
2021-12-03 16:39:04 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets ( #86821 )
2021-08-30 15:41:02 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Karol
8ffe7c56d7
Fix painting material toggle ( #78733 ) ( #78744 )
2021-06-21 16:46:02 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push ( #82564 )
2021-05-21 15:09:03 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push ( #82057 )" ( #82525 )
2021-05-14 12:09:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push ( #82057 )
2021-05-13 14:34:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push ( #81235 )" ( #81829 )
...
This reverts commit 35ad43f20caa71ec051a97bc8bc8fec552fb4452.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push ( #81235 )
2021-05-03 17:14:03 -07:00
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas ( #81329 )
2021-04-27 17:09:03 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push ( #76288 )" ( #81226 )
...
This reverts commit c26ed03c8a77810136cc087ae60048ace062842d.
2021-04-26 12:57:17 -07:00
Michael Goderbauer
9f2b93ae40
Dispose thumbPainter in Switch to avoid crash ( #81089 )
2021-04-26 11:49:03 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push ( #76288 )
...
* Migrate to ChannelBuffers.push
* Move TestDefaultBinaryMessenger to its own file
* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Michael Goderbauer
2530f4c5eb
Fix some issues flagged by unawaited_futures lint ( #77844 )
2021-03-11 15:55:03 -08:00
Michael Goderbauer
67edb63d84
Re-land "Toggable Refactor ( #76745 )" ( #77263 )
2021-03-04 11:34:04 -08:00
