2070 Commits

Author SHA1 Message Date
Alexander Aprelev
f4a038da63
Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)
* Roll engine to rolled dart
Add connectionTimeout property to class that extends HttpOverrides.
Upgrade packages.
Add more type fixes.
Update goldens hash.
Add more type fixes.
Upgrade packages.
Fix tests.
Remove strong-mode from analysis options yaml file.
Increase dev/devicelab timeout from 2 to 10 seconds.
Added getVM to waitForViews. Fix type errors in compileExpression.

* Pick up engine revision with fix for microbenchmarks regression.
Increase default timeout from 20/30 to 60s.
2018-07-11 12:13:28 -07:00
Danny Tuppeny
127d1f85dd
Improve error message in microbenchmarks when flutter run lives too long (#19200)
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
2018-07-10 17:09:39 +01:00
Ian Hickson
03a1f4acb3
Remove bogus SDK constraint lines. (#19013) 2018-07-09 17:27:33 -07:00
Danny Tuppeny
5413560415 Revert "Add temporary debug prints to identify devicelab failures (#19093)" (#19095)
This reverts commit edc16473bfdafc0f5fe546610d3b0fe0eecdd080.
2018-07-05 18:58:26 +02:00
Danny Tuppeny
edc16473bf
Add temporary debug prints to identify devicelab failures (#19093) 2018-07-05 14:16:44 +01:00
Danny Tuppeny
e1d396d5ca
Attempt to fix race in microbenchmark error handling code (#19092)
Await stream cancellations before trying to complete
2018-07-05 13:06:43 +01:00
Mikkel Nygaard Ravn
c34daae2d6
Avoid repeating microbenchmark (#19087) 2018-07-05 11:11:17 +02:00
Danny Tuppeny
0329f0c179
Include stdout/stderr in failure messages for devicelab's tests (#18990)
* Include stdout/stderr in failure messages

Sometimes some of these tests unexpectedly fail with a non-zero exit code. This ensures stdout/stderr is included in the test failure message when this happens so that we can track down the issue.

* Remove redundant info about exit code

* Remove unnecessary indenting

The [markers] make it fairly clear so this just makes the test code noisy.
2018-07-03 07:37:34 +01:00
Mikkel Nygaard Ravn
647076d767
Fix module_test (#18993) 2018-07-02 14:45:42 +02:00
Mikkel Nygaard Ravn
ca0e144f9f
Mark non-flaky tests as such (#18927) 2018-06-29 10:55:31 +02:00
liyuqian
8c1d8a6a6b
Add 90th and 99th percentiles to dashboard (#18930)
This fixes #18727
2018-06-28 16:19:23 -07:00
Florian Loitsch
a8d97a6dc9
Wait before running the second test. (#18826) 2018-06-28 14:35:08 +02:00
Ian Hickson
35ad2a786d
Remove race conditions involving finding available ports (#18698)
This is an attempt to reland #18488 with less breakage on macOS.
2018-06-27 16:44:28 -07:00
Danny Tuppeny
e87b83bfd8 Mark flutter_gallery_instrumentation_test as flaky (#18887)
See #18879.
2018-06-27 15:48:22 -07:00
Ian Hickson
3ecd4301bf
Test performance of "flutter test" (#18810) 2018-06-26 17:34:25 -07:00
Jason Simmons
43e6372128
Update the ICU data file asset path in the devicelab tests (#18854) 2018-06-26 16:01:31 -07:00
Mikkel Nygaard Ravn
579116412f
Fix gradle plugin test (#18824) 2018-06-26 12:18:50 +02:00
Mikkel Nygaard Ravn
5e54b9e0fd
Find Java for gradlew executions (#18821) 2018-06-26 10:10:43 +02:00
Ian Hickson
73498a54bc
Make flaky test as such. (#18815) 2018-06-25 19:25:01 -07:00
Mikkel Nygaard Ravn
d4db748047
Add2app devicelab test (#18795) 2018-06-25 22:37:47 +02:00
Chris Bracken
7213a7805a
Mark flutter_attach_test flaky (#18801)
Introduced in d248725e1509603551fc4e70e532c190743cd4ab, but has been red
since landing. Marking flaky rather than reverting since it's the only
failure.
2018-06-25 11:04:51 -07:00
Florian Loitsch
783a278956
Replace existing app if it already exists. (#18796)
The `flutter attach` test was failing because the Android device had
the app already installed.
2018-06-25 16:12:06 +02:00
Florian Loitsch
d248725e15
Flutter attach (#18677)
Add `flutter attach` command.

This command allows Flutter to connect to applications that haven't been launched using `flutter run`.
2018-06-25 15:33:42 +02:00
Michael Goderbauer
f11b790b8c
Track size of App.framework and Flutter.framework for Hello World (#18701) 2018-06-22 09:27:31 -07:00
Ian Hickson
6599271bf5
Revert matcher package (#18614)
The new matcher package deprecates isInstanceOf which seems eggregious.
2018-06-19 17:22:56 -07:00
Florian Loitsch
bb23a110e0
Fix test (#18603)
Fix test.

This makes the buildbot green again.
2018-06-19 16:41:27 +02:00
Greg Spencer
08d1ec36de Roll engine to 0c119932c0d6cb30dafd75ec717d1eda76fd7651 (#18575) 2018-06-19 09:58:20 +02:00
Michael Goderbauer
9a8c4dfef6
Report compressed/uncompressed size of icudtl, snapshots, and libflutter (#18583)
Reported for the hello_world compile benchmark in devicelab for now.
2018-06-18 17:12:14 -07:00
Michael Goderbauer
ebb174b0bf
Add size benchmark for hello_world (#18522) 2018-06-16 00:08:33 -07:00
Michael Goderbauer
2a19dae28b
Fix aot_snapshot_size_* benchmarks (#18520)
... and make sure they fail if they can't report the size.
2018-06-15 17:17:28 -07:00
Ian Hickson
0fa5ba43a1
Revert "Remove race conditions involving finding available ports (#18488)" (#18521)
This reverts commit 775087225141573d20224e3cda3cff9e56a6cd1e.
2018-06-15 15:37:20 -07:00
Ian Hickson
7750872251
Remove race conditions involving finding available ports (#18488) 2018-06-15 14:16:18 -07:00
Michael Goderbauer
409007827b
Keep TextFields visible when keyboard comes up (#18291)
Fixes #10826.

Also in this PR: If you focus a text field, scroll it out of view and then start typing it will scroll back into view.
2018-06-15 10:11:10 -07:00
Mikkel Nygaard Ravn
e713b3349a
Update all packages (#18506) 2018-06-15 17:46:36 +02:00
Danny Tuppeny
86ed141bef
Revert "Update all packages (#18471)" (#18492)
This reverts commit e593dc70e8871a4407d74aa05640bc13bf58f651.
2018-06-15 09:13:09 +01:00
Danny Tuppeny
e593dc70e8
Update all packages (#18471)
"flutter update-packages --force-upgrade"
2018-06-14 21:09:32 +01:00
Ian Hickson
d1cc8b6de8
Clean up output of "flutter run --release" (#18380)
(second attempt)
2018-06-14 12:30:20 -07:00
Chris Bracken
2ae48845a8
Revert elimination of Dart 1 (#18460)
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb2. (#18362)
This reverts commit 3daebd0. (#18316)
2018-06-13 12:46:39 -07:00
Greg Spencer
6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. (#18362)
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Chris Bracken
3daebd059c
It's time to #deleteDart1 (again) (#18316)
* It's time to #deleteDart1 (#18293)

Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.

* Fix indentation, remove no longer necessary .toList()

* Only push udpated kernel if >0 invalidated srcs
2018-06-08 15:49:24 -07:00
Chris Bracken
9495df4bc3
Revert "It's time to #deleteDart1 (#18293)" (#18313)
Several benchmarks started failing during kernel compile:
1. Timeouts:
   * commands_test
   * hot_mode_dev_cycle__benchmark
   * run_machine_concurrent_hot_reload
   * service_extensions_test

2. Kernel compiler crash:
   * hot_mode_dev_cycle_linux__benchmark
   * routing_test

3. Unexpected termination:
   * hot_mode_dev_cycle_win__benchmark

This reverts commit ed63e7082ac89ea9851ae645ae69842da0c6150c.
2018-06-08 12:43:11 -07:00
Chris Bracken
ed63e7082a
It's time to #deleteDart1 (#18293)
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.
2018-06-08 11:04:57 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Ian Hickson
944f0a4cc1
Revert "Clean up output of "flutter run --release" (#18049)" (#18184)
This reverts commit 4f1b66044c075dee734d3a426a77d54b96971d0c.
2018-06-04 16:17:08 -07:00
Ian Hickson
4f1b66044c
Clean up output of "flutter run --release" (#18049) 2018-06-04 15:22:51 -07:00
Ian Hickson
e3427550e9
Be less verbose in the logs. (#17401)
Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
2018-06-04 15:22:19 -07:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)
This reverts commit 3258602073c6a05b1b051fddf644cba92116694b.
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)
Fixes #18028

Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Mikkel Nygaard Ravn
f986048094
Mark flaky test as such (#18019) 2018-05-30 12:54:46 +02:00
Todd Volkert
70772ea5a0
Remove flaky marker on some tests. (#17882)
They've been mostly green since https://github.com/flutter/flutter/pull/17812
2018-05-24 13:57:52 -07:00