DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,011 Commits 882 Branches 1,069 Tags
Commit Graph

22955 Commits

Author SHA1 Message Date
Chris Yang
4e696fc84d Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652) 
`UnMergeNowIfLastOne` is called during shell destruction. When there are other shells with threads unmerged and the current destroying shell with thread merged. `UnMergeNowIfLastOne` should unmerge the threads. 

This PR Make `UnMergeNowIfLastOne` not only unmerge if the current merger is the last merger, but also unmerge if the current merger is the last merger that is merged.

Fixes https://github.com/flutter/flutter/issues/127168

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 22:17:21 +00:00
Dan Field
6fdde7e901 Revert https://github.com/flutter/engine/pull/43533 (flutter/engine#43654) 
Reverts  https://github.com/flutter/engine/pull/43533
Cause of https://github.com/flutter/flutter/issues/130476

I was trying to add a test for this but it's taking me a while to get a working test so here's the revert.
 2023-07-13 22:13:45 +00:00
skia-flutter-autoroll
b69b3b6f9e Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655) 
https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780

2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh.
2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config.
2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal.
2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use.
2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely
2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes
2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations
2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level
2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 22:05:37 +00:00
Jason Simmons
4f384979af Fix a Fuchsia formatter type mismatch flagged by the pending Clang roll (flutter/engine#43651) 2023-07-13 20:13:55 +00:00
Jonah Williams
f64d4f6eb7 [Impeller] Switch back to using explicit flush for device buffers. (flutter/engine#43644) 
Not all devices support the host_coherent + host_visible + device_local combo (though most do). I believe this change was associated with a slight regression in performance, so back it out and go back to flush to see if that improves things.

https://flutter-flutter-perf.skia.org/e/?begin=1687535096&end=1689267073&queries=device_type%3DSM-G973U1%26test%3Dnew_gallery_impeller__transition_perf&requestType=0&selected=commit%3D35596%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DSM-G973U1%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller__transition_perf%252C

Specifically:

![image](https://github.com/flutter/engine/assets/8975114/fedabc18-9091-45c0-b7b3-ee9945c2239c)
 2023-07-13 18:13:03 +00:00
Victoria Ashworth
1a078f8091 Add logs to debug VM Service Publication (flutter/engine#43616) 
Adding logs to help debug why VM Service is being published when it shouldn't (https://github.com/flutter/flutter/issues/129987 and https://github.com/flutter/flutter/issues/129836).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 17:55:48 +00:00
LongCatIsLooong
64c139e98a Revert "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43642) 
Reverts flutter/engine#43118

The incorrect default value (`true` instead of  `false`) was used in the PR and that caused internal test failures. I'll add a test before trying to reland.
 2023-07-13 17:54:33 +00:00
chunhtai
8f5fb30a7f [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter/engine#43279) 
fixes https://github.com/flutter/flutter/issues/128709

requires https://github.com/flutter/flutter/pull/129652

The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-13 17:43:53 +00:00
John McCutchan
d2e61e5689 Improve Stencil Playground test (flutter/engine#43641) 
- Add UI to select front and back face comparision functions.
- Fix back face.
 2023-07-13 10:21:52 -07:00
skia-flutter-autoroll
d7c244c593 Roll Skia from c2d28b15c246 to 743ad92f5de2 (4 revisions) (flutter/engine#43640) 
https://skia.googlesource.com/skia.git/+log/c2d28b15c246..743ad92f5de2

2023-07-13 herb@google.com Use the correct signatures for functions
2023-07-13 kjlubick@google.com Add staging gni filegroup for files which need SKSL from core
2023-07-13 robertphillips@google.com Add label output to GrGpuResource::dumpMemoryStatisticsPriv
2023-07-13 johnstiles@google.com Revert "Disable render-task reordering on Iris Xe on OpenGL."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:56:52 +00:00
skia-flutter-autoroll
ee096091da Roll Fuchsia Linux SDK from xBJq6PsO5ebblODMe... to -csWUV7Dv3hETOoDw... (flutter/engine#43639) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:48:59 +00:00
skia-flutter-autoroll
a224a4e19f Roll Skia from 56b68ce6196c to c2d28b15c246 (1 revision) (flutter/engine#43638) 
https://skia.googlesource.com/skia.git/+log/56b68ce6196c..c2d28b15c246

2023-07-13 wcandillon@gmail.com matchFamilyStyle to the external definition and refine the TypefaceFontProvide type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 16:08:46 +00:00
Jason Simmons
49813d1e77 Apply the transform of an image filter layer to paint bounds in the CanvasKit backend (flutter/engine#43353) 
Fixes https://github.com/flutter/flutter/issues/128788
 2023-07-13 14:26:04 +00:00
Ian Hickson
93a21790b4 Make GOMA state automatic by default (flutter/engine#43584) 
We used to default to force-enabled, which would fail on non-GOMA setups.
 2023-07-13 06:34:51 +00:00
skia-flutter-autoroll
ea4c2b7268 Roll Skia from c8da0c657c4e to 811b046c673b (3 revisions) (flutter/engine#43630) 
https://skia.googlesource.com/skia.git/+log/c8da0c657c4e..811b046c673b

2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c7cba4b06eab to bd8a6b1b3547
2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c60298c2b806 to c7cba4b06eab (5 revisions)
2023-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 75bc633f02db to 7a6604d0564b (28 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 06:21:33 +00:00
Chinmay Garde
359fbbb34c [Impeller] Remove unactionable error logs and use structure chains for instance creation. (flutter/engine#43629) 
I didn't know this when I wrote it initially but structure chains will throw a compile time error if a chain member violates the Vulkan spec. pNext chaining is easy to mess up otherwise and we should use structure chains where possible. We are already doing this during pipeline construction.
 2023-07-13 05:54:00 +00:00
Chinmay Garde
88df88c3ff [Impeller] Add RAII wrappers for VMA objects. (flutter/engine#43626) 
Uses `fml::UniqueObject<T>`.
 2023-07-13 05:18:06 +00:00
skia-flutter-autoroll
a9fe0fd8ac Roll Fuchsia Linux SDK from 1STsUj0X5YgpiSNEb... to xBJq6PsO5ebblODMe... (flutter/engine#43627) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 03:52:19 +00:00
skia-flutter-autoroll
1be57144b4 Roll Skia from 6ed93436d57c to 7f391ea9164e (1 revision) (flutter/engine#43625) 
https://skia.googlesource.com/skia.git/+log/6ed93436d57c..7f391ea9164e

2023-07-13 michaelludwig@google.com [skif] Replace SkTileImageFilter with nested crops

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 02:55:04 +00:00
skia-flutter-autoroll
c201a35829 Roll Skia from bedc92598644 to 6ed93436d57c (3 revisions) (flutter/engine#43621) 
https://skia.googlesource.com/skia.git/+log/bedc92598644..6ed93436d57c

2023-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4ba3255697ef to 3b2c55a1bc2b (5 revisions)
2023-07-12 jvanverth@google.com [graphite] Add wait/signal semaphore support to InsertRecordingInfo.
2023-07-12 herb@google.com Move sk_float_nextlog2 to WangsFormula.h and cleanup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-13 01:12:05 +00:00
Jonah Williams
24c6a07906 [Impeller] Add support to embedder for Impeller on GL (via Angle on Windows). (flutter/engine#43388) 
Actually works now, though there is some issue with the default fbo stencil so I've filled https://github.com/flutter/flutter/issues/130048

Other issues:
* ~~Rendering looks wrong~~
* ~~Resizing window hangs~~
* ~~Reactor isn't set up correctly and all blit passes are currently failing.~~
* ~~Needs to handle falling back to sample count of 1 like we do on Android~~.
 2023-07-13 00:34:34 +00:00
Jonah Williams
02f100995e [Impeller] Allocate buffers out of a pool on the raster thread. (flutter/engine#43564) 
https://github.com/flutter/flutter/issues/129392

Buffer allocations on worker threads can interefere with allocations on the main thread. Since all buffers that we allocate on the main thread are discarded after a frame, we can use a ring buffer of VmaPool objects with a linear allocate bit to get faster allocations.

This works for buffers because they are likely to be suballocated, so we can continue to reuse the same memory over and over. Whereas most of our textures require dedicated allocations.

In order to support this, we need the allocator to track an incrementing frame counter (actually this would probably be useful for the context to do in general, but we'll get there eventually).

![image](https://github.com/flutter/engine/assets/8975114/4a485e2b-c557-4567-9266-a725fc1448db)
 2023-07-12 23:12:50 +00:00
skia-flutter-autoroll
973747f0bd Roll Skia from 4e989b1564ee to bedc92598644 (1 revision) (flutter/engine#43617) 
https://skia.googlesource.com/skia.git/+log/4e989b1564ee..bedc92598644

2023-07-12 johnstiles@google.com Fix double-evaluation of complex out-parameters in Metal.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 22:50:16 +00:00
Jim Graham
ce4c7d3ffd move rtree and canvas_spy sources to Fuchsia sub-directory (flutter/engine#43615) 
These sources have long been obsolete for most of the engine, except for the Fuchsia sources. They do not need to be built for any other platform so this PR moves them into a Fuchsia platform-specific build directory so that they are only present in the Fuchsia binaries.
 2023-07-12 22:22:39 +00:00
skia-flutter-autoroll
a14900f889 Roll Skia from 68e3c0b3eea7 to 4e989b1564ee (6 revisions) (flutter/engine#43614) 
https://skia.googlesource.com/skia.git/+log/68e3c0b3eea7..4e989b1564ee

2023-07-12 jamesgk@google.com [graphite] Use AnalyticRRectRenderStep AA outset for clipping
2023-07-12 jmbetancourt@google.com [skottie] move scalar slot tracking to bind call
2023-07-12 herb@google.com Reland "Reland "Update constants used by SkFloatingPoint.h""
2023-07-12 johnstiles@google.com Replace hand-computed lerp with mix.
2023-07-12 brianosman@google.com Only build SkXmp when necessary
2023-07-12 johnstiles@google.com Remove out-param helper functions from Metal.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 21:56:27 +00:00
Ian Hickson
eaca35dd7c Document (and assert) that channel names can't contains nulls (flutter/engine#43593) 
Fixes https://github.com/flutter/flutter/issues/116652
 2023-07-12 21:44:31 +00:00
Srujan Gaddam
49e8ec8b0b Reland "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43363) 
This reverts commit dce75ab4cf647eec6699f8a30ba2289a3738b307.

This also makes some small changes to make onBenchmark a
JSExportedDartFunction instead of a JSBoxedDartObject. This is for
changes in https://github.com/flutter/flutter/pull/129436 and to account
for the fact that flutter/packages provides an `allowInterop`'d
function. Benchmarks tests pass with this CL.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [ ] All existing and new tests are passing.
 2023-07-12 14:27:16 -07:00
LongCatIsLooong
3b27aa3e95 Add a flag to ParagraphBuilder for rounding hack migration (flutter/engine#43118) 
The goal is to remove the rounding applied in skparagraph and in the framework: https://github.com/flutter/flutter/issues/31707

The plumbing is done via a new static variable `ParagraphBuilder.shouldDisableRoundingHack` that toggles the rounding behavior in skparagraph and the flag is read by framework code. Application code and test code can either use `ParagraphBuilder.setDisableRoundingHack` or `--dart-define="SKPARAGRAPH_REMOVE_ROUNDING_HACK=1"` to opt-in. 
Once the internal migration is finished the default value of the flag will be set to true.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-12 20:36:45 +00:00
John McCutchan
67399264f1 [Impeller] Fixes for asymmetric stencil descriptors (flutter/engine#43535) 
Fixes for asymmetric stencil descriptors

- Fix GLES implementation to properly set back and front face options in
the case that they aren't identical.
- Add write_mask to hash function.

https://github.com/flutter/flutter/issues/129855
 2023-07-12 12:57:45 -07:00
skia-flutter-autoroll
0f2f65f4aa Roll Skia from adeeb8d50f7c to 68e3c0b3eea7 (1 revision) (flutter/engine#43609) 
https://skia.googlesource.com/skia.git/+log/adeeb8d50f7c..68e3c0b3eea7

2023-07-12 robertphillips@google.com Add new (internal) SkCanvas drawAsTiledImageRect virtual

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 18:43:40 +00:00
Jim Graham
d42609bd14 Add comment to use of 3x3 mapRect in TransformLayer (flutter/engine#43608) 
Addresses comment in https://github.com/flutter/flutter/issues/130303#issuecomment-1632895439

No tests as this is just a comment.
 2023-07-12 18:41:22 +00:00
skia-flutter-autoroll
95232a4379 Roll Skia from a251a36ea519 to adeeb8d50f7c (1 revision) (flutter/engine#43606) 
https://skia.googlesource.com/skia.git/+log/a251a36ea519..adeeb8d50f7c

2023-07-12 robertphillips@google.com Change DrawImageRect* utils to not fallback to the non-tiled draw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 17:56:44 +00:00
skia-flutter-autoroll
90a9eddcea Roll Skia from ebc149cff431 to a251a36ea519 (2 revisions) (flutter/engine#43604) 
https://skia.googlesource.com/skia.git/+log/ebc149cff431..a251a36ea519

2023-07-12 brianosman@google.com Revert "Reland "Update constants used by SkFloatingPoint.h""
2023-07-12 michaelludwig@google.com [skif] Remove invalid Tile->Offset optimization

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 17:07:49 +00:00
Jonah Williams
9f11809bb7 [Impeller] Use new SkParagraph APIs for stroked text. (flutter/engine#41735) 
~~Requires https://skia-review.googlesource.com/c/skia/+/692196~~ Landed

Fixes https://github.com/flutter/flutter/issues/126010

Looks correct on iOS, renders incorrectly on Android 🤷 . Might be related to all of our text bounds looking off.

### iOS

![flutter_03](https://github.com/flutter/engine/assets/8975114/50897fd0-47fd-4cad-b158-1662aa650092)

### Android

![flutter_04](https://github.com/flutter/engine/assets/8975114/bcefe843-71a0-4b98-956f-039918e9a4cc)
 2023-07-12 16:29:13 +00:00
skia-flutter-autoroll
e0d567bc40 Roll Skia from ac4c113c071d to ebc149cff431 (4 revisions) (flutter/engine#43603) 
https://skia.googlesource.com/skia.git/+log/ac4c113c071d..ebc149cff431

2023-07-12 herb@google.com Reland "Update constants used by SkFloatingPoint.h"
2023-07-12 aredulla@google.com [ssci] Added Shipped field to READMEs
2023-07-12 markbrand@google.com Check the result of descriptor.findEntry.
2023-07-12 kjlubick@google.com Roll Dawn from 17da531ab3fb to 75bc633f02db (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 15:54:15 +00:00
skia-flutter-autoroll
b68d930463 Roll Fuchsia Linux SDK from zTuZjXzI3bqscWmeo... to 1STsUj0X5YgpiSNEb... (flutter/engine#43602) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 15:03:18 +00:00
skia-flutter-autoroll
9c2bdabea0 Roll Skia from 9038aec6a23a to ac4c113c071d (1 revision) (flutter/engine#43600) 
https://skia.googlesource.com/skia.git/+log/9038aec6a23a..ac4c113c071d

2023-07-12 johnstiles@google.com Disable render-task reordering on Iris Xe on OpenGL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 13:51:29 +00:00
skia-flutter-autoroll
3a0058690f Roll Skia from 0ac60b2cecfe to 0fb595ccc6a7 (1 revision) (flutter/engine#43596) 
https://skia.googlesource.com/skia.git/+log/0ac60b2cecfe..0fb595ccc6a7

2023-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 860d0cbba7e1 to c60298c2b806 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 09:02:29 +00:00
Jim Graham
870fc78163 header file cleanup focusing on removing unnecessary SkPicture includes (flutter/engine#43589) 
Most of the #include directives for SkPicture are removed except where they are still functional. Many comments rewritten to no longer be SkPicture-centric.

- DL unit tests still use it for consistency testing
- rasterizer/engine still use it for screen shot support
- Fuchsia still uses it extensively
 2023-07-12 08:17:06 +00:00
Brandon DeRosier
fb1b34a38c [Impeller] Document ColorSourceContents (flutter/engine#43590) 
Someday all the things will be documented and explained intuitively.
 2023-07-12 01:09:33 -07:00
skia-flutter-autoroll
943e61fb35 Roll Skia from 7b0d85cff28a to 33cfa4fc2aeb (1 revision) (flutter/engine#43586) 
https://skia.googlesource.com/skia.git/+log/7b0d85cff28a..33cfa4fc2aeb

2023-07-12 armansito@google.com [graphite][vello] Encode unsupported stroke styles as fills

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 03:50:27 +00:00
skia-flutter-autoroll
fa64be2899 Roll Skia from d0ecba6d753c to 7b0d85cff28a (1 revision) (flutter/engine#43585) 
https://skia.googlesource.com/skia.git/+log/d0ecba6d753c..7b0d85cff28a

2023-07-12 armansito@google.com [graphite] ComputePathAtlas per DrawContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 03:05:18 +00:00
Chinmay Garde
3ac3578efc [Impeller] Remove un-actionable info log about validations. (flutter/engine#43575) 2023-07-12 02:42:04 +00:00
Chinmay Garde
5bee234c0f [Impeller] Create a resource manager that batch deallocates resources on a dedicated thread. (flutter/engine#43579) 
This also sets up well for a unified resource pooling and deferred collection mechanism.
 2023-07-12 02:42:02 +00:00
skia-flutter-autoroll
4182cba124 Roll Fuchsia Linux SDK from EnRnFf_eyS6SGqpHi... to zTuZjXzI3bqscWmeo... (flutter/engine#43583) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 02:16:31 +00:00
skia-flutter-autoroll
96bf71f61c Roll Skia from c769464a8b79 to d0ecba6d753c (2 revisions) (flutter/engine#43582) 
https://skia.googlesource.com/skia.git/+log/c769464a8b79..d0ecba6d753c

2023-07-12 brianosman@google.com Revert "Update constants used by SkFloatingPoint.h"
2023-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 03c816988bfd to 2a8992497955 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-12 02:10:05 +00:00
Jason Simmons
2b231a05fd Release the mutex in the CanCreateConcurrentMessageLoop test before waking the latch (flutter/engine#43574) 
If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it.

Fixes https://github.com/flutter/flutter/issues/130344
 2023-07-11 23:18:48 +00:00
skia-flutter-autoroll
726e36bc6c Roll Skia from 2998197ce4ca to c769464a8b79 (2 revisions) (flutter/engine#43577) 
https://skia.googlesource.com/skia.git/+log/2998197ce4ca..c769464a8b79

2023-07-11 herb@google.com Update constants used by SkFloatingPoint.h
2023-07-11 armansito@google.com [graphite] Fix bug in AtlasShapeRenderStep module helper invocation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 22:59:01 +00:00
Zachary Anderson
8e4206c239 Run linux_unopt on a machine with more cores (flutter/engine#43473) 
The unit tests can run in parallel so running on a bigger machine gives a good speedup. This shaves ~10 minutes off of linux_unopt time. Some of the DisplayList unit tests go over the 120s limit, so this PR also bumps the default limit to 300s.
 2023-07-11 22:56:05 +00:00
skia-flutter-autoroll
d73e8749ec Roll Skia from d2051446ee6b to 2998197ce4ca (1 revision) (flutter/engine#43572) 
https://skia.googlesource.com/skia.git/+log/d2051446ee6b..2998197ce4ca

2023-07-11 herb@google.com Move index out of bounds to SkAssert.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-11 21:49:22 +00:00