This fixes#71222
* Implement operator = and hashcode for CupertinoThemeData and CupertinoTextThemeData which CupertinoThemeData depends on.
* Add basic tests for CupertinoThemeData equality and hashcode.
I also manually tested the case mentioned in #71222, e.g. equality of ThemeData(cupertinoOverrideTheme: someTheme)
Co-authored-by: Jacob Simionato <jsimionato@google.com>
This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app.
* changed controlsBuilder signature
combined all parameters into ControlsDetails class
* sample fixes
* updates to docstrings
* switched to positional argument for stepper.controlsbuilder
* Merge branch 'master' into stepper-builder-fix
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>
This PR fixed the problem that prevented platform_channel_test.dart being shuffled. Part of #85160.
A couple of tests sets up callbacks through setMethodCallHandler() that gets unresolved and breaks other tests.
This PR clears those callbacks by passing null to setMethodCallHandler.
This PR fixed the problem that has prevented app_overrides_test.dart being shuffled. Part of #85160.
This test is testing WidgetsApp.showPerformanceOverlayOverride and WidgetsApp.debugAllowBannerOverride.
The problem: There was a strong dependecy to the default ordering of the tests. The value of showPerformanceOverlayOverride or debugAllowBannerOverride was expected to be the value that was set in previous test.
The fix: Make the values be set to default values after each test:
WidgetsApp.showPerformanceOverlayOverride=false
WidgetsApp.debugAllowBannerOverride=true
Set the expected value at the start of the test, if the default value is not expected.
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>
This PR fixed the problem that has prevented scheduler_test.dart being shuffled. Part of #85160.
One test schedules a task, but events are locked so the scheduled task does not execute and this messes up other tests.
This PR adds a teardown that executes the scheduled task after the test, when events are unlocked.
Fixes test/painting/image_stream_test.dart of #85160
The problem: The timeDilation was changed to 2.0 but not restored. The changed timeDilation carried on to following tests which messed up some of them when using test ordering seed 456.
The Fix: Restore timeDilation to 1.0 at the end of test.
