10 Commits

Author SHA1 Message Date
Eric Seidel
295f920116 Fix sky include guards to match Chromium style
I wrote a script to do this which is attached
to the bug.

TBR=abarth@chromium.org
BUG=435361

Review URL: https://codereview.chromium.org/736373003
2014-11-21 02:48:38 -08:00
Eric Seidel
e0fd75b5ab Make absolute and sort all Sky headers
This caused us to lose our gn check certification. :(

Turns out gn check was just ignoring all the header
paths it didn't understand and so gn check passing
for sky wasn't meaning much.  I tried to straighten
out some of the mess in this CL, but its going to take
several more rounds of massaging before gn check
passes again.  On the bright side (almost) all of
our headers are absolute now.  Turns out my script
(attached to the bug) didn't notice ../ includes
but I'll fix that in the next patch.

R=abarth@chromium.org
BUG=435361

Review URL: https://codereview.chromium.org/746023002
2014-11-20 17:42:05 -08:00
Eric Seidel
66bad10810 Remove a bunch of OS(MACOSX) code
This code is unused in sky.

Amazing how much code we had for dealing with old
versions of MSVC.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/709603006
2014-11-11 15:33:38 -08:00
Elliott Sprehn
e9073fbdc0 Remove PODIntervalTree and machinery.
This was for floats and shapes which we removed.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/705373003
2014-11-07 17:01:02 -08:00
Ojan Vafai
3b628f7d39 Delete a ton more dead vertical writing mode code.
No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684383002
2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code.
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
2014-10-29 19:06:59 -07:00
Ojan Vafai
959c404854 Remove all writing mode function arguments and remove writing mode from RenderStyle.
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/683803006
2014-10-29 12:18:30 -07:00
Ojan Vafai
8b0d9e8ac9 First past at removing writing mode.
This removes the parsing and the enum. This leaves a bunch of
dead code around to fix in a followup.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689743002
2014-10-29 12:17:11 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00