godofredoc
465c5dc0a7
[Cleanup] remove type=local from local test/generators. ( flutter/engine#41465 )
...
The `"type": "local"` property from local test and generators was never used. Removing from configurations.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 02:53:06 +00:00
Jonah Williams
78d8124320
Revert "[impeller] convert src over to src for solid color" ( flutter/engine#41466 )
...
Reverts flutter/engine#41351
2023-04-25 00:49:11 +00:00
godofredoc
fe21fedc1e
Remove empty tests properties. ( flutter/engine#41461 )
...
Tests property is optional, empty tests property can be safely removed from the build configurations.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-24 23:03:16 +00:00
skia-flutter-autoroll
fd65498026
Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) ( flutter/engine#41462 )
...
https://skia.googlesource.com/skia.git/+log/0ec4c84abd0b..5f4dd36a69f9
2023-04-24 johnstiles@google.com Add release note for SkRP.
2023-04-24 jamesgk@google.com Early-out instead of asserting in make_vk_backend_texture
2023-04-24 istepancar@gmail.com fix(*): fix links in canvaskit readme
2023-04-24 sunnyps@chromium.org graphite: Split backend include sources in build
2023-04-24 johnstiles@google.com Create dedicated SkRP op for matrix-multiply.
2023-04-24 brianosman@google.com (Reland) Always run color space math in full-float
2023-04-24 johnstiles@google.com Use packed contexts for small swizzles in SkRP.
2023-04-24 cmumford@google.com Switch to putting new release notes in //relnotes/
2023-04-24 johnstiles@google.com Eliminate SkVM-specific features from Viewer.
2023-04-24 johnstiles@google.com Rewrite ES2 loop-test conditions that use !=.
2023-04-24 egdaniel@google.com [Graphite] Add support for purgeNotUsedSinced to ResourceCache.
2023-04-24 brianosman@google.com Remove SkXfermode and SkXfermode_opts
2023-04-24 kjlubick@google.com Add minimal viewer build with Bazel.
2023-04-24 michaelludwig@google.com [skif] Cleanup FilterResultTest to prep for color filters
2023-04-24 michaelludwig@google.com [skif] Inline FilterResult::concatTransform() into applyTransform()
2023-04-24 johnstiles@google.com Eliminate SkVM-specific bots.
2023-04-24 brianosman@google.com Remove xfermode support from legacy shader blitter
2023-04-24 johnstiles@google.com Eliminate 'skia_compare_vm_vs_rp' benchmarking code.
2023-04-24 johnstiles@google.com Increase the arena stack size in onFilterColor4f.
2023-04-24 johnstiles@google.com Add a pad_stack op to the RP builder.
2023-04-24 johnstiles@google.com Eliminate SkVM unit tests for debug tracing.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 22:41:17 +00:00
godofredoc
2e49be471e
Reland "Upload windows arm artifacts to production bucket." ( flutter/engine#41409 )
...
Reverts flutter/engine#41372
The duplicated artifacts were removed from Windows Host Engine in https://flutter-review.googlesource.com/c/recipes/+/42340 . After the recipes change lands and is propagated it will be safe to update the `Windows windows_arm_host_engine` build to upload the artifacts to prod.
Bug: https://github.com/flutter/flutter/issues/125262
2023-04-24 21:17:24 +00:00
keyonghan
b896507aea
Add 16.2 runtime to Mac unopt ( flutter/engine#41456 )
...
Fixes: https://github.com/flutter/flutter/issues/124408
2023-04-24 19:55:21 +00:00
skia-flutter-autoroll
526f2abfa6
Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) ( flutter/engine#41449 )
...
https://skia.googlesource.com/skia.git/+log/1f84e5060646..0ec4c84abd0b
2023-04-24 kjlubick@google.com Remove SkImageEncoder and SkImage::encodeToData
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 60517cf84231 to 4b61bdad813f (1 revision)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77d86c4a7ecc to b58ef53abced (11 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 83a6fdf2e118 to fab3b205b6c7
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 003e879fd974 to d2b5bd140525 (14 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5a15d80499c to 83a6fdf2e118 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 13:57:52 +00:00
dependabot[bot]
06b8eef0d8
Bump actions/setup-python from 4.5.0 to 4.6.0 ( flutter/engine#41444 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.5.0 to 4.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases ">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>Add allow-prereleases input</h2>
<p>In scope of this release we added a new input (<code>allow-prereleases</code>) to allow <a href="https://redirect.github.com/actions/setup-python/pull/414 ">falling back to pre-release versions of Python when a matching GA version of Python is not available</a></p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.12
allow-prereleases: true
</code></pre>
<p>Besides, we added such changes as:</p>
<ul>
<li>Fix bug to trim new line for PyPy version: <a href="https://redirect.github.com/actions/setup-python/pull/610 ">actions/setup-python#610</a></li>
<li>Added pip dependency file to generate hash from it: <a href="https://redirect.github.com/actions/setup-python/pull/604 ">actions/setup-python#604</a></li>
<li>Improved error handling for saving and restoring cache: <a href="https://redirect.github.com/actions/setup-python/pull/618 ">actions/setup-python#618</a></li>
<li>Add warning if cache paths are empty: <a href="https://redirect.github.com/actions/setup-python/pull/642 ">actions/setup-python#642</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="57ded4d7d5https://redirect.github.com/actions/setup-python/issues/655 ">#655</a>)</li>
<li><a href="df6abcc733https://redirect.github.com/actions/setup-python/issues/652 ">#652</a>)</li>
<li><a href="7a4f344e33https://redirect.github.com/actions/setup-python/issues/642 ">#642</a>)</li>
<li><a href="d1244c8404https://redirect.github.com/actions/setup-python/issues/641 ">#641</a>)</li>
<li><a href="3091b37310https://redirect.github.com/actions/setup-python/issues/637 ">#637</a>)</li>
<li><a href="dfa76f8d0dhttps://redirect.github.com/actions/setup-python/issues/622 ">#622</a>)</li>
<li><a href="03eb867e3dhttps://redirect.github.com/actions/setup-python/issues/618 ">#618</a>)</li>
<li><a href="b41aaf9f0chttps://redirect.github.com/actions/setup-python/issues/621 ">#621</a> from akv-platform/reusable-workflow</li>
<li><a href="0ffa49cfcaec365b4ebahttps://redirect.github.com/actions/setup-python/issues/617 ">#617</a>)</li>
<li>Additional commits viewable in <a href="d27e3f3d7c...57ded4d7d5https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4.5.0&new-version=4.6.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-04-24 10:13:05 +00:00
skia-flutter-autoroll
f253f78e2a
Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... ( flutter/engine#41428 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 06:39:10 +00:00
skia-flutter-autoroll
623c2fd396
Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... ( flutter/engine#41424 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 16:43:38 +00:00
skia-flutter-autoroll
48672abb9c
Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) ( flutter/engine#41422 )
...
https://dart.googlesource.com/sdk.git/+log/be6db2b60a41..fd4797c1464b
2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-34.0.dev
2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-33.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com ,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:33:04 +00:00
skia-flutter-autoroll
b8244e7e08
Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) ( flutter/engine#41421 )
...
https://skia.googlesource.com/skia.git/+log/9912500bcca3..b9c90858cdd8
2023-04-22 johnstiles@google.com Preserve SkRP execution masks when calling to/fromLinearSrgb.
2023-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 172c51ea9b08 to 60517cf84231 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:31:21 +00:00
skia-flutter-autoroll
a49c2876c9
Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) ( flutter/engine#41413 )
...
https://skia.googlesource.com/skia.git/+log/aa592c60846d..36a6690cd1f1
2023-04-21 johnstiles@google.com Ignore SkVM-related flags when SK_ENABLE_SKVM is not defined.
2023-04-21 johnstiles@google.com Fix lifetime issue with deferred uniforms in SkRP.
2023-04-21 brianosman@google.com Fully remove legacy sprite blitters for everything but SrcOver
2023-04-21 johnstiles@google.com Revert "Disable SkVM by default."
2023-04-21 johnstiles@google.com Disable SkVM by default.
2023-04-21 jvanverth@google.com [graphite] Still more steps to get dm running with Vulkan
2023-04-21 johnstiles@google.com Simplify shuffle instruction-encoding in RP builder.
2023-04-21 rmistry@google.com Update "directly ping rmistry@" documentation
2023-04-21 johnstiles@google.com Move #ifdef guards to fix Chrome roll.
2023-04-21 fmalita@chromium.org [skottie] Plumb new text direction property
2023-04-21 blundell@chromium.org [Graphite] Return null when color type not found in DawnCaps.cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 01:26:25 +00:00
skia-flutter-autoroll
46b36722ee
Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... ( flutter/engine#41407 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 23:29:05 +00:00
Jason Simmons
6f5ee7f984
[Impeller] Add a CommandBuffer::WaitUntilScheduled API ( flutter/engine#41303 )
...
This can be used by IO thread operations such as image decoding to ensure that the results of GPU commands become visible to the raster thread.
2023-04-21 19:08:04 +00:00
gaaclarke
b6818a0773
[Impeller] Turned off the TextRotated golden test again ( flutter/engine#41399 )
...
We previously turned this test to `ignore` to see if we could get it to stabilize by accepting the variants and it doesn't seem to have worked. I'm going to turn it off again.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 18:26:10 +00:00
skia-flutter-autoroll
041e2f267d
Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) ( flutter/engine#41398 )
...
https://skia.googlesource.com/skia.git/+log/5754b81988b8..aa592c60846d
2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com (Manual) Roll Dawn from 9e9c4560752a to 003e879fd974 (22 revisions)
2023-04-21 johnstiles@google.com Eliminate redundant register/stack exchanges.
2023-04-21 ccameron@chromium.org SkJpeg: Update gainmap encode and decode to reflect spec changes
2023-04-21 johnstiles@google.com Wrap SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap remaining usage of SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkSLVMCodeGenerator with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkColorFilter/Blender::onProgram calls with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Reland "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-21 kjlubick@google.com Expose SkPixmapUtils
2023-04-21 kjlubick@google.com Move most of the Ganesh code out of SkImage_Base and SkImage_Lazy
2023-04-21 michaelludwig@google.com Fix anisotropic subset check in GrTextureEffect
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 17:48:45 +00:00
gaaclarke
3d7eeccb55
[impeller] fixed flake where blit wasn't tracking its texture ( flutter/engine#41347 )
...
fixes https://github.com/flutter/flutter/issues/125147
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-21 10:45:26 -07:00
Prashant Andoriya
238f79d114
removing the check_gn_format.py file from ci/ ( flutter/engine#41397 )
...
Delete obsolete empty script.
fixes: flutter/flutter#100741
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
- [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [+] I signed the [CLA].
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:34 +00:00
David Iglesias
dfd9ef5e60
[web] Fix HashUrlStrategy.addPopStateListener ( flutter/engine#41384 )
...
During a JS-interop refactor, we introduced a small bug in the `addPopStateListener` method of the `HashUrlStrategy` object (web).
This wasn't caught before because the existing tests were mocking the refactored code.
## Issues
Fixes: https://github.com/flutter/flutter/issues/125228
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:31 +00:00
Brandon DeRosier
549dd82f2f
[Impeller] Fix division by zero for transparent shadows ( flutter/engine#41391 )
...
A division by zero happens if the shadow color is fully transparent, and
the NaNs are getting assigned to the RGB values of the paint color being
handed to the rrect shadow draw. This doesn't cause a problem when wide
gamut is off because NaN output ends up being interpreted as zero (thus
making the shadow output fully transparent black, which happens to be
the expected and correct result). However, when a wide gamut attachment
is present, the NaN output ends up being interpreted as a negative
value.
Reproduction app:
```dart
import 'package:flutter/material.dart';
void main() => runApp(const GeneralDialogApp());
class EvilPainter extends CustomPainter {
@override
void paint(Canvas canvas, Size size) {
final Rect rect = Offset.zero & size;
canvas.drawPaint(Paint()..color = Colors.white);
canvas.saveLayer(null, Paint()..blendMode = BlendMode.srcOver);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.black54, 15, false);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.black54, 15, false);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.transparent, 15, false);
canvas.restore();
}
@override
bool shouldRepaint(EvilPainter oldDelegate) => false;
@override
bool shouldRebuildSemantics(EvilPainter oldDelegate) => false;
}
class GeneralDialogApp extends StatelessWidget {
const GeneralDialogApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
restorationScopeId: 'app',
home: CustomPaint(painter: EvilPainter()),
);
}
}
```
Before:
After:
2023-04-21 08:58:05 -07:00
skia-flutter-autoroll
6df3a85712
Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... ( flutter/engine#41393 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 09:21:09 +00:00
Brandon DeRosier
c222cc4715
[Impeller] Fix SupportsReadFromOnscreenTexture capability check ( flutter/engine#41386 )
2023-04-21 01:45:35 -07:00
Brandon DeRosier
b98bc7c360
[Impeller] Always use BGRA10_XR for wide gamut ( flutter/engine#41385 )
...
Fixes errors blitting offscreen textures to onscreen textures
when wide gamut is enabled due to the mismatching formats.
2023-04-21 01:45:06 -07:00
skia-flutter-autoroll
cbd8789c22
Roll Skia from 524ecb58945e to 90a93bb0990f (1 revision) ( flutter/engine#41390 )
...
https://skia.googlesource.com/skia.git/+log/524ecb58945e..90a93bb0990f
2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8b632f5f2d8d to f5a15d80499c (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 07:24:27 +00:00
skia-flutter-autoroll
6c76730570
Roll Skia from f4609aa2eaba to 524ecb58945e (23 revisions) ( flutter/engine#41388 )
...
https://skia.googlesource.com/skia.git/+log/f4609aa2eaba..524ecb58945e
2023-04-21 fmalita@chromium.org [skottie] Add option for disabling image asset scaling
2023-04-20 johnstiles@google.com Reland "Add a GN flag 'skia_enable_skvm'."
2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c1d27abff170 to 2c49741eda05 (8 revisions)
2023-04-20 herb@google.com Cleanup code for SkGlyph underline
2023-04-20 johnstiles@google.com Use src.rgba for SkRP execution masks.
2023-04-20 sunnyps@chromium.org graphite: Add test guard for RecorderPriv::resourceCache
2023-04-20 brianosman@google.com Reland "Change Flutter to always use analytic AA"
2023-04-20 scroggo@google.com Remove group_static_libs
2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com (Manual) Roll Dawn from 27c772262048 to 9e9c4560752a (61 revisions)
2023-04-20 chillers@google.com Revert "Change Flutter to always use analytic AA"
2023-04-20 jmbetancourt@google.com Revert "[skottie] pass slot id to opacity callback"
2023-04-20 johnstiles@google.com Create a Raster Pipeline op to exchange src.rgba with memory.
2023-04-20 robertphillips@google.com [graphite] Make SkGradientShaderBase own the color and offset bitmap
2023-04-20 brianosman@google.com Reland "Always run color space math in full-float within Ganesh"
2023-04-20 briansalomon@gmail.com Add BAZEL.build file for tools/gpu/mtl
2023-04-20 briansalomon@gmail.com [bazel] Support optional building of Ganesh Metal backend.
2023-04-20 johnstiles@google.com Revert "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-20 johnstiles@google.com Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM.
2023-04-20 lehoangquyen@chromium.org graphite-dawn: Use Depth24PlusStencil8 instead of Depth32FloatStencil8.
2023-04-20 robertphillips@google.com [graphite] Share boilerplate code in ProxyCacheTests
2023-04-20 johnstiles@google.com Add header guards to SkSLRasterPipelineBuilder.h.
2023-04-20 herb@google.com Unposion stack allocated memory in arena allocs
2023-04-20 johnstiles@google.com Revert "Add a GN flag 'skia_enable_skvm'."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 05:37:52 +00:00
keyonghan
a1fa5b436e
Update xcode to 14c18 ( flutter/engine#41370 )
...
With https://flutter-review.googlesource.com/c/recipes/+/42160 , we are
ready to make all tests consistent with xcode 14c18.
Fixes https://github.com/flutter/flutter/issues/125216
2023-04-20 20:53:35 -07:00
Zachary Anderson
30bcef02d5
Revert "[Impeller] Turned on wide gamut support by default." ( flutter/engine#41382 )
...
Reverts flutter/engine#39801
`customer: chalk` hit some rendering issues that was narrowed down to this: b/278976014
2023-04-21 02:20:12 +00:00
Casey Hillers
124093c6de
Revert "Manual roll skia to d5b4acfb4" ( flutter/engine#41381 )
...
Reverts flutter/engine#41378
Tests are passing at
https://dart.googlesource.com/sdk/+/7247a1b3b7166c828a0c2e00259ec03fd737d455
2023-04-20 18:36:06 -07:00
Loïc Sharma
f79695512e
[Windows] Don't block raster thread until v-blank ( flutter/engine#41231 )
...
Currently the Windows raster thread blocks until the v-blank. As a result, on Windows a frame can spend 17ms on the raster thread even if rasterization completes in under 1ms. This behavior prevents us from rendering multiple views on the same raster thread on Windows.
This change does not make rasterization faster. Instead, it allows the raster thread to do more work.
Addresses https://github.com/flutter/flutter/issues/124903
### Results
Here are the performance graphs if I hover on and off the counter app's button repeatedly.
#### Before
The raster thread spends ~17ms per frame consistently:
#### After
After this change, the raster thread spends less than 1ms per frame consistently:
### Background
Blocking until the v-blank prevents screen tearing if the OS does not synchronize to the vsync. Windows does synchronize if the Desktop Windows Manager composition is enabled, which is required on Windows 8 and newer. In other words, this blocking behavior is unnecessary for Windows 8 and newer.
For Windows 7, screen tearing is possible if DWM composition is disabled (either by the user or by an app). In this scenario, the Flutter app should block until the v-blank to synchronize with the vsync and prevent screen tearing. We can detect if DWM composition is disabled using [`DwmIsCompositionEnabled`](https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmiscompositionenabled ). We can detect changes to DWM composition using the top-level [`WM_DWMCOMPOSITIONCHANGED`](https://learn.microsoft.com/en-us/windows/win32/dwm/wm-dwmcompositionchanged ) Windows message.
Useful resources:
1. https://learn.microsoft.com/en-us/windows/win32/dwm/composition-ovw
2. https://www.khronos.org/opengl/wiki/Swap_Interval
3. https://forums.imgtec.com/t/eglswapinterval-0-tearing-problem/2356/5
4. https://stackoverflow.com/questions/32282252/can-eglswapinterval0-cause-screen-tearing
5. https://bugs.chromium.org/p/chromium/issues/detail?id=480361
2023-04-21 01:01:50 +00:00
Casey Hillers
d6886ee41e
Manual roll skia to d5b4acfb4 ( flutter/engine#41378 )
2023-04-20 17:01:14 -07:00
Jenn Magder
bda11b675c
Run mac unopt arm builds with arm toolchain ( flutter/engine#41353 )
...
Add `--force-mac-arm64` to arm gn commands running on Mac ARM bots to compile natively and not with Rosetta. Sometimes we've seen random slow-downs in CI when lots of Rosetta processes run at the same time.
This will disable goma for these builds but it doesn't seem to be much slower:
`build ios_debug_sim_arm64` step on prod:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/123894/overview - 1.1 minute
vs this PR:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/747210/overview - 1.8 minute
2023-04-21 00:00:53 +00:00
Zachary Anderson
d2cf696dc0
Revert "re-land "Migrate mac_host_engine to engine v2 builds." ( #41233 )"" ( flutter/engine#41380 )
...
Reverts flutter/engine#41323
2023-04-20 23:48:08 +00:00
yaakovschectman
690791e88a
Move ownership of AccessibilityBridgeWindows to FlutterWindowsView ( flutter/engine#41308 )
...
Move ownership of the pointer to `AccessibilityBridgeWindows` from
`FlutterWindowsEngine` to `FlutterWindowsView` in preparation for
multi-window.
https://github.com/flutter/flutter/issues/124995
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-20 16:28:00 -04:00
skia-flutter-autoroll
57773fc8af
Roll Fuchsia Linux SDK from AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... ( flutter/engine#41373 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 19:33:03 +00:00
godofredoc
c503b3632b
Revert "Upload windows arm artifacts to production bucket." ( flutter/engine#41372 )
...
Reverts flutter/engine#41324
2023-04-20 18:06:19 +00:00
godofredoc
0a0aa1e23e
re-land "Migrate mac_host_engine to engine v2 builds." ( #41233 )" ( flutter/engine#41323 )
...
This reverts commit 2753bcaf63ebe94f84c091cb84f23c01b5a718e3.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-20 17:12:14 +00:00
godofredoc
8bb1f32551
Upload windows arm artifacts to production bucket. ( flutter/engine#41324 )
...
This will start uploading the arm artifacts to the production bucket without the experimental namespace.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-20 15:47:12 +00:00
Jason Simmons
8e87882fec
[Impeller] Change the default color format for the GLES backend to RGBA ( flutter/engine#41342 )
...
This provides compatibility with BlitCopyTextureToBufferCommandGLES::Encode and glReadPixels (which only guarantees support for RGBA).
2023-04-20 15:40:22 +00:00
maRci002
da6f9f69f2
[web] change status bar color based on SystemUiOverlayStyle ( flutter/engine#40599 )
...
Closes flutter/flutter#123365
In my [example code](https://github.com/flutter/flutter/issues/123365#issue-1638490447 ) I'm using `SystemUiOverlayStyle.dark` which has `null` `statusBarColor` by default (_which can be changed via `Change status bar color` button_) in this case we do not override browser's default status bar color.
| Old behaviour | New behaviour |
| -- | -- |
| <video src="https://user-images.githubusercontent.com/8436039/227386349-e30cce47-ffc6-4465-bb30-cd2888f77d32.mp4 " /> | <video src="https://user-images.githubusercontent.com/8436039/227580430-a25e57dc-9d5a-43a1-bcb3-3bd8abd753d8.mp4 " /> |
In case of PWA the when `statusBarColor` is `null` it will use `theme_color` property from `manifest.json` (I don't know from where does flutter generate `manifest.json`).
The default status bar color for PWA is: `"theme_color": "#0175C2",`
f4caee6efb/examples/api/web/manifest.json (L7)https://user-images.githubusercontent.com/8436039/227607373-79be7294-d9f7-4a45-9014-28720acce0c7.mp4 " /> | <video src="https://user-images.githubusercontent.com/8436039/227607329-be16131f-4104-419a-8e16-2b229d73d95e.mp4 " /> |
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-20 14:33:07 +00:00
skia-flutter-autoroll
2cbc1424bf
Roll Skia from c21e7df194c3 to c50081c62219 (11 revisions) ( flutter/engine#41358 )
...
https://skia.googlesource.com/skia.git/+log/c21e7df194c3..c50081c62219
2023-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b944a5cb38c to 8b632f5f2d8d (3 revisions)
2023-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4fbe7556fc02 to 2782b5af9734 (2 revisions)
2023-04-19 brianosman@google.com Revert "Always run color space math in full-float within Ganesh"
2023-04-19 brianosman@google.com Revert "Always run color space math in full-float on the GPU (Part 2)"
2023-04-19 jvanverth@google.com [graphite] Stub in VulkanGraphicsPipeline.
2023-04-19 brianosman@google.com Always run color space math in full-float on the GPU (Part 2)
2023-04-19 brianosman@google.com Always run color space math in full-float within Ganesh
2023-04-19 scroggo@google.com Clarify where changes to gn_to_bp should be submitted
2023-04-19 johnstiles@google.com Add a GN flag 'skia_enable_skvm'.
2023-04-19 johnstiles@google.com Restructure Generator::pushConstructorCast to use a switch.
2023-04-19 michaelludwig@google.com [graphite] Replace BlockReader with ShaderNode trees
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 07:01:22 +00:00
skia-flutter-autoroll
ab43e2c479
Roll Fuchsia Linux SDK from Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... ( flutter/engine#41357 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 05:19:25 +00:00
Jason Simmons
7938a1c2b3
Manual Skia roll from ad90b6bd4760 to c21e7df194c3 ( flutter/engine#41341 )
...
https://skia.googlesource.com/skia.git/+log/ad90b6bd4760..c21e7df194c3
2023-04-19 brianosman@google.com Change Flutter to always use analytic
AA
2023-04-19 18:46:55 -07:00
Jonah Williams
f73ae51144
[impeller] convert src over to src for solid color ( flutter/engine#41351 )
...
Related to https://github.com/flutter/flutter/issues/114402
At least in the flutter gallery test app, with https://github.com/flutter/gallery/pull/909 reverted - this significantly improves the performance in the Xcode frame debugger. If we wanted to do this for more color sources or filter effects, we need to do much more work to track texture opacity, but this seems like a reasonable and low cost first step.
### Before
### After
2023-04-20 01:07:33 +00:00
Brandon DeRosier
b4271c24de
Add missing header guards ( flutter/engine#41322 )
...
These keep turning up, so I did a little bash-fu to find them all.
```bash
grep -lL "#pragma once" $(grep -lL "#ifndef .*_H_" $(find . | grep "\.h$")) | cut -c 3-
```
2023-04-19 21:20:21 +00:00
joshualitt
90138c2003
[web] Fix trivial type issue. ( flutter/engine#40956 )
2023-04-19 12:58:30 -07:00
Brandon DeRosier
c43fb87612
[Impeller] Comprehensively label snapshots ( flutter/engine#41325 )
...
Makes it much easier to work out where things are going wrong in filter
chains.
For example, when capturing the app in
https://github.com/flutter/flutter/issues/124956 , the chain of
RenderPasses gets labeled as follows:
1. Contents to ForegroundPorterDuffBlend Filter Snapshot
2. Contents to GaussianBlur Filter Snapshot
3. Directional Gaussian Blur Filter
4. Directional Gaussian Blur Filter
...and so it's easy to see that the filter chain is
ForegroundPorterDuffBlend->DirectionalGaussianBlur->DirectionalGaussianBlur,
and the former two are triggering a non-collapsed snapshot of their
inputs.
2023-04-19 11:56:12 -07:00
Brandon DeRosier
c7eefdf7f0
[Impeller] Fix transform regressions for chained filters ( flutter/engine#41332 )
...
Resolves https://github.com/flutter/flutter/issues/124956 .
Fixes some recent transform issues that mainly apply to chained filters
(like when both a color + image filter has been set).
- For all filters, the returned entity should just be an identity matrix
because the snapshot transform gets fully absorbed.
- For all filters, given entity's transform should be applied in the
coverage proc (although this currently makes no difference because of
the way coverage is queried when snapshotting).
- For filters drawing with coverage + transforming UVs, the transform
handed to the contents of the deferred entity needs to be applied.
Otherwise the entity won't get repositioned correctly while
snapshotting.
2023-04-19 11:55:42 -07:00
Chinmay Garde
4117cb927e
[Impeller] Make //impeller/display_list TU naming consistent. ( flutter/engine#41174 )
...
No change in functionality. I've just renamed the TU's to replace `display_list_` to `dl_`. I am sure there are chances to make the naming better. For instance, the op receiver still being named a dispatcher.
2023-04-19 17:32:53 +00:00
Mouad Debbar
2bc352f431
[web] Remove non-ShadowDom mode ( flutter/engine#39915 )
...
If we still want to do this, here's a quick PR :)
Fixes https://github.com/flutter/flutter/issues/116204
2023-04-19 16:15:21 +00:00
