Camille Simon
e0742ebb24
[Android] Add spell check suggestions toolbar ( #114460 )
...
* Add spell check suggestions toolbar
* Fix test and move menu
* Cleanup
* Cleanup and fix bug
* More cleanup
* Make height dynamic and use localized delete
* Begin adding tests
* Create var checking for results
* Add tests
* Fix analyze (sorta)
* Add back hideToolbar call for testing
* Add back hidetoolbar in ts and delete one in et
* Remove unecessary calls to hidToolbar
* Fix analyze and docs
* Test fix
* Fix container issue
* Clean up
* Fix analyze
* Move delegate
* Fix typos
* Start addressing review
* Continue addressing review
* Add assert
* Some refactoring
* Add test for button behavior
* Undo test change
* Make spell check results public
* Rearrange test
* Add comment
* Address review
* Finish addressing review
* remove unused imports
* Address nits
* Address review
* Fix formatting
* Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints
* Fix analyze:
2022-12-20 19:56:12 +00:00
Michael Goderbauer
fa3777bd3e
Enable sized_box_shrink_expand lint ( #117371 )
...
* Enable lint
* note about discarded_futures
* note about use_decorated_box
* update note on require_trailing_commas
2022-12-20 19:07:15 +00:00
harperl-lgtm
7f7a8778d8
Implemented Scrim Focus for BottomSheet ( #116743 )
...
* Implemented Scrim Focus for BottomSheet so that assistive technology users can focus and tap on the scrim to close the BottomSheet, which they could not do before the change . The Scrim Focus's size changes to avoid overlapping the BottomSheet.
2022-12-20 10:02:22 -05:00
Michael Goderbauer
bf5fdb9f96
Reland "Inject current FlutterView into tree and make available via View.of(context) ( #116924 )" ( #117244 )
...
* Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924 )"
This reverts commit 9102f2fe0bd26db6074ac4a17785296cd341ecb9.
* remove window placeholder
2022-12-17 06:14:19 +00:00
htoor3
98e9032ca3
[web] Allow shift + left/right keyboard shortcuts to be handled by framework on web ( #117217 )
...
* Remove DoNothing actions for shift + left/right keyboard shorcuts on web and add tests
* Fix spacing
* Add select all left/right cases + tests
2022-12-16 22:12:41 +00:00
Casey Hillers
9102f2fe0b
Revert "Inject current FlutterView into tree and make available via View.of(context) ( #116924 )" ( #117214 )
...
This reverts commit a34e41948461de77bdec3dcc884900cd4544abb1.
2022-12-16 17:48:23 +00:00
chunhtai
23a2fa31d2
Reland "Adds API in semanticsconfiguration to decide how to merge chi… ( #116895 )
...
* Reland "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730 )"
This reverts commit 7549925c8c44dea92c7bc75be676c17b7613f87f.
* makes markNeedsSemanticsUpdate more robust
* address comment
2022-12-16 17:20:20 +00:00
Michael Goderbauer
a34e419484
Inject current FlutterView into tree and make available via View.of(context) ( #116924 )
...
* enable View.of
* tests
* ++
* greg review
* rewording
* hide view from public
2022-12-16 00:13:56 +00:00
hangyu
c98978ae36
Update Navigator updatePages() ( #116945 )
...
* Update navigator.dart
* Update navigator.dart
* Add test
* Update navigator.dart
* lint
* Update packages/flutter/test/widgets/navigator_test.dart
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
* Update packages/flutter/test/widgets/navigator_test.dart
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2022-12-15 14:30:21 -08:00
Jonah Williams
169b49fba7
Revert "[framework] make transform with filterQuality a rpb ( #116792 )" ( #117095 )
...
This reverts commit e331dcda1785982a9efbc762e08e9c617cd3f6ae.
2022-12-15 17:11:42 +00:00
Michael Goderbauer
dbc9306380
Failure to construct ErrorWidget for build errors does not destroy tree ( #117090 )
2022-12-14 21:53:20 +00:00
Callum Moffat
97df2b3191
Fix scroll jump when NestedScrollPosition is inertia-cancelled. ( #116689 )
...
* Fix scroll jump when NestedScrollPosition is inertia-cancelled.
* Switch to using pointerScroll(0)
2022-12-13 00:20:30 +00:00
Jonah Williams
e331dcda17
[framework] make transform with filterQuality a rpb ( #116792 )
...
* [framework] make transform with filterQuality a rpb
* fix tests
* ++
2022-12-12 23:30:17 +00:00
Callum Moffat
601f48cd95
InteractiveViewer discrete trackpad panning ( #112171 )
...
* InteractiveViewer web trackpad panning
* Address feedback
2022-12-12 22:34:24 +00:00
Callum Moffat
8e1f8352bf
Fix MediaQuery.paddingOf ( #116858 )
...
* Fix MediaQuery.paddingOf
* Try to fix test overflow on web
2022-12-12 21:54:54 +00:00
Jonah Williams
d19047d8a1
[framework] make opacity widget create a repaint boundary ( #116788 )
2022-12-12 18:40:13 +00:00
Michael Goderbauer
5a229e2827
Add LookupBoundary to Overlay ( #116741 )
...
* Add LookupBoundary to Overlay
* fix analysis
2022-12-12 18:16:06 +00:00
Casey Hillers
7549925c8c
Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations ( #110730 )" ( #116839 )
...
This reverts commit 352ad3a9efccc8c54deb72eb0d7164bfb42b2a49.
2022-12-11 02:23:40 +00:00
Callum Moffat
c4b8046d96
Floating cursor cleanup ( #116746 )
...
* Floating cursor cleanup
* Use TextSelection.fromPosition
2022-12-10 00:24:23 +00:00
Michael Goderbauer
9dd30878d9
Add LookupBoundary to Material ( #116736 )
2022-12-09 15:48:00 -08:00
Callum Moffat
73cb7c2fc5
Squashed MediaQuery InheritedModel ( #114459 )
2022-12-09 20:59:11 +00:00
chunhtai
521028c808
Reland "Use semantics label for backbutton and closebutton for Android" ( #116676 )
...
* Reland "Use semantics label for backbutton and closebutton for Android"
This reverts commit cc256c3e33d74ed861640e09e8e21957ddd94c1e.
* Makes the semantics slider test more robust
2022-12-07 21:46:17 +00:00
Michael Goderbauer
297f094c01
LookupBoundary ( #116429 )
...
* LookupBoundary simplified
* tests
* doc and impl complete
* doc fixes
* add more tests
* review
* empty
2022-12-07 19:26:12 +00:00
chunhtai
cc256c3e33
Revert "Use semantics label for backbutton and closebutton for Android" ( #116675 )
...
This reverts commit 68ce1aeaeb33ad960fb5195852e4dc66f680d4ff.
2022-12-07 10:33:44 -08:00
chunhtai
68ce1aeaeb
Reland "Use semantics label for backbutton and closebutton for Android" ( #115776 )
...
* Reland "Use semantics label for backbutton and closebutton for Android"
This reverts commit 20a78ed69f45502344010aedff4d915db27072b2.
* change to default target platform
2022-12-07 18:03:17 +00:00
Casey Hillers
7673108d7e
Revert "Speed up first asset load by encoding asset manifest in binary rather than JSON ( #113637 )" ( #116662 )
...
This reverts commit 56cad89b1e8d79b75b88116a5db9cb70f91c4986.
2022-12-07 17:29:05 +00:00
chunhtai
352ad3a9ef
Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations ( #110730 )
...
* Adds semantics merger API and fix input decorator
* addressing comments
* abstractnode to object
* feature complete
* addressing comments
* fix comments
* conditionally add sort order
* fix bool
* fix test
* more fix
* fix tests
2022-12-07 16:59:16 +00:00
Greg Spencer
fb9133b881
Add ListenableBuilder with examples ( #116543 )
...
* Add ListenableBuilder with examples
* Add tests
* Add tests
* Fix Test
* Change AnimatedBuilder to be a subclass of ListenableBuilder
2022-12-07 01:15:22 +00:00
Andrew Kolos
56cad89b1e
Speed up first asset load by encoding asset manifest in binary rather than JSON ( #113637 )
2022-12-05 10:39:10 -08:00
Jonah Williams
e065c7fea2
[framework] make ImageFiltered a repaint boundary ( #116385 )
...
* ++
* ++
* ++
2022-12-02 19:48:00 +00:00
Greg Spencer
0234b18f88
Tweak directional focus traversal ( #116230 )
...
* Use distance instead of coord
* Sort by distance prefer axis
* Switch initial sort back to sort by coordinate.
* revert test change
* Fix tests
* Simplify test case
* Add a test for irregular grids
* Review Changes
2022-12-01 23:41:09 +00:00
Casey Hillers
d2af134578
Revert "Fix Slider semantic node size ( #115285 )" ( #116294 )
...
This reverts commit 8473da22cde2fcedd51af654822cac83a9b5ecb5.
2022-11-30 11:21:39 -08:00
Taha Tesser
8473da22cd
Fix Slider semantic node size ( #115285 )
2022-11-30 02:27:45 +00:00
LongCatIsLooong
24db45e792
Disable backspace/delete handling on iOS & macOS ( #115900 )
...
* Disable backspace/delete handling on iOS
* fix tests
* review
* macOS too
* review
2022-11-29 10:03:15 +00:00
LongCatIsLooong
ccc277c38b
Fix LayoutExplorer cycle ( #115526 )
...
* Fix LayoutExplorer cycle
* fix tests
* Update widget_inspector.dart
* Update widget_inspector.dart
* review
* expandPropertyValues
2022-11-28 22:25:07 +00:00
chunhtai
224fae5063
Fix iOS selectWordEdge doesn't account for affinity ( #115849 )
...
* Fix iOS selectWordEdge doesn't account for affinity
* fix test
* update
2022-11-28 17:32:17 +00:00
Jim Graham
0eb2d51ec9
Use the new pushImageFilter offset parameter to fix the transform of the children ( #113673 ) ( #115884 )
2022-11-23 07:42:34 +00:00
Taha Tesser
94b9fa4111
Provide an option to update Focus's semantics under FocusableActionDetector` ( #115833 )
...
Update test
Update comments
2022-11-22 22:49:19 +00:00
Jonah Williams
9bb07b5f70
Revert "Use the new pushImageFilter offset parameter to fix the transform of the children ( #113673 )" ( #115861 )
...
This reverts commit 91aeda7bf6f977207d7ac07ca46c26560007a244.
2022-11-22 13:29:56 -08:00
Jim Graham
91aeda7bf6
Use the new pushImageFilter offset parameter to fix the transform of the children ( #113673 )
2022-11-22 17:24:44 +00:00
Callum Moffat
3fe7794255
BouncingScrollPhysics should propagate decelerationRate. ( #115797 )
2022-11-22 00:15:52 +00:00
chunhtai
567d0045bf
Add clip option for navigator ( #115775 )
2022-11-21 19:21:17 +00:00
chunhtai
01c1e8e587
Allows pushing page based route as pageless route ( #114362 )
...
* Allows pushing page based route as pageless route
* update
2022-11-18 14:38:50 -08:00
fzyzcjy
98077617bb
Tiny improvement of RouteSettings display ( #114481 )
...
* impl
* Update packages/flutter/lib/src/widgets/navigator.dart
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
* Update navigator_test.dart
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2022-11-18 19:38:10 +00:00
chunhtai
c2b29501f4
Add selection feedback for both selection area and text field ( #115373 )
...
* Add selection feedback for both selection area and text field
* Addressing comment
* Fixes more test
2022-11-17 18:27:56 +00:00
Greg Spencer
93c4b09e62
Add RestorableEnumN<T> and RestorableEnum<T> to restorable primitive types ( #115050 )
...
* Add RestorableEnumN and RestorableEnum to restorable primitive types
* Review Changes
* Change to assert if not part of the valid set.
* Assert if default value isn't in the enum
2022-11-16 02:07:50 +00:00
Maurice Parrish
95ace11afa
Include initial offset when using PlatformViewSurface ( #114103 )
...
* add position to layout creation
* make position nullable
* fix tests
* test
* clear test size
* clear device pixel ratio
* add more documentaiton
* add comment about localToGlobal
2022-11-15 18:21:37 +00:00
fzyzcjy
8e3ea14787
Incorrect rendering of SnapshotWidget ( #114400 )
...
* add tests
* try to fix
* fix compile error
* refactor code
* rename
* doc
* refactor test
* simple rename
2022-11-15 01:39:57 +00:00
Dan Field
9e314ff749
Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets ( #115173 )
...
* Make FutureBuilder handle SynchronousFuture correctly
* Reland "Load assets in flutter_test without turning event loop. (#115123 )" (#115156 )"
This reverts commit 3895786f9854a73c92406f7f8ccf8db06d3581b7.
2022-11-12 01:36:05 +00:00
Xilai Zhang
338841afd3
Revert "Revert "Revert "Scribble mixin ( #104128 )" ( #114647 )" ( #114698 )" ( #115146 )
...
This reverts commit 3cde69e8d9dff7e081cb6daa6cd633c49176cb32.
2022-11-11 10:01:11 -08:00
