9649 Commits

Author SHA1 Message Date
Michael Goderbauer
0220afdd3e
enable use_enums (#117376) 2022-12-20 20:06:24 +00:00
Camille Simon
e0742ebb24
[Android] Add spell check suggestions toolbar (#114460)
* Add spell check suggestions toolbar

* Fix test and move menu

* Cleanup

* Cleanup and fix bug

* More cleanup

* Make height dynamic and use localized delete

* Begin adding tests

* Create var checking for results

* Add tests

* Fix analyze (sorta)

* Add back hideToolbar call for testing

* Add back hidetoolbar in ts and delete one in et

* Remove unecessary calls to hidToolbar

* Fix analyze and docs

* Test fix

* Fix container issue

* Clean up

* Fix analyze

* Move delegate

* Fix typos

* Start addressing review

* Continue addressing review

* Add assert

* Some refactoring

* Add test for button behavior

* Undo test change

* Make spell check results public

* Rearrange test

* Add comment

* Address review

* Finish addressing review

* remove unused imports

* Address nits

* Address review

* Fix formatting

* Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints

* Fix analyze:
2022-12-20 19:56:12 +00:00
Michael Goderbauer
fa3777bd3e
Enable sized_box_shrink_expand lint (#117371)
* Enable  lint

* note about discarded_futures

* note about use_decorated_box

* update note on require_trailing_commas
2022-12-20 19:07:15 +00:00
Ondrej Simek
8289ea624e
Move a comment where it belongs (#117385) 2022-12-20 17:07:31 +00:00
harperl-lgtm
38e3930f39
Exposed tooltip longPress action when available (#117338)
* Exposed tooltip longPress action when available (Trigger mode is long press)
2022-12-20 10:03:31 -05:00
harperl-lgtm
7f7a8778d8
Implemented Scrim Focus for BottomSheet (#116743)
* Implemented Scrim Focus for BottomSheet so that assistive technology users can focus and tap on the scrim to close the BottomSheet, which they could not do before the change . The Scrim Focus's size changes to avoid overlapping the BottomSheet.
2022-12-20 10:02:22 -05:00
Taha Tesser
5fcb48d598
Fix NavigationRail highlight (#117320) 2022-12-19 10:45:30 -08:00
Taha Tesser
cb988c7b6e
Add indicatorColor & indicatorShape to NavigationRail, NavigationDrawer and move these properties from destination to NavigationBar (#117049) 2022-12-19 10:39:27 -08:00
alanwutang11
c0dddacb81
Fix is canvas kit bool (#116944)
* isCanvasKit implement and test

* isCanvasKit implement and test

* ++

* forgot license

* make isCanvasKit a getter

* addressed comments

* forgot to change names of integration test files

* typo

* simplified tests

* comments
2022-12-17 23:33:32 -08:00
Michael Goderbauer
bf5fdb9f96
Reland "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117244)
* Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)"

This reverts commit 9102f2fe0bd26db6074ac4a17785296cd341ecb9.

* remove window placeholder
2022-12-17 06:14:19 +00:00
htoor3
98e9032ca3
[web] Allow shift + left/right keyboard shortcuts to be handled by framework on web (#117217)
* Remove DoNothing actions for shift + left/right keyboard shorcuts on web and add tests

* Fix spacing

* Add select all left/right cases + tests
2022-12-16 22:12:41 +00:00
Greg Spencer
ecf9b2d20a
Update localization of shortcut labels in menus (#116681)
* Fix Menu shortcut labels

* Remove invalid localizations

* Add more localization for Shift

* Add generated localizations

* Fix Test
2022-12-16 19:57:17 +00:00
LongCatIsLooong
3d0607b543
Defer systemFontsDidChange to the transientCallbacks phase (#117123)
* Always defer systemFontsDidChange to transientCallbacks phase

* unnecessary import
2022-12-16 19:27:03 +00:00
Casey Hillers
9102f2fe0b
Revert "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117214)
This reverts commit a34e41948461de77bdec3dcc884900cd4544abb1.
2022-12-16 17:48:23 +00:00
chunhtai
23a2fa31d2
Reland "Adds API in semanticsconfiguration to decide how to merge chi… (#116895)
* Reland "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)"

This reverts commit 7549925c8c44dea92c7bc75be676c17b7613f87f.

* makes markNeedsSemanticsUpdate more robust

* address comment
2022-12-16 17:20:20 +00:00
Eilidh Southren
da7b8327e4
Bottom App Bar M3 background color fix (#117082)
* Bottom App Bar M3 background color fix

* update test

* test update

* remove whitespace
2022-12-16 09:03:40 +00:00
Lucas.Xu
80e1008cbc
fix: #110342 unable to update rich text widget gesture recognizer (#116849) 2022-12-16 09:32:09 +01:00
LongCatIsLooong
76bb8ead5a
Reland "Fix text field label animation duration and curve" (#114646)"
This reverts commit 9f6090c9adb6265feaee68661dcf22fe3a2c5937.
2022-12-15 19:38:53 -08:00
Michael Goderbauer
a34e419484
Inject current FlutterView into tree and make available via View.of(context) (#116924)
* enable View.of

* tests

* ++

* greg review

* rewording

* hide view from public
2022-12-16 00:13:56 +00:00
hangyu
c98978ae36
Update Navigator updatePages() (#116945)
* Update navigator.dart

* Update navigator.dart

* Add test

* Update navigator.dart

* lint

* Update packages/flutter/test/widgets/navigator_test.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

* Update packages/flutter/test/widgets/navigator_test.dart

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2022-12-15 14:30:21 -08:00
Christopher Fujino
1eaf5c0f08
[flutter_tools] tree shake icons from web builds (#115886)
* wip

* remove temp text file

* fix tests

* add test

* default to off

* restore gitignore

* update

* apply annotation to cupertino icons as well

* update reference to library in icon_tree_shaker.dart

* update tests

* fix tests

* remove hack to skip non-const check on web

* add hint about how much reduction and test
2022-12-15 22:13:17 +00:00
Martin Kustermann
fc3571eff4
Improve documentation of compute() function (#116878)
This improves the documentation of the `compute()` function as follows:

  * Instead of making `compute` a top-level constant, we make it a
    function. This allows the generated API docs to show a function
    signature with parameters and their names, making it *much* clearer
    to users what function is being documented.

  * We mention that on web-backends this is running `compute()` on the
    normal eventloop whereas on on native platforms it runs in a
    separate isolate.

  * We mention that callback, message and result have to be sendable
    across isolates. We also mention that they may be copied.

  * We link to both `Isolate.run` & `SendPort.send` for more information.

  * We use `M` for the type of `message` instead the rather confusing
    `Q`.
2022-12-15 19:25:07 +01:00
Justin McCandless
dcd2170d14
Fix typos in scale gesture recognizer docs (#117116)
Just two small typo fixes.
2022-12-15 09:13:36 -08:00
Jonah Williams
169b49fba7
Revert "[framework] make transform with filterQuality a rpb (#116792)" (#117095)
This reverts commit e331dcda1785982a9efbc762e08e9c617cd3f6ae.
2022-12-15 17:11:42 +00:00
Michael Goderbauer
dbc9306380
Failure to construct ErrorWidget for build errors does not destroy tree (#117090) 2022-12-14 21:53:20 +00:00
Tomasz Gucio
7b19b4d387
Fix CupertinoTextSelectionToolbar showing unnecessary pagination (#104587) 2022-12-14 22:38:04 +01:00
Darren Austin
d8b7eb6e29
Updated token templates to sync with master code. (#117097) 2022-12-14 21:32:12 +00:00
Taha Tesser
57fb36ee0a
[reland] Add Material 3 support for ListTile - Part 1 (#116963)
* [reland] Add Material 3 support for `ListTile` - Part 1

* Update doc
2022-12-14 21:13:59 +00:00
Taha Tesser
f07db4018a
NavigationBar improvements (#116992) 2022-12-13 17:25:49 -08:00
Greg Spencer
fae458b925
Convert TimePicker to Material 3 (#116396)
* Make some minor changes in preparation for updating the Time Picker to M3

* Revert OutlineInputBorder.borderRadius type change

* Revert more OutlineInputBorder.borderRadius changes.

* Convert TimePicker to Material 3

* Add example test

* Revert OutlineInputBorder.borderRadius type change

* Fix test

* Review Changes

* Merge changes

* Some sizing and elevation fixes

* Fix localization tests
2022-12-14 00:09:52 +00:00
Daniel Iglesia
0c7d84aa78
Add AppBar.forceMaterialTransparency (#101248) (#116867)
* Add AppBar.forceMaterialTransparency (#101248)

Allows gestures to reach widgets beneath the AppBar (when Scaffold.extendBodyBehindAppBar is true).
2022-12-14 09:45:50 +11:00
Michael Thomsen
f5249bcb0a
Remove use of NullThrownError (#116122) 2022-12-13 08:42:54 +01:00
LongCatIsLooong
04ee5926a2
Remove RenderEditable textPainter height hack (#113301)
* remove RenderEditable textPainter height hack

* Still applies the hack on web

* unskip web
2022-12-13 03:42:23 +00:00
Callum Moffat
97df2b3191
Fix scroll jump when NestedScrollPosition is inertia-cancelled. (#116689)
* Fix scroll jump when NestedScrollPosition is inertia-cancelled.

* Switch to using pointerScroll(0)
2022-12-13 00:20:30 +00:00
Jonah Williams
e331dcda17
[framework] make transform with filterQuality a rpb (#116792)
* [framework] make transform with filterQuality a rpb

* fix tests

* ++
2022-12-12 23:30:17 +00:00
Callum Moffat
601f48cd95
InteractiveViewer discrete trackpad panning (#112171)
* InteractiveViewer web trackpad panning

* Address feedback
2022-12-12 22:34:24 +00:00
Callum Moffat
8e1f8352bf
Fix MediaQuery.paddingOf (#116858)
* Fix MediaQuery.paddingOf

* Try to fix test overflow on web
2022-12-12 21:54:54 +00:00
Hans Muller
882e105a4c
Revert "Add Material 3 support for ListTile - Part 1 (#116194)" (#116908)
This reverts commit e57b7f4ea8ab8b348810d0a76f7bcf4aeabbe6d2.
2022-12-12 20:06:21 +00:00
Jonah Williams
d19047d8a1
[framework] make opacity widget create a repaint boundary (#116788) 2022-12-12 18:40:13 +00:00
Michael Goderbauer
5a229e2827
Add LookupBoundary to Overlay (#116741)
* Add LookupBoundary to Overlay

* fix analysis
2022-12-12 18:16:06 +00:00
Taha Tesser
a8c9f9c6f4
Fix NavigationBar ripple for non-default NavigationDestinationLabelBehavior (#116888) 2022-12-12 18:02:20 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. (#116061) 2022-12-11 22:43:22 +00:00
Ian Hickson
c02d53fc0e
More gracefully handle license loading failures (#87841) 2022-12-11 05:17:19 +00:00
Casey Hillers
7549925c8c
Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (#116839)
This reverts commit 352ad3a9efccc8c54deb72eb0d7164bfb42b2a49.
2022-12-11 02:23:40 +00:00
Callum Moffat
c4b8046d96
Floating cursor cleanup (#116746)
* Floating cursor cleanup

* Use TextSelection.fromPosition
2022-12-10 00:24:23 +00:00
Michael Goderbauer
9dd30878d9
Add LookupBoundary to Material (#116736) 2022-12-09 15:48:00 -08:00
Callum Moffat
73cb7c2fc5
Squashed MediaQuery InheritedModel (#114459) 2022-12-09 20:59:11 +00:00
Taha Tesser
e57b7f4ea8
Add Material 3 support for ListTile - Part 1 (#116194)
* Add Material 3 support for `ListTile` - Part 1

* minor refactor

* Add `useMaterial3: false` to M2 tests
2022-12-09 20:05:12 +00:00
hangyu
003608f182
Update text field input width when there are prefix/suffix icons (#116690)
* Update input_decorator_test.dart

Update input_decorator.dart

Update input_decorator.dart

Update input_decorator.dart

Update input_decorator.dart

Update input_decorator.dart

Revert "Update input_decorator.dart"

This reverts commit 6a6d2fd0c145c15440405060190ef714b78441c9.

Update input_decorator.dart

Update input_decorator_test.dart

Update input_decorator.dart

lint

* Update input_decorator.dart
2022-12-08 10:27:46 -08:00
ivirtex
ef40e3ea6f
Add CupertinoSliverNavigationBar large title magnification on over scroll (#110127)
* Add magnification of CupertinoSliverNavigationBar large title

* Fix padding in maximum scale computation

* Apply magnification by using RenderBox

* Do not pass key to the superclass constructor

* Use `clampDouble` instead of `clamp` extension method

* Remove trailing whitespaces to make linter happy

* Name test variables more precisely

* Move transform computation to `performLayout` and implement `hitTestChildren`

* Address comments

* Address comments

* Address comments

* Update comment about scale

* Fix hit-testing

* Fix hit-testing again

* Make linter happy

* Implement magnifying without using LayoutBuilder

* Remove trailing spaces

* Add hit-testing of the large title

* Remove whitespaces

* Fix scale computation and some tests

* Fix remaining tests

* Refactor and fix comments

* Update comments
2022-12-08 17:15:09 +00:00