This reverts commit a44f174efc218ac1b4b94b9d77dafdb5dfea1432.
Reason: start_up tests become flaky.
See https://github.com/flutter/flutter/issues/28374
TBR: xster
Merge on red to fix the tree
This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for `runApp` so developers can customize the warm up process.
This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).
The tradeoff the is the startup time (time to first frame). Our `flutter run --profile --trace-startup` seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.
This also adds a cubic_bezier benchmark to test the custom shader warm up process.
This should fix https://github.com/flutter/flutter/issues/813 (either by `defaultShaderWarmUp`, or a `customShaderWarmUp`).
* Add ability to set shadow color for chips and for chip themes
* Add selected shadow color as a property as well
* Update phrasing of documentation
* Address PR feedback
* Add outer try block for obtainKey errors. Add docs.
* change to // from ///, and do specific error handling
* Add return statement after error
* Add test
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.
I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.
This PR fixes these problems with examples:
1. Switching tabs in a snippet now works if there is more than one snippet in
a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
remove the contents of the supplied temp directory before running, since
having files that hang around is problematic (only a problem when running
locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
the samples thanks to dartfmt, but still).
Fixes#26398Fixes#27411
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
* Update stepper.dart
Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.
* Update stepper.dart
Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.
* Update stepper.dart
Ran through format to remove unwanted whitespace which Analysis isn't happy about.
* Update stepper.dart
Tried reformatting again.
* Update stepper.dart
Tried reformatting again.
* Update stepper.dart
Formatting again why do you hate me github editor.
* Update stepper.dart
* Update stepper.dart
if this format doesn't work i'll cry
* Update stepper_test.dart
Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`
* Update stepper_test.dart
Added const constructors
* Update stepper_test.dart
trying to get rid of whitespace again
* Update stepper_test.dart
* Update stepper_test.dart
why whitespace why
* Update stepper_test.dart
* Update stepper_test.dart
* Update stepper_test.dart
* Update stepper_test.dart
Swapped to `findsNothing` because I'm an idiot.
* Update stepper_test.dart
* Update stepper.dart
