Ojan Vafai
b9f182a6bd
Stop rendering text inside flex boxes.
...
Text can only only inside paragraphs and inlines. This patch makes it
so we stop putting such text nodes in the render tree at all if their
parent is not a paragraph or an inline.
This is the final step in making it so that we don't create anonymous
renderers, which fixes a crash in the new custom layout code.
R=eseidel@chromium.org
Review URL: https://codereview.chromium.org/1077473002
2015-04-09 11:40:03 -07:00
Adam Barth
f2d2e80e59
Merge the Sky Engine changes from the SkyDart branch
...
This CL flips the switch to make Sky use Dart.
TBR=eseidel@chromium.org
BUG=454613
Review URL: https://codereview.chromium.org/922893002
2015-02-12 15:06:03 -08:00
Matt Perry
7f17e0b4b9
Unrevert "Sky: When an iframe element is removed, delete its mojo View."
...
This reverts commit acec66c735d6a40d3da3e0e9a6ee5f278bdfe043.
Scott thinks he fixed the crash.
BUG=434555
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/740383002
2014-11-20 11:13:16 -05:00
Matt Perry
2a60db84ea
Revert "Sky: When an iframe element is removed, delete its mojo View."
...
This reverts commit 45991a3752e6a6298901eba36e7bf4cdec4d263c.
It was causing flaky crashes on the bots.
TBR=esprehn@chromium.org
BUG=434555
Review URL: https://codereview.chromium.org/740773002
2014-11-19 15:13:28 -05:00
Matt Perry
14ec13d9c0
Sky: When an iframe element is removed, delete its mojo View.
...
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/733063007
2014-11-18 14:00:05 -05:00
Matt Perry
d091d0474c
Sky: Change iframe positioning to use absoluteContentBox for the View's
...
coordinate system.
This fixes a bug where the iframe's view would be positioned incorrectly if there were elements above it.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/730253002
2014-11-17 17:38:27 -05:00
Matt Perry
5907fa183a
Sky: Add a test for the <iframe> element.
...
Had to disable a DCHECK for now. Scott will investigate why the DCHECK is hit.
BUG=432658
R=sky@chromium.org
Review URL: https://codereview.chromium.org/722713003
2014-11-12 16:50:34 -05:00
Matt Perry
88d5783746
Remove iframe.sky test. It's timing out on the bots.
...
TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/707283002
2014-11-07 17:25:17 -05:00
Matt Perry
72037425fd
Add iframe.sky test expectations for dump-as-render-tree.
...
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/708163002
2014-11-07 17:14:15 -05:00
Matt Perry
694cabc454
Initial work on a new <view> element backed by a mojo::View.
...
This CL introduces an HTMLViewElement which, when inserted into a document,
causes a mojo::View to be created and navigated to the provided URL. No
compositing is done, but the view manager handles the rendering (as I
understand it).
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/708903002
2014-11-07 14:34:07 -05:00
