2695 Commits

Author SHA1 Message Date
chunhtai
70f21de9de
reland always adds alert label for alert dialog in Android (#66057) 2020-09-17 16:17:05 -07:00
godofredoc
8cb09cf44b
Enable pre/post submit hostonly tests. (#65985) 2020-09-17 15:32:09 -07:00
Jonah Williams
b1d17c914d
Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (#66043)
We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional.

Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter
2020-09-17 15:18:31 -07:00
Jenn Magder
c61c8f303b
Check that header exists instead of content (#65961) 2020-09-17 15:17:31 -07:00
Ben Konyi
fb08acf10c
Roll packages to fix #66038 (#66052)
PR #65873 enabled DDS for non-web Flutter applications. This change
surfaced a bug where DDS would not send ServiceRegistered events to VM
service clients when they subscribed to the Service stream. This would
cause tools and tests that rely on these events (e.g., hot reload in
VSCode) to fail.

Fixes #66038.
2020-09-17 12:28:49 -07:00
Ben Konyi
a17b330980
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#65873)
This reverts commit 66b01c1f2905f6b4f845f7283abe3e458351fe2e.

* Add DDS ipv6 support

* Use --dds-port for DDS instead of hijacking --host-vmservice-port
2020-09-16 16:27:42 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Yuqian Li
82e459fcf3
Mark nonflaky tests as such (#65898) 2020-09-16 14:12:05 -07:00
Hans Muller
3e6384b4f1
Updated references to obsolete Material button classes in microbenchmarks (#65950) 2020-09-16 14:10:51 -07:00
George Wright
bb2ab8838a
[manual roll] Roll Engine from 1ef10b240e28 to f84e7a019663 (12 revisions) (#65949) 2020-09-16 11:22:02 -07:00
Hans Muller
82706d730b
Updated references to obsolete Material button classes in benchmarks/macrobenchmarks (#65900) 2020-09-16 07:57:04 -07:00
godofredoc
24b2b55c20
Enable mac sdk tests and remove them from cirrus. (#65896) 2020-09-16 07:52:04 -07:00
Ming Lyu (CareF)
b3f19a3e1a
migrate animated_placeholder_perf (#64478) 2020-09-16 07:47:03 -07:00
Tong Mu
a48e14308e
Expose GestureBinding.handlePointerEvent, replacing dispatchEvent as the preferred way to dispatch events (#64846) 2020-09-15 22:17:06 -07:00
Greg Spencer
199a7c1964
Fix the character field of the RawKeyEvent to hold correct data on non-Android platforms. (#65667)
This fixes a problem where the character field of the RawKeyEvent was not being set at all for non-Android platforms.

I also updated the key maps, and corrected a problem with the Windows key map where the backquote character wasn't correctly mapped.
2020-09-15 13:02:16 -07:00
Yuqian Li
b8a39c15f8
Collect memory metrics (#65798) 2020-09-15 12:47:05 -07:00
Jenn Magder
7e27b140f0
Avoid thinning frameworks in iOS extensions (#65198) 2020-09-15 11:10:25 -07:00
Jonah Williams
b88f308af7
[flutter_tools] port deprecated settings test to flutter integration shard (#65806)
Port the deprecated settings devicelab test to tool integration shard. Tests that apps can be built using the deprecated android/settings.gradle file.

Part of #65790
2020-09-15 10:55:07 -07:00
Hans Muller
0e4cca4f69
Updated references to obsolete Material button classes in benchmarks/test_apps/stocks (#65799) 2020-09-14 19:22:06 -07:00
Jonah Williams
4e20f00053
[ci] remove create offline tests (#65791)
Currently these tests are taking CI time without providing any value, because there is no verification that network connectivity is avoided. This is better covered by a unit test that verifies that --offline is passed to pub.
2020-09-14 17:54:59 -07:00
Jenn Magder
7e41425d4a
Match benchmark iOS project bundle identifiers (#65793) 2020-09-14 14:31:56 -07:00
Greg Spencer
94592acb71
Creates a way to test private APIs in the Flutter package. (#65505) 2020-09-13 15:52:03 -07:00
Ming Lyu (CareF)
51f1c98490
migrate cubic_bezier_perf to e2e (#64487) 2020-09-11 20:02:03 -07:00
Tong Mu
87617e4cc3
New benchmark: bench_mouse_region_mixed_grid_hover (#63808)
* Adds a new web benchmark bench_mouse_region_mixed_grid_hover
2020-09-11 18:05:15 -07:00
Yuqian Li
e1eddb401d
Revert the revert (#65602) 2020-09-11 16:20:03 -07:00
godofredoc
53f9653e6b
Add mac builders to try configurations. (#65578) 2020-09-10 20:20:04 -07:00
Ben Konyi
577de1c44e
Roll forward package:test to 1.16.0-nullsafety.4 to prepare for (#65571) 2020-09-10 15:55:03 -07:00
xster
65ae30c8cc
Update create templates to 1.0.0 (#65234) 2020-09-10 12:57:56 -07:00
godofredoc
f246a8ce8b
Add mac builder in prod. (#65566) 2020-09-10 12:50:10 -07:00
Chris Yang
ad5370e43c
mark as flaky (#65577) 2020-09-10 12:48:00 -07:00
godofredoc
9e315985d0
Remove mac prod builder. (#65481)
This is in preparation to enable the new mac builders.

Bug:
  https://github.com/flutter/flutter/issues/65223
2020-09-09 09:47:46 -07:00
Tong Wu
abeaf11829
[devicelab] Remove ~/.gradle after each devicelab task run (#65434) 2020-09-09 01:50:03 -07:00
Yuqian Li
46d1aba2e2
Remove flutter_gallery_ios32__transition_perf test (#65415) 2020-09-08 15:55:12 -07:00
Jonah Williams
29898812d4
[framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267)
Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.

One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.

This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.

This PR does not adjust:

kTouchSlop used in scroll_physics.dart's minFlingDistance
kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
2020-09-08 15:53:36 -07:00
Ian Hickson
e10bdbbd9d
Fix RangeMaintainingScrollPhysics (#65135) 2020-09-07 11:40:03 -07:00
Jim Graham
9f4d4a5c59
re-enable the post_backdrop_filter test with CPU/GPU measurements (#65201) 2020-09-04 18:00:02 -07:00
Yuqian Li
d7d1461f75
Increase simple animation delay and duration (#64002)
Previously, the CPU/GPU measurement using gauge happened after the
driver test is done. Now, the measurement happens within the driver
test. So we need to properly increase the delay and duration to get a
comparable reading as the old gauge measurements.
2020-09-03 13:25:19 -07:00
Yuqian Li
1135002b0f
Mark nonflaky tests as such (#65054)
Those 2 tests have been green for the last 10 runs
2020-09-03 12:46:24 -07:00
Shi-Hao Hong
b80b432555
Move gen_l10n into flutter_tools (#65025) 2020-09-03 09:26:58 -07:00
Jenn Magder
ace54425e0
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 18:47:56 -07:00
Jenn Magder
259deec221
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#65138)" (#65141)
This reverts commit 5e0aa8b9fc423a2e05d47fba0cfe1ef3f47cb303.
2020-09-02 18:31:45 -07:00
Jenn Magder
5e0aa8b9fc
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 17:57:43 -07:00
gaaclarke
37de94d7d2
devicelab: started averaging startup time for ios test (#64978) 2020-09-02 16:35:03 -07:00
Jenn Magder
2e67bf2e32
Require xcode_backend.sh arguments (introduced in Flutter v0.0.7) (#65124) 2020-09-02 16:33:26 -07:00
Jenn Magder
cb819504f3
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#64988)" (#65109)
This reverts commit 4fde217dea5b5404660a02ed4cc1d9071085098a.
2020-09-02 12:31:17 -07:00
Christopher Fujino
237c0ab424
Delete catalog generator android/ios tests (#64977) 2020-09-02 11:25:04 -07:00
Yuqian Li
484f3f2646
Add FrameTiming delay to watchPerformance (#64780) 2020-09-02 11:15:08 -07:00
Pedro Massango
7fdd9218b0
Proposal: deprecate autovalidate parameter of the Form, FormField and TextFormField widget (#61648) 2020-09-02 11:15:05 -07:00
Jenn Magder
4fde217dea
Add observatory Bonjour service to built iOS Info.plist bundle (#64988) 2020-09-02 11:11:07 -07:00
Dan Field
a8281e31af
Mark large_image_changer tests as not flaky (#65033)
They appear to be passing now.
2020-09-01 10:57:59 -07:00