Instead, this PR copies the frontend server from the Dart SDK (whether prebuilt or not) into the location expected by internal engine tests and artifact construction. This PR also consolidates the three GN templates that invoked the frontend server down to one.
Framework presubs: https://github.com/flutter/flutter/pull/135836
Related: https://github.com/flutter/flutter/issues/60007
The change
https://dart-review.googlesource.com/c/sdk/+/323000 added a dependency on dart2wasm to the frontend_server package.
Flutter engine has all dependencies in its source checkout, and paths to their locations hardcoded in the dependency_ovedrrides of flutter_frontend_server's pubspec.yaml.
Add the dart2wasm package location to pubspec.yaml. Add the transitive dependency wasm_builder package lcoation to pubspec.yaml.
Update: Blocked on https://github.com/flutter/engine/pull/44912 landing,
and merging into google3.
---
Partial work towards https://github.com/flutter/flutter/issues/112498.
_**tl;dr**: In Impeller's backend we intend to _always_ dither
gradients, and never allow any changes long-term (i.e., write your own
shader if you want different behavior) with the assumption that dithered
gradients look better most of the time, and don't typically hurt
elsewhere._
Note that, at the time of this writing, I couldn't find a single case of
this being set explicitly to `true` inside Google, and there are between
[100 and 200 publicly accessible on
GitHub](https://github.com/search?q=%22Paint.enableDithering%22+language%3ADart&type=code&l=Dart),
of which virtually all are setting it explicitly to `true`.
There are some (valid) concerns this would cause a lot of golden-file
image diffs, so I'm going to seek explicit approval from the Google
testing team as well as someone from the framework team before landing
this commit.
The CL in [0] added package:ffi as dependency to package:compiler. Since
flutter_frontend_server needs all dependencies as path dependencies, we
need to add package:ffi there via path.
[0] https://dart-review.googlesource.com/c/sdk/+/269640
* update for the latest Dart SDK roll
* Update DEPS
update the dart revision to 204b67e5a029de64899154068cf1099b4f7db1f1
* Update license hash
Co-authored-by: Alexander Aprelev <aam@google.com>
The charcode package has been removed from the Dart SDK source
checkout, and the Flutter engine packages that list it in
their pubspecs do not depend on it directly or indirectly.
Remove it from their pubspecs, so they do not break when
the package disappears from the engine source checkout.
Bug: https://dart-review.googlesource.com/c/sdk/+/247500
* Roll dart sdk to 1bdb83bddf96c41cc046810c697a2c80bfaaaf19
Changes since las troll:
```
1bdb83bddf9 Version 2.18.0-122.0.dev
6ebd2633cd7 Use `any` deps for all unpublished packages
09b7f36b2fa [vm, compiler] Support ShadowCallStack on Fuchsia RISC-V.
e1773c7ebc3 Bump boolean_selector to 1d3565e2651d16566bb556955b96ea75018cbd0c
ae727399f2e [pkg/meta] prep for publishing package:meta 1.8.0
7b578ca6166 Add experimental flag `inference-update-2`.
5729605e183 [dart2wasm] Implement `FunctionType` Type.
c6d5cd043b8 [js_util] Add `dartify` and some helpers.
2b8429252e9 Issue 49031. Read files during applyPendingFileChanges(), so getFile() uses new content.
36acc59dcbb [analyser] support code completion for `errors` and `enable-experiment`
dd298c1ca36 Use a wrapper object for allResults in AnalysisDriver tests.
eb458cf46a9 [build] Fix false detection of compressed pointers as cross builds.
bbd7e5a4d9f Fix bad sdk-path error message
b36f4518bf9 Bump webkit_inspection_protocol to e4965778e2837adc62354eec3a19123402997897
```
* Update license hash
* Roll dart sdk to 7b24ff4d92e2d2136020fc5bedadfe7025861510
Changes since last roll:
```
7b24ff4d92e Version 2.18.0-111.0.dev
37eff8b8bcd Revert "[vm, compiler] Let SIMD values become constants."
f8645091bdc Version 2.18.0-110.0.dev
07aeba22865 Add implementations for LibraryAugmentationElementImpl and friends.
292e92be2d9 Move more completion override tests to run on both protocols.
1e04fe1fd05 Reland "Sync packages from shelf mono repo"
9f149e9f5db Bump pool to c40cc32eabecb9d60f1045d1403108d968805f9a
f5af2d9e776 Use ParameterMember when substituting function types.
e593b865b23 Prepare to publish analyzer_plugin 0.10.0
bcc7bda3d8e [analysis_server] Sort fields, enum members and base types consistently
bdacbb8decb [vm, compiler] Let SIMD values become constants.
862a2c6caf8 Roll zlib to pick up more 1.2.12 fixes
6ac1718994c Make typeParameterDeclaration implement TypeDeclaration
1cdc606ab3d [vm, compiler] Include the global object pool in AOT's --disassemble.
885d7843a73 [vm, compiler] Shorter LoadImmediate sequences for RV64.
8f3284098cd Declare LibraryAugmentationElement and AugmentationImportElement.
a9804e3259d [analysis_server] Simplify types for LSP documentChanges
8188d2824a8 Bump pub to 51435efcd574b7bc18d47a5dd620cb9759dea8f8
c0c51c2279c [infra] Upgrade checked-in SDKs to 2.17.0
```
* Update license hash
* Add pkg:smith as a dependency for flutter_frontend_server.
This is needed to roll dart past b453c6bcba
* Update few more packages that depend on internal dart sdk expect package
* Roll dart to 2.15.0-18.0.dev
Changes since last roll:
```
d39206fb4e2 (tag: 2.15.0-18.0.dev) Version 2.15.0-18.0.dev
6e28f8bb404 [vm] Avoid reserved register error on newer compilers
d2bd43f43e6 [python3] Migrate PRESUBMIT.py files
79be5898b46 [co19] LibTests/typed_data tests skipped for dart2js
af6f6cf9826 (tag: 2.15.0-17.0.dev) Version 2.15.0-17.0.dev
f0f94705a49 In ScopeResolverVisitor, don't visit identifiers to the right of `.`.
6274633ea1b Merge ScopedVisitor with ScopeResolverVisitor classes.
80ec62a3fd2 (tag: 2.15.0-16.0.dev) Version 2.15.0-16.0.dev
fc4d4144fb0 (origin/base) Added js_util import to html_dart2js
d2855e703e2 [ CLI ] Default to printing CLI usage message instead of VM usage
af2ec43d447 [vm/compiler] Fix incorrect assertion in LoadOptimizer
3365b77ac2d use code from package:devtools_shared
16ff4aec0ea Revert "[vm] Hide internal implementation List types and expose them as List"
6465ee4ad8a analyze pkg/nnbd_migration on the bots
cd6fb671034 [vm] Clean up changes around internal-only class ids.
7ac9c46977b [dart2js_info] Fix tests after migration.
1f405bf163c [VM/Runtime] Added a Dart VM initialization state to prevent racy access to VM state from Dart API calls.
824bec596f5 [vm] Hide internal implementation List types and expose them as List
```
This change removes uses of toString transformer from Flutter engine. The transformer is already wired up in Dart SDK: front-end server from Dart SDK supports --delete-tostring-package-uri option. After this change only the integration test is left in the Flutter engine to make sure dart:ui is properly transformed.
dart-lang/sdk#46022
This change prepares Flutter front-end server to the migration of --delete-tostring-package-uri option to Dart SDK. This is needed to call toString transformation before tree shaking.
dart-lang/sdk#46022
