4917 Commits

Author SHA1 Message Date
Jason Simmons
3c3ddb0a37 Remove unused GrContext in AndroidSurfaceGL (flutter/engine#7258) 2018-12-19 15:06:58 -08:00
skia-flutter-autoroll
f66774427d Roll src/third_party/skia 8d23a584fc43..ce9a901a76eb (10 commits) (flutter/engine#7259)
https://skia.googlesource.com/skia.git/+log/8d23a584fc43..ce9a901a76eb


Created with:
  gclient setdep -r src/third_party/skia@ce9a901a76eb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 17:24:44 -05:00
Stanislav Baranov
c85ef14c19 Update dynamic patching terminilogy to match that of the flutter tool (flutter/engine#7248) 2018-12-19 10:31:54 -08:00
skia-flutter-autoroll
e7d872fea7 Roll src/third_party/skia 1a237195b527..8d23a584fc43 (8 commits) (flutter/engine#7255)
https://skia.googlesource.com/skia.git/+log/1a237195b527..8d23a584fc43


Created with:
  gclient setdep -r src/third_party/skia@8d23a584fc43

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 13:31:02 -05:00
Dan Field
e12c087f9e Fix javadoc for Android-28 (flutter/engine#7254)
* Fix javadoc for Android-28

* build javadoc as part of pre-submit
2018-12-19 09:24:02 -08:00
skia-flutter-autoroll
ee6078eead Roll src/third_party/skia 192d66440910..1a237195b527 (1 commits) (flutter/engine#7253)
https://skia.googlesource.com/skia.git/+log/192d66440910..1a237195b527


Created with:
  gclient setdep -r src/third_party/skia@1a237195b527

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 08:29:05 -05:00
skia-flutter-autoroll
73800db30d Roll src/third_party/skia b933285ebb4e..192d66440910 (3 commits) (flutter/engine#7252)
https://skia.googlesource.com/skia.git/+log/b933285ebb4e..192d66440910


Created with:
  gclient setdep -r src/third_party/skia@192d66440910

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-19 03:05:23 -05:00
Chris Bracken
50f04cdc63 Fix a misspelling (flutter/engine#7234)
Change funciton to function in a doc comment.
2018-12-18 20:08:46 -08:00
Chris Bracken
548657787a Extract function to collect licenses for component (flutter/engine#7250)
Extracts _collectLicensesForComponent() from main, which collects the
licenses for the specified component (e.g. flutter, third_party, skia).

This is pre-factoring related to a fix for flutter/flutter#25519.
2018-12-18 20:08:15 -08:00
skia-flutter-autoroll
9268e50483 Roll src/third_party/skia 67761eb35f97..b933285ebb4e (1 commits) (flutter/engine#7251)
https://skia.googlesource.com/skia.git/+log/67761eb35f97..b933285ebb4e


Created with:
  gclient setdep -r src/third_party/skia@b933285ebb4e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 22:56:43 -05:00
Dan Field
5a59304379 Roll buildroot to support Android SDK 28 (flutter/engine#7245)
* Roll to buildroot and support Android SDK 28

* Ubuntu 16 for android build test
2018-12-18 19:38:28 -08:00
skia-flutter-autoroll
d4e13a25c4 Roll src/third_party/skia 4b75254560d4..67761eb35f97 (6 commits) (flutter/engine#7249)
https://skia.googlesource.com/skia.git/+log/4b75254560d4..67761eb35f97


Created with:
  gclient setdep -r src/third_party/skia@67761eb35f97

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 18:40:26 -05:00
skia-flutter-autoroll
17a114e8c2 Roll src/third_party/skia e6f635476da3..4b75254560d4 (61 commits) (flutter/engine#7247)
https://skia.googlesource.com/skia.git/+log/e6f635476da3..4b75254560d4


Created with:
  gclient setdep -r src/third_party/skia@4b75254560d4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-18 16:07:27 -05:00
Jason Simmons
9eae3293a3 Update iOS unit test for the removal of hex string encoding of uint64 data (flutter/engine#7246) 2018-12-18 11:16:38 -08:00
liyuqian
3f5e53a4c7 Compute cull_rect and optimize in Layer::Preroll (flutter/engine#6923)
This PR replaces the unused `PrerollContext::child_paint_bounds` with `PrerollContext::cull_rect` so we can prune unnecessary preroll tasks (especially cache) based on clips. This PR fixes https://github.com/flutter/flutter/issues/24712

Performance test has been added (https://github.com/flutter/flutter/pull/25381) to make sure that we won't regress again in the future.

Note that the cull_rect here is very similar to those removed in https://github.com/flutter/engine/pull/6352 .     We can't compute cull rects in SceneBuilder because of retained layers. But we can still compute and use them to optimize performance in Preroll.
2018-12-18 09:54:52 -08:00
Todd Volkert
70a7f91e86 Fix linter errors in ResourceUpdater (flutter/engine#7240) 2018-12-18 07:40:57 -08:00
Chris Bracken
0435cdb920 Revert spelling correction in licence matcher (flutter/engine#7242)
In 0e73c0f16da78665b8786e0eb559da11b787ae11 (#7179), the word
'publically' was altered to 'publicly', causing the licence aggregator
to fail to match the licence text included in many BoringSSL source
files.

The original licence includes several misspellings (e.g. 'rouines'
rather than 'routines') which we need to faithfully reproduce in our
match regex.

The failure this triggered went unnoticed during pre-/post-submit
due to the fact that the contents of the third_party directory didn't
change, so hash of the list of files used as a signature matched the
signature in the golden file, causing the run to be skipped.
2018-12-17 18:57:04 -08:00
Todd Volkert
cf3c281533 Allow inferred types using diamond syntax (flutter/engine#7237) 2018-12-17 16:35:10 -08:00
Todd Volkert
2d383262d7 Simplify nested try-with-resources statements (flutter/engine#7239) 2018-12-17 16:34:54 -08:00
Jason Simmons
1449f3af36 Fix destruction of the child object list in the iOS accessibility bridge (flutter/engine#7108)
Fixes https://github.com/flutter/flutter/issues/22206
2018-12-17 16:05:23 -08:00
Jason Simmons
5463140ef4 Simplify conversion of numeric types in the message codec on iOS (flutter/engine#7097)
Consistently handle Int32/Int64 types on both 32-bit and 64-bit versions
of iOS.  Drop usage of the obsolete hex string encoding for BigInt types.

Fixes https://github.com/flutter/flutter/issues/21313
2018-12-17 15:54:57 -08:00
Chris Bracken
fff4720f2c Verify RunConfiguration is valid before running (flutter/engine#6922)
In cases where a valid IsolateConfiguration cannot be inferred, (e.g.,
settings.kernel_list_asset is missing) RunConfiguration can be created
with a null IsolateConfiguration. In such cases, bail out early with
kInvalidSettings.

Also adds a redundant paranoid check to EmbedderEngine::Run.
2018-12-16 14:07:42 -08:00
Jimmy Casey
0e73c0f16d Correct spelling in doc comments (flutter/engine#7179)
Applies spelling corrections to accessibility-related doc comments and in the
license tool.
2018-12-16 12:51:00 -08:00
Chris Bracken
8a0cc94b1a Compile embedder unit test Dart to kernel (flutter/engine#7231)
As of the migration to Dart 2, it has been necessary to compile Dart to
kernel prior to execution. The embedder currently requires that the
resulting kernel file be named `kernel_blob.bin` and be located at the
root of the assets directory passed to the embedder API.

This patch updates the test_fixtures build rule to perform a kernel
compile using frontend_server, outputting `kernel_blob.bin` to
`fixtures/test_target_name` directory, and updates the embedder
unittests to specify the kernel file rather than the Dart source file.

Since the kernel compiler requires a `main()` function to be defined, it
also updates `simple_main.dart` from runtime_unittests to define
`main()` rather than `simple_main()`.

This also updates all existing sub-targets to be testonly.

This relands commit 4e4fb4608da95d198b0e796478462285ab974a3c, which was
reverted in commit 566db0ecb8f293bb9f7ff1fc39076b08336e0148. Rather than
running as prebuilt_dart_action, we use dart_action to ensure the
frontend snapshot it compatible with the VM on which it's executed.
2018-12-16 12:23:18 -08:00
skia-flutter-autoroll
1097bc02e1 Roll src/third_party/skia cb8157e6266c..e6f635476da3 (1 commits) (flutter/engine#7233)
https://skia.googlesource.com/skia.git/+log/cb8157e6266c..e6f635476da3


Created with:
  gclient setdep -r src/third_party/skia@e6f635476da3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-16 05:57:53 -05:00
skia-flutter-autoroll
30d881fa44 Roll src/third_party/skia 2e6db18c4309..cb8157e6266c (1 commits) (flutter/engine#7232)
https://skia.googlesource.com/skia.git/+log/2e6db18c4309..cb8157e6266c


Created with:
  gclient setdep -r src/third_party/skia@cb8157e6266c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-16 01:56:15 -05:00
Chris Bracken
566db0ecb8 Revert "Compile embedder unit test Dart to kernel (#7227)" (flutter/engine#7230)
This reverts commit 4e4fb4608da95d198b0e796478462285ab974a3c.

This broke dynamic release mode builds of
//flutter/runtime:runtime_fixtures_kernel (likely all product-mode
builds).
2018-12-15 14:43:26 -08:00
skia-flutter-autoroll
1ff3da8881 Roll src/third_party/skia 282ec5dc6ca7..2e6db18c4309 (1 commits) (flutter/engine#7228)
https://skia.googlesource.com/skia.git/+log/282ec5dc6ca7..2e6db18c4309


Created with:
  gclient setdep -r src/third_party/skia@2e6db18c4309

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-15 17:13:05 -05:00
Chris Bracken
4e4fb4608d Compile embedder unit test Dart to kernel (flutter/engine#7227)
Compile embedder unit test Dart to kernel

As of the migration to Dart 2, it has been necessary to compile Dart to
kernel prior to execution. The embedder currently requires that the
resulting kernel file be named `kernel_blob.bin` and be located at the
root of the assets directory passed to the embedder API.

This patch updates the test_fixtures build rule to perform a kernel
compile using frontend_server, outputting `kernel_blob.bin` to
`fixtures/test_target_name` directory, and updates the embedder
unittests to specify the kernel file rather than the Dart source file.

Since the kernel compiler requires a `main()` function to be defined, it
also updates `simple_main.dart` from runtime_unittests to define
`main()` rather than `simple_main()`.

This also updates all existing sub-targets to be testonly.
2018-12-15 13:59:58 -08:00
skia-flutter-autoroll
ba8ff96c34 Roll src/third_party/skia d4962e7e07c0..282ec5dc6ca7 (1 commits) (flutter/engine#7226)
https://skia.googlesource.com/skia.git/+log/d4962e7e07c0..282ec5dc6ca7


Created with:
  gclient setdep -r src/third_party/skia@282ec5dc6ca7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-15 13:21:32 -05:00
Ian Hickson
59f0587095 Undeprecated BigInteger support, but document what it actually does. (flutter/engine#6903) 2018-12-15 08:32:20 -08:00
Ian Hickson
ce62ca408f Offset.fromDirection and Size.aspectRatio (flutter/engine#6805) 2018-12-15 08:31:59 -08:00
skia-flutter-autoroll
8f9b7589ed Roll src/third_party/skia 8b78d70b9a10..d4962e7e07c0 (1 commits) (flutter/engine#7225)
https://skia.googlesource.com/skia.git/+log/8b78d70b9a10..d4962e7e07c0


Created with:
  gclient setdep -r src/third_party/skia@d4962e7e07c0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-15 05:24:07 -05:00
skia-flutter-autoroll
fdb527128f Roll src/third_party/skia a1bded9a4f28..8b78d70b9a10 (1 commits) (flutter/engine#7224)
https://skia.googlesource.com/skia.git/+log/a1bded9a4f28..8b78d70b9a10


Created with:
  gclient setdep -r src/third_party/skia@8b78d70b9a10

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-15 01:37:22 -05:00
skia-flutter-autoroll
893c9a0afd Roll src/third_party/skia 16d00eeef7d1..a1bded9a4f28 (2 commits) (flutter/engine#7223)
https://skia.googlesource.com/skia.git/+log/16d00eeef7d1..a1bded9a4f28


Created with:
  gclient setdep -r src/third_party/skia@a1bded9a4f28

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-14 21:23:01 -05:00
skia-flutter-autoroll
54b5bf84f2 Roll src/third_party/skia f391d0f771c6..16d00eeef7d1 (4 commits) (flutter/engine#7222)
https://skia.googlesource.com/skia.git/+log/f391d0f771c6..16d00eeef7d1


Created with:
  gclient setdep -r src/third_party/skia@16d00eeef7d1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-14 17:37:25 -05:00
Craig Stout
9be12e78ce [vulkan] Fix Fuchsia build
Stub out VulkanSwapchain.

Test:Fuchsia release *and* debug builds
2018-12-14 14:08:43 -08:00
skia-flutter-autoroll
fdff63b27d Roll src/third_party/skia f6206f91b3c1..f391d0f771c6 (4 commits) (flutter/engine#7220)
https://skia.googlesource.com/skia.git/+log/f6206f91b3c1..f391d0f771c6


Created with:
  gclient setdep -r src/third_party/skia@f391d0f771c6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-14 13:46:13 -05:00
Anthony Bullard
28d536a39a Support real fonts in 'flutter test' (flutter/engine#6913)
* Support real fonts in 'flutter test'

Change the order of font_managers to query in font_collection
so that dynamic_font_manager fonts will be resolved.

Tested with test case in `flutter/flutter` repo:

`packages/flutter/test/rendering/localized_fonts_test.dart`

Ensured:
- A font loaded with FontLoader will be used
- The default 'Ahem' font is still loaded by default

The test above still cannot be fixed because FontLoader and the
underlying mechanisms don't cover Locale-specific font loading
and therefore a CJK font-family won't be able to be loaded as needed
for that test.

Fixes #17700

* Format fixup
2018-12-14 10:05:41 -08:00
skia-flutter-autoroll
10c1075394 Roll src/third_party/skia 59c9f1595ecd..f6206f91b3c1 (1 commits) (flutter/engine#7219)
https://skia.googlesource.com/skia.git/+log/59c9f1595ecd..f6206f91b3c1


Created with:
  gclient setdep -r src/third_party/skia@f6206f91b3c1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-14 09:47:00 -05:00
skia-flutter-autoroll
97f479f4ed Roll src/third_party/skia 42e7a7ed6511..59c9f1595ecd (3 commits) (flutter/engine#7218)
https://skia.googlesource.com/skia.git/+log/42e7a7ed6511..59c9f1595ecd


Created with:
  gclient setdep -r src/third_party/skia@59c9f1595ecd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-14 03:04:13 -05:00
skia-flutter-autoroll
f7644ff93a Roll src/third_party/skia 21a7be0741ac..42e7a7ed6511 (1 commits) (flutter/engine#7217)
https://skia.googlesource.com/skia.git/+log/21a7be0741ac..42e7a7ed6511


Created with:
  gclient setdep -r src/third_party/skia@42e7a7ed6511

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-13 23:05:49 -05:00
jslavitz
0abb1665f5 Adds force cursor support (flutter/engine#6945)
* engine force cursor support
2018-12-13 18:45:38 -08:00
skia-flutter-autoroll
880010c54d Roll src/third_party/skia cb6b4bde0c2e..21a7be0741ac (3 commits) (flutter/engine#7216)
https://skia.googlesource.com/skia.git/+log/cb6b4bde0c2e..21a7be0741ac


Created with:
  gclient setdep -r src/third_party/skia@21a7be0741ac

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-13 19:17:56 -05:00
Chris Bracken
23db336526 [Fuchsia] Depend on libtrace when that is what's really meant (flutter/engine#7214)
libtrace-provider has libtrace listed as a dependency when really it
does not have any such dependency. This lets trace clients use
libtrace-provider as a dependency when what they really mean is libtrace.

This errant dependency in trace-provider is being fixed, which
means we need to fix these clients.
2018-12-13 13:13:38 -08:00
skia-flutter-autoroll
19ca929f14 Roll src/third_party/skia f9e824b8e749..cb6b4bde0c2e (7 commits) (flutter/engine#7215)
https://skia.googlesource.com/skia.git/+log/f9e824b8e749..cb6b4bde0c2e


Created with:
  gclient setdep -r src/third_party/skia@cb6b4bde0c2e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-13 15:36:23 -05:00
Gary Qian
34ea3f7a7f Fallback font match caching to fix emoji lag. (flutter/engine#7208) 2018-12-13 10:39:09 -08:00
Stanislav Baranov
255b2e2f89 Downloading and installation of dynamic updates on Android (flutter/engine#7207) 2018-12-13 10:17:37 -08:00
skia-flutter-autoroll
d60b5d973e Roll src/third_party/skia 5eb29448dfbd..f9e824b8e749 (10 commits) (flutter/engine#7212)
https://skia.googlesource.com/skia.git/+log/5eb29448dfbd..f9e824b8e749


Created with:
  gclient setdep -r src/third_party/skia@f9e824b8e749

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-13 11:46:05 -05:00
skia-flutter-autoroll
af9fb317ee Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211)
https://skia.googlesource.com/skia.git/+log/a69b10312977..5eb29448dfbd


Created with:
  gclient setdep -r src/third_party/skia@5eb29448dfbd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-12-13 07:51:56 -05:00