DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,433 Commits 882 Branches 1,069 Tags
Commit Graph

24587 Commits

Author SHA1 Message Date
skia-flutter-autoroll
3a12ca33cd Roll Skia from 065f0d2302ca to b3360479118f (4 revisions) (flutter/engine#47510) 
https://skia.googlesource.com/skia.git/+log/065f0d2302ca..b3360479118f

2023-10-31 sharaks@google.com Merge 11 release notes into RELEASE_NOTES.md
2023-10-31 kjlubick@google.com Check for success in WebPPictureInit calls
2023-10-31 sharaks@google.com Update Skia milestone to 121
2023-10-31 michaelludwig@google.com Add epsilon tolerance to QuadContainsRect

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 16:39:36 +00:00
skia-flutter-autoroll
d82fa93ef9 Roll Skia from 40223641388b to 065f0d2302ca (2 revisions) (flutter/engine#47509) 
https://skia.googlesource.com/skia.git/+log/40223641388b..065f0d2302ca

2023-10-31 kjlubick@google.com Fix tests with empty default font
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6f7cb42b9111 to a55ce4970dfd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 15:45:04 +00:00
skia-flutter-autoroll
26464eb973 Roll Skia from 817fca468240 to 40223641388b (19 revisions) (flutter/engine#47507) 
https://skia.googlesource.com/skia.git/+log/817fca468240..40223641388b

2023-10-31 kjlubick@google.com [canvaskit] Add shim for old function name
2023-10-31 lehoangquyen@chromium.org GraphiteDawn: use dynamic offsets for uniform buffers.
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e334b7a22bdd to 9700973b4f9a (5 revisions)
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 95fe7e470418 to 8e8b4dc940dc (12 revisions)
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 61b4a8b2976d to ff59f0a147f2
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5454137fb7d to 61b4a8b2976d (5 revisions)
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d9ec9befba05 to 5c95af798ba4 (1 revision)
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 52564ab1a0e3 to 1f568ab4ba16 (18 revisions)
2023-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c01d0bc50536 to 29ce1bdfaccc (1 revision)
2023-10-31 mike@reedtribe.org Add drawing downsampler
2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fa50717f8c06 to c01d0bc50536 (3 revisions)
2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1a99a795c229 to e334b7a22bdd (7 revisions)
2023-10-30 egdaniel@google.com Move Android Image and Surface factories out of default GPU build.
2023-10-30 herb@google.com Guard against null tops and bottoms
2023-10-30 kjlubick@google.com Remove empty typeface define for now
2023-10-30 kjlubick@google.com Expose SkTypeface::MakeEmpty
2023-10-30 jvanverth@google.com Revert "[graphite] Simplify vertex processing for PerEdgeAAQuadRenderStep."
2023-10-30 kjlubick@google.com Make default typeface return empty
2023-10-30 kjlubick@google.com [canvaskit] Get rid of dependency on default fontmgr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 14:48:11 +00:00
skia-flutter-autoroll
cc2becf0dd Roll Dart SDK from 2a80a8adf898 to 776fad25647a (1 revision) (flutter/engine#47505) 
https://dart.googlesource.com/sdk.git/+log/2a80a8adf898..776fad25647a

2023-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-81.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 13:40:58 +00:00
skia-flutter-autoroll
b8023fd169 Roll Fuchsia Linux SDK from 0D7msIyC3p_BdEY03... to LCfhx_lTRJI51G0zc... (flutter/engine#47503) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 11:49:05 +00:00
skia-flutter-autoroll
96c9fba0c0 Roll Dart SDK from c8f75afabaf1 to 9cc76cb23b8c (1 revision) (flutter/engine#47498) 
https://dart.googlesource.com/sdk.git/+log/c8f75afabaf1..9cc76cb23b8c

2023-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-31 01:38:20 +00:00
Chris Bracken
6fbf2e7123 [macOS] Wrap external texture tests in autorelease pool (flutter/engine#47492) 
Wraps all FlutterExternalTexture tests in an autorelease pool to ensure resources are cleaned up between tests.

Prior to this change, running these tests via:

    ../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
        --gtest_filter='FlutterEmbedderExternalTextureUnittests.*'

Resuling in a segfault:

    [ERROR:flutter/shell/platform/darwin/graphics/FlutterDarwinContextMetalSkia.mm(35)]
    Could not create Metal command queue.
    zsh: segmentation fault
    ../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-30 23:47:18 +00:00
skia-flutter-autoroll
2be61e33b3 Roll Dart SDK from 85e149f894df to c8f75afabaf1 (1 revision) (flutter/engine#47479) 
https://dart.googlesource.com/sdk.git/+log/85e149f894df..c8f75afabaf1

2023-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-78.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 21:02:43 +00:00
Matan Lurey
52d45d8af1 [Impeller] Switch from glBlitFramebuffer to implicit MSAA resolution. (flutter/engine#47282) 
Closes https://github.com/flutter/flutter/issues/137093.

This widens supports from Open GLES 3.x to Open GLES 2.x, and uses [ARM
GPU Best
Practices](https://developer.arm.com/documentation/101897/0301/Fragment-shading/Multisampling-for-OpenGL-ES):

> Do not use `glBlitFramebuffer()` to implement a multisample resolve.

This PR:

- Removes usage of `glBlitFramebuffer`
- Adds the capability check, `SupportsImplicitResolvingMSAA`, which is
`false` outside of GLES
- Does not discard color attachments resolved by
`EXT_multisampled_render_to_texture` (done implicitly)

I spoke to @jonahwilliams about the changes to the HAL, who I believe
also talked to @bdero about it. The short explantation is that, with the
`EXT_multisampled_render_to_texture`, we can be more efficient by
letting GLES perform multisampled rendering for us (no per-sample data
is written out).

See also
https://registry.khronos.org/OpenGL/extensions/EXT/EXT_multisampled_render_to_texture.txt
for details.
 2023-10-30 12:28:04 -07:00
skia-flutter-autoroll
0307c66cbb Roll Dart SDK from 5a666e8d8259 to 85e149f894df (6 revisions) (flutter/engine#47470) 
https://dart.googlesource.com/sdk.git/+log/5a666e8d8259..85e149f894df

2023-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-77.0.dev
2023-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-76.0.dev
2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-75.0.dev
2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-74.0.dev
2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-73.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-72.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 12:11:44 -07:00
Daco Harkes
0ecf21bb19 [deps] Stop moving NDK folder inside Android SDK (flutter/engine#47454) 
One step in the direction of addressing

* https://github.com/flutter/flutter/issues/136666

I can't actually upload the packages: ` Instance registration failed: "user:dacoharkes@google.com" has no required WRITER role in prefix`. I have verified locally that the directory structure is as expected by preventing the tmp folder from being deleted and browsing inside it.

Old structure:

* `sdk/`
* `ndk/`

New structure

* `sdk/ndk/22.xxxx/`

This PR does not yet update any of the DEPS anywhere yet, so we will need to do that after uploading new packages.

Edit: new CIPD packages uploaded with: `~/flt/engine/src/flutter/tools/android_sdk$ ./create_cipd_packages.sh 33v6transitional2` (The script does now allow underscores in the tag.)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-30 19:07:05 +00:00
Jonah Williams
b4efc3450e Revert "[Impeller] remove image upload workarounds." (flutter/engine#47402) 
Reverts flutter/engine#47209

This actually did regress things, I benchmarked poorly!

see https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf

I did check https://developer.arm.com/documentation/101897/0301/CPU-overheads/Vulkan-CPU-memory-mapping and we're following the expected advice there. Without a much deeper investigation though we may not have any idea what to do
 2023-10-30 17:34:15 +00:00
skia-flutter-autoroll
aa1517890d Roll Skia from 89250a0bd6bb to 817fca468240 (3 revisions) (flutter/engine#47465) 
https://skia.googlesource.com/skia.git/+log/89250a0bd6bb..817fca468240

2023-10-30 kjlubick@google.com Deduplicate SkFontMgr_FCI onLegacyMakeTypeface
2023-10-30 davidben@google.com Don't apply pragma pack to SkOTTableName::Iterator
2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from a5580e2b5bcd to fa50717f8c06 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 16:55:13 +00:00
skia-flutter-autoroll
fccfecd719 Roll Skia from 006424658682 to 89250a0bd6bb (3 revisions) (flutter/engine#47463) 
https://skia.googlesource.com/skia.git/+log/006424658682..89250a0bd6bb

2023-10-30 jvanverth@google.com [graphite] Simplify vertex processing for PerEdgeAAQuadRenderStep.
2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b9465588c600 to 6f7cb42b9111
2023-10-30 nigeltao@google.com SkWuffsCodec: don't rely on SkStream::isAtEnd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 16:07:24 +00:00
Chinmay Garde
cd82ec8461 Migrate inja, sqlite, libtess2 to //flutter/third_party. (flutter/engine#47408) 
Part of https://github.com/flutter/flutter/issues/67373
 2023-10-30 16:00:38 +00:00
Zachary Anderson
67dc900feb Revert "Roll Dart SDK from 5a666e8d8259 to 38e8459ca2aa (4 revisions)" (flutter/engine#47459) 
Reverts flutter/engine#47426

Failing to roll to the framework
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/67482/overview
 2023-10-30 07:42:39 -07:00
skia-flutter-autoroll
f601c968b7 Roll Skia from 09818d8c9d3c to 006424658682 (1 revision) (flutter/engine#47458) 
https://skia.googlesource.com/skia.git/+log/09818d8c9d3c..006424658682

2023-10-30 egdaniel@google.com Reland "Fix checking of power of 2 for scratch buffer caching."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 14:33:10 +00:00
skia-flutter-autoroll
6b97ede670 Roll Skia from 6e9cd1b79105 to 09818d8c9d3c (1 revision) (flutter/engine#47456) 
https://skia.googlesource.com/skia.git/+log/6e9cd1b79105..09818d8c9d3c

2023-10-30 michaelludwig@google.com [skif] Use SkBitmapDevice::Create in Backend::makeDevice

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 13:49:34 +00:00
Kevin Lubick
6cf3dac92a Remove call to SkTypeface::MakeDefault (flutter/engine#47344) 
Skia plans to remove the default (global) SkFontMgr, which in turn,
requires the removal of a default typeface (e.g. the
typeface returned by `SkTypeface::MakeDefault` and when `nullptr` passed
in to the `SkFont` constructor).

See https://g-issues.skia.org/issues/305780908

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-30 07:48:30 -04:00
skia-flutter-autoroll
05465f99bf Roll Fuchsia Linux SDK from LbIVijDVwcB56_wgv... to zf2xLsbeoVrbnEDiH... (flutter/engine#47452) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 10:16:19 +00:00
skia-flutter-autoroll
e43c792622 Roll Skia from e45946f89a8b to c732ec7f5d74 (2 revisions) (flutter/engine#47448) 
https://skia.googlesource.com/skia.git/+log/e45946f89a8b..c732ec7f5d74

2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f5454137fb7d to 382c1d1c6042
2023-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac82f8a7da91 to f5454137fb7d (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-30 06:26:26 +00:00
skia-flutter-autoroll
14c0da8bc8 Roll Fuchsia Linux SDK from ESkamdoXWIwkdWdP-... to nreLekedxzmcdb3ww... (flutter/engine#47429) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-28 14:52:23 +00:00
skia-flutter-autoroll
c0bef146d0 Roll Dart SDK from 5a666e8d8259 to 38e8459ca2aa (4 revisions) (flutter/engine#47426) 
https://dart.googlesource.com/sdk.git/+log/5a666e8d8259..38e8459ca2aa

2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-75.0.dev
2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-74.0.dev
2023-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-73.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-72.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-28 09:29:23 +00:00
skia-flutter-autoroll
3d834a833e Roll Skia from 71449db76bef to 60f985e90c5d (2 revisions) (flutter/engine#47415) 
https://skia.googlesource.com/skia.git/+log/71449db76bef..60f985e90c5d

2023-10-28 mike@reedtribe.org Refactor SkMipmap::Build
2023-10-28 brianosman@google.com Implement gradient fixup for powerless hue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-28 03:09:02 +00:00
skia-flutter-autoroll
68e199f9ac Roll Skia from 64f13d5be3f7 to 71449db76bef (1 revision) (flutter/engine#47413) 
https://skia.googlesource.com/skia.git/+log/64f13d5be3f7..71449db76bef

2023-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from f1e5fc856f1b to a5580e2b5bcd (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-28 02:24:12 +00:00
Jim Graham
83db1b6e5f [Impeller] Rect getters (flutter/engine#47411) 
This is a precursor change that will allow us to migrate all of the Impeller sources off of accessing the `origin` and `size` fields in preparation for improving the implementation of `Rect`.

No code has been migrated to use the new fields yet, and so this code should be completely benign as is, but there will be a number of follow-on PRs that all share this PR as a pre-requisite and so it needs to be landed independently of any of the PRs that will modify code currently in use.
 2023-10-28 02:24:10 +00:00
Ricardo Amador
d4db18900a Add Android Emulator dependencies as "test_dependencies" to Android tests (flutter/engine#47384) 
# Description

Emulator dependencies were not getting picked up correctly when running the Recipes through engine_v2. The fix was to allow the context it runs through to be passed the version via the flutter_deps module. That change can be found here: https://flutter-review.googlesource.com/c/recipes/+/51869.

Do not land until above cl has been merged.

## Related Issue
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/137350

## Validation
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-28 00:05:23 +00:00
Mouad Debbar
57cc7e9136 [web] DomManager for each FlutterView (flutter/engine#47388) 
The PR may seem large, but the main changes are simple:

- Introduce a `DomManager` that aims to take over all DOM responsibilities from `FlutterViewEmbedder`.
- Update all references to `flutterViewEmbedder.*domElement*` to `domManager.*domElement*`.
- Describe the general DOM structure of a Flutter View in a doc comment.

Next steps (in future PRs):
- Move all DOM manipulation methods out of `FlutterViewEmbedder` into `DomManager`.
- Move DOM creation logic out of `FlutterViewEmbedder` into `DomManager`.
 2023-10-27 23:53:27 +00:00
skia-flutter-autoroll
a20662c91d Roll Skia from 77abd518ad4a to 64f13d5be3f7 (2 revisions) (flutter/engine#47406) 
https://skia.googlesource.com/skia.git/+log/77abd518ad4a..64f13d5be3f7

2023-10-27 michaelludwig@google.com [graphite] Implement drawCoverageMask, enable mask filters
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from fd22bd69eb33 to 0b52da754fe9 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 23:41:24 +00:00
gaaclarke
86d8689ce2 [Impeller] started scaling the gaussian blur sigma to match skia output (flutter/engine#47405) 
fixes https://github.com/flutter/flutter/issues/127770

This will help performance as well since our kernels will be smaller.
The justification for scaling the sigma is that we need to account in
the math the scaling down that we are doing of the input.

Here are the side-by-side comparisons with this math and skia, impeller
is always on the right:

## sigma 10

<img width="1395" alt="blur_10"
src="https://github.com/flutter/engine/assets/30870216/d534d71f-b35b-46aa-be79-8337172968a8">

## sigma 75

<img width="1398" alt="blur_75"
src="https://github.com/flutter/engine/assets/30870216/a8a77048-5212-470d-b537-a0aea98efce6">

## sigma 164 (sigma in bug)
<img width="1402" alt="blur_164"
src="https://github.com/flutter/engine/assets/30870216/cc620d02-4460-4cc8-9798-8dd21530eeed">

## sigma 400
<img width="1404" alt="blur_400"
src="https://github.com/flutter/engine/assets/30870216/653c1f1b-8156-4cff-bfcf-bf1ba737b386">

## sigma 1000
<img width="1395" alt="blur_1000"
src="https://github.com/flutter/engine/assets/30870216/c3456275-7876-4733-a27b-6022140c6a24">



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-27 16:39:29 -07:00
skia-flutter-autoroll
b403f8f1dc Roll Fuchsia Linux SDK from gPQSfYJVLOgXjxQce... to ESkamdoXWIwkdWdP-... (flutter/engine#47404) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 23:29:36 +00:00
Zachary Anderson
879275cda3 Remove //third_party/khronos (flutter/engine#47398) 
It was introduced for a Linux/GTK component in https://github.com/flutter/engine/pull/17634.  But it looks like that dependency was later removed.
 2023-10-27 22:11:12 +00:00
skia-flutter-autoroll
a2c31cd0f8 Roll Skia from ccc3518a67b5 to 77abd518ad4a (5 revisions) (flutter/engine#47399) 
https://skia.googlesource.com/skia.git/+log/ccc3518a67b5..77abd518ad4a

2023-10-27 brianosman@google.com Expand powerless hue gradient testing
2023-10-27 michaelludwig@google.com Fix auto-expanding layers when there are no filters
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 14b5f7ddbad3 to b9465588c600
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from ad6eaad9b866 to b842291db7bb
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 78f3bf93ca15 to b8b6ef8feccd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 21:48:59 +00:00
skia-flutter-autoroll
a07f243df6 Roll Dart SDK from 360370ff93b0 to 5a666e8d8259 (15 revisions) (flutter/engine#47392) 
https://dart.googlesource.com/sdk.git/+log/360370ff93b0..5a666e8d8259

2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-71.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-70.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-69.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-68.0.dev
2023-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-67.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-66.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 21:01:03 +00:00
Zachary Anderson
b7d61edc74 Move gtest-parallel to flutter/third_party (flutter/engine#47393) 
As part of eliminating the Flutter buildroot (https://github.com/flutter/flutter/issues/67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
 2023-10-27 20:47:37 +00:00
Zachary Anderson
59cc39e9bd Move flatbuffers to flutter/third_party (flutter/engine#47387) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 13:05:56 -07:00
skia-flutter-autoroll
c0a52aa663 Roll Skia from ba3e1db468d0 to ebb2a3d4699b (10 revisions) (flutter/engine#47390) 
https://skia.googlesource.com/skia.git/+log/ba3e1db468d0..ebb2a3d4699b

2023-10-27 brianosman@google.com Add position storage to SkColor4fXformer
2023-10-27 armansito@google.com [graphite] Reduce conditional compilation sites to query vello support
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 0d214ae84fb2 to 14b5f7ddbad3
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from bce95eb72596 to 54d970f7a773
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 243e5abc4daa to 78f3bf93ca15
2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from ead32575e5bc to ad6eaad9b866
2023-10-27 jvanverth@google.com [graphite] Switch to using CoreFoundation type rather than MtlHandle.
2023-10-27 nicolettep@google.com Remove Vulkan dynamic rendering and inline uniform extension checks
2023-10-27 nicolettep@google.com Add VK_NV_present_barrier to list of unsupported debug layer extensions
2023-10-27 michaelludwig@google.com [graphite] Generalize transform handling in CoverageMaskRenderStep

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 19:47:05 +00:00
gaaclarke
caa9f39916 Made FlutterTaskQueue visible for Swift. (flutter/engine#47348) 
fixes https://github.com/flutter/flutter/issues/118832

This makes the `FlutterTaskQueue` protocol visible, but keeps the
`dispatch:` selector private. Under the covers there are runtime checks
to make sure `dispatch:` is available since we can't have compile time
checks anymore.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-27 11:01:08 -07:00
Zachary Anderson
bcfec4bcfc Move shaderc to flutter/third_party (flutter/engine#47383) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 10:45:20 -07:00
Jonah Williams
4c9b181ee3 [Impeller] Add present wait latch. (flutter/engine#47311) 
It turns out the fixing https://github.com/flutter/engine/pull/47249 revealed further bugs: we were actually overwriting previous presents and dropping frames, which was what the forward progress error was hinting. Once this problem is fixed, we started hitting present timeouts or overdraw of swapchain images.

The fix for this is that we shouldn't even ask for a swapchain image until after we've called present, which actually wasn't tracked with anything.

The error:

```
A Dart VM Service on Pixel 6 Pro is available at: http://127.0.0.1:62491/_N4PSEPUtA0=/
The Flutter DevTools debugger and profiler on Pixel 6 Pro is available at: http://127.0.0.1:9102?uri=http://127.0.0.1:62491/_N4PSEPUtA0=/
W/OnBackInvokedCallback(19160): OnBackInvokedCallback is not enabled for the application.
W/OnBackInvokedCallback(19160): Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
W/vulkan  (19160): dequeueBuffer timed out: Function not implemented (-38)
E/flutter (19160): [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not acquire next swapchain image: Timeout
E/flutter (19160): [ERROR:flutter/shell/gpu/gpu_surface_vulkan_impeller.cc(64)] No surface available.
```
 2023-10-27 15:27:51 +00:00
Zachary Anderson
e1fc52e2b6 Move rapidjson to flutter/third_party (flutter/engine#47354) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-10-27 08:00:56 -07:00
Jason Simmons
e866800c0c [Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (flutter/engine#47364) 
The GLES MSAA implementation may need to call FramebufferTexture2DMultisampleEXT for the stencil attachment.

See https://github.com/flutter/flutter/issues/137252
 2023-10-27 14:44:58 +00:00
Jason Simmons
e40bd4d3dd [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362) 2023-10-27 14:37:29 +00:00
auto-submit[bot]
fa847e083e Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380) 
Reverts flutter/engine#47357
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:13:17 +00:00
skia-flutter-autoroll
f433c373d6 Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379) 
https://skia.googlesource.com/skia.git/+log/0122c0e18d26..fe9959acc5e0

2023-10-27 jvanverth@google.com [graphite] Add per-edge AA quad shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:05:32 +00:00
skia-flutter-autoroll
34f1b9cb0e Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 09:58:05 +00:00
skia-flutter-autoroll
24822888df Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370) 
https://skia.googlesource.com/skia.git/+log/fbdd7d97b26e..fe61b3467547

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 50a46e8932cc to ac82f8a7da91 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 05:26:23 +00:00
Jim Graham
cc929700b6 [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183) 
The new method allows a caller to ask for the coverage of the input pixels required to produce an output that spans a given area. This allows the code to clip a saveLayer that has an image filter applied to it.
 2023-10-27 01:16:23 +00:00
John McCutchan
632d65292d Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358) 
When we enter hybrid composition mode we 'pause' the default RenderSurface (implemented by SurfaceView or TextureView) and swap to an ImageReader based RenderSurface.

When we return from hybrid composition mode we recreate and re-initialize the real RenderSurface as if it was being used for the first time.

This broke Platform Views in an internal app b/306122497 because we would incorrectly tell the texture to attach when it was never detached.

This CL changes the protocol so that when we return from hybrid composition mode we only swap the RenderSurface and do not re-create it. This avoids doing a bunch of unnecessary work and fixes the logic error of re-attaching textures that were never detached.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-27 00:33:23 +00:00
skia-flutter-autoroll
9572116d73 Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 00:12:58 +00:00