338 Commits

Author SHA1 Message Date
Polina Cherkasova
3860498972
Fix performance regression. (#111615) 2022-09-14 17:11:12 -07:00
Kenzie Davisson
a34e6b0792
Create enum for service extensions in services library (#111412) 2022-09-12 15:22:28 -07:00
Polina Cherkasova
a3c3dc864c
Create class MemoryAllocations. (#110230) 2022-09-09 17:23:10 -07:00
Kenzie Davisson
8708493352
Create enum for scheduler service extension names so they can be accessed from tooling (#111222)
* Create enum for scheduler service extension names so they can be accessed from tooling

* fix two more strings
2022-09-09 08:54:36 -07:00
Kenzie Davisson
fe309e3415
Create service extension consts for rendering lib (#111149) 2022-09-07 17:54:54 -07:00
Kenzie Davisson
31709953b0
only include foundation changes (#111146) 2022-09-07 16:32:04 -07:00
Kenzie Davisson
c10164c4b2
Create consts for service extension names so they can be accessed from tooling (#110876) 2022-09-07 15:38:38 -07:00
Michael Goderbauer
2b9beda0d0
Reland "Keep dirty manipulations private to Element base class (#109401)" (#109562) 2022-08-15 19:59:13 +00:00
Greg Spencer
7887ca5bb5
Revert "Keep dirty manipulations private to Element base class (#109401)" (#109481)
Landing on red to green the build.
2022-08-12 18:28:24 -07:00
Michael Goderbauer
a624cb71b3
Keep dirty manipulations private to Element base class (#109401) 2022-08-12 12:54:03 -07:00
chunhtai
6225bea261
Can call ChangeNotifier.hasListeners after disposed (#108931) 2022-08-04 17:21:06 +00:00
Michael Goderbauer
ed0c8d77f8
Remove some outdated ignores from framework (#108915) 2022-08-03 22:42:06 +00:00
Michael Goderbauer
c7498f607b
Improve dumpSemanticsTree error when semantics are unavailable (#108574) 2022-07-29 22:37:06 +00:00
Vyacheslav Egorov
8130029374
Use persistent hash map to store _inheritedWidgets (#107068)
* Use persistent hash map to store _inheritedWidgets

Instead of using a HashMap and copying it down the tree
which leads to quadratic time and space complexity
use a persistent data structure which can amortize
the cost by sharing parts of the structure.

The data shows HAMT based PersistentHashMap to be
5-10x faster for building _inheritedWidgets and
considerably more space effecient (e.g. bringing
amount of memory allocated when constructing
_inheritedWidgets in a tree with 150 InheritedWidget
down to 70Kb from 970Kb).

PersistentHashMap is slower than HashMap for
access: 2-3x in relative terms, but in absolute
terms we are only talking about ~0.2ns slow down
per access and various app benchmarks we run have
have not revealed any significant regressions.
2022-07-19 21:45:26 -07:00
Daniel Chevalier
76f056ac6f
Improve pub root directory interface (#106567)
The pubRoot directory interface is being changed to promote adding and removing directories
2022-07-07 15:29:39 -04:00
Lasse R.H. Nielsen
94e318456e
Mark use of deprecated type. (#106282) 2022-06-22 22:13:05 +00:00
Lasse R.H. Nielsen
3f401a1930
Ignore uses of soon-to-be deprecated NullThrownError. (#105693) 2022-06-16 13:38:07 -07:00
Alexandre Ardhuin
0cdb3bf582
Export public API types from foundation/*.dart library. (#105648) 2022-06-09 11:53:11 -07:00
Alexandre Ardhuin
56c4e3cdd8
add some exports of public API in foundation/serialization.dart (#104231) 2022-06-08 13:33:12 -07:00
Greg Spencer
16b7348155
Switch debugAssertNotDisposed to be a static (#104772)
This reverts part of the change made in #103456 to expose a debug check for subclasses of ChangeNotifier to avoid code duplication. Instead of making debugAssertNotDisposed a public instance function, it is now a public static function. It makes it harder to call, slightly, but it means that everyone who implemented ChangeNotifier instead of extending it doesn't get broken.
2022-05-31 10:33:46 -07:00
Pierre-Louis
9cc72df781
Use curly_braces_in_flow_control_structures for foundation, gestures, painting, physics (#104610)
* Use `curly_braces_in_flow_control_structures` for `foundation`

* Use `curly_braces_in_flow_control_structures` for `gestures`

* Use `curly_braces_in_flow_control_structures` for `painting`

* Use `curly_braces_in_flow_control_structures` for `physics`

* fix comments

* remove trailing space

* fix TODO style
2022-05-25 19:55:22 +02:00
Michael Goderbauer
d5fbc3750e
Remove unused code from tests (#104550) 2022-05-25 09:38:09 -07:00
gaaclarke
64a0c19652
switched to a double variant of clamp to avoid boxing (#103559) 2022-05-18 13:26:08 -07:00
Kenzie Davisson
0d08756232
Register a service extension for profileUserWidgetBuilds (#101989) 2022-04-15 15:26:24 -07:00
Michael Goderbauer
51bcdb9407
super parameters for framework (#100905) 2022-04-13 22:38:40 -07:00
gaaclarke
38f360f91a
Increased WriteBuffers starting capacity to 64 bytes. (#101790) 2022-04-12 19:14:10 -07:00
jellynoone
3420b9c50e
Fix compute in unsound null safety debug mode (#100544) 2022-03-23 11:30:07 -07:00
Jonah Williams
32c021bd33
[framework] use Uint8List for SMC (#100582) 2022-03-22 15:00:13 -07:00
jellynoone
3c6b760e4c
Refractor compute (#99527) 2022-03-17 13:40:10 -07:00
Michael Goderbauer
7f2c1cd772
Use PlatformDispatcher.instance over window where possible (#99496) 2022-03-03 14:46:16 -08:00
Ian Hickson
fce2f93b75
Add a BindingBase.debugBindingType() method to enable asserts that want to verify that the binding isn't initialized (#98226) 2022-02-11 14:35:09 -08:00
chunhtai
5f3bee55ad
Allow remove listener on disposed change notifier (#97988) 2022-02-09 11:10:13 -08:00
Ian Hickson
5ddc00cc03
Use EnumName.name where possible. (#94496) 2021-12-03 16:39:04 -08:00
Kenzie (Schmoll) Davisson
8fa2a5e886
Add profileRenderObjectPaints and profileRenderObjectLayouts service extensions (#91822) 2021-10-14 15:05:36 -07:00
Kenzie (Schmoll) Davisson
43249469ee
Add service extensions to expose debug rendering toggles (#91499) 2021-10-08 12:52:22 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Darren Austin
a1cd3f45e0
Updated some skip test comments that were missed in the audit. (#88893) 2021-08-25 11:49:04 -07:00
Darren Austin
962f57f847
Updated skipped tests for foundation directory. (#87293) 2021-08-02 14:38:57 -07:00
Greg Spencer
738ce43d97
Randomize tests, exclude tests that fail with randomization. (#86793)
* Randomize tests, exclude tests that fail with randomization.

* Disable some more tool tests
2021-07-26 23:40:49 -07:00
Jason Simmons
2dc11a85ff
Close the exit port used by the compute isolate utility function (#86591) 2021-07-22 17:56:03 -07:00
Jonah Williams
7f26dbe0d4
[flutter] remove elevation checker (#86837) 2021-07-21 21:51:06 -07:00
Jeff Ward
841beff520
Support Float32Lists in StandardMessageCodec (#72613) (#83318) 2021-07-20 14:31:07 -07:00
Ahmed Ashour
a666925a02
Add newline at end of file (#86008) 2021-07-08 15:01:10 -07:00
Alexandre Ardhuin
80990c21e2
code formatting (#85783) 2021-07-07 23:06:05 -07:00
Viren Khatri
de36e51155
pass style argument to super of IntProperty (#85414) 2021-07-07 14:51:02 -07:00
Greg Spencer
6adea05276
Revert "Randomize Framework tests, opt out some tests that currently fail. (#85159)" (#85673)
This reverts commit b5f9612 because it is taking about 40% longer to run the tests, which is causing timeouts.
2021-06-30 19:38:09 -07:00
Greg Spencer
b5f9612cac
Randomize Framework tests, opt out some tests that currently fail. (#85159)
This turns on order shuffling for all tests that don't fail with it on, marking those tests that do fail with a tag so that they will be run without shuffling on.

To determine which tests fail with it on, I ran all the tests 100 times with different random shuffle seeds, and then also ran it with the date seeds from today until the end of July, and tagged all of the test suites (files) that fail, with a seed that caused them to fail.
2021-06-29 13:46:13 -07:00
Dan Field
025397ae3f
Release retained resources from layers/dispose pictures (#84740) 2021-06-25 12:01:03 -07:00