engine-flutter-autoroll
35aa07e4ea
Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) ( #170955 )
...
https://dart.googlesource.com/sdk.git/+log/a6a3d65e33d7..6325aeacaef4
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-259.0.dev
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 07:21:42 +00:00
engine-flutter-autoroll
549fa4e6fb
Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) ( #170953 )
...
https://dart.googlesource.com/sdk.git/+log/750eaa028445..a6a3d65e33d7
2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-257.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 02:05:41 +00:00
YU-KI Hidea
453d113161
Fix the Japanese IME problem on macOS reported in the following issue. ( #166291 )
...
flutter/engine#57286
Fixes https://github.com/flutter/flutter/issues/160935
2025-06-21 00:10:21 +00:00
engine-flutter-autoroll
7f3f08cff2
Roll Skia from 104460420c48 to 773188560221 (2 revisions) ( #170942 )
...
https://skia.googlesource.com/skia.git/+log/104460420c48..773188560221
2025-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 316ed08fbc9a to a875f13dac14 (8 revisions)
2025-06-20 thomsmit@google.com Fix SubSetting on Mali400
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 23:22:08 +00:00
engine-flutter-autoroll
cca7287639
Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) ( #170933 )
...
https://dart.googlesource.com/sdk.git/+log/a554bdd0a2cc..750eaa028445
2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-256.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 21:00:18 +00:00
engine-flutter-autoroll
67b3104f74
Roll Skia from f1e68950ea7b to b638003de37e (5 revisions) ( #170923 )
...
https://skia.googlesource.com/skia.git/+log/f1e68950ea7b..b638003de37e
2025-06-20 lukasza@chromium.org [rust png] More resilient
`fIncrementalDecodingState` checks.
2025-06-20 lukasza@chromium.org [rust png] Ignore `fcTL` chunk if there
is no `acTL` chunk.
2025-06-20 lukasza@chromium.org [rust png] Preserve M136 encoding
behavior despite `png` crate changes.
2025-06-20 jreck@google.com gn_to_bp.py tweaks for libdng_sdk dep and
libskia_skcms
2025-06-20 michaelludwig@google.com Revert "[graphite]
Context::insertRecording returns more status info on failure"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 17:46:39 +00:00
gaaclarke
374321614f
[licenses_cpp] jun17 ( #170845 )
...
We are still executing < 40s and I'm down to about 98 errors.
- cleaned up the output
- added include_filter flag to help debugging
- added a lot of instances to the data directory
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-20 17:04:17 +00:00
Camille Simon
c7362b4755
[Android] Add a way to request new Surfaces from SurfaceProducer and avoid SurfaceProducer returning invalid Surface ( #169899 )
...
> [!NOTE]
> For anyone reviewing this PR, see
https://github.com/flutter/packages/pull/9360 for how I'd use the
`getSurface(boolean forceNewSurface)` method.
> [!NOTE]
> For anyone coming across this PR post-landing, in the code review
process, I renamed `getSurface(boolean forceNewSurface)` to
`getForcedNewSurface()`.
### What this does
(1) Adds method `getSurface(boolean forceNewSurface)` to
`SurfaceProducer` that will force the creation of a new `Surface` when
`SurfaceProducer.getSurface()` is called.
(2) Fixes `SurfaceProducer` to avoid returning invalid `Surface`s when
`SurfaceProducer.getSurface()`/`getSurface(boolean forceNewSurface)` is
called.
### Why we should...
#### (1) Add `getSurface(boolean forceNewSurface)`
My motivation for adding this is directly tied to
https://github.com/flutter/flutter/issues/155294 . The
`camera_android_camerax` plugin supports a camera preview use case that
requires providing a `Surface` to in order to render the preview. It
does so via `SurfaceProducer`; we provide a `Surface` retrieved from
`SurfaceProducer.getSurface()` to the CameraX library to render a camera
preview, and when the camera preview is done, a callback that we provide
is called, reporting that `Surface` as used and that it now should be
released/invalidated (see
[`SurfaceRequest`](https://developer.android.com/reference/androidx/camera/core/SurfaceRequest ),
[`SurfaceRequest.Result`](https://developer.android.com/reference/androidx/camera/core/SurfaceRequest#provideSurface(android.view.Surface,java.util.concurrent.Executor,androidx.core.util.Consumer%3Candroidx.camera.core.SurfaceRequest.Result%3E) )).
However, the CameraX library [makes no
guarantees](https://developer.android.com/reference/androidx/camera/core/Preview.SurfaceProvider#onSurfaceRequested(androidx.camera.core.SurfaceRequest):~:text=The%20camera%20may%20repeatedly%20request%20surfaces%20throughout%20usage%20of%20a%20Preview%20use%20case%2C%20but%20only%20a%20single%20request%20will%20be%20active%20at%20a%20time .)
about when requests for new `Surface`s are made, so the following race
condition can happen:
1. CameraX requests a `Surface`
2. We provide `Surface` A from `SurfaceProducer.getSurface()`
3. The camera preview was paused; CameraX requests a new `Surface`
4. The camera preview is resumed
5. We provide `Surface` A from `SurfaceProducer.getSurface()` because it
is still technically valid
6. CameraX calls our callback and now `Surface` A is released/invalid
I believe `SurfaceProducer` currently has no way to handle the level of
complexity of `Surface` handling required for use cases like the
`camera_android_camerax` camera preview, where a `Surface` may be
invalidated between calls to `SurfaceProducer.getSurface()`. So,
`getSurface(boolean forceNewSurface)` can support these use cases.*
`getSurface(boolean forceNewSurface)` simply will force
`SurfaceProducer` to return a new `Surface` when
`SurfaceProducer.getSurface` is called versus potentially returning the
same `Surface` as the previous invocation.
For `camera_android_camerax`, see
https://github.com/flutter/packages/pull/9360 for an example of how it
would be used.
*I'd like to note that I also played around with creating new
`SurfaceProducer`s to solve the camera problem, which _was_ successful
and probably could be generally for that use case, but I think it's
cleaner to support this functionality from within the same
`SurfaceProducer` since we can 🤷♀️ It also helps avoid the user from
needing to create/manage multiple Flutter `Texture`s, from my
understanding.
#### (2) Fix `SurfaceProducer.getSurface()`/`getSurface(boolean
forceNewSurface)` to never return an invalid `Surface`s
I noticed that `SurfaceProducer.getSurface()`/`getSurface(boolean
forceNewSurface)` does not check for `Surface` validity before returning
them while I was working on (1). Honestly, this just feels right? We
should ensure that a `Surface` is valid and can be used before returning
it and potentially confusing the user.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-20 16:05:41 +00:00
engine-flutter-autoroll
9a8cbb88d0
Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) ( #170912 )
...
https://dart.googlesource.com/sdk.git/+log/cc2f604acb05..a554bdd0a2cc
2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-255.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 15:55:31 +00:00
engine-flutter-autoroll
3788c7a38b
Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) ( #170906 )
...
https://skia.googlesource.com/skia.git/+log/8a710de2a1d3..2fc58cffe69b
2025-06-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from d2f0baa84b48 to 825731c55823 (25 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 09:16:44 +00:00
engine-flutter-autoroll
c6ae3efa2a
Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) ( #170900 )
...
https://skia.googlesource.com/skia.git/+log/2ac2476b0bcb..8a710de2a1d3
2025-06-20 syoussefi@google.com [vulkan] Generate SPIR-V directly in
vector<uint32_t>
2025-06-20 syoussefi@google.com [graphite][vulkan] Make render pass
handling less special
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 07:02:26 +00:00
engine-flutter-autoroll
6d821e6681
Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) ( #170895 )
...
https://dart.googlesource.com/sdk.git/+log/6a4b11760906..cc2f604acb05
2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-254.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 03:51:10 +00:00
engine-flutter-autoroll
ff957e10a8
Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) ( #170890 )
...
https://skia.googlesource.com/skia.git/+log/61c89daa3888..2ac2476b0bcb
2025-06-19 syoussefi@google.com [vulkan] Use std::vector<uint32_t> for
SPIR-V
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 978144890e92 to 1c18b20944ca (14 revisions)
2025-06-19 michaelludwig@google.com Revert "[Fontations] Roll
Fontations"
2025-06-19 michaelludwig@google.com [graphite] Context::insertRecording
returns more status info on failure
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 22:10:36 +00:00
engine-flutter-autoroll
0970a6bedb
Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) ( #170884 )
...
https://dart.googlesource.com/sdk.git/+log/bce9abe03175..6a4b11760906
2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-253.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 19:44:12 +00:00
engine-flutter-autoroll
6cfdc63c91
Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) ( #170878 )
...
https://skia.googlesource.com/skia.git/+log/794936b23812..61c89daa3888
2025-06-19 mike@reedtribe.org Introducing SkPathRaw
2025-06-19 mike@reedtribe.org Use SkSpan in SkData
2025-06-19 syoussefi@google.com Manual bug id map to the new issue
tracker
2025-06-19 syoussefi@google.com [graphite][vulkan] Simplify render pass
creation
2025-06-19 mike@reedtribe.org Reapply "remove guard -- it is now in all
clients"
2025-06-19 drott@chromium.org [Fontations] Roll Fontations
2025-06-19 michaelludwig@google.com [graphite] Generate blurred rrect
profile on the GPU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 17:13:13 +00:00
engine-flutter-autoroll
85a9b4f389
Roll Skia from af242598f14d to 794936b23812 (2 revisions) ( #170875 )
...
https://skia.googlesource.com/skia.git/+log/af242598f14d..794936b23812
2025-06-19 syoussefi@google.com Replace bug ids with mapped ids in the
new issue tracker - v2
2025-06-19 syoussefi@google.com Reland "[vulkan] Add helpers for Skia to
enable Vulkan features"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 14:56:50 +00:00
gourabkumarsi
3143e7c00c
Drop support for 21/22 Lollipop ( #170748 )
...
Update Robolectric tests to run on minSdk 23. Some of the code are
modified/removed to support the same.
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-19 14:53:21 +00:00
engine-flutter-autoroll
2d383ad32e
Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) ( #170872 )
...
https://dart.googlesource.com/sdk.git/+log/6020126c10e8..bce9abe03175
2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-252.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 14:37:26 +00:00
engine-flutter-autoroll
44c6e065d7
Roll Skia from df97f7f407db to af242598f14d (4 revisions) ( #170867 )
...
https://skia.googlesource.com/skia.git/+log/df97f7f407db..af242598f14d
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 9e0008570681 to 5928133450bb (4 revisions)
2025-06-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 591e8cd0c6ad to 83f69a4f154f (19 revisions)
2025-06-19 syoussefi@google.com [graphite] Remove ShaderInfo::fRootNodes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 10:38:19 +00:00
engine-flutter-autoroll
a56ef5fa31
Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) ( #170864 )
...
https://skia.googlesource.com/skia.git/+log/1d8f7ebd23cc..df97f7f407db
2025-06-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ee0bcc111afe to 978144890e92 (1 revision)
2025-06-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from e3ddb182d581 to d2f0baa84b48 (17 revisions)
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 7b7b93aa0b85 to 47399fc146fa (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 08:28:33 +00:00
engine-flutter-autoroll
4953a988cd
Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) ( #170862 )
...
https://dart.googlesource.com/sdk.git/+log/4ab716b09e9d..6020126c10e8
2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-251.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 08:24:40 +00:00
engine-flutter-autoroll
40f4988e53
Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) ( #170857 )
...
https://skia.googlesource.com/skia.git/+log/291d41414fa7..1d8f7ebd23cc
2025-06-19 mike@reedtribe.org Revert "remove guard -- it is now in all
clients"
2025-06-18 nicolettep@google.com [graphite] Add skipColorXForm attribute
to PaintOption
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 03:41:25 +00:00
engine-flutter-autoroll
2bf0e0c683
Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) ( #170855 )
...
https://dart.googlesource.com/sdk.git/+log/b32559bca3cc..4ab716b09e9d
2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-250.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-249.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-248.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-247.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-246.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-245.0.dev
2025-06-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-244.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-243.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-242.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 02:55:07 +00:00
engine-flutter-autoroll
2e50924df5
Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) ( #170836 )
...
https://skia.googlesource.com/skia.git/+log/5f110d5f48a3..291d41414fa7
2025-06-18 michaelludwig@google.com Skip SkColorSpaceXform_* GPU tests
on protected configs
2025-06-18 nicolettep@google.com Update some files to use new SkMatrix
span APIs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-18 23:16:06 +00:00
Robert Ancell
d4ab90823e
Use a shared vertex buffer for rendering layers. ( #170717 )
...
Only generate the vertex buffer once, and use uniforms to translate and
scale it in the vertex shader.
We still need to generate the vertex for each view, which seems
unnecessary but it cannot be shared across contexts in OpenGL. This
should be tackled in a future change.
2025-06-18 23:14:11 +00:00
gaaclarke
db2832a644
fixes deeplinking in uiscenedelegate migrated projects ( #170452 )
...
fixes https://github.com/flutter/flutter/issues/170350
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-18 21:43:51 +00:00
Jonah Williams
0d333d7193
[Impeller] fix array uniforms on GLES backend. ( #170710 )
...
Fixes https://github.com/flutter/flutter/issues/170647
Correctly account for the size of array elements for runtime effect
shaders on the GLES backend.
2025-06-18 21:12:03 +00:00
Chinmay Garde
edc792e098
[Impeller] Update README to add section about custom embedders. ( #170077 )
...
Also cleans up out-of-date iOS/Android guidance.
Fixes https://github.com/flutter/flutter/issues/170074
2025-06-18 21:01:19 +00:00
Jason Simmons
37a6e5fbfb
Escape the forbidden strings in the regex used to check test command output ( #170702 )
...
The forbidden string might be something like "[ERROR" that contains
characters used in the regex syntax.
2025-06-18 20:49:59 +00:00
gaaclarke
556b20e7c3
License cpp jun16 ( #170716 )
...
The big additions here are:
1) Checking against the catalog of known licenses
1) Parsing of the known catalogs from disk
1) Nicer error messages
With this PR we are getting pretty close to feature parity. The big
changes left are updating the contents of of the data directory so we
match what we want. Execution across the directory is still around 35s.
Known extra work:
1) Propagate the `data` directory
1) Make sure the auditable output is looking as we want it
1) Make sure to treat the root directory different where we want to
enforce the presence of the file copyright
1) Remove hardcoded name "engine" for the root directory (that means
shifting all the integration tests to run in a `engine` directory.
1) Maybe cleanup the file format for the known licenses?
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-18 20:47:39 +00:00
Chinmay Garde
9c3a133e4f
Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. ( #170822 )
...
Evolution of a previous blocker
https://github.com/flutter/engine/pull/43091 .
Fixes b/423885648
2025-06-18 20:03:27 +00:00
engine-flutter-autoroll
ae285146ba
Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) ( #170821 )
...
https://skia.googlesource.com/skia.git/+log/297dbc32a6c7..5f110d5f48a3
2025-06-18 robertphillips@google.com [graphite] More Android-specific
PaintOptions
2025-06-18 michaelludwig@google.com Revert "[vulkan] Add helpers for
Skia to enable Vulkan features"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-18 19:19:54 +00:00
Tirth
9bfb92e6f8
Rename entryPointBaseUrl to entrypointBaseUrl ( #170166 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Closes #168968
Need to change here as well -
https://github.com/flutter/website/blob/main/src/content/platform-integration/web/initialization.md
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-18 17:48:04 +00:00
engine-flutter-autoroll
fac358d6fe
Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) ( #170809 )
...
https://skia.googlesource.com/skia.git/+log/1cb13a21b547..297dbc32a6c7
2025-06-18 michaelludwig@google.com [graphite] De-register gen ID
listeners added by ProxyCache
2025-06-18 syoussefi@google.com [vulkan] Add helpers for Skia to enable
Vulkan features
2025-06-18 ccameron@chromium.org HDR v2: Add SkColorSpaceXform raster,
graphite, and GLSL support
2025-06-18 mike@reedtribe.org remove guard -- it is now in all clients
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-18 16:58:13 +00:00
Derek Xu
b6d2b3552b
Add --profile-microtasks switch ( #170690 )
...
This PR adds a switch that can be used to set [the Dart VM's
`profile_microtasks`
flag](c48dd51b90/runtime/vm/microtask_mirror_queues.cc (L18-L23)
2025-06-18 14:13:32 +00:00
engine-flutter-autoroll
112f101328
Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) ( #170772 )
...
https://skia.googlesource.com/skia.git/+log/75af9450b121..ff7fffa5dac5
2025-06-17 thomsmit@google.com Remove adaptive epsilon for
GrTriangulator
2025-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 8d1a39bd39e4 to b72a76c990d9 (3 revisions)
2025-06-17 michaelludwig@google.com [graphite] Visit clip stack before
choosing renderer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com ,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-18 03:06:26 +00:00
gaaclarke
b1af493964
Started bridging the scene delegate to the lifecycle delegate for shortcuts ( #170180 )
...
testing: There integration tests in the plugins repo.
fixes: https://github.com/flutter/flutter/issues/169928
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-17 22:57:31 +00:00
Jonah Williams
85824038d0
[ui] npot display_list allocation. ( #170447 )
...
Split off of https://github.com/flutter/flutter/pull/168019/
Worst case allocation performance for dl is fairly bad as we end up
copying the data many more times than something like an STL vector
would. At the cost of more memory usage, we can improve the case where
the display list grows quite large.
2025-06-17 22:06:32 +00:00
engine-flutter-autoroll
eaad9f44e2
Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) ( #170746 )
...
https://dart.googlesource.com/sdk.git/+log/4fad61257b29..b32559bca3cc
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-241.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-240.0.dev
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-239.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-17 17:21:26 +00:00
engine-flutter-autoroll
22613b764d
Roll Dart SDK from 68d7e34bdabf to 4fad61257b29 (1 revision) ( #170725 )
...
https://dart.googlesource.com/sdk.git/+log/68d7e34bdabf..4fad61257b29
2025-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-238.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-17 06:38:37 +00:00
Robert Ancell
117c60edcf
Update Linux embedder to new semantics flags API ( #170497 )
...
As changed in https://github.com/flutter/flutter/pull/167738 .
2025-06-17 04:01:19 +00:00
engine-flutter-autoroll
3fee9b9814
Roll Skia from d4e426456e7d to 8879db3b3319 (10 revisions) ( #170722 )
...
https://skia.googlesource.com/skia.git/+log/d4e426456e7d..8879db3b3319
2025-06-17 lukasza@chromium.org [rust png] Allow
`startIncrementalDecode` to switch to another frame.
2025-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5f9183df4e99 to 3395378f6990 (7 revisions)
2025-06-16 robertphillips@google.com [graphite] Disable
PaintParamsKeyTest on Release, Dawn_GLES and Dawn_Vulkan
2025-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from fdff117046ce to 79ec8b3400ce (7 revisions)
2025-06-16 michaelludwig@google.com [graphite] Don't include AA outset
in bounds when visiting clip
2025-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 31cf85d685b9 to 8123122b08a7 (16 revisions)
2025-06-16 robertphillips@google.com [graphite] Add
DrawTypeFlags::kDropShadows
2025-06-16 robertphillips@google.com [graphite] Add new Android-specific
PaintOptions
2025-06-16 fmalita@google.com Revert "move pathops into a module"
2025-06-16 fmalita@google.com Revert "Build fixes after PathOps
relocation"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC danieldilan@google.com ,jsimmons@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-17 03:14:26 +00:00
engine-flutter-autoroll
b42c00bca8
Roll Dart SDK from e8fda1e72d64 to 68d7e34bdabf (1 revision) ( #170719 )
...
https://dart.googlesource.com/sdk.git/+log/e8fda1e72d64..68d7e34bdabf
2025-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-237.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-17 01:17:38 +00:00
gaaclarke
b0735bfa73
License cpp jun13 ( #170620 )
...
Still executing around 35s. It still doesn't match licenses against the
database. I don't expect that to add much time considering how we plan
to do it.
1) fixes the way c strings strip out comments
1) started handling LICENSE files more correctly
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-16 21:11:36 +00:00
Jackson Gardner
dbb105a74d
Reland lazy path and object arenas ( #170303 )
...
This PR is an attempt to reland
https://github.com/flutter/flutter/pull/168996
There were some issues that cropped up in the `web_long_running_test`
shards. However, it turns out that these tests don't actually run in
presubmit on any PR that has any engine changes, which is not ideal. I
modified the long running tests to run in presubmit, but this had issues
because apparently a big chunk of these integration tests actually are
trying to download canvaskit from CDN. I changed almost all of the tests
to use local canvaskit (which should make them more reliable and
hermetic). There is one test whose job is to actually test the CDN
itself, and I am leaving that disabled in presubmit for PRs that have
engine changes (since the engine artifacts won't be uploaded to CDN yet)
but the rest of them are all running and passing now.
Also, I fixed the underlying issue that was exposed by the long running
tests, which is that the CanvasKit path clipping stuff in the layer
visitor needs to be aware of LazyPath.
2025-06-16 18:31:10 +00:00
Jonah Williams
5100884018
[Impeller] Removal of MSAA for intermediate render targets used in filtering. ( #169692 )
...
When drawing a full screen filter effect in an intermediate render
target, MSAA doesn't provide any AA benefit as it only anti aliases the
edges of geometry.
2025-06-16 18:29:03 +00:00
engine-flutter-autoroll
82b799d5ec
Roll Fuchsia Linux SDK from qRgW6vhjBdWGGopHL... to XX8LxiX10yPg8EwED... ( #170659 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-16 16:22:40 +00:00
engine-flutter-autoroll
efeaa9a16e
Roll Skia from f8cd9fe75f21 to d4e426456e7d (4 revisions) ( #170669 )
...
https://skia.googlesource.com/skia.git/+log/f8cd9fe75f21..d4e426456e7d
2025-06-16 danieldilan@google.com Add end to end colorspace test
2025-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 222889ea0395 to 5f9183df4e99 (12 revisions)
2025-06-16 fmalita@google.com Build fixes after PathOps relocation
2025-06-16 robertphillips@google.com [graphite] Add AnalyticClip option
to Precompile
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC danieldilan@google.com ,jsimmons@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-16 16:22:39 +00:00
engine-flutter-autoroll
fb42702f65
Roll Dart SDK from ae721d7d5b51 to e8fda1e72d64 (1 revision) ( #170662 )
...
https://dart.googlesource.com/sdk.git/+log/ae721d7d5b51..e8fda1e72d64
2025-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-236.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-16 16:18:07 +00:00
engine-flutter-autoroll
e2e543dbd7
Roll Fuchsia Linux SDK from nUffQhlaVpp0P2Yl6... to qRgW6vhjBdWGGopHL... ( #170638 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-15 06:17:28 +00:00
