xster
8661d8aecd
Test text paint orders by color ( #27983 )
2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text ( #27970 )
2019-02-14 16:50:06 -08:00
xster
32b9c2f07e
Add more RenderEditable test coverage ( #27003 )
2019-02-05 00:54:54 -08:00
Matt Carroll
92125ed38f
Enable dependency injection of Window instead of using static property ( #27389 )
2019-02-04 16:46:04 -08:00
Michael Goderbauer
6d20ff2446
Remove all obsolete "// ignore:" ( #27271 )
2019-01-30 08:56:12 -08:00
Alexandre Ardhuin
ef276ffea5
format initializer list of constructors ( #27111 )
2019-01-29 21:47:16 +01:00
Konstantin Scheglov
4fe41abfcc
Add default values for optional parameters. ( #27197 )
2019-01-29 11:49:57 -08:00
jslavitz
d2a2a5cfe2
Adds a fade in and out, rounds corners, fixes offset and fixes height of cursor on iOS ( #24876 )
...
* Fixes cursor on iOS devices
2019-01-28 19:49:19 -08:00
Alexandre Ardhuin
66f424f0f8
fix some bad indentations ( #26921 )
...
* fix some bad indentations
* remove suspicious line
2019-01-23 15:43:27 +01:00
Michael Goderbauer
56039b4ba7
Make getOffsetToReveal work with nested Viewports ( #26663 )
...
Fixes #20893 , the most-upvoted bug for framework.
A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Michael Goderbauer
b4e9d0a440
Add tests for getOffsetToReveal on RenderSlivers ( #26598 )
2019-01-16 08:47:37 -08:00
matthew-carroll
517f8dc279
Add consumedScrollExtent to SliverConstraints as reported by Viewport ( #24551 )
2019-01-09 12:34:54 -08:00
Alexandre Ardhuin
868ff42821
fix doc-comment snippets ( #25579 )
2019-01-07 21:44:16 +01:00
Justin McCandless
9161ec42cb
Include cursor in textfield intrinsic width measurement ( #25055 )
...
* Include cursor in textfield intrinsic width measurement
* Add cursorWidth assertion, add comment about assumed cursor width, and test null stepWidth
2018-12-26 08:56:02 -08:00
Michael Goderbauer
59bfab157e
Reland "Call mark* methods before attaching child ( #25239 )" ( #25395 )
...
This reverts commit ea7d086e11e31d32fef1f6217566361f763c1429.
The revert did not fix the flakiness.
2018-12-15 13:29:54 -08:00
jslavitz
ad2e3eb3b5
Adds support for floating cursor ( #25384 )
...
* Adds support for floating cursor.
2018-12-14 15:17:33 -08:00
Michael Goderbauer
ea7d086e11
Revert "Call mark* methods before attaching child ( #25239 )" ( #25382 )
...
This reverts commit 5c1f1d7618e27a3ed5a97971edc95eff9d0ba967.
Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
2018-12-14 10:30:49 -08:00
Jonah Williams
4cd87705b7
Revert "Adds support for floating cursor ( #24761 )" ( #25352 )
...
This reverts commit 46878d848566769e51f21407de2fead528c1d2c4.
2018-12-13 20:36:08 -08:00
jslavitz
46878d8485
Adds support for floating cursor ( #24761 )
...
* Adds support for floating cursor!
2018-12-13 20:14:27 -08:00
Michael Goderbauer
5c1f1d7618
Call mark* methods before attaching child ( #25239 )
2018-12-12 16:45:51 -08:00
Michael Goderbauer
8d249c25ea
Fix semantics compiler for offstage children ( #24862 )
...
Fixes #20313 .
2018-12-10 08:58:14 -08:00
sjindel-google
db9fe3f827
Fix text field clipping when erasing rapidly. ( #23894 )
...
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.
This fixes #22288 and #14121
2018-11-04 03:20:44 +01:00
liyuqian
744b872f65
Add unit tests to mutate layer fields ( #23599 )
...
So we're sure that:
1. We won't break the API by not allowing to mutate fields
2. We won't forget to markNeedsAddToScene after mutation
2018-11-02 08:02:22 -07:00
liyuqian
883e2dc272
Maintain dirtiness and use retained engine layers ( #23434 )
...
For #21756
2018-10-25 14:17:12 -07:00
namanix
7aeb539da9
Added a filterQuality parameter to images. ( #23329 )
...
* Added a filterQuality parameter to images.
* Removed this break by accident.
* Modified the test case to check the filterQuality
* Update packages/flutter/lib/src/rendering/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/rendering/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/rendering/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/widgets/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/widgets/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/rendering/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Update packages/flutter/lib/src/rendering/image.dart
Co-Authored-By: namanix <namanix@gmail.com>
* Added documentation for the new parameter and corrected some space issue's
2018-10-20 20:47:10 -07:00
Stanislav Baranov
d5777b6a9a
Implement correct orthographic projection ( #22985 )
2018-10-18 11:27:02 -07:00
Alexandre Ardhuin
8b0de38ef8
fix upcoming lint avoid_returning_null_for_void ( #23190 )
2018-10-17 11:01:37 +02:00
Alexandre Ardhuin
0e76cb4c10
prefer_void_to_null in flutter_test ( #22847 )
...
* prefer_void_to_null in flutter_test
* fix CI
2018-10-11 18:00:46 +02:00
Alexandre Ardhuin
2ea1d81cdc
sort_constructors_first ( #22575 )
2018-10-04 07:28:07 +02:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases ( #21680 )
2018-09-14 21:06:19 +02:00
Jonah Williams
23499f4004
Fix typo in MediaQuery.fromWindow and add invertColors flag to images for smart invert. ( #21457 )
2018-09-12 14:50:49 -07:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
jslavitz
9dce4b8259
Shortcuts ( #21558 )
...
* added shortcuts and delete functionality
* added first test
* afew chnages
* a few changes
* hope this works
* small change
* small changes
* fixed nits
* final changes:
* fixed initializing formals
* update comment
* minor change:
* added line
* final changes
* random change
* changed function to void
* one more
* removed line
* dis betta work
* final change
* actual final chnge
2018-09-10 13:47:04 -07:00
Jonah Williams
11943ce7e7
Revert "Shortcuts ( #21083 )" ( #21556 )
...
This reverts commit 6e7f3e6f5a11341edd5c2519cbe1c7bc178cb8e9.
2018-09-07 10:36:52 -07:00
jslavitz
6e7f3e6f5a
Shortcuts ( #21083 )
...
* added shortcuts and delete functionality
* added first test
* afew chnages
* a few changes
* hope this works
* small change
* small changes
* fixed nits
* final changes:
* fixed initializing formals
* update comment
* minor change:
* added line
* final changes
2018-09-07 10:28:35 -07:00
Jacob Richman
a2acc6a3e5
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )" ( #21395 )" ( #21448 )
...
This reverts commit 5b5a5b82286923f52225320f5e9fc9f558838c05.
2018-09-07 10:02:05 -07:00
Ben Konyi
de9f775fc0
Fixed missing implementations of toString() in two tests ( #21509 )
2018-09-07 09:48:33 -07:00
Jonah Williams
908de76c17
Remove value listener from semantics bindings ( #21296 )
2018-09-07 09:24:08 -07:00
Alexandre Ardhuin
976cffa24d
lint unnecessary_new on samples ( #21539 )
...
* lint unnecessary_new on samples
* fix tests
2018-09-07 11:00:05 +02:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )" ( #21395 )
...
This reverts commit 3306fc10421cfbad8f772d23c02aca27c7ca1d76.
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )
...
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.
Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 ( #21181 )
2018-08-29 16:48:23 -07:00
Jonah Williams
e235ccd76f
Support disabled animations ( #20354 )
2018-08-23 11:50:04 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax ( #20837 )
...
Fixes the pattern for some TODOs to match our style guide.
(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links ( #20772 )
...
* Fixes resulting from audit of issues links
I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
* Update run_test.dart
skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
Ian Hickson
686d8f8a22
Shim package:test to avoid matcher issues ( #20602 )
...
* Upgrade everything except matcher.
* Roll matcher (and test)
* Adjust tests that depend on flutter:test directly to depend on a shim
* Require use of package:test shim and remove other references to package:test
2018-08-14 20:33:58 -07:00
Ian Hickson
21f22ed3ba
Visibility widget ( #20365 )
...
* Visibility widget
This attempts to address the confusion around how to hide a widget subtree.
* Apply review comments
* More clarifications
2018-08-09 18:23:36 -07:00
liyuqian
13bfa7353e
Set default clipBehavior to Clip.none and update tests ( #20205 )
...
This fixes https://github.com/flutter/flutter/issues/18057
2018-08-09 16:38:08 -07:00
liyuqian
9ffa1c5174
Add Clip enum to Material and related widgets ( #18576 )
...
See details in our proposal for this breaking API change and #18057 . This PR setup all code paths to allow the change but doesn't change the clip behavior by itself. We'll change `defaultClipBehavior` from `Clip.antiAlias` to `Clip.none` in the following PR to change the clip behavior and update tests.
2018-08-03 09:56:23 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const ( #20103 )
2018-08-02 12:02:32 +02:00