* Update stepper.dart
Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.
* Update stepper.dart
Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.
* Update stepper.dart
Ran through format to remove unwanted whitespace which Analysis isn't happy about.
* Update stepper.dart
Tried reformatting again.
* Update stepper.dart
Tried reformatting again.
* Update stepper.dart
Formatting again why do you hate me github editor.
* Update stepper.dart
* Update stepper.dart
if this format doesn't work i'll cry
* Update stepper_test.dart
Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`
* Update stepper_test.dart
Added const constructors
* Update stepper_test.dart
trying to get rid of whitespace again
* Update stepper_test.dart
* Update stepper_test.dart
why whitespace why
* Update stepper_test.dart
* Update stepper_test.dart
* Update stepper_test.dart
* Update stepper_test.dart
Swapped to `findsNothing` because I'm an idiot.
* Update stepper_test.dart
* Update stepper.dart
* Provide a simmplified API for skipping over slider thumb, overlay, and tick mark painting
* doc fixes
* comments
* comments
* comments
* comments
* comments
* analyzer
* comments
This PR does two things:
- It allows BottomAppBar to have a custom shape even when it doesn't
have a notch.
- It adds AutomaticNotchedShape, an adapter from ShapeBorder to
NotchedShape.
* Crash when a TabBar is put in a BottomAppBar.
* Tabs bugs (e.g. crash on transparent material)
- Tabs would crash when placed on transparent Materials
- Tabs would fail to render the child if an icon was specified
In certain situations, a developer may require the border of a Material to be painted behind its child. For example a Card widget that has a full width image across the top half. In that scenario, the image should ideally be painted above the border with regards to z-position.
This change exposes a flag on Material widget to achieve this behavior. Additionally, the same flag is exposed on Card widget to allow the Card widget to pass this down to its Material.
I added a couple golden tests to verify this new behavior. Goldens are here:
46a3d26acb
This change creates an `AppBarTheme` to be used with `AppBar` widgets. This allows for users to theme their AppBars separately from their overall Theme if they choose.
There's no reason to disallow this as TextStyle can handle lerping between null parameters just fine. This change also adds tests to ensure the correct behavior
* [FAB] Adding FAB as class in tests.
* [Material] FAB theme tests corrected. Also deeper into Material for elevation testing.
* [Material] Comment clarification.
* [Material] TODO formatting.
* [Material] Formatting.
* [Material] Comment correction.
* [Material] Updated values.
* [Material] Removing comment, low-level check, and adding safety.
* Add more animation tests for rotation
* Test animation progress
* Progress on the tests
* Everything 'works'
* We don't need to guarantee the rotation of the fab as it exits.
* Remove print statement
* Cleanup extra lines
* Remove whitespace
* Include caret gaps in position calculation to avoid descender cutoff
* Calculate caret offset instead of exposing it
* Test that textfields scroll vertically by full line height
* Only add offset to end of caret to avoid going above 0.0
* Fix and test horizontal vs. vertical scrolling
* CR: docs and top caret offset logic
* Take max instead of assuming caretRect.top is always a full line down
* Always subtract caretOffset from caretTop since caretRect.top can be negative
Previously, a disabled floating action button always had zero
elevation, which looks dumb.
This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.
This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
* Allow a widget to be specified for the textfield count, and allow no count at all
* Test all possible states for counter and counterText
* Docs for counter
* counter is a function that generates a widget
* Tests use counter as function
* Fix analyze error in docs
* InputDecoration has counter widget, TextField has buildCounter function
* InputDecorator tests expect counter to be widget again and include
buildCounter
* counter widget example that might actually fit
* Clarify accessiblity concerns in docs
* Include isFocused param for accessibility
* Fix analyze error
* Improve docs per code review
* Rearrange getEffectiveDecoration a bit for clarity
* Fix analyze error about hashValues params
* Clean up docs and redundant code per code review
* Code review doc improvement
* Automatically wrap buildCounter widget in a Semantics widget for accessibility
