5734 Commits

Author SHA1 Message Date
Ali EP
307848953f Fixes crossAxisSpacing overflow in RTL (#27945) 2019-02-20 15:43:01 -08:00
Sander Kersten
d1136e3109 Fix issue where SliverPersistentHeader that is both floating and pinned would scroll down when scrolling past the beginning of the ScrollView (#27433) 2019-02-20 15:42:15 -08:00
Michael Goderbauer
655800260a
Add TextOverflow.visible (#28182) 2019-02-20 15:40:25 -08:00
xster
e100ddfe26
Rename SuperellipseShare ContinuousRectangleBorder (#28183) 2019-02-20 15:35:22 -08:00
xster
39b1ff1aa3
revert 26001 (#28032) 2019-02-20 15:34:44 -08:00
Kaushik Iska
9931a275b9
Add outer try block for obtainKey errors. Add docs. (#27953)
* Add outer try block for obtainKey errors. Add docs.

* change to // from ///, and do specific error handling

* Add return statement after error

* Add test
2019-02-20 15:31:07 -08:00
Michael Goderbauer
fbafe64fd7
Fix 'to to' (#28216) 2019-02-20 09:57:42 -08:00
Dan Field
dd23be3936
Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
Hans Muller
19f79ac8da
Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00
Jonah Williams
c8c67b79c3
remove accidentally commited libs (#28011) 2019-02-15 11:59:23 -08:00
jslavitz
07fdfb70d3
Fixes switch vibration (#27900)
* Fixes Cupertino switch vibration
2019-02-15 10:55:06 -08:00
Gary Qian
29618f0b04
Roll engine for flutter/engine#7791 - Add trailing whitespace tracking. 2019-02-15 10:28:21 -08:00
Kate Lovett
70dfe01a15
Sample code for Icon class (#27968)
* Added sample code for a simple Icon, ref: #21136

* Removed duplicate line.

* Fixed incoreect parameter.

* Update icon.dart

Removed empty prose and added better context for sample code. Changed sample code for better visibility in execution of default app themes.

* Alas, Trailing space.

Nixed trailing space in comments.
2019-02-15 10:24:14 -08:00
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Todd Volkert
3b47b44348
Re-apply "Ensure all curves return 0 and 1 in .transform(t) when t=0/1" (#28006)
Re-applies #27409 by reverting #27919

The analyzer issue (dart-lang/sdk#35940) has been temporarily
worked around by virtue of #27929
2019-02-15 12:29:09 -05:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
Martin Kustermann
7862bef13a
Use double literals where a double type is expected (#27929)
This makes the code more consistent but also fixes our flutter-analyze bot.

Issue https://github.com/dart-lang/sdk/issues/35940
2019-02-15 14:10:55 +01:00
Jonah Williams
9bc5656637
Wire dart2js through flutter tool, add compilation test (#27668) 2019-02-14 22:42:30 -08:00
xster
8661d8aecd
Test text paint orders by color (#27983) 2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00
Anthony
d1371cd269 Do not draw Slider tick marks if they are too dense (#27969) 2019-02-14 16:42:30 -08:00
Michael Goderbauer
d1707ab0ad
Revert "Fix overflow clipping/fading for text (#27892)" (#27966)
This reverts commit 46cabdab22ce59ba06949d666216ae4d10b76761.
2019-02-14 15:15:01 -08:00
Todd Volkert
4309fe863a
Revert "Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409)" (#27919)
This reverts commit d8cd2ff484c7799db0a7ed01f1a448dba14e6cec.
2019-02-14 02:20:35 -05:00
Todd Volkert
f1a8eed083
Revert "Clean up matters related to "offstageness". (#27425)" (#27915)
This reverts commit 1d93e924b7a1b4611de74537eba4f2bf25a4d0cf.
2019-02-13 20:58:41 -05:00
Tim Traversy
2cbd050f92 Adding horizontal and vertical scale parameter to ScaleUpdateDetails. (#27752) 2019-02-13 15:51:22 -08:00
Ian Hickson
1d93e924b7
Clean up matters related to "offstageness". (#27425)
In particular, make debugVisitOnstageChildren only work in debug mode, and add documentation.
2019-02-13 15:36:47 -08:00
Marco Scannadinari
d8cd2ff484 Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409) 2019-02-13 15:17:42 -08:00
Michael Goderbauer
46cabdab22
Fix overflow clipping/fading for text (#27892) 2019-02-13 13:49:00 -08:00
Tim Traversy
f372eb37e6 DatePicker noon/midnight overflow fix (#27773) 2019-02-13 13:03:12 -08:00
jslavitz
1196dbe94a
Fixes a cursor offset mistake for Material on iOS (#27851)
* Fixes offset and unblocks roll
2019-02-13 12:25:25 -08:00
Greg Spencer
ef9c059ef2
Hook up character events and unmodified code points to Android raw key event handling. (#27853)
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
2019-02-12 19:40:19 -08:00
xster
8d0346a0ec
Handle back swipe completed->completed or completed->dismissed transitions (#27866) 2019-02-12 18:50:06 -08:00
Jonah Williams
7cc694e5d5
Track InheritedElement dependencies in diagnostic properties (#27387) 2019-02-12 18:37:51 -08:00
Michael Goderbauer
aa8f86135d
Fix crash when disposing nested Scrollables while holding in overscroll position (#27864) 2019-02-12 18:00:35 -08:00
Raouf Rahiche
964fab0205 fix small typo (#27659)
just a small typo 
the word "the constraints" is duplicated
2019-02-12 15:54:50 -08:00
xster
892c8919c7
Add long-press-drag cursor move support on iOS (#26001) 2019-02-12 15:10:48 -08:00
Gary Qian
e44fc1356f
Temporarily disable inconsistent golden tests due to test fonts (#27861) 2019-02-12 15:02:45 -08:00
Jake Gough
dfce0a7f0b Added 'physics' prop to Stepper. (#26297)
* Update stepper.dart

Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.

* Update stepper.dart

Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.

* Update stepper.dart

Ran through format to remove unwanted whitespace which Analysis isn't happy about.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Formatting again why do you hate me github editor.

* Update stepper.dart

* Update stepper.dart

if this format doesn't work i'll cry

* Update stepper_test.dart

Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`

* Update stepper_test.dart

Added const constructors

* Update stepper_test.dart

trying to get rid of whitespace again

* Update stepper_test.dart

* Update stepper_test.dart

why whitespace why

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

Swapped to `findsNothing` because I'm an idiot.

* Update stepper_test.dart

* Update stepper.dart
2019-02-12 14:02:36 -08:00
rami-a
c348be9739
[Material] Update the card demo in the Gallery to demonstrate different uses of the Card widget (#27699)
Additionally, this adds a tappable Card example to the Card documentation.
2019-02-12 16:56:47 -05:00
vanya elizarov
f021ee27be CupertinoSliverRefreshControl inactive overscroll behavior (#27588) 2019-02-12 13:41:17 -08:00
Ian Hickson
58939b70ef Prevent tests from importing other tests. (#27800)
This pattern is problematic when Flutter is ported to build systems
that require each executable end-point to be self-contained (e.g.
Bazel).
2019-02-12 12:29:36 -08:00
KyleWong
cb2ac0a125 Null check logic for datatable. (#27632) 2019-02-12 01:05:09 -08:00
Hans Muller
5ee5766c89
Add builder parameter to showDatePicker, showTimePicker (#27703) 2019-02-11 15:53:31 -08:00
Kate Lovett
c58e31a74f
Cupertino TextField Cursor Fix (#27697)
* Fix for #26261. Changes CupertinoTextField's cursorColor to read from CupertinoTheme instead of prior default of activeBlue. CursorColor will still default to activeBlue for light theme and activeOrange for dark theme if a primary color has not been specified for the CupertinoTheme.

* Reverted unnecessary changes in XCode file.

* Updated text_field.dart per suggestions from @gspencergoog

* Updated comments for cursorColor to reflect appropriate hyperlinks per @Hixie

* Simplified cursorColor assignment per @xster

* Added test in cupertino/text_field_test.dart to check for correct cursorColor based on CupertinoTheme per @Hixie & @xster.
2019-02-11 12:54:21 -08:00
Anthony
39bb6712f6
[Material] Simple API for skipping over certain Slider shapes (#27613)
* Provide a simmplified API for skipping over slider thumb, overlay, and tick mark painting

* doc fixes

* comments

* comments

* comments

* comments

* comments

* analyzer

* comments
2019-02-11 14:57:41 -05:00
Hans Muller
944ede85ff
TextField should only set EditableText.cursorOffset for iOS (#27663) 2019-02-08 14:31:35 -08:00
Phil Quitslund
9e3a0d30c9
remove super_goes_last (#27690)
In Dart 2, it is a compile-time error if a superinitializer
appears in an initializer list at any other position than at the end so this
rule is made redundant by the Dart analyzer's basic checks and is no longer
necessary.
2019-02-08 13:46:01 -08:00
Greg Spencer
431cfdafd9
Adding support for logical and physical key events (#27627)
This adds support for logical and physical key information inside of RawKeyEvent. This allows developers to differentiate keys in a platform-agnostic way. They are able to tell the physical location of a key (PhysicalKeyboardKey) and a logical meaning of the key (LogicalKeyboardKey), as well as get notified of the character generated by the keypress. All of which is useful for handling keyboard shortcuts.

This PR builds on the previous PR (#27620) which generated the key code mappings and definitions.
2019-02-08 12:42:34 -08:00
Kartik Sharma
b7807ce84c Update an IconButton sample, add RaisedButton sample (#27169) 2019-02-08 12:14:38 -08:00
Hans Muller
022f7d892e
Make FlexibleSpaceBar title padding configurable (#27623) 2019-02-08 10:44:50 -08:00