30726 Commits

Author SHA1 Message Date
engine-flutter-autoroll
306b350bdb
Roll Dart SDK from 4bd485d911a1 to c44e64e5a856 (2 revisions) (#171260)
https://dart.googlesource.com/sdk.git/+log/4bd485d911a1..c44e64e5a856

2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-283.0.dev
2025-06-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-282.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 07:06:21 +00:00
engine-flutter-autoroll
cd4d714db0
Roll Skia from d388ecb0ceea to 062c986ad62e (1 revision) (#171259)
https://skia.googlesource.com/skia.git/+log/d388ecb0ceea..062c986ad62e

2025-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 793884c7084d to 8acd0e40f584 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 06:48:26 +00:00
engine-flutter-autoroll
49cd72063e
Roll Skia from 28b3d2dad5d5 to f041aa580d11 (23 revisions) (#171248)
https://skia.googlesource.com/skia.git/+log/28b3d2dad5d5..f041aa580d11

2025-06-26
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 08cf3372adf6 to 216f8f420080 (4 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 14960950b20c to b3ec3a5f5448 (4 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0b45ace1550e to 793884c7084d (7 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from f1e896dba6c3 to 772f77165cdf (19 revisions)
2025-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from ed01d9931de3 to 436722b39118 (1 revision)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1b6f53279a7b to 08cf3372adf6 (16 revisions)
2025-06-25 danieldilan@google.com Use NinePatch for
SkBitmapDevice::drawBlurredRRect()
2025-06-25 michaelludwig@google.com [graphite] Treat inverse filled
draws as kDifference ops for clip stack traversal
2025-06-25 michaelludwig@google.com [graphite] Check for null surface
for GPU blur profile
2025-06-25 robertphillips@google.com [graphite] Additional
Android-specific PaintOptions
2025-06-25
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 79ac1a8cd767 to 14960950b20c (3 revisions)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 6043290d5e93 to 0b45ace1550e (9 revisions)
2025-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 0df5a8fd9a75 to f1e896dba6c3 (24 revisions)
2025-06-25
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-24 fmalita@google.com Revert "Reland "move pathops into a
module""
2025-06-24 michaelludwig@google.com [graphite] Clip shape intersections
rely only on relative transform
2025-06-24 sharaks@google.com Merge 7 release notes into
RELEASE_NOTES.md
2025-06-24 sharaks@google.com Update Skia milestone to 140
2025-06-24 michaelludwig@google.com [graphite] Differentiate async
compile failures from other command failures

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-27 00:07:07 +00:00
engine-flutter-autoroll
c136585897
Roll Dart SDK from 21c55ff25118 to 4bd485d911a1 (2 revisions) (#171243)
https://dart.googlesource.com/sdk.git/+log/21c55ff25118..4bd485d911a1

2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-281.0.dev
2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-280.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 23:22:08 +00:00
gaaclarke
2597ee726b
License cpp jun25 (#171235)
Changes:
1) Headers are now included in the output even if there is a covering
LICENSE file
1) .c files are now included
1) excluded files are now printed out in --v=1
1) there's a new flag that allows us to treat unmatched comments as
errors (since this represents the last of what is missing between
LICENSE and LICENSE_CPP)
1) Adds a tool for auditing LICENSE versus LICENSE_CPP
1) Adds "COPYING" as a potential license file name

The results of the comparison tool showed us that the difference between
LICENSE and LICENSE_CPP is all the matched header licenses for files
that have covering LICENSE files in their directories.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-26 22:26:10 +00:00
engine-flutter-autoroll
cf045ea520
Roll Skia from a462e701b493 to 28b3d2dad5d5 (5 revisions) (#171093)
https://skia.googlesource.com/skia.git/+log/a462e701b493..28b3d2dad5d5

2025-06-24 fmalita@google.com Guard AnnotationTest on SK_SUPPORT_PDF
2025-06-24 robertphillips@google.com [graphite] Treat linear/encode as
sRGBish for fast path
2025-06-24 kainino@chromium.org [graphite] Handle Dawn breaking change
in WGPUInstanceDescriptor
2025-06-24 michaelludwig@google.com Reland "[graphite]
Context::insertRecording returns more status info on failure"
2025-06-24 nscobie@google.com Revert "Reland "[Fontations] Roll
Fontations""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 21:48:55 +00:00
Jason Simmons
5285cbb750
Clamp the alpha channel to the valid range in the DlColor constructor (#171203) 2025-06-26 20:58:55 +00:00
Jason Simmons
6af3df8d9a
Add a flag that disables SecureSocket support in Dart (#171201)
See https://github.com/flutter/flutter/issues/170459
2025-06-26 20:03:32 +00:00
engine-flutter-autoroll
1147f14a04
Roll Dart SDK from 7c1fb216a4f2 to 21c55ff25118 (1 revision) (#171232)
https://dart.googlesource.com/sdk.git/+log/7c1fb216a4f2..21c55ff25118

2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-279.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 17:57:26 +00:00
engine-flutter-autoroll
edb19e6dd6
Roll Dart SDK from f83d43fa2ff4 to 7c1fb216a4f2 (1 revision) (#171225)
https://dart.googlesource.com/sdk.git/+log/f83d43fa2ff4..7c1fb216a4f2

2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-278.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 12:51:18 +00:00
engine-flutter-autoroll
961ce3ec82
Roll Fuchsia Linux SDK from XX8LxiX10yPg8EwED... to lOriymW5zTP5ByH8-... (#171206)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 04:08:58 +00:00
engine-flutter-autoroll
9f3a323242
Roll Dart SDK from b43ca793d4bf to f83d43fa2ff4 (1 revision) (#171205)
https://dart.googlesource.com/sdk.git/+log/b43ca793d4bf..f83d43fa2ff4

2025-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-277.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-26 04:07:32 +00:00
engine-flutter-autoroll
8d89d1edac
Roll Dart SDK from d9edd9e7a634 to b43ca793d4bf (8 revisions) (#171189)
https://dart.googlesource.com/sdk.git/+log/d9edd9e7a634..b43ca793d4bf

2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-276.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-275.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-274.0.dev
2025-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-273.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-272.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-271.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-270.0.dev
2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-25 22:59:20 +00:00
Jason Simmons
89ba94902a
[Impeller] Make ContextVK hash values globally unique (#171119)
ContextVK had been using a thread-local counter to assign the value
returned by GetHash. But CommandPoolRecyclerVK was using these values as
keys in a process-wide global map.

If two engine instances using different task runner threads both created
a ContextVK, then the thread-local counter could cause both contexts to
share the same hash. So when
CommandPoolRecyclerVK::DestroyThreadLocalPools destroys the pools
associated with the first context's hash, it will also incorrectly
destroy the second context's pools.

Fixes https://github.com/flutter/flutter/issues/170141
2025-06-25 22:20:14 +00:00
Chinmay Garde
a39147c813
Allow uninstalling Git hooks. (#170839)
The hooks get in the way of pushing to branches via tools like Sublime
Merge. Installation of these hooks can be disabled via the
setup_githooks DEPS [custom
variable](edc792e098/DEPS (L127)).
In case the hook is installed already, the installation script is now
augmented to accept an `--unset` argument. The default behavior remains
unchanged.
2025-06-25 21:56:47 +00:00
Chinmay Garde
f8f7455a12
[Impeller] libImpeller: Allow user supplied fragment programs to shade pixels. (#170616)
Fixes https://github.com/flutter/flutter/issues/170008
2025-06-25 21:18:44 +00:00
John "codefu" McDole
90e5f43ada
feat: upload artifacts to content_hash if signaled (#171166)
part of #167780

`upload_content_hash` is paired with

[cocoon's](2a5f4afa3d/app_dart/config.yaml (L12-L15))
`waitOnContentHash` flag. When enabled, cocoon will add the
`content_hash` solution to the luci build properties when scheduling
[merge group

targets](2a5f4afa3d/app_dart/lib/src/service/scheduler.dart (L703-L706)).

If `upload_content_hash` is present and the `content_hash` is passed,
the [engine_v2 & builder
recipie](https://flutter-review.googlesource.com/c/recipes/+/66780) will
upload to a second location. This upload should happen only once; for
the first matching engine change.

> [!IMPORTANT]
>
[`windows_arm_host_engine`](https://flutter-dashboard.appspot.com/#/build?taskFilter=windows_arm_host_engine&repo=flutter&branch=master)
is not built in the merge queue and won't get the content_hash value
passed down to it, so it will not get uploaded today. This should be
fine given we're still testing; but Cocoon would need to schedule
limited post submits so this eventually only builds and uploads once.
2025-06-25 21:00:51 +00:00
gaaclarke
091f0ff99e
License cpp jun24 (#171088)
additions:
- root package files need a header
- added ci step
- performance increases (executes in like 15s now)
- added README.md to the data directory
- cleaned up --v=1 log

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-25 18:29:57 +00:00
gaaclarke
14bee0273a
License cpp jun23 (#171047)
Additions:
- There are no runtime exceptions now.
- There are some cases that are ignored for now where there wasn't clear
action on how to resolve them.
- Adds a script and license file that will be run by ci.
- Switched the excluded file to relative paths.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-24 21:51:19 +00:00
Mouad Debbar
caf0c82b82
[web] More granular configuration of the test environment (#168767)
There's today a single boolean `debugEmulateFlutterTesterEnvironment`
that determines certain behaviors in the engine to emulate how the
Flutter Tester runs (more details at
https://github.com/flutter/flutter/issues/145779).

With this PR:
- Run all engine unit tests in production mode by default.
- Give tests more granular control over which test behaviors to
enable/disable (e.g. Ahem font).
- Keep it easy for framework tests to enable all emulation behaviors.

Fixes https://github.com/flutter/flutter/issues/145779
2025-06-24 19:45:19 +00:00
Jason Simmons
12e4a898dc
Support wide gamut colors when applying a DlColor to an SkPaint (#170613)
Fixes https://github.com/flutter/flutter/issues/170203
2025-06-24 17:06:07 +00:00
engine-flutter-autoroll
a545ff5a33
Roll Skia from 132cb2052565 to a462e701b493 (2 revisions) (#171063)
https://skia.googlesource.com/skia.git/+log/132cb2052565..a462e701b493

2025-06-24 drott@google.com Reland "[Fontations] Roll Fontations"
2025-06-24
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 11:20:36 +00:00
engine-flutter-autoroll
c2988b0bab
Roll Skia from f88706e3a863 to 132cb2052565 (4 revisions) (#171057)
https://skia.googlesource.com/skia.git/+log/f88706e3a863..132cb2052565

2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 5220e634850e to 79ac1a8cd767 (8 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d03fe7eda12d to 0df5a8fd9a75 (15 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 63bd78a28535 to 6043290d5e93 (3 revisions)
2025-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 0ce9bc68d3fc to ed01d9931de3 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 09:10:28 +00:00
engine-flutter-autoroll
1c00399b47
Roll Dart SDK from aebd78999b1a to d9edd9e7a634 (1 revision) (#171053)
https://dart.googlesource.com/sdk.git/+log/aebd78999b1a..d9edd9e7a634

2025-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 04:04:34 +00:00
engine-flutter-autoroll
0db6d7b1bb
Roll Skia from a7735d517e6a to ae517eba0170 (9 revisions) (#171049)
https://skia.googlesource.com/skia.git/+log/a7735d517e6a..ae517eba0170

2025-06-23 mike@reedtribe.org Declare SkPathVerb to use uint8_t storage
2025-06-23 fmalita@google.com [gn] Split :pdf and :xps from :skia
2025-06-23 fmalita@google.com Reland "move pathops into a module"
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 syoussefi@google.com [vulkan] Remove VulkanPreferredFeautres
usage assert
2025-06-23 robertphillips@google.com [graphite] Handle
"CoverBoundsRenderStep[InverseCover] + (empty)" Pipeline(s)
2025-06-23 michaelludwig@google.com [graphite] Add
SK_TRACE_GRAPHITE_PIPELINE_USE build variant, expand tracing
2025-06-23 zengyonghust@gmail.com Correct the writing errors in
discardStatement().
2025-06-23 danieldilan@google.com Implement specialized A8 blur to
SkBlurEngine from SkMaskBlurFilter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-24 01:20:24 +00:00
Ryan Macnak
475f732faa
Enable interpretation fallback when unable to JIT on iOS. (#170835)
Bug: https://github.com/flutter/flutter/issues/163984
2025-06-24 01:12:29 +00:00
engine-flutter-autoroll
86ce755359
Roll Dart SDK from a09de0d3556c to aebd78999b1a (2 revisions) (#171039)
https://dart.googlesource.com/sdk.git/+log/a09de0d3556c..aebd78999b1a

2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-267.0.dev
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-266.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 22:57:29 +00:00
engine-flutter-autoroll
02c90f0089
Roll Skia from 0311837abe86 to a7735d517e6a (12 revisions) (#171037)
https://skia.googlesource.com/skia.git/+log/0311837abe86..a7735d517e6a

2025-06-23 michaelludwig@google.com [graphite] Extract intersect_shape
helper from RawElement::combine
2025-06-23 mike@reedtribe.org Make pathbuilder robust for odd inputs
2025-06-23 robertphillips@google.com [graphite] Expand
PrecompileSettings to include kAnalyticClip handling
2025-06-23 mike@reedtribe.org Use SkPathBuilder for building
2025-06-23 mike@reedtribe.org Use pathbuilder in freetype
2025-06-23 kjlubick@google.com Make SkImage_Raster get cpu Recorder from
GPU recorders
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 317a1e4780ef to 31127c60fb32 (1 revision)
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 9e24b0b15986 to 5220e634850e (7 revisions)
2025-06-23
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 825731c55823 to 63bd78a28535 (5 revisions)
2025-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 47399fc146fa to 0ce9bc68d3fc (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 21:24:09 +00:00
bungeman
a7713b0168
Pass font scanner to font mgr that need it (#170701)
Skia is removing the constructors which default to the FreeType font
scanner. This will allow Skia to simplify dependencies.
2025-06-23 21:12:30 +00:00
ash2moon
4fb1042870
rename from announce to supportsAnnounce on engine (#170618)
Part of https://github.com/flutter/flutter/issues/165510

⤴️ Original PR: https://github.com/flutter/flutter/pull/169685
⤵️ Child PR: https://github.com/flutter/flutter/pull/168992

This is a renaming of the announce to `supportsAnnounce`. See more info
in this comment thread:
https://github.com/flutter/flutter/pull/168992#discussion_r2146068546

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 18:17:09 +00:00
jesswrd
20969cf264
Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (#170816)
Documenting that starting Android 16 (API 36) there will be no way to
opt out of Edge to Edge mode, which was added in Android 15 (API 35)
with a way to opt out.

Fixes https://github.com/flutter/flutter/issues/165329

Partially Addresses https://github.com/flutter/flutter/issues/169746,
https://github.com/flutter/flutter/issues/169251,
https://github.com/flutter/flutter/issues/163545,
https://github.com/flutter/flutter/issues/165329

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 16:33:51 +00:00
gaaclarke
bc30d1cd41
License cpp jun20 (#170948)
I'm down to 40 exceptions and runtime 20s.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-23 16:18:37 +00:00
engine-flutter-autoroll
ff1be7d67e
Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (#171000)
https://dart.googlesource.com/sdk.git/+log/bb16990911b5..a09de0d3556c

2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-265.0.dev
2025-06-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-264.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-23 14:18:46 +00:00
Robert Ancell
8d5d0e21e9
Clear background in the GTK layer, instead of OpenGL (#170840)
Since OpenGL was being blitted, it would overwrite the color set with
clear color anyway. Also fix the software rendering case that was not
setting any background.

This could cause a black screen to show by default, if you want the
previous behaviour set the view background to transparent with:
```
GdkRGBA background_color;
gdk_rgba_parse(&background_color, "#00000000");
fl_view_set_background_color(view, &background_color);
```

---------

Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
2025-06-22 23:55:25 +00:00
engine-flutter-autoroll
dd40c13375
Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (#170988)
https://dart.googlesource.com/sdk.git/+log/98db1db5ff65..bb16990911b5

2025-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-22 22:13:32 +00:00
engine-flutter-autoroll
06911952c8
Roll Dart SDK from e5db5e0f81ba to 98db1db5ff65 (2 revisions) (#170979)
https://dart.googlesource.com/sdk.git/+log/e5db5e0f81ba..98db1db5ff65

2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-262.0.dev
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-22 00:00:39 +00:00
engine-flutter-autoroll
6a3cc3f372
Roll Dart SDK from 6325aeacaef4 to e5db5e0f81ba (1 revision) (#170958)
https://dart.googlesource.com/sdk.git/+log/6325aeacaef4..e5db5e0f81ba

2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-260.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 12:30:42 +00:00
engine-flutter-autoroll
35aa07e4ea
Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) (#170955)
https://dart.googlesource.com/sdk.git/+log/a6a3d65e33d7..6325aeacaef4

2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-259.0.dev
2025-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 07:21:42 +00:00
engine-flutter-autoroll
549fa4e6fb
Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) (#170953)
https://dart.googlesource.com/sdk.git/+log/750eaa028445..a6a3d65e33d7

2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-257.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-21 02:05:41 +00:00
YU-KI Hidea
453d113161
Fix the Japanese IME problem on macOS reported in the following issue. (#166291)
flutter/engine#57286

Fixes https://github.com/flutter/flutter/issues/160935
2025-06-21 00:10:21 +00:00
engine-flutter-autoroll
7f3f08cff2
Roll Skia from 104460420c48 to 773188560221 (2 revisions) (#170942)
https://skia.googlesource.com/skia.git/+log/104460420c48..773188560221

2025-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 316ed08fbc9a to a875f13dac14 (8 revisions)
2025-06-20 thomsmit@google.com Fix SubSetting on Mali400

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 23:22:08 +00:00
engine-flutter-autoroll
cca7287639
Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) (#170933)
https://dart.googlesource.com/sdk.git/+log/a554bdd0a2cc..750eaa028445

2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-256.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 21:00:18 +00:00
engine-flutter-autoroll
67b3104f74
Roll Skia from f1e68950ea7b to b638003de37e (5 revisions) (#170923)
https://skia.googlesource.com/skia.git/+log/f1e68950ea7b..b638003de37e

2025-06-20 lukasza@chromium.org [rust png] More resilient
`fIncrementalDecodingState` checks.
2025-06-20 lukasza@chromium.org [rust png] Ignore `fcTL` chunk if there
is no `acTL` chunk.
2025-06-20 lukasza@chromium.org [rust png] Preserve M136 encoding
behavior despite `png` crate changes.
2025-06-20 jreck@google.com gn_to_bp.py tweaks for libdng_sdk dep and
libskia_skcms
2025-06-20 michaelludwig@google.com Revert "[graphite]
Context::insertRecording returns more status info on failure"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 17:46:39 +00:00
gaaclarke
374321614f
[licenses_cpp] jun17 (#170845)
We are still executing < 40s and I'm down to about 98 errors.

- cleaned up the output
- added include_filter flag to help debugging
- added a lot of instances to the data directory

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-20 17:04:17 +00:00
Camille Simon
c7362b4755
[Android] Add a way to request new Surfaces from SurfaceProducer and avoid SurfaceProducer returning invalid Surface (#169899)
> [!NOTE]  
> For anyone reviewing this PR, see
https://github.com/flutter/packages/pull/9360 for how I'd use the
`getSurface(boolean forceNewSurface)` method.

> [!NOTE]  
> For anyone coming across this PR post-landing, in the code review
process, I renamed `getSurface(boolean forceNewSurface)` to
`getForcedNewSurface()`.

### What this does
(1) Adds method `getSurface(boolean forceNewSurface)` to
`SurfaceProducer` that will force the creation of a new `Surface` when
`SurfaceProducer.getSurface()` is called.
(2) Fixes `SurfaceProducer` to avoid returning invalid `Surface`s when
`SurfaceProducer.getSurface()`/`getSurface(boolean forceNewSurface)` is
called.

### Why we should...

#### (1) Add `getSurface(boolean forceNewSurface)`

My motivation for adding this is directly tied to
https://github.com/flutter/flutter/issues/155294. The
`camera_android_camerax` plugin supports a camera preview use case that
requires providing a `Surface` to in order to render the preview. It
does so via `SurfaceProducer`; we provide a `Surface` retrieved from
`SurfaceProducer.getSurface()` to the CameraX library to render a camera
preview, and when the camera preview is done, a callback that we provide
is called, reporting that `Surface` as used and that it now should be
released/invalidated (see
[`SurfaceRequest`](https://developer.android.com/reference/androidx/camera/core/SurfaceRequest),
[`SurfaceRequest.Result`](https://developer.android.com/reference/androidx/camera/core/SurfaceRequest#provideSurface(android.view.Surface,java.util.concurrent.Executor,androidx.core.util.Consumer%3Candroidx.camera.core.SurfaceRequest.Result%3E))).
However, the CameraX library [makes no
guarantees](https://developer.android.com/reference/androidx/camera/core/Preview.SurfaceProvider#onSurfaceRequested(androidx.camera.core.SurfaceRequest):~:text=The%20camera%20may%20repeatedly%20request%20surfaces%20throughout%20usage%20of%20a%20Preview%20use%20case%2C%20but%20only%20a%20single%20request%20will%20be%20active%20at%20a%20time.)
about when requests for new `Surface`s are made, so the following race
condition can happen:

1. CameraX requests a `Surface`
2. We provide `Surface` A from `SurfaceProducer.getSurface()`
3. The camera preview was paused; CameraX requests a new `Surface`
4. The camera preview is resumed
5. We provide `Surface` A from `SurfaceProducer.getSurface()` because it
is still technically valid
6. CameraX calls our callback and now `Surface` A is released/invalid

I believe `SurfaceProducer` currently has no way to handle the level of
complexity of `Surface` handling required for use cases like the
`camera_android_camerax` camera preview, where a `Surface` may be
invalidated between calls to `SurfaceProducer.getSurface()`. So,
`getSurface(boolean forceNewSurface)` can support these use cases.*

`getSurface(boolean forceNewSurface)` simply will force
`SurfaceProducer` to return a new `Surface` when
`SurfaceProducer.getSurface` is called versus potentially returning the
same `Surface` as the previous invocation.

For `camera_android_camerax`, see
https://github.com/flutter/packages/pull/9360 for an example of how it
would be used.

*I'd like to note that I also played around with creating new
`SurfaceProducer`s to solve the camera problem, which _was_ successful
and probably could be generally for that use case, but I think it's
cleaner to support this functionality from within the same
`SurfaceProducer` since we can 🤷‍♀️ It also helps avoid the user from
needing to create/manage multiple Flutter `Texture`s, from my
understanding.

#### (2) Fix `SurfaceProducer.getSurface()`/`getSurface(boolean
forceNewSurface)` to never return an invalid `Surface`s

I noticed that `SurfaceProducer.getSurface()`/`getSurface(boolean
forceNewSurface)` does not check for `Surface` validity before returning
them while I was working on (1). Honestly, this just feels right? We
should ensure that a `Surface` is valid and can be used before returning
it and potentially confusing the user.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-06-20 16:05:41 +00:00
engine-flutter-autoroll
9a8cbb88d0
Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (#170912)
https://dart.googlesource.com/sdk.git/+log/cc2f604acb05..a554bdd0a2cc

2025-06-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-255.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 15:55:31 +00:00
engine-flutter-autoroll
3788c7a38b
Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (#170906)
https://skia.googlesource.com/skia.git/+log/8a710de2a1d3..2fc58cffe69b

2025-06-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from d2f0baa84b48 to 825731c55823 (25 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 09:16:44 +00:00
engine-flutter-autoroll
c6ae3efa2a
Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (#170900)
https://skia.googlesource.com/skia.git/+log/2ac2476b0bcb..8a710de2a1d3

2025-06-20 syoussefi@google.com [vulkan] Generate SPIR-V directly in
vector<uint32_t>
2025-06-20 syoussefi@google.com [graphite][vulkan] Make render pass
handling less special

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 07:02:26 +00:00
engine-flutter-autoroll
6d821e6681
Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (#170895)
https://dart.googlesource.com/sdk.git/+log/6a4b11760906..cc2f604acb05

2025-06-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-254.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-20 03:51:10 +00:00
engine-flutter-autoroll
ff957e10a8
Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (#170890)
https://skia.googlesource.com/skia.git/+log/61c89daa3888..2ac2476b0bcb

2025-06-19 syoussefi@google.com [vulkan] Use std::vector<uint32_t> for
SPIR-V
2025-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 978144890e92 to 1c18b20944ca (14 revisions)
2025-06-19 michaelludwig@google.com Revert "[Fontations] Roll
Fontations"
2025-06-19 michaelludwig@google.com [graphite] Context::insertRecording
returns more status info on failure

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
danieldilan@google.com,jimgraham@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-06-19 22:10:36 +00:00