1903 Commits

Author SHA1 Message Date
Jonah Williams
3cd6f40a34
wire bold text flag to text widget (#21325) 2018-09-04 13:49:20 -07:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)" (#21395)
This reverts commit 3306fc10421cfbad8f772d23c02aca27c7ca1d76.
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… (#20637)
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.

Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Hans Muller
343b57036a
InheritedModel - an InheritedWidget for data models (#19739)
Added InheritedModel:  An InheritedWidget that's intended to be used as the base class for models whose dependents may only depend on one part or "aspect" of the overall model.
2018-09-04 09:31:52 -07:00
xster
457e7b23df
Fix FixedExtentScrollController.animateToItem (#20618) 2018-09-01 04:06:46 -07:00
Greg Spencer
ec5c2e3e0c
Add links to implicit animation illustrations. (#21092)
This adds links to the already existing animated diagrams in the asset-for-api-docs repo.
2018-08-30 10:09:22 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 (#21181) 2018-08-29 16:48:23 -07:00
Alexander Aprelev
a7d954eb31
Add TODOs to remove lint ignore directives. (#21170)
This is follow-up to https://github.com/flutter/flutter/pull/21143.
2018-08-29 10:25:19 -07:00
Alexander Aprelev
abc17236f7
Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll). (#21143)
* Roll engine to 56139397e6ae1257bdabd1ef79ff7aca96c67d4.6

Changes since last roll:
```
56139397e Roll src/third_party/skia 7ba1d64f0706..5f0726b01019 (12 commits) (#6104)
47a1ce0e6 Allow embedders to set the root surface transformation. (#6085)
```

* Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll).

* Add const

* Add ignore analyzer prefer_const_constructors_in_immutables
2018-08-28 21:30:36 -07:00
xster
373243bcf8
make /timeline-dashboard consistent between build and paint profiles (#21099) 2018-08-28 16:48:58 -07:00
xster
f23c9ae5f8
Cupertino nav bar transitions between routes (#20322) 2018-08-28 16:44:34 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
Greg Spencer
7a07b28c93
Fix typo in AnimatedWidget (#21091) 2018-08-28 09:12:16 -07:00
Amir Hardon
c5b7766cbb
Re-land "Make AndroidView participate in gesture arenas." (#21097)
This re-lands commit c594696.

The original PR was breaking the integration test as while the
gesture was active the AndroidView's parent widget got rebuilt which
disposed the _AndroidViewGestureRecognizer and dropped pointer events
from that point on.

This change adds a unit test that reproduces the failure case, and
fixes it by not rebuilding the _AndroidViewGestureRecognizer if the
list of gesture recognizers did not change.
2018-08-28 08:52:46 -07:00
Michael Goderbauer
f88d2d9c12
Revert 20917 platform view arena (#21086)
This reverts commit c594696f0626e32dcd83d2a7d8c479460d475374.
2018-08-27 17:36:40 -07:00
amirh
c594696f06
Make AndroidView participate in gesture arenas. (#20917)
Pointer events are dispatched to the Android view only if it won
Flutter's gesture arena for the pointer.
Specific gestures that should be dispatched to the android view can be
specified with the gestureRecognizers parameter.
2018-08-27 15:07:19 -07:00
amirh
688d96b652
Add a creation parameters argument to AndroidView. (#21067)
This allows to pass construction parameters for the embedded Android
view from the Dart side.
2018-08-27 11:24:54 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
Jonah Williams
e235ccd76f
Support disabled animations (#20354) 2018-08-23 11:50:04 -07:00
amirh
1fc7814bb1
Add a layoutDirection parameter to AndroidView (#20838) 2018-08-22 21:42:40 -07:00
Ian Hickson
94f9604a96
Cleanup (#20754)
- remove an //ignore that is no longer needed
- fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
- add some asserts to help track down bugs quicker
- update a TODO to point to the currently relevant bug
- fix some indenting
- improve the naming of some privates to improve readability
2018-08-21 14:02:48 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
Ian Hickson
ad1eaff45a
flutter analyze cleanup (#20490)
* `flutter analyze` cleanup

* Make `--dartdocs` work in all modes.
* Make `analyze-sample-code.dart` more resilient.
* Add a test for `analyze-sample-code.dart`.
* Minor cleanup in related code and files.

* Apply review comments

* Fix tests
2018-08-20 12:51:07 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links (#20772)
* Fixes resulting from audit of issues links

I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.

* Update run_test.dart

skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
Janice Collins
82d43b952a
Use markdown table (#20721) 2018-08-17 14:36:24 -07:00
Ian Hickson
3acc278521
Documentation regarding tap gesture callbacks (#20647) 2018-08-17 14:31:35 -07:00
Jonah Williams
e56a73e42c
Add support for by word movement granularities to semantics (#19949) 2018-08-17 12:17:34 -07:00
xster
ea355c66df
Create a ValueListenableBuilder (#19729) 2018-08-15 19:22:08 -07:00
xster
ede7c15a2f
Add doc describing sliver children's lifecycle and persistence options (#19795) 2018-08-15 17:24:32 -07:00
Michael Goderbauer
4d9c3cc377
Always honor explicitly set keyboardType and inputAction for TextField (#20547)
With this change you can now create "wrapping" text fields that do not show the new line button:

```dart
new TextField(
  maxLines: null,
  keyboardType: TextInputType.text,
);
```
2018-08-15 11:35:49 -07:00
Jonah Williams
8de0e15e4f
Revert to defaultClipBehavior (#20578) 2018-08-14 20:23:04 -07:00
Viet Do
1057d39dd0
Support infinite scrolling for CupertinoPicker. (#19789)
Allows the cupertino picker to be scroll infinitely by adding builder.
2018-08-13 12:26:07 -07:00
Greg Spencer
ba723b6038
Adding animation links for the *Transition widgets. (#20395)
This adds the animation links for illustrations of the Transition widgets, as well as adding a cross-references to the other transition widgets in the "See also" for each of their docs.
2018-08-12 16:01:39 -07:00
Mikkel Nygaard Ravn
1e565ec42d
Fix typo (#20423) 2018-08-10 13:13:54 +02:00
Mikkel Nygaard Ravn
9cb0b21e9c
Fix typos (#20417) 2018-08-10 09:56:13 +02:00
Natalie Sampsell
96326d4743
CupertinoActionSheet (#19232)
Adding CupertinoActionSheet, showCupertinoModalPopup
2018-08-09 21:55:41 -07:00
Ian Hickson
21f22ed3ba
Visibility widget (#20365)
* Visibility widget

This attempts to address the confusion around how to hide a widget subtree.

* Apply review comments

* More clarifications
2018-08-09 18:23:36 -07:00
liyuqian
13bfa7353e
Set default clipBehavior to Clip.none and update tests (#20205)
This fixes https://github.com/flutter/flutter/issues/18057
2018-08-09 16:38:08 -07:00
Natalie Sampsell
ace8abf365
Fixes to CupertinoScrollbar minLength (#20101)
Add minOverscrollLength to make CupertinoScrollbar thumb correct size in long scroll views.
2018-08-09 15:08:03 -07:00
Harry Terkelsen
71048065b8 Fix bug in FadeInImage causing changes in placeholder to be missed (#20356) 2018-08-08 17:11:08 -07:00
Natalie Sampsell
345d939ee8
Add showCupertinoDialog and showGeneralDialog (#20152) 2018-08-08 10:31:07 -07:00
Jonah Williams
b32c77a012
Use scrollPhysics.allowImplicitScrolling to configure scrollable semantics (#20210) 2018-08-07 17:09:14 -07:00
Amir Hardon
ccaa06367b AndroidView touch support.
This PR adds 2 features to RenderAndroidView and AndroidView:

1. Hit testing behavior
Adds a `PlatformViewHitTestBehavior` which is similar to
`HitTestBehavior` without the `deferToChild` option (as platform views
don't have child render objects) and with a `transparent` option which
prevents it from forwarding any events to the Android view.

2. MotionEvent recomposing logic
FlutterView and the framework `converter.dart` are working together to
transform each Android MotionEvent object into one or more
`PointerEvent` objects.

This PR adds the reverse logic (in _MotionEventDispatcher which is used
by RenderAndroidView) which turns a stream of PointerEvent objects into
MotionEvent objects.

The correctness of the recomposing logic is tested in an integration
test which will land in a separate PR (the unit test PR is pretty big,
trying to keep as many bite-size PRs for reviewer's convenience)
2018-08-07 15:30:14 -07:00
Jonah Williams
4de692a2b9
Add AccessibilityFeatures to media query and fix Snackbar a11y behavior (#19336) 2018-08-07 10:11:21 -07:00
amirh
83f3b7db87
Rename OnPlatformViewCreated to PlatformViewCreatedCallback (#20189) 2018-08-07 09:51:47 -07:00
sandrasandeep
d041b319e8
EditableText Cursor can be set to not blink for testing (#20004)
* no blinking cursor

* debugDeterministicCursor: private -> public

* added documentation

* whitespace
2018-08-06 12:51:22 -07:00
liyuqian
9ffa1c5174
Add Clip enum to Material and related widgets (#18576)
See details in our proposal for this breaking API change and #18057. This PR setup all code paths to allow the change but doesn't change the clip behavior by itself. We'll change `defaultClipBehavior` from `Clip.antiAlias` to `Clip.none` in the following PR to change the clip behavior and update tests.
2018-08-03 09:56:23 -07:00
Jonah Williams
55c7e6e3f8
Support customizing standard accessibility action hints on Android. (#19665) 2018-08-02 10:20:47 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00