skia-flutter-autoroll
690259fcea
Roll Skia from 3b0b79511469 to 8feb4b6a4aa6 (18 revisions) ( flutter/engine#51305 )
...
https://skia.googlesource.com/skia.git/+log/3b0b79511469..8feb4b6a4aa6
2024-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 886dbf1a5a87 to 912fc2090a1b
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fa4c93a17fe6 to b440ca2fa89c (1 revision)
2024-03-08 bungeman@google.com Remove SkScalerContextFTUtils::drawCOLRv1Glyph assert
2024-03-08 nscobie@google.com Experimenting with OWNERS.android rules for SkUserConfig.h files
2024-03-08 jvanverth@google.com [graphite] Add limited resource test for PathAtlases.
2024-03-08 robertphillips@google.com [graphite] Add Android precompile code path
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3d5581c920a3 to 563dc550e3e6 (5 revisions)
2024-03-08 bungeman@google.com Add --fontations flag to test Fontations
2024-03-08 robertphillips@google.com Actually propagate the stable key to the blur runtime effects
2024-03-08 mike@reedtribe.org Reapply "factor out SkCTFontCreateExactCopy into its own file(s)"
2024-03-08 jvanverth@google.com [graphite] Disable MSAA support on Mac Intel devices.
2024-03-08 kjlubick@google.com Reland "Fix debugger bazel build"
2024-03-08 fmalita@chromium.org [dm] Skip empty sources
2024-03-08 kjlubick@google.com Remove some dead code guarded by legacy defines
2024-03-08 lovisolo@google.com [bazel] Fix //tools/viewer.
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 00ea56c88561 to 055af5b4a051 (4 revisions)
2024-03-08 robertphillips@google.com Final batch of StableKeys ...
2024-03-08 robertphillips@google.com Revert "factor out SkCTFontCreateExactCopy into its own file(s)"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 03:23:16 +00:00
skia-flutter-autoroll
388e358166
Manual roll Dart SDK from 4c64fcc134bf to b52b754d5d3e (6 revisions) ( flutter/engine#51304 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/4c64fcc134bf..b52b754d5d3e
2024-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-218.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-217.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-216.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-215.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-214.0.dev
2024-03-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-213.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-09 03:21:13 +00:00
Chinmay Garde
dfb7d84ab8
[Impeller] Use the AHB prefix for utils that work with Android Hardware Buffers. ( flutter/engine#51298 )
...
Also doesn't compile the TU on non-Android platforms.
Part of https://github.com/flutter/engine/pull/51213 being chopped up.
No change in functionality. Just renames and moves stuff around.
2024-03-09 00:52:25 +00:00
Chinmay Garde
fcba196886
[Impeller] Make DeviceHolder follow convention for backend specific utilities. ( flutter/engine#51300 )
...
Utilities below the HAL that are backend specific have the VK (in case of Vulkan) suffix. The only class that doesn't follow this convention is/was DeviceHolder. This caused some confusion when reading code leading to wondering what a device holder above the HAL was supposed to do/mean. Adds the VK suffix to device holder with a docstring. Also adds the file the source set as it was missing.
No change in functionality. Just a rename of an existing class.
2024-03-09 00:28:46 +00:00
Harry Terkelsen
4c86674a0f
Optimize overlays in CanvasKit ( flutter/engine#47317 )
...
Optimize overlays by detecting when Flutter-rendered content intersects
with platform views. Overlay canvases are only needed when the content
intersects, so by checking for this, we can optimize out most overlays.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-08 14:28:24 -08:00
skia-flutter-autoroll
4dc296c0ab
Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... ( flutter/engine#51296 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 22:09:14 +00:00
Chinmay Garde
03a4ec697e
[Impeller] Add the KHR prefix to existing swapchain utilities. ( flutter/engine#51295 )
...
This is part of blowing up https://github.com/flutter/engine/pull/51213 into smaller commits.
Our current swapchain is based on the VK_KHR_swapchain extension. When this was the only swapchain that could be created, the KHR prefix was dropped. Since we are going to be having multiple swapchain types, add the KHR prefix and make room for other swapchains.
No change in functionality. Just renames classes and files.
2024-03-08 22:07:23 +00:00
Zachary Anderson
e1b970ca47
Revert test if changes to golden tests ( flutter/engine#51291 )
...
The tests are not running when they should be:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/760676/overview
2024-03-08 13:31:18 -08:00
Dan Field
a4c787e072
Use io.flutter.Build.API_LEVELS rather than android.os.Build.VERSION_CODES ( flutter/engine#51171 )
...
Updates the linting script to ban the use of `VERSION_CODES`.
We currently have a mish-mash of using the integers, using `VERSION_CODES`, and even how we import the version codes. This makes it more confusing when doing things like #51070 - I think it is clearer to see `22` than `LOLLIPOP_MR1`.
I'd like to get LGTM (or at least no opinion) from all the requested reviewers here.
2024-03-08 19:04:20 +00:00
Chris Bracken
c1415300a1
Migrate vulkan_memory_allocator to flutter/third_party ( flutter/engine#51275 )
...
Migrates vulkan_memory_allocator from the buildroot's third_party directory to the engine's.
Issue: https://github.com/flutter/flutter/issues/144812
Part of: https://github.com/flutter/flutter/issues/67373
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-08 17:17:16 +00:00
Jason Simmons
7da9c29b79
Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart ( flutter/engine#51276 )
...
See https://github.com/flutter/flutter/issues/143335
2024-03-08 17:00:17 +00:00
skia-flutter-autoroll
0c2b784e45
Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) ( flutter/engine#51280 )
...
https://skia.googlesource.com/skia.git/+log/093994f8f078..15f8d03a9594
2024-03-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0dc646b71e8d to 886dbf1a5a87 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-08 05:46:21 +00:00
Chris Bracken
0575633c34
Move ANGLE to flutter/third_party ( flutter/engine#51270 )
...
This moves Flutter out of the buildroot's third_party directory and into
//flutter/third_party and updates all BUILD and gni files.
Issue: https://github.com/flutter/flutter/issues/144786
Part of: https://github.com/flutter/flutter/issues/67373
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] The odds of this passing on its first CI run is 0%, because
there's no way the licence script isn't going to have a fit over it, at
which point I promise on my honour that I will dutifully fix all the
things it complains about and re-run, probably more than once.
- [X] This PR fulfils the minimum [Canadian
Content](https://www.youtube.com/watch?v=h9NMnPm5kXc&list=PLJ7QPuvv91JuoPWrLhqX0zDFUoLdynMEk&index=3 )
regulations mandated by the CRTC.
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-07 16:23:14 -08:00
skia-flutter-autoroll
d620dd0864
Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) ( flutter/engine#51268 )
...
https://skia.googlesource.com/skia.git/+log/4a65dfcc70a5..bf3f9c5f0edb
2024-03-07 penghuang@chromium.org Use ProxyTexture::texture()::textureInfo() to determine depth
2024-03-07 michaelludwig@google.com [sksl] support wgsl's frexp/modf intrinsics
2024-03-07 kjlubick@google.com Start enforcing IWYU on src/gpu
2024-03-07 mike@reedtribe.org factor out SkCTFontCreateExactCopy into its own file(s)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 23:22:26 +00:00
skia-flutter-autoroll
ca81103956
Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) ( flutter/engine#51263 )
...
https://skia.googlesource.com/skia.git/+log/6bfd57b8790f..4a65dfcc70a5
2024-03-07 herb@google.com Cleanup SkSwizzler_opt.inc
2024-03-07 kjlubick@google.com Fix debugger bazel build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 22:21:50 +00:00
Chris Bracken
b9d7f23abd
Migrate build_overrides from buildroot to engine ( flutter/engine#51258 )
...
Files under the build_overrides directory in the buildroot are typically hardcoded imports in third-party dependencies used for project-specific configuration. For example, ANGLE hardcodes an import of `//build_overrides/angle.gni` so that consumers of ANGLE can configure the build to their needs.
This adds a copy all existing src/build_overrides files at the equivalent `src/flutter/build_overrides` path in the engine. A followup patch will replace each existing file under `src/build_overrides` in the buildroot with a shim that just imports the files landed in this patch. This allows third-party dependencies to continue hardcoding the `//build_overrides/foo.gni` path, but provides a seamless path forward when we drop the buildroot.
Issue: https://github.com/flutter/flutter/issues/144790
Part of: https://github.com/flutter/flutter/issues/67373
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-07 21:42:06 +00:00
skia-flutter-autoroll
6f59be7215
Roll Fuchsia Linux SDK from y67DIBX84h7pAekIp... to 5Ra_AjCji-uR1GaX7... ( flutter/engine#51261 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 20:58:17 +00:00
skia-flutter-autoroll
1894cb830d
Roll Skia from cf7fefd0bbfb to 6bfd57b8790f (24 revisions) ( flutter/engine#51260 )
...
https://skia.googlesource.com/skia.git/+log/cf7fefd0bbfb..6bfd57b8790f
2024-03-07 robertphillips@google.com Reduce matrix convolution image filter's maximum kernel size
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 99a18601ac24 to e649d06fbad1
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 82a4580a3c5a to f2cacee81b83 (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from b04a5aef564b to cbf986e97789
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 0ccdb32ff1ca to 453d00b44c6b
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from be5714074b1a to 24edbde4082b
2024-03-07 michaelludwig@google.com [skif] Add direct-drawing analog to getAnalyzedShaderView
2024-03-07 johnstiles@google.com Remove flag for SK_RASTER_PIPELINE_FASTER_POW_LOG.
2024-03-07 jlavrova@google.com Moving to the newer ICU4x version (1.4.1)
2024-03-07 jvanverth@google.com [graphite] Move small path management into RasterPathAtlas.
2024-03-07 robertphillips@google.com Manual Roll Dawn from 91a0358034d1 to 58cd45951deb (15 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9cd617cb0454 to 82a4580a3c5a (3 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 756dffd9e74f to 0dc646b71e8d (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 20d29a6cac1b to 0dc646b71e8d
2024-03-06 michaelludwig@google.com [skif] Add animating blur GM testing each tile mode
2024-03-06 jvanverth@google.com [graphite] Switch RasterPathAtlas to use DrawAtlasMgr.
2024-03-06 kjlubick@google.com Fix IWYU and clang-tidy suggestions on ganesh/geometry
2024-03-06 lovisolo@google.com [bazel] Fix broken CI task: BazelTest-benchmark-cpu_8888_benchmark_test-linux_rbe-linux_x64-NUC9i7QN_Debian11.
2024-03-06 penghuang@chromium.org Fix a crash in debug build
2024-03-06 kjlubick@google.com Try limiting all link jobs to 2 at a time
2024-03-06 nscobie@google.com Build Graphite in Android.bp's libskia_renderengine
2024-03-06 brianosman@google.com Add Cargo.lock and target/ to .gitignore
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 49ae911d780a to 9cd617cb0454 (34 revisions)
2024-03-06 michaelludwig@google.com [skif] Separate X and Y transform analysis
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 20:56:31 +00:00
skia-flutter-autoroll
e365aa3c39
Roll Skia from f17ec7494469 to cf7fefd0bbfb (1 revision) ( flutter/engine#51227 )
...
https://skia.googlesource.com/skia.git/+log/f17ec7494469..cf7fefd0bbfb
2024-03-06 drott@chromium.org [Fontations-backend] Color bitmap support.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 19:51:12 +00:00
Jesús S Guerrero
464ecf3948
Skip impeller goldens on release ( flutter/engine#51240 )
2024-03-07 17:24:33 +00:00
skia-flutter-autoroll
83afc6b52b
Roll Dart SDK from 2cdf8f23c55f to 3538739eeea9 (1 revision) ( flutter/engine#51249 )
...
https://dart.googlesource.com/sdk.git/+log/2cdf8f23c55f..3538739eeea9
2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-208.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 06:38:53 +00:00
Tong Mu
67603e5e32
Reland 5: Multiview pipeline ( flutter/engine#51186 )
...
This relands https://github.com/flutter/engine/pull/50931 .
The crash that caused the 4th revert has been fixed by https://github.com/flutter/flutter/pull/144212 .
[There has been discussion](https://github.com/flutter/engine/pull/51019 ) on why the benchmark in previous attempts show significant drop in build time. This PR addresses it using option a as described in [this comment](https://github.com/flutter/engine/pull/51186#issuecomment-1977820525 ).
This PR also addresses https://github.com/flutter/flutter/issues/144584 with option 1. A test is added.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-07 01:54:14 +00:00
Jonah Williams
1322186f32
[Impeller] add a per-frame trace event for heap usage on Vulkan. ( flutter/engine#51246 )
...
Part of https://github.com/flutter/flutter/issues/144617
Adds MemoryBudgetUsageMB which includes the MB of VMA allocated GPU and host memory, approximately per frame. This will be recorded in the devicelab and used to track how much memory pressure we're creating.
Split out from https://github.com/flutter/engine/pull/51187 since that was reverted (and doing big changes is a bad idea anyway).
2024-03-07 01:40:04 +00:00
Chris Bracken
0e6d56bc1c
Move Abseil from src to flutter third_party dir ( flutter/engine#51245 )
...
In combination with:
* https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848
* https://github.com/flutter/buildroot/pull/831
this updates Flutter's references to Abseil from
//third_party/abseil-cpp to //flutter/third_party/abseil-cpp.
Issue: https://github.com/flutter/flutter/issues/144201
Part of: https://github.com/flutter/flutter/issues/67373
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-07 01:19:17 +00:00
skia-flutter-autoroll
049983fc56
Manual roll Dart SDK from 9ea8813ab4d4 to 3ad64881a209 (5 revisions) ( flutter/engine#51242 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/9ea8813ab4d4..3ad64881a209
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-205.0.dev
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-204.0.dev
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-203.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-202.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-201.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-07 00:13:11 +00:00
auto-submit[bot]
e3e37f2bee
Reverts "[Impeller] fold memory check into allocator_vk ( #51187 )" ( flutter/engine#51243 )
...
Reverts: flutter/engine#51187
Initiated by: jonahwilliams
Reason for reverting: unexpected benchmark regression
https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396
Original PR Author: jonahwilliams
Reviewed By: {matanlurey}
This change reverts the following previous change:
Various cleanups to Vulkan allocator implementation:
1. Fixes https://github.com/flutter/flutter/issues/137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.
Part of https://github.com/flutter/flutter/issues/144617
2024-03-06 23:52:25 +00:00
skia-flutter-autoroll
149c31822f
Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) ( flutter/engine#51239 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/50464546d92d..9ea8813ab4d4
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-200.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-199.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-198.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-197.0.dev
2024-03-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-196.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 22:55:58 +00:00
Jesús S Guerrero
06c1e204da
Skip impeller goldens on release branches ( flutter/engine#51237 )
...
https://github.com/flutter/flutter/issues/144700
2024-03-06 22:00:46 +00:00
Jonah Williams
749903e027
[Impeller] fold memory check into allocator_vk ( flutter/engine#51187 )
...
Various cleanups to Vulkan allocator implementation:
1. Fixes https://github.com/flutter/flutter/issues/137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.
Part of https://github.com/flutter/flutter/issues/144617
2024-03-06 20:10:55 +00:00
skia-flutter-autoroll
8ea6cd44a4
Roll Fuchsia Linux SDK from ujOkbeYbrC8loPbfR... to y67DIBX84h7pAekIp... ( flutter/engine#51233 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 19:58:17 +00:00
skia-flutter-autoroll
faac7b1f6e
Manual roll Dart SDK from 728fcf0bcbca to 50464546d92d (5 revisions) ( flutter/engine#51228 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/728fcf0bcbca..50464546d92d
2024-03-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-195.0.dev
2024-03-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-194.0.dev
2024-03-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-193.0.dev
2024-03-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-192.0.dev
2024-02-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-191.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 08:46:53 -08:00
skia-flutter-autoroll
63bb168431
Roll Skia from db3a36120ae2 to f17ec7494469 (3 revisions) ( flutter/engine#51226 )
...
https://skia.googlesource.com/skia.git/+log/db3a36120ae2..f17ec7494469
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 756dffd9e74f to 20d29a6cac1b
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 65414438feb7 to 756dffd9e74f (6 revisions)
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f7e1ef5d45e2 to 91a0358034d1 (16 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 06:51:32 +00:00
skia-flutter-autoroll
7160bada6e
Roll Skia from 1d1fd7fe1a89 to db3a36120ae2 (1 revision) ( flutter/engine#51222 )
...
https://skia.googlesource.com/skia.git/+log/1d1fd7fe1a89..db3a36120ae2
2024-03-05 penghuang@chromium.org dawn: fix DawnCaps.cpp compile errors with webgpu
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 02:59:11 +00:00
skia-flutter-autoroll
85a60e33ae
Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) ( flutter/engine#51216 )
...
https://skia.googlesource.com/skia.git/+log/37947aec8c5c..1d1fd7fe1a89
2024-03-05 jvanverth@google.com [graphite] Use internal class to manage DrawAtlas in SmallPathAtlas.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-06 01:18:05 +00:00
skia-flutter-autoroll
c715937d13
Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) ( flutter/engine#51211 )
...
https://skia.googlesource.com/skia.git/+log/17677914dabf..37947aec8c5c
2024-03-05 drott@chromium.org Iterate emoji color font tests over more color font formats
2024-03-05 penghuang@chromium.org Add Caps::getDepthAttachmentDimensions()
2024-03-05 brianosman@google.com Remove SK_LEGACY_SNAP_DRAW_IMAGE_TRANSLATION
2024-03-05 drott@chromium.org [Fontations-backend] Add an empty FontMgr for Fontations
2024-03-05 jvanverth@google.com [graphite] Atlas management fixes for SmallPathAtlas.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 22:57:48 +00:00
skia-flutter-autoroll
d706543640
Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) ( flutter/engine#51207 )
...
https://skia.googlesource.com/skia.git/+log/875b356e4d96..17677914dabf
2024-03-05 jvanverth@google.com Reland "[graphite] Rasterize SmallPathAtlas paths to the Plot backing store."
2024-03-05 johnstiles@google.com Reland "Use nmad in pow/log computation."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 21:19:21 +00:00
Chinmay Garde
db4a60e675
[Impeller] Implement YUV texture import and sampling for video player frames. ( flutter/engine#50730 )
...
This patch rounds out support for importing Android Hardware Buffers as Vulkan
images and sampling from them.
Not all Android Hardware Buffers are in formats that Vulkan (let alone Impeller)
understands. Some YUV textures have formats with no equivalent `vk::Format` enum
and need extra information on how to sample from them.
This patch adds support for correctly importing and sampling from such formats.
There are severe restrictions on how sampling from such external formats works.
For one, it isn’t possible to assign a combined image sampler in the render
pass. The pipeline itself needs to be rebuilt to reference a specially created
immutable sampler. This immutable sampler is a combination of the usual
information present in an Impeller SamplerDescriptor as well as a custom
“conversion” object obtained while importing the Android Hardware Buffer.
There is no way to predict what conversion object will be necessary ahead of
time as this will depend on the source of the Android Hardware Buffers and is
likely different for different video feeds, camera sources, and other Android
Hardware Buffer texture sources.
To handle this uncertainty, a new pipeline variant with a JIT determined
immutable sampler will be hashed and cached before being used in a render pass.
The number of pipeline variants created just-in-time will depend on the number
of sampler variants used in the render pass to sample from wrapped Image. For
instance, specifying a sampler with a different address mode will likely result
in a new pipeline variant being created.
In most cases however, there will just be one or two additional pipeline
variants per application. Impellers sampler diversity is very low with most
samplers being the usual NN samplers. It may be possible to preload even this
pipeline by trying known conversions. As said previously, there can only be a
handful of these conversions.
More restrictions on sampling from such images includes being limited to
`VK_FILTER_LINEAR` without additional format and extension wrangling and
performance penalties.
Fixes https://github.com/flutter/flutter/issues/142082 .
2024-03-05 12:42:51 -08:00
skia-flutter-autoroll
1af64b266a
Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) ( flutter/engine#51202 )
...
https://skia.googlesource.com/skia.git/+log/453cb0d04584..875b356e4d96
2024-03-05 johnstiles@google.com Remove flag guard for SK_RASTER_PIPELINE_FASTER_HUE_SAT_CLR_LUM.
2024-03-05 kjlubick@google.com Migrate CanvasKit to use modular build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 19:51:22 +00:00
skia-flutter-autoroll
a66c694ddf
Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) ( flutter/engine#51201 )
...
https://skia.googlesource.com/skia.git/+log/de108a9c8b54..453cb0d04584
2024-03-05 coldpalelight@gmail.com Fix rounding error in non-AA curve edge smoothing
2024-03-05 nscobie@google.com Reland "Enforce explicit OWNERS.android approval for generated SkUserConfig.h files"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 18:32:13 +00:00
Zachary Anderson
8928d5284c
Folds concurrent job calculation into tools/gn ( flutter/engine#51193 )
...
Folds the `get_concurrent_jobs.py` script into `tools/gn` and stops calling it with `exec_script()` during GN.
Part of https://github.com/flutter/flutter/issues/144430
2024-03-05 17:57:14 +00:00
skia-flutter-autoroll
46a92d295e
Roll Skia from 10058142c8a2 to de108a9c8b54 (4 revisions) ( flutter/engine#51199 )
...
https://skia.googlesource.com/skia.git/+log/10058142c8a2..de108a9c8b54
2024-03-05 egdaniel@google.com Fix native graphite vk jobs to use correct config.
2024-03-05 nscobie@google.com Revert "Enforce explicit OWNERS.android approval for generated SkUserConfig.h files"
2024-03-05 robertphillips@google.com Yet more stable keys
2024-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fc440afa62a7 to b978974d98eb (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 17:09:02 +00:00
skia-flutter-autoroll
f47498d99f
Roll Skia from 5839a94bf28b to 10058142c8a2 (2 revisions) ( flutter/engine#51197 )
...
https://skia.googlesource.com/skia.git/+log/5839a94bf28b..10058142c8a2
2024-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 65414438feb7 to cc6c9c14800c
2024-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5ba03c10e1a to 65414438feb7 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 15:58:23 +00:00
auto-submit[bot]
f29d809efb
Reverts "Reland: [macOS] Use CVDisplayLink to drive repaint ( #51126 )" ( flutter/engine#51192 )
...
Reverts flutter/engine#51126
Initiated by: cbracken
Reason for reverting: looks like this regressed Skia benchmarks: https://flutter-flutter-perf.skia.org/e/?keys=Xbf8dce9c233bce34d20e2280e3f1d8db&selected=commit%3D39653%26name%3D%2Carch%3Dintel%2Cbranch%3Dmaster%2Cconfig%3Ddefault%2Cdevice_type%3Dnone%2Cdevice_version%3Dnone%2Chost_type%3Dmac%2Csub_result%3DtimeToFirstFrameRasterizedMicros%2Ctest%3Dflutter_gallery_macos__start_up%2C&xbaroffset=39569
The regression s
Original PR Author: knopp
Reviewed By: {cbracken}
This change reverts the following previous change:
Original Description:
This relands the PR reverted in https://github.com/flutter/engine/pull/51095
Changes since the original PR:
- The macOS embedder does not assume particular clock when calling the embedder API, but converts CAMediaTime to engine time and back (`FlutterTimeConverter`)
- `FlutterVSyncWaiter` does not wait for displaylink callback during warmup frame. This should prevent `timeToFirstFrameRasterizedMicros` regressions.
- When enforcing frame pacing the raster thread is not blocked. This should prevent `average_frame_rasterizer_time_millis` regressions.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-05 03:25:18 +00:00
skia-flutter-autoroll
9b21b47a8a
Roll Skia from 9c62e7b382cf to a577399ed6fb (1 revision) ( flutter/engine#51190 )
...
https://skia.googlesource.com/skia.git/+log/9c62e7b382cf..a577399ed6fb
2024-03-05 johnstiles@google.com Revert "Use nmad in pow/log computation."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-05 02:40:22 +00:00
LongCatIsLooong
8fd9bbee17
Reland "Remove migration flag and unused header files #50216 " ( flutter/engine#50259 )
...
Forgot to update a pinned dependency in the previous attempt: https://github.com/flutter/tests/pull/340
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-05 02:17:05 +00:00
Gray Mackall
879a9147d9
[Re-land] Remove WindowManager reflection in SingleViewPresentation.java ( flutter/engine#50890 )
...
relands https://github.com/flutter/engine/pull/49996
Context b/326363243
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-03-04 23:49:38 +00:00
skia-flutter-autoroll
00654f0f36
Roll Skia from 9ab297bf1c34 to 9c62e7b382cf (1 revision) ( flutter/engine#51182 )
...
https://skia.googlesource.com/skia.git/+log/9ab297bf1c34..9c62e7b382cf
2024-03-04 nscobie@google.com Enforce explicit OWNERS.android approval for generated SkUserConfig.h files
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 23:43:14 +00:00
skia-flutter-autoroll
b6dae829cf
Roll Skia from f65ecbdfb09c to 9ab297bf1c34 (4 revisions) ( flutter/engine#51178 )
...
https://skia.googlesource.com/skia.git/+log/f65ecbdfb09c..9ab297bf1c34
2024-03-04 kjlubick@google.com Avoid use-after-move in SkShaper_harfbuzz
2024-03-04 johnstiles@google.com Remove divisions from Raster Pipeline blend ops.
2024-03-04 michaelludwig@google.com Use makeInset() for layer clip
2024-03-04 kjlubick@google.com Address clang tidy suggestions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,herb@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 22:12:05 +00:00
Matej Knopp
ac9586994e
Reland: [macOS] Use CVDisplayLink to drive repaint ( flutter/engine#51126 )
...
This relands the PR reverted in
https://github.com/flutter/engine/pull/51095
Changes since the original PR:
- The macOS embedder does not assume particular clock when calling the
embedder API, but converts CAMediaTime to engine time and back
(`FlutterTimeConverter`)
- `FlutterVSyncWaiter` does not wait for displaylink callback during
warmup frame. This should prevent `timeToFirstFrameRasterizedMicros`
regressions.
- When enforcing frame pacing the raster thread is not blocked. This
should prevent `average_frame_rasterizer_time_millis` regressions.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-04 21:57:45 +01:00
Jason Simmons
652c0e071c
Support gtest-parallel when running Impeller unit tests ( flutter/engine#51079 )
...
ImpellerC tests that use a temporary directory will append the current process ID to the directory name to avoid collisions.
The temporary directory will also be deleted after each test case completes.
See https://github.com/flutter/flutter/issues/143379
2024-03-04 20:17:07 +00:00
