5807 Commits

Author SHA1 Message Date
Danny Tuppeny
801ad5cd5a
Don't terminate Dart process pids from VM Service, record flutter_tools VM pid (#100223)
* Don't terminate Dart process pids from VM Service

These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
2022-03-23 16:31:31 +00:00
Danny Tuppeny
ea8aeb7427
[dap] Remove some code that's not longer required (#98928) 2022-03-22 14:20:12 -07:00
Anurag Roy
74f08c7352
[flutter_tools] Skip version freshness check for non-standard remotes (#97202) 2022-03-22 12:50:21 -07:00
Michael Goderbauer
8560d914eb
Upgrade to flutter_lints 2.0 (#99881) 2022-03-22 11:00:23 -07:00
Chris Bracken
fd3c34c9d4
[macOS] Use arm64 snapshot in arm64 App.framework (#100504)
Previously, https://github.com/flutter/flutter/pull/100271 enabled
building universal macOS binaries by default, but included a bug causing
the arm64 App.framework to be built such that the TEXT section
containing the app instructions built by gen_snapshot incorrectly
contained x86_64 instructions rather than arm64 instructions.

When building macOS (and iOS) apps, Flutter builds them in three
components:
* The Runner application: built by Xcode
* The bundled App.framework: built from assembly code generated by
  gen_snapshot from the application's Dart sources.
* The bundled FlutterMacOS.framework: built as part of the engine build
  and packaged by copying the distributed binary framework from our
  artifacts cache.

Building App.framework consists of the following steps:
* For each architecture, invoke gen_snapshot to generate
  architecture-specific assembly code, which is then built to object
  code and linked into an architecture-specific App.framework.
* Use the `lipo` tool to generate a universal binary that includes both
  x86_64 and arm64 architectures.

Previously, we were building architecture specific App.framework
binaries. However, for all architectures we were (mistakenly) invoking
the general `gen_snapshot` tool (which emitted x64 instructions, and
which is now deprecated) instead of the architecture-specific
`gen_snapshot_x86` and `gen_snapshot_arm64` builds which emit
instructions for the correct architecture.

This change introduces a small refactoring, which is to split the
`getNameForDarwinArch` function into two functions:
* `getDartNameForDarwinArch`: the name for the specified architecture as
  used in the Dart SDK, for example as the suffix of `gen_snapshot`.
* `getNameForDarwinArch`: the name for the specified architecture
  as used in Apple tools, for example as an argument to `lipo`. For
  consistency, and to match developer expectations on Darwin platforms,
  this is also the name used in Flutter's build outputs.

Issue: https://github.com/flutter/flutter/issues/100348
2022-03-21 20:36:57 -07:00
Jesús S Guerrero
50f3e47b67
Revert "[flutter_tools] remove pub dependencies from universal #97722" (#100508) 2022-03-21 19:20:10 -07:00
gaaclarke
97258979df
Revert "Starts using the --source flag to compile the dart registrant. (#98046) (#100493) 2022-03-21 13:40:23 -07:00
Dan Field
ff74557c3a
Specify destination when building for macOS (#100315)
Fixes #86590
2022-03-17 16:39:05 -07:00
Jesús S Guerrero
03b4f2bf50
[flutter_tools] process exception during linux_doctor is handled (#100159) 2022-03-17 16:15:22 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Christopher Fujino
e99a66a47e
[flutter_tools] check if stream is open before sending message in ios device (#99947) 2022-03-17 15:55:24 -07:00
Liam Appelbe
1d2f9c975b
Reintroduce the ability to override the coverage formatter (#100320) 2022-03-17 13:38:36 -07:00
Christopher Fujino
0d83e80104
[flutter_tools] Null safe update packages (#99357) 2022-03-17 13:35:17 -07:00
Chris Bracken
a618ca27a7
[macOS] Enable universal binary builds by default (#100271)
This changes the default build architectures for Flutter macOS apps to
x86_64 and arm64. Previously, we manually excluded arm64 builds via the
EXCLUDE_ARCHS Xcode setting in Flutter's generated xcconfig file. This
eliminates setting EXCLUDE_ARCHS during the build and updates the
default architectures in the tool and in the macos_assemble.sh wrapper.

Issue: https://github.com/flutter/flutter/issues/97681
Umbrella issue: https://github.com/flutter/flutter/issues/60113
2022-03-17 12:28:39 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
iroiroys
6f6b5647f5
Add more specific cause on web development tool error output (#98553) 2022-03-15 18:15:07 -07:00
Lau Ching Jun
722cbc52b8
Add portForwarder for ProxiedDevice. (#100111) 2022-03-15 14:30:21 -07:00
nicolasvac
201a64c98f
Fix flutter web app not respecting assets path when in non-root folder (#96774) 2022-03-10 15:50:16 -08:00
Jeff Ward
0aab22807c
First pass at using platform abstraction for plugins (#92672) 2022-03-09 14:10:21 -08:00
Lau Ching Jun
dbed10bb59
Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (#99791) 2022-03-09 00:30:17 -08:00
Jenn Magder
dd97133df2
Remove tool crash git.io link shortener (#99574) 2022-03-08 17:00:06 -08:00
Tacca
c8538873c8
95533 min sdk error msgs enhancements (#99550) 2022-03-08 16:20:21 -08:00
Felix
cd9e30bb5d
[flutter_tools] Fix Typo in tool error message (#97793)
Fixes a typo mutidex to multidex in a console hint to the user.
2022-03-08 15:24:51 -08:00
Jesús S Guerrero
fbbf3ec471
Support route on ios (#99078) 2022-03-07 11:31:21 -08:00
Anurag Roy
b02150781f
[flutter_tools] Add timeout duration to error and handle exceptions for HttpHostValidator. (#98290) 2022-03-07 11:21:06 -08:00
Jenn Magder
7596a3daf6
Add logging when first frame is not rendering (#99566) 2022-03-04 17:16:21 -08:00
Jonah Williams
59859df126
Add Windows performance benchmark (#99564) 2022-03-04 15:41:14 -08:00
Viren Khatri
671aa9e95e
complete migration of flutter repo to Object.hash* (#99505) 2022-03-04 12:56:21 -08:00
Mathieu Dubois-Briand
020bf31c99
Fix custom-device default forwardPortSuccessRegex (#97719) 2022-03-04 11:06:22 -08:00
Jenn Magder
8f360c977a
Update minimum required version to Xcode 13 (#97746) 2022-03-01 16:26:11 -08:00
gaaclarke
fdcd14464c
Starts using the --source flag to compile the dart registrant. (#98046)
* Starts using the `--source` flag to compile the dart registrant.

* updated general.shard tests

* Fixed the resident compiler flow

* added integration test

* made the integration test self contained

* renamed generated_main to dart_plugin_registrant

* cleaned up for review

* added task runner for ci

* added bringup and TESTOWNERS

* updated failure message
2022-03-01 16:24:47 -08:00
Emmanuel Garcia
9cb60c9828
Revert "reads min/target sdk versions from localproperties" (#99191) 2022-02-28 11:41:22 -08:00
Jenn Magder
c80ff45afe
Print events and views when first frame is taking awhile during tracing (#98957) 2022-02-28 11:16:12 -08:00
stuartmorgan
80660b2d5e
Work around VS CMake generation bug (#98945) 2022-02-26 11:56:22 -08:00
Jonah Williams
0a9a43b99a
Use flutter pub instead of dart pub (#99159) 2022-02-25 11:31:23 -08:00
Jenn Magder
9369bd3222
Wait for ios-deploy stdout before closing logLine stream (#99041) 2022-02-24 19:21:23 -08:00
Danny Tuppeny
76758ef960
[dap] Don't use --start-paused when running in Profile/Release mode (#98926) 2022-02-24 17:06:24 -08:00
Tacca
37a1aaf8c1
reads min/target sdk versions from localproperties (#98450) 2022-02-24 12:16:15 -08:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 (#98621) 2022-02-24 12:11:21 -08:00
Lau Ching Jun
6a9ac4509b
Add option in ProxiedDevice to only transfer the delta when deploying. (#97462) 2022-02-23 12:09:16 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Zachary Anderson
54a9d65282
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803) 2022-02-19 10:09:26 -08:00
Christopher Fujino
4b2e828924
[flutter_tools] deprecate the dev branch from the feature system (#98689) 2022-02-18 16:24:22 -08:00
Emmanuel Garcia
c8266d34f4
Improve Gradle retry logic (#96554) 2022-02-18 13:54:41 -08:00
Ben Konyi
4add01ab68
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#98769)
This reverts commit ac3c44355ae035b1e7f67881d956bcdfb8223e6f.
2022-02-18 13:28:42 -08:00
Ben Konyi
50c4720913
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc (#98513) 2022-02-18 12:32:08 -08:00
Tim Sneath
5c7ca2e738
Remove "beta-quality" for Windows (#98614) 2022-02-17 16:44:23 -08:00
Jenn Magder
cef6823637
Dump backtrace when cannot attach to observatory (#98550) 2022-02-16 14:10:18 -08:00
Christopher Fujino
4a11cc4b9c
[flutter_tools] do not validate maven upstream if cloud storage override provided (#98293) 2022-02-15 11:40:15 -08:00
Ben Konyi
2a2f973120
Update flutter_tools to look for new VM service message (#97683)
* Update flutter_tools to look for new VM service message

The Dart SDK will soon move away from the current Observatory message:

"Observatory listening on ..."

To a new message that no longer references Observatory:

"Dart VM Service listening on ..."

This change updates all tests with mocks to check for the new message
and also adds support for the new message in ProtocolDiscovery.

See https://github.com/dart-lang/sdk/issues/46756

* Fix some parsing locations

* Fix analysis failures

* Update message

* Remove extra comment

* Update message

* Add globals prefix
2022-02-15 07:33:57 -08:00