DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
30,410 Commits 882 Branches 1,069 Tags
Commit Graph

23192 Commits

Author SHA1 Message Date
skia-flutter-autoroll
2dad77487e Roll Skia from c74c10128334 to bddb07184f88 (1 revision) (flutter/engine#44214) 
https://skia.googlesource.com/skia.git/+log/c74c10128334..bddb07184f88

2023-08-01 jvanverth@google.com Revert "[graphite] Enable Vulkan draws and binding texture/samplers"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-01 13:06:39 +00:00
skia-flutter-autoroll
65f04dce63 Roll Skia from 177897b13a89 to c74c10128334 (4 revisions) (flutter/engine#44213) 
https://skia.googlesource.com/skia.git/+log/177897b13a89..c74c10128334

2023-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 143fa68f50b7 to 6dc0c9d62755 (13 revisions)
2023-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a0873d3f0d98 to fda6bb7fc626
2023-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1695fc6fc41d to a0873d3f0d98 (4 revisions)
2023-08-01 nicolettep@google.com [graphite] Enable Vulkan draws and binding texture/samplers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-01 11:48:20 +00:00
skia-flutter-autoroll
778d7e5c18 Roll Fuchsia Linux SDK from wIpcCOc0TtDYasQbl... to lwCo6le6r0X-Srvx3... (flutter/engine#44208) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-01 07:49:58 +00:00
skia-flutter-autoroll
bafe244e55 Manual roll Dart SDK from a58ca112af1c to aca45d2e133c (2 revisions) (flutter/engine#44203) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/a58ca112af1c..aca45d2e133c

2023-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-19.0.dev
2023-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-18.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-01 04:59:11 +00:00
David Worsham
716b6a2cd4 [fuchsia] Only use upstream vulkan headers (flutter/engine#44157) 
Stop using the special fuchsia headers, as they are contributing to
undefined behavior when building with LTO.
They are also no longer needed. All relevant fuchsia extensions were
upstreamed some time ago.

In the process, engage in some cleanup which means the "vulkan_config"
is also no longer needed. Rely on GN "public_deps" to provide the vulkan
include paths to various source sets.

See b/291462180 for more details on why this fix was neccesary.
 2023-08-01 13:17:14 +10:00
Matan Lurey
bc3b2e01ef [Impeller] Implement, non user-facing, dithering for LinearGradients. (flutter/engine#44181) 
Partial work towards https://github.com/flutter/flutter/issues/131450.

---

Run the Playground locally:

```bash
$ENGINE/out/host_debug_unopt/impeller_unittests \
  --enable_playground \
  --gtest_filter="*CanRenderLinearGradientWithDithering*"
```

Summary of changes:

- Added a playground/test for dithering disabled and enabled.
- Added `bool dither` to Impeller's `Paint`, but `SetDither` (use-facing) is ignored.
- Converted [Skia's dithering](f9de059517/src/opts/SkRasterPipeline_opts.h (L1717)) to GLSL and invoked it when `dither` is set.

## Before

![Screenshot 2023-07-31 at 1 29 16 PM](https://github.com/flutter/engine/assets/168174/51d2f7a0-dc22-44fe-b7f9-990b826c5fd9)

## After

![Screenshot 2023-07-31 at 1 29 25 PM](https://github.com/flutter/engine/assets/168174/78da2efe-2c5d-438f-b7f7-d8eb092c6a2c)

## Deleted Scenes

<details>
<summary>Here are some of my earlier attempts that are fun to share :)</summary>

![Screenshot 2023-07-31 at 11 35 07 AM](https://github.com/flutter/engine/assets/168174/719f97fc-1a3d-4920-8687-486c4de28b79)

![Screenshot 2023-07-31 at 12 12 38 PM](https://github.com/flutter/engine/assets/168174/ed262f83-442f-484b-8288-30e8e0d5e768)

![Screenshot 2023-07-31 at 12 19 56 PM](https://github.com/flutter/engine/assets/168174/057b1f95-fbd2-4ae2-bb25-8dd967cf8466)

![Screenshot 2023-07-31 at 12 25 59 PM](https://github.com/flutter/engine/assets/168174/34857c6e-49cd-40c1-9e91-646b7bfbf97c)

![Screenshot 2023-07-31 at 12 44 08 PM](https://github.com/flutter/engine/assets/168174/3b272428-b5be-4ca5-8cfe-1b12062a64f4)

</details>
 2023-08-01 02:02:25 +00:00
Chinmay Garde
4c6b677ded [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195) 
Saying this fixes the two linked issue pushes the bounds of credulity. But this is the best information we have ATM on how to fix the obscure "Invalid UUID" error. And, I have linked to the PR thread as a breadcrumb. Not sure how to do better 🤷🏽‍♂️.

Fixes https://github.com/flutter/flutter/issues/120326
Fixes https://github.com/flutter/flutter/issues/121430
 2023-08-01 00:04:23 +00:00
Chinmay Garde
ee65190753 [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196) 2023-07-31 23:43:01 +00:00
Siva
4f13581147 Manual roll of Dart with fixups to zircon system.dart (flutter/engine#44185) 
https://dart.googlesource.com/sdk.git/+log/4fd35600b477..0e02245635ea

Merge to Dart Version 3.2.0-16.0.dev
 2023-07-31 16:03:14 -07:00
Chinmay Garde
8b852e3aec [Impeller] Update guidance on how to run with Metal validation without Xcode. (flutter/engine#44190) 
Fixes https://github.com/flutter/flutter/issues/114202
 2023-07-31 22:43:29 +00:00
Ian Hickson
ddb2a2b8b3 Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189) 2023-07-31 22:32:17 +00:00
skia-flutter-autoroll
1b46ad1000 Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187) 
https://skia.googlesource.com/skia.git/+log/db813f4043fe..2e5f08012a92

2023-07-31 herb@google.com Update AutoTArray to always track size

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 22:07:08 +00:00
Chinmay Garde
e494c2f4df [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186) 
The website was updated in https://github.com/flutter/website/pull/9114/files
 2023-07-31 21:54:52 +00:00
Chinmay Garde
70d6d7cb22 [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183) 2023-07-31 21:24:12 +00:00
skia-flutter-autoroll
3cbc4eaedf Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182) 
https://skia.googlesource.com/skia.git/+log/06174bc8f4d5..db813f4043fe

2023-07-31 herb@google.com Use unique_ptr in THashTable

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 21:12:48 +00:00
Jason Simmons
3bb1764557 [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171) 
In https://github.com/flutter/engine/pull/41059 the Android context and surface were changed to share one impeller::ContextVK across all instances of AndroidSurfaceVulkanImpeller.  However, the ContextVK holds a reference to the current swapchain.  If an app uses multiple AndroidSurfaceVulkanImpeller instances (e.g. for platform views), then one surface may overwrite the ContextVK's swapchain while another surface is trying to render.

This patch allows each surface to get its own impeller::Context instance holding a swapchain tied to that surface.  The per-surface contexts will delegate most operations to the shared parent ContextVK.
 2023-07-31 20:49:11 +00:00
skia-flutter-autoroll
722441b8f5 Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179) 
https://skia.googlesource.com/skia.git/+log/ea0c9c0935ae..06174bc8f4d5

2023-07-31 brianosman@google.com Remove Debian10-GCC jobs and docker support
2023-07-31 johnstiles@google.com Remove ModifiersPool entirely.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 20:05:20 +00:00
skia-flutter-autoroll
e7a92219bb Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177) 
https://skia.googlesource.com/skia.git/+log/9c12eb0e158a..ea0c9c0935ae

2023-07-31 brianosman@google.com Switch GCC jobs on CQ to Debian-11/GCC-10.3
2023-07-31 johnstiles@google.com Move storage of Layout to ExtendedVariable.
2023-07-31 kjlubick@google.com Make deleteBackendTexture take a const reference
2023-07-31 johnstiles@google.com Split Variable modifiers() into layout() and modifierFlags().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 19:20:37 +00:00
skia-flutter-autoroll
d3dc6b8fcd Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173) 
https://skia.googlesource.com/skia.git/+log/685e29df6704..9c12eb0e158a

2023-07-31 johnstiles@google.com Avoid mutating parameter flags after creation.
2023-07-31 johnstiles@google.com Remove builtin-layout values for runtime effect parameters.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 18:35:20 +00:00
skia-flutter-autoroll
1d8a35d3ca Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170) 
https://skia.googlesource.com/skia.git/+log/cb61dd4af8a5..685e29df6704

2023-07-31 brianosman@google.com Add Debian11-GCC jobs
2023-07-31 drott@chromium.org [Fontations] Move C++ side to pure virtual interfaces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 16:39:54 +00:00
skia-flutter-autoroll
7a143cd26b Roll Skia from 6ee21fa70879 to cb61dd4af8a5 (1 revision) (flutter/engine#44165) 
https://skia.googlesource.com/skia.git/+log/6ee21fa70879..cb61dd4af8a5

2023-07-31 johnstiles@google.com Remove ModifiersPool usage from ModifiersDeclaration.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 15:50:55 +00:00
skia-flutter-autoroll
8ccb4ff473 Roll Skia from 3febb7d97cb0 to 1146dd2212ba (1 revision) (flutter/engine#44158) 
https://skia.googlesource.com/skia.git/+log/3febb7d97cb0..1146dd2212ba

2023-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5724c6b09fee to 1695fc6fc41d (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-31 05:36:22 +00:00
Chinmay Garde
3ac37e1133 [Impeller] Update documentation on RenderDoc frame capture. (flutter/engine#44124) 
Fixes https://github.com/flutter/flutter/issues/131461
 2023-07-29 20:16:16 +00:00
skia-flutter-autoroll
541cf5af1d Roll Fuchsia Linux SDK from 1KABCKdr8VToJTlt-... to -5L2wI7BjRNgnccfl... (flutter/engine#44136) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-29 13:02:30 +00:00
skia-flutter-autoroll
aed2018dfe Roll Skia from 7dca9cd5bf70 to 2c964e925435 (1 revision) (flutter/engine#44128) 
https://skia.googlesource.com/skia.git/+log/7dca9cd5bf70..2c964e925435

2023-07-29 ajgo@chromium.org Prime expat's hash salt on Windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-29 04:02:21 +00:00
skia-flutter-autoroll
56900c9074 Roll Skia from 7fe2e36ea05e to 7dca9cd5bf70 (1 revision) (flutter/engine#44126) 
https://skia.googlesource.com/skia.git/+log/7fe2e36ea05e..7dca9cd5bf70

2023-07-29 michaelludwig@google.com Revert "[skif] Update MatrixConvolution to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-29 02:10:03 +00:00
skia-flutter-autoroll
21160c257a Roll Fuchsia Linux SDK from OMmwdXn8XxipooPBo... to 1KABCKdr8VToJTlt-... (flutter/engine#44123) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 23:51:21 +00:00
skia-flutter-autoroll
af48f817f8 Roll Skia from 4c3594988d77 to 7fe2e36ea05e (1 revision) (flutter/engine#44120) 
https://skia.googlesource.com/skia.git/+log/4c3594988d77..7fe2e36ea05e

2023-07-28 brianosman@google.com Fix some GCC warnings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 23:03:49 +00:00
Jonah Williams
d51e84f5f2 [Impeller] revert removal of wait until scheduled. (flutter/engine#44121) 
More context is "See also", but this doesn't work for applications with particularly high application load.

Reverts https://github.com/flutter/engine/pull/42160

Fixes https://github.com/flutter/flutter/issues/131490

See also : https://github.com/flutter/flutter/issues/131520
 2023-07-28 23:02:22 +00:00
skia-flutter-autoroll
b719c54ccf Roll Skia from 8f734fbb34a7 to 4c3594988d77 (9 revisions) (flutter/engine#44119) 
https://skia.googlesource.com/skia.git/+log/8f734fbb34a7..4c3594988d77

2023-07-28 michaelludwig@google.com [skif] Update MatrixConvolution to use FilterResult
2023-07-28 michaelludwig@google.com [graphite] Split cubic and regular image shader snippets
2023-07-28 johnstiles@google.com Split apart Layout and flags in SkSL fields.
2023-07-28 johnstiles@google.com Remove Layout from FunctionDeclaration.
2023-07-28 johnstiles@google.com Make ModifierFlags into a full-fledged class.
2023-07-28 johnstiles@google.com Migrate Layout-checking code into SkSLLayout.
2023-07-28 brianosman@google.com Add Debian-11 docker files
2023-07-28 penghuang@chromium.org graphite: use target texture info instead of color type to make copy
2023-07-28 jvanverth@google.com Reland "[graphite] Move rescale code to separate utility function."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 22:07:04 +00:00
Jason Simmons
208c8eb4bf Set the required Android API level when Vulkan validation layers are automatically enabled for android_debug_unopt_arm64 builds (flutter/engine#44116) 
The Vulkan validation layer headers will not build if the Android API level is 23 or lower.

Currently the engine buildroot's default Android API level is 23.  The API level must be overridden for any configuration where Vulkan validation is enabled.
 2023-07-28 21:44:50 +00:00
yaakovschectman
cae74e2674 Listen to window notifications to update application lifecycle (flutter/engine#43558) 
Use `WM_SIZE, WM_SHOWWINDOW, WM_SETFOCUS, and WM_KILLFOCUS` to update
the application lifecycle state on Windows.

https://github.com/flutter/flutter/issues/103637

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Brandon DeRosier <bdero@google.com>
Co-authored-by: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
 2023-07-28 16:48:36 -04:00
Tong Mu
585acdf97b Remove a temporary lint ignore (flutter/engine#44091) 
[The issue](https://github.com/dart-lang/linter/issues/4562) has been resolved.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-28 19:48:11 +00:00
Camille Simon
39cbbd22a3 [Android] Removes handling of Flutter splash screen (flutter/engine#44047) 
Fixes https://github.com/flutter/flutter/issues/105173.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-07-28 18:08:35 +00:00
skia-flutter-autoroll
456ee04c63 Roll Skia from c98a755dff8e to 8f734fbb34a7 (3 revisions) (flutter/engine#44108) 
https://skia.googlesource.com/skia.git/+log/c98a755dff8e..8f734fbb34a7

2023-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 074ef48b9cd5 to efb70f7806ac (5 revisions)
2023-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 5724c6b09fee to 0c9cbe84b2cb
2023-07-28 johnstiles@google.com Add explicit to SkEnumBitMask::operator bool.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 17:09:13 +00:00
Dan Field
f6bbd12456 [Impeller] Avoid culling when the current matrix has perspective. (flutter/engine#44089) 
Fixes https://github.com/flutter/flutter/issues/130613

Before this patch, the test would fail to render anything because the culling would decide it fell outside the cull rect when the transform has perspective sometimes. We should fix our Rect::TransformBounds implementation, but I can't quite seem to get it happy enough here so I'm just bailing out on culling if there is perspective instead, which is safe. This also makes the patch a bit easier/safer to cherry pick since it's a simple de-optimization when perspective is involved for the sake of fidelity, instead of a larger change that may have other side effects.

Filed https://github.com/flutter/flutter/issues/131445 to track the perspective issue.
 2023-07-28 15:18:54 +00:00
Jackson Gardner
12c34f4b33 Roll Chrome to 115 (flutter/engine#44076) 
Update the version of Chrome we use for unit tests to 115.
 2023-07-28 15:03:05 +00:00
skia-flutter-autoroll
427947ee0e Roll Dart SDK from 1b85515a995b to e9bdbe308478 (1 revision) (flutter/engine#44104) 
https://dart.googlesource.com/sdk.git/+log/1b85515a995b..e9bdbe308478

2023-07-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-12.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 14:46:17 +00:00
skia-flutter-autoroll
636babf422 Roll Skia from f538575451a8 to c98a755dff8e (1 revision) (flutter/engine#44103) 
https://skia.googlesource.com/skia.git/+log/f538575451a8..c98a755dff8e

2023-07-28 kjlubick@google.com Remove gl-mock hack

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 14:03:06 +00:00
skia-flutter-autoroll
70ae1b1b87 Roll Fuchsia Linux SDK from wgkZmRBHTT7DehhUL... to OMmwdXn8XxipooPBo... (flutter/engine#44101) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 11:07:04 +00:00
skia-flutter-autoroll
af2b4fba2e Roll Dart SDK from aab0233f76b7 to 1b85515a995b (1 revision) (flutter/engine#44096) 
https://dart.googlesource.com/sdk.git/+log/aab0233f76b7..1b85515a995b

2023-07-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-11.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 06:05:26 +00:00
Matan Lurey
88cfeedf51 [Impeller] Set 'enable_vulkan_validation_layers' if --unopt and Vulkan is enabled. (flutter/engine#44055) 
Context:

> @matanlurey:
> Would it make sense for `--unopt` to imply
`--enable-vulkan-validation-layers` if `--enable-vulkan` is set?
> The reason I ask is because it does seem to imply `glGetError` checks,
which (I could be wrong) is roughly similar?

> @chinmaygarde:
> Makes sense.

... so uh, here it is (let me know if we prefer anything different).
 2023-07-27 22:48:22 -07:00
skia-flutter-autoroll
e82c9d9c4a Roll Skia from f2362d22abcf to 8739fd6d422c (1 revision) (flutter/engine#44095) 
https://skia.googlesource.com/skia.git/+log/f2362d22abcf..8739fd6d422c

2023-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3fc36175ddcf to 5724c6b09fee (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 05:38:03 +00:00
skia-flutter-autoroll
92c97ed9b9 Roll Dart SDK from e851b8e49ade to aab0233f76b7 (2 revisions) (flutter/engine#44092) 
https://dart.googlesource.com/sdk.git/+log/e851b8e49ade..aab0233f76b7

2023-07-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-10.0.dev
2023-07-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-9.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-28 01:57:09 +00:00
Qun Cheng
58c5cbd17f Add Expanded/Collapsed state for SubmenuButton (flutter/engine#43983) 
This PR is to add support for the expanded/collapsed-state semantics flag to the engine. After adding another PR to Flutter, we will be able to support the expanded/collapsed state in semantics for submenu buttons.

Related to [#127617](https://github.com/flutter/flutter/issues/127617) in flutter
 2023-07-28 00:49:12 +00:00
skia-flutter-autoroll
1347d4dc89 Roll Skia from 100d67ed0b61 to 5403af73dfef (4 revisions) (flutter/engine#44088) 
https://skia.googlesource.com/skia.git/+log/100d67ed0b61..5403af73dfef

2023-07-27 mike@reedtribe.org Unfriend nearly everyone from SkGlyph
2023-07-27 johnstiles@google.com Convert layout flags to SkEnumBitMask.
2023-07-27 johnstiles@google.com Convert WGSLCodeGenerator::FunctionDependencies to SkEnumBitMask.
2023-07-27 armansito@google.com [graphite][compute] Support samplers in ComputeSteps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-27 23:26:50 +00:00
skia-flutter-autoroll
abd0da6c70 Roll Skia from d3a7efb77af3 to 100d67ed0b61 (1 revision) (flutter/engine#44086) 
https://skia.googlesource.com/skia.git/+log/d3a7efb77af3..100d67ed0b61

2023-07-27 johnstiles@google.com Move SkSL modifier flags into an SkEnumBitMask.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-27 22:15:08 +00:00
skia-flutter-autoroll
2a6bfcadab Roll Fuchsia Linux SDK from FwIA6BaHtZg2mRS-0... to wgkZmRBHTT7DehhUL... (flutter/engine#44084) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-27 21:50:03 +00:00
skia-flutter-autoroll
c942ed6dc4 Roll Skia from 20108acef7d2 to d3a7efb77af3 (2 revisions) (flutter/engine#44082) 
https://skia.googlesource.com/skia.git/+log/20108acef7d2..d3a7efb77af3

2023-07-27 michaelludwig@google.com Revert "[graphite] Move rescale code to separate utility function."
2023-07-27 jamesgk@google.com [graphite] Rename "ssbo"-related stuff to "uniform"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-07-27 21:29:16 +00:00
Renzo Olivares
e29f713d01 [iOS] TextInputPlugin should batch TextEditingDeltas and dispatch on the next runLoop (flutter/engine#43267) 
Fixes https://github.com/flutter/flutter/issues/129061
 2023-07-27 20:56:07 +00:00