Jonah Williams
00495da0b5
Revert "[framework] use shader tiling instead of repeated calls to drawImage" ( #124640 )
...
Reverts flutter/flutter#119495
We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
2023-04-15 22:04:20 +00:00
Jonah Williams
d1d426e5a8
[cupertino] improve cupertino picker performance by using at most one opacity layer ( #124719 )
...
Fixes https://github.com/flutter/flutter/issues/124703
Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.
Before:
Doesn't finish, 100s of passes
After:
See also:
https://github.com/flutter/flutter/issues/124658
2023-04-15 22:00:48 +00:00
hangyu
4d6ef78ca5
Add optional labelText and semanticLabel to Checkbox ( #124555 )
...
Re-open from https://github.com/flutter/flutter/pull/116551
This PR added optional labelText (which will be rendered side by side with Checkbox in the future, and thus is also announced by default by screen readers), and semanticLabel(which will be announced by screen reader if provided, overrides labelText, in order to do that we might want to wrap the Text widget inside ExcludeSemantics in the future).
Issues fixed:
[b/239564167]
2023-04-14 22:40:10 +00:00
Justin McCandless
119744a63c
iOS context menu shadow ( #122429 )
...
Update the visuals of the iOS context menu to match iOS 16.3.1 more closely.
2023-04-14 10:43:17 -07:00
Tirth
aa8cc44e03
[CupertinoListSection] adds new property separatorColor ( #124803 )
...
Adds new property `separatorColor` to `CupertinoListSection` widget.
Fixes : #124744
### `separatorColor` property is null
<img src="https://user-images.githubusercontent.com/13456345/231840875-22605c23-ee9f-464f-a005-c9fce1b641a7.png " width=350>
### `separatorColor` property is not-null
| Color.fromARGB(255, 136, 13, 207) | Color.fromARGB(255, 13, 62, 207) | Color.fromARGB(255, 29, 207, 13) |
| --- | --- | --- |
|  |  |  |
2023-04-14 17:19:19 +00:00
Taha Tesser
4c41c0dbcd
Fix CupertinoContextMenu throws exception on route animation ( #124785 )
...
Fix `CupertinoContextMenu` throws exception on route animation
2023-04-14 01:59:11 +00:00
Taha Tesser
55dc9f93ea
Refactor SliverAppBar.medium & SliverAppBar.large to fix several issues ( #122542 )
...
Refactor `SliverAppBar.medium` & `SliverAppBar.large` to fix several issues
2023-04-13 18:54:08 +00:00
Justin McCandless
62cb61d3f3
Improve the docs around the TextSelectionHandleControls deprecations ( #123827 )
...
Explain how to do the two-step migration to the context menus feature.
2023-04-13 10:13:13 -07:00
Justin McCandless
8abeefef91
Localize the 'No Replacements Found' spell check string ( #124259 )
...
Localize the 'No Replacements Found' spell check string
2023-04-12 22:15:05 +00:00
Bernardo Ferrari
2e4d976bde
SemanticsFlag/SemanticsAction cleanup (part 4) (#123329 )
...
`SemanticsFlag`/`SemanticsAction` cleanup (part 4)
2023-04-12 19:07:08 +00:00
Nabeel Parkar
6d01ae1377
Bug report 2 issue template ( #122385 )
...
Bug report 2 issue template
2023-04-12 11:06:16 +00:00
Bernardo Ferrari
56e4f8e0ff
Add StrokeCap to CircularProgressIndicator ( #122664 )
...
Add `StrokeCap` to `CircularProgressIndicator`
2023-04-12 00:35:46 +00:00
Gabriel Gava
ee0b67dd8a
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList ( #124459 )
...
Exposed EdgeDraggingAutoScroller velocityScalar to ReorderableList
2023-04-12 00:07:20 +00:00
xubaolin
328635b3df
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics ( #123109 )
...
DraggableScrollableSheet & NestedScrollView should respect NeverScrollableScrollPhysics
2023-04-12 00:01:11 +00:00
Justin McCandless
f5c1fb1d26
Remove deprecations from TextSelectionHandleControls instances ( #124611 )
...
Moves to a two-step deprecation process for context menus, avoiding immediate breaking changes.
2023-04-11 16:43:40 -07:00
pdblasi-google
6839b3cbd6
Adds dart_fix support to flutter_test ( #124347 )
...
Adds `dart_fix` support to `flutter_test`
2023-04-11 21:09:07 +00:00
Chris Bobbe
952ace627f
BottomAppBar: Fix doubled layers of color and shadow ( #123294 )
...
Fixes BottomAppBar with translucent colors.
2023-04-11 11:21:13 -07:00
Aditya Thakur
c9f23b0bc2
Fix ShaderMask Example issue ( #124511 )
...
Fix ShaderMask Example issue
2023-04-11 18:17:53 +00:00
Tae Hyung Kim
3c18f57480
Sliver Constrained Cross Axis ( #124337 )
...
Sliver Constrained Cross Axis
2023-04-10 21:15:48 +00:00
chunhtai
f662f2efe8
ExpansionTile audit ( #124281 )
...
ExpansionTile audit
2023-04-10 20:22:54 +00:00
Callum Moffat
535b4d5ec3
Reduce macOS overscroll friction ( #122142 )
...
Reduce macOS overscroll friction
2023-04-10 19:34:51 +00:00
joshualitt
191465ac6f
[web] Migrate the bulk of JS interop to JS types. ( #123286 )
2023-04-10 12:08:26 -07:00
luckysmg
f4cd897e7e
[Text Input] Only unfocus when receive connectionClosed on platform except web ( #123929 )
...
[Text Input] Only unfocus when receive connectionClosed on platform except web
2023-04-10 02:09:21 +00:00
Christopher Fujino
3ea2d72446
document StaticIconProvider ( #120935 )
...
document StaticIconProvider
2023-04-08 02:45:14 +00:00
Greg Spencer
ba097e2371
Prepare for adding values to AppLifecycleState ( #119954 )
...
Prepare for adding values to AppLifecycleState
2023-04-08 02:43:23 +00:00
Bruno Leroux
9f98f63585
Fix InkWell ripple visible on right click when not expected ( #124386 )
...
Right clicking an InkWell with no secondary tap handlers will no longer cause a ripple.
2023-04-07 16:02:14 -07:00
chunhtai
e5e765e683
Reland Refactor reorderable list semantics ( #124395 )
...
Reland Refactor reorderable list semantics
2023-04-07 17:47:06 +00:00
chunhtai
9884b5f55e
Fixes IgnorePointer and AbsorbPointer to only block user interactions… ( #120619 )
...
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
2023-04-07 15:51:05 +00:00
Bruno Leroux
aa6a0a9dea
Fix EditableText misplaces caret when selection is invalid ( #123777 )
...
Fix EditableText misplaces caret when selection is invalid
2023-04-07 04:52:30 +00:00
Xilai Zhang
e749db6f91
Revert "Refactor reorderable list semantics" ( #124368 )
...
Revert "Refactor reorderable list semantics"
2023-04-07 01:46:06 +00:00
Greg Spencer
692a7efa3f
Initialize ThemeData.visualDensity using ThemeData.platform instead of defaultTargetPlatform ( #124357 )
...
Initialize `ThemeData.visualDensity` using `ThemeData.platform` instead of `defaultTargetPlatform`
2023-04-07 01:44:23 +00:00
Henry Riehl
73996ea40b
Add vertical alignment offset to the ``MenuAnchor`` widget when overflowing ( #123740 )
...
Positioning of cascading menus.
2023-04-06 16:57:30 -07:00
Michael Goderbauer
9ebd4b49f7
Fix double the ( #124236 )
...
Fix double the
2023-04-06 22:29:24 +00:00
chunhtai
94327e7aa8
Refactor reorderable list semantics ( #123263 )
...
Refactor reorderable list semantics
2023-04-06 22:01:03 +00:00
Tirth
6338ab1575
[DropdownMenu] add helperText & errorText to DropdownMenu Widget ( #123775 )
...
[DropdownMenu] add helperText & errorText to DropdownMenu Widget
2023-04-06 21:33:21 +00:00
Justin McCandless
e4f2d61b5c
TextSelectionHandleControls deprecation deletion timeframe ( #124262 )
...
Make sure the removal of deprecated APIs TextSelectionControls.buildToolbar and TextSelectionHandleControls happen in two separate steps. Will make a tricky migration situation a little easier for affected users.
2023-04-06 14:00:22 -07:00
Ian Hickson
806c1f8186
Deprecate these old APIs ( #116793 )
...
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Gregory Conrad
4fc78b9355
Fix a memory leak in AutomaticKeepAlive ( #124163 )
...
Fix a memory leak in `AutomaticKeepAlive`
2023-04-06 18:17:56 +00:00
Tirth
743fcf7fcc
[Docs] Fix Typos ( #124249 )
...
[Docs] Fix Typos
2023-04-06 15:43:21 +00:00
Loune Lam
5eb236c3c5
Remove mouse tap text drag selection throttling to improve responsiveness ( #123460 )
...
Remove mouse tap text drag selection throttling to improve responsiveness
2023-04-06 13:32:55 +00:00
Michael Goderbauer
98f35be7d9
Fix error about missing MediaQuery ( #124243 )
2023-04-05 22:19:30 -07:00
Qun Cheng
3a4fb9df4f
Fix search view position ( #124169 )
2023-04-05 16:27:45 -07:00
Renzo Olivares
90f8ac5b41
TapAndDragGestureRecognizer should declare victory immediately when drag is detected ( #123055 )
...
TapAndDragGestureRecognizer should declare victory immediately when drag is detected
2023-04-05 23:00:52 +00:00
Loïc Sharma
6058e95919
Add CallbackShortcuts example ( #123944 )
...
Add CallbackShortcuts example
2023-04-05 22:17:59 +00:00
Camille Simon
bc0cbc15d6
Add spell check TextSpan creation logic that doesn't rely on composing region ( #123481 )
...
Fixes https://github.com/flutter/flutter/issues/119534 by adding extra
logic to allow the proper `TextSpan` trees to be build with spell check
results that does not rely on the composing region.
Also, refreshes the algorithm used to correct spell check results to
improve cases where spell check results are out of date, but the
composing region line does not help smooth over this fact by giving the
framework extra time to update while a word is being composed (because a
composing region line would cover up any flashing red underlines).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-05 14:43:56 -07:00
Kate Lovett
0cfcdeec89
Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation" ( #124226 )
...
Revert "Fix scrolling in the `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation"
2023-04-05 16:10:32 +00:00
hellohuanlin
d1b8527f6b
[platform_view]fix iOS platform view's focus node leakage ( #124066 )
...
[platform_view]fix iOS platform view's focus node leakage
2023-04-05 03:56:51 +00:00
Taha Tesser
38805a4392
Fix clipBehavior for Drawer with shape and add clipBehavior property. ( #124104 )
2023-04-04 16:23:32 -07:00
chunhtai
9e4b5fb7d9
Adds i18n to widget layer ( #123620 )
...
Adds i18n to widget layer
2023-04-04 22:57:35 +00:00
Rydmike
be5a84295d
FIX: SegmentedButton segments background cannot be made transparent ( #123293 )
2023-04-04 15:38:20 -07:00
