5536 Commits

Author SHA1 Message Date
Hey24sheep
bec1b9a15c Optimize gesture recognizer instantiation (#35979) 2019-07-13 10:33:21 -07:00
chunhtai
fc7bd6ad24
refactor out selection handlers (#35207) 2019-07-12 12:13:50 -07:00
Dan Field
7a20148548
Add colorFilterLayer/Widget (#35468) 2019-07-11 15:49:51 -07:00
LongCatIsLooong
539f09f801
Remove _debugWillReattachChildren assertions from _TableElement (#34202) 2019-07-11 13:54:51 -07:00
Greg Spencer
e8fbdd85f0
Add example showing how to move from one field to the next. (#35926)
This adds an example of how to move to the "next" field when using TextInputAction.next. This is all that is needed to have "next field" functionality in a field. I thought about making it the default when handling the "next" or "previous" actions, but it's better that the developer has control over whether or not they actually move to the next field, and within which scope.
2019-07-11 07:56:30 -07:00
Greg Spencer
3b945da00d
Change focus example to be more canonical (and correct), listening to the focus node for changes. (#35913)
This changes the example for FocusNode to be more correct, listening to the focus node for changes, instead of assuming that it is the only one doing the changing.
2019-07-10 16:49:32 -07:00
Justin McCandless
ff53fbe194
Text selection menu show/hide cases (#35219)
Show and hide the text selection menu at the correct time with various gestures in the text field.
2019-07-10 14:08:14 -07:00
Tom Robinson
ef42c36ab0
Cleanup widgets/sliver_persistent_header.dart with resolution of dart-lang/sdk#31543 (#35828)
* Remove extra classes.

Now that https://github.com/dart-lang/sdk/issues/31543 is fixed, we
can remove extra classes.

* Add snapConfiguration to parameters for _RenderSliverFloatingPersistentHeaderForWidgets and _RenderSliverFloatingPinnedPersistentHeaderForWidgets constructors.
2019-07-10 13:54:27 -07:00
rami-a
70bb5d1d5a
Add flag to use root navigator for showModalBottomSheet (#35878)
* Add flag to use root navigator for showModalBottomSheet

* Add documentation

* Add tests

* Address feedback and fix analyzer issues

* Address feedback

* Update comments
2019-07-10 16:07:15 -04:00
Kate Lovett
14e4565fa4
Doc fixes (#35892)
* Fixed assets embedding

* ++

* Completed snippet audit

* Analyzer
2019-07-10 12:40:35 -07:00
Shi-Hao Hong
e7ef75680e
Update Dark Theme disabledColor to White38 (#35136)
* Add Colors.white38

* Update ThemeData.disabledColor and ButtonThemeData.disabledColor to Colors.white38

* Update pre-existing tests to expect Colors.white38 instead of Colors.white30

* Update API documentation to reflect these changes
2019-07-10 08:50:24 -07:00
Greg Spencer
e3a08d2392
Remove reverseDuration from implicitly animated widgets, since it's ignored. (#35785)
When I added reverseDuration to animation controllers in #32730, I also added it to the implicit animations that Flutter has. However, as @efortuna pointed out to me, it doesn't actually do anything there, since all of the intrinsic animations run forwards, not in the reverse direction, and there's no way to reverse them.

So, this PR removes the reverseDuration argument from the implicit animations to avoid confusion.

Fixes #35769
2019-07-10 08:18:26 -07:00
John Ryan
871b58986d
add sample code for AnimatedContainer (#35225)
* add sample code for AnimatedContainer

* use stateful_widget_scaffold snippet template

* add sample explanation

* add setState() to example assumptions for analyzer

* update description

* use snippet instead of sample

* change sample to match assets-for-api-docs

* remove constant

* update AnimatedContainer sample description

add indication the example is depicted by the video and animates when
tapped

* fix example formatting

* make sample conform to 80 col limit

* add "implemented below" to illustration description

* formatting for readability
2019-07-09 15:34:39 -07:00
Darren Austin
af1bd09c78
Added MaterialApp.themeMode to control which theme is used. (#35499)
Added support for a themeMode property to the MaterialApp to control
how the light or dark theme is selected.
2019-07-09 15:26:42 -07:00
Gary Qian
9c1783e989
Update TextStyle and StrutStyle height docs (#33281) 2019-07-09 10:38:01 -07:00
Anthony
aae50f541a
[Material] Text scale and wide label fixes for Slider and Range Slider value indicator shape (#35496)
Various bug fixes for Slider and Range Slider value indicator around accessibility and wide labels.
2019-07-09 13:26:10 -04:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget (#32511) 2019-07-09 10:18:30 -07:00
Kate Lovett
97b2c98642
Navigator pushAndRemoveUntil Fix (#35223)
* Initial work

* ++

* Updated tests

* Moved TestObserver out for access across tests.

* ++

* Added hero tests

* Review feedback

* simplified preceding route overlay

* Review feedback

* trailing doc slash
2019-07-09 10:17:30 -07:00
Hiroki Matsue
0e7cfc1e41 Add missing [applicationIcon] property to LicensePage widget (#34906)
* Add missing [applicationIcon] property to LicensePage widget
2019-07-08 17:30:28 -07:00
Michael Goderbauer
4e973adc79
Various doc fixes (#35548) 2019-07-08 17:02:25 -07:00
Dan Field
39baa0995c
Fix semantics for floating pinned sliver app bar (#35574) 2019-07-08 14:02:42 -07:00
Jonah Williams
cac8835de3
Update annotated region findAll implementation to use Iterable (#35725) 2019-07-08 13:32:59 -07:00
Shi-Hao Hong
2ba85a22dd
Simple Doc Fixes (#35743)
* Fix "the a" typos

* Rephrase global key API doc description
2019-07-08 10:42:08 -07:00
Chris Yang
49cce98483
add documentation: conic path clipping not supported for UIKitView (#35063) 2019-07-08 08:24:23 -07:00
Gary Qian
a0c47e2216
Do not use ideographic baseline for RenderPargraph baseline (#35493) 2019-07-03 15:04:18 -07:00
Dan Field
f85630b18a
Fix RenderFittedBox when child.size.isEmpty (#35487) 2019-07-03 12:40:06 -07:00
chunhtai
f143fd6a4f
fix Selection handles position is off (#34665) 2019-07-03 10:50:10 -07:00
Michael Goderbauer
d41eeeb50d
Include tags in SemanticsNode debug properties (#35491) 2019-07-03 09:13:37 -07:00
Michael Goderbauer
4ca7bfa0c2
Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' (#35492) 2019-07-03 09:13:09 -07:00
Justin McCandless
2d2bb6bf92
CupertinoTextField vertical alignment (#34723)
CupertinoTextField now supports vertical alignment via the textAlignVertical parameter.
2019-07-03 08:22:31 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Dan Field
e2a55fe83f
update reassemble doc (#35164) 2019-07-02 11:11:48 -07:00
Tong Mu
1a374d820d
New parameter for RawGestureDetector to customize semantics mapping (#33936)
This PR adds a new parameter to RawGestureDetector, `semantics`, which configures how detectors handle semantics gestures. It has a default delegate that keep the current behavior.
2019-07-01 16:17:11 -07:00
Shi-Hao Hong
ddd5ccd011
Add Container fallback to Ink build method (#35282)
* Add Container fallback to Ink build method

* Add tests for Ink container fallback
2019-07-01 08:28:34 -07:00
Dan Field
9e1b4b22c2
tests for about page (#35290) 2019-06-30 22:40:09 -07:00
Dan Field
3eb40925e5
Always test semantics (#35110)
Default `semanticsEnabled` to true for `testWidgets` and fix associated bugs
2019-06-28 12:40:23 -07:00
MH Johnson
90284305fc
Re-land "[Material] Support for hovered, focused, and pressed border color on OutlineButtons" (#35278)
* outline border implements material state property
2019-06-28 14:40:42 -04:00
Todd Volkert
17c18da0c6
Revert "[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)" (#35276)
This reverts commit 3f9415998906a2465dc63a749cfe2fa05dad629c.
2019-06-28 09:18:30 -07:00
MH Johnson
3f94159989
[Material] Support for hovered, focused, and pressed border color on OutlineButtons (#34872)
* outline border implements material state property
2019-06-28 11:55:54 -04:00
hizzd
d780c2cff6 Fixed the LicensePage to close the page before loading the License causes an error (#34907) 2019-06-28 08:50:01 -07:00
Shi-Hao Hong
892043842e
child param doc update in Ink and Ink.image (#35211)
* Add doc suggesting Container for BoxDecorations that have no child widget
2019-06-27 19:37:20 -07:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Yegor
c5f5b3c98a
Reuse matrix instance for transient transforms in _transformRect for fewer allocations (#35132) 2019-06-27 10:05:25 -07:00
rami-a
9166337698
Allow for customizing SnackBar's content TextStyle in its theme (#35075)
* Allow for customizing Snackbar's content TextStyle in its theme

* Address PR feedback

* Fix analyzer issues

* Address more PR feedback
2019-06-27 11:19:14 -04:00
Kasper
b6349e7d9a Added onChanged property to TextFormField (#34932) 2019-06-26 18:13:53 -07:00
miDeb
6cebd350f5 Remove duplicate error parts (#34919) 2019-06-26 14:56:09 -07:00
Kate Lovett
f9118c0fd0
Preserving SafeArea : Part 2 (#34298)
* WIP

* Added tests and updated SafeArea implementation.

* Analyzer nits

* Review feedback

* Updated for SnackBar and PersistentFooterButton cases, added tests to check other potential spots.

* doc addition for SafeArea

* Typos
2019-06-26 12:29:50 -07:00
Brian Egan
259151c39c
Add generated Icon diagram to api docs (#35046)
* Add generated Icon diagram to api docs
2019-06-26 18:16:16 +02:00
Alexandre Ardhuin
c7408be181
prepare for lint update of prefer_final_fields (#35059) 2019-06-25 19:39:34 +02:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00