453 Commits

Author SHA1 Message Date
Dan Field
110a5f320c
Reset a11y bridge state on hot restart (#6857) 2018-11-14 11:13:39 -08:00
Dan Field
114d33d3ca
Set and unset accessibility flags even when re-entrant (#6853)
* Make sure to not unset a11y flags on reentrant calls to API
2018-11-13 23:54:45 -08:00
Michael Goderbauer
1e7e676e4d
Remove unused import (#6854) 2018-11-13 23:31:56 -08:00
Michael Goderbauer
09ef73ff6e
Fix code smells reported by chrome's clang plugin (#6833) 2018-11-12 19:59:29 -08:00
Dan Field
ea4bbbd440
Avoid announcing text field when it lacks a11y focus (#6830)
* Avoid announcing text field when it lacks a11y focus
2018-11-12 16:08:59 -08:00
Amir Hardon
266b0986de
Release the surface texture entry when the platform view is disposed. (#6829)
We were leaking the texture after the view was disposed.
2018-11-12 14:23:25 -08:00
Mehmet Fidanboylu
94dd7165ef
Skia Cleanup (#6786) 2018-11-07 15:29:52 -08:00
Michael Goderbauer
70a1106b50
Unify copyright lines (#6757) 2018-11-07 12:24:35 -08:00
Todd Volkert
4cdddbac42
Fix String comparison as if Java were Dart. (#6781)
This also removes unused imports and sorts imports correctly
2018-11-07 09:59:51 -08:00
Stanislav Baranov
b5758d0d38
Propagate positions of secondary pointers in UP events on Android (#6716) 2018-11-02 10:51:35 -07:00
Stanislav Baranov
dd791f36ac
Propagate pointer size from Android MotionEvent (#6662) 2018-10-26 09:39:10 -07:00
Jonah Williams
cf75289b68
TextField is only a live region when it has input focus (#6649) 2018-10-25 08:37:49 -07:00
Chinmay Garde
e1e60933b2
Realize kernel asset mappings on a worker thread if one is available. (#6648) 2018-10-24 11:33:46 -07:00
Gary Qian
8cb3965a3e
Properly gate android API < 21 and remove extraneous data array. (#6619) 2018-10-19 15:01:43 -07:00
Gary Qian
09dcc3d5ee
Gate locale.getScript() behind version check for android API < 21 (#6592) 2018-10-18 14:03:48 -07:00
Gary Qian
35340ceaf0
Pass full locale list with script and variant codes to framework (#6557)
* Locale Passing

* Pass full locale list and script and variant codes to framework

* Working Android locale list passing and fallback
2018-10-17 10:53:01 -07:00
Shaoxing Wang
26f437f377 Fix crash when removeViewImmediate invoked from platform view (#6266)
* Fix crash when removeViewImmediate invoked from platform view

* Clear animation before remove view from mFakeWindowRootView
2018-10-15 16:09:10 -07:00
Jonah Williams
436f9707b9
Add version check for dismissable (#6522) 2018-10-12 15:47:11 -07:00
谢然
05aac0f270 fix ResourceExtractor npe. (#6461) 2018-10-12 09:56:00 -07:00
Gary Qian
61cf4c01fd
Pass scriptcode and variantcode to dart:ui Window. (#6493) 2018-10-10 17:22:59 -07:00
Jason Simmons
155ba09619
Use an older version of SurfaceTexture.setOnFrameAvailableListener when running on pre-Lollipop devices (#6489)
Fixes https://github.com/flutter/flutter/issues/21730
2018-10-10 15:01:48 -07:00
Jonah Williams
647302a287
Correct issues in visible children determination (#6455)
* fix off by one

* add documentation on counting for setToIndex
2018-10-08 11:05:09 -07:00
liyuqian
90b1023c84
Remove unused imports and variables (#6437)
This is discovered in the new Google3 checks. It should not block our
roll but it's nice to fix them.
2018-10-04 16:01:49 -07:00
Jonah Williams
ae4db4469f
Ensure setViewIdResourceName has the correct version guard (#6404) 2018-10-03 17:44:32 -07:00
Kirill Nikolaev
68a42e3f47 Add nullability annotations to MethodChannel/MethodCall. (#6393)
This works towards resolving https://github.com/flutter/flutter/issues/19888.
2018-10-02 15:02:16 -07:00
Jonah Williams
a785b25f4a
do not count Hidden nodes at the beginning of the scrollable (#6381) 2018-10-01 11:15:22 -07:00
Jonah Williams
77c30caddf
make sure we dont set live regionin api level < 18 (#6375) 2018-09-27 23:24:54 -07:00
Kirill Nikolaev
27f77cbef5 Document that all MethodChannel callbacks must be called on the main thread. (#6245)
This further addresses https://github.com/flutter/flutter/issues/14568.
2018-09-27 15:48:29 -07:00
Chinmay Garde
f2a3df97e2
Wire up the Skia persistent GPU related artifacts cache. (#6278)
Also teaches FML to create files and directories.
2018-09-26 14:54:09 -07:00
Gary Qian
8247ce26ba
Implement restore functions on Android and iOS (#6322)
This will not be active on the Framework until https://github.com/flutter/flutter/pull/22221 lands.
2018-09-25 13:46:38 -07:00
Dan Field
8743bb82db
Format for #6324 (#6326)
Format code from previous patch
2018-09-24 18:42:04 -04:00
Dan Field
89516aad94
Engine::Run returns enum: success, failure, or isolate already running (#6324)
* If isolate is already running, return true

* Use shell::Engine::RunStatus as result of Engine::Run
2018-09-24 18:01:22 -04:00
Gary Qian
74625aed32
Keyboard padding detection heuristic to distringuish when to include bottom inset. (#6288)
Use a screen height ratio to determine if the keyboard is onscreen or not. This is used because Android does not provide a deterministic API to detect this.

We remove the padding when the keyboard is closed and the inset is due to the hidden navigation bar, otherwise, we apply the full keyboard inset.
2018-09-24 11:38:13 -07:00
Amir Hardon
02901b78c6
Decouple PlatformViewsController from FlutterView. (#6303)
Decouple PlatformViewsController from FlutterView.

Instead of getting a FlutterView instance, depend on the specific interfaces required by
PlatformViewsController (BinaryMessenger, TextureRegistry, and Context).

This allows using PlatformViewsControlling in the flutter/embedding
code.
2018-09-21 15:40:17 -07:00
Gary Qian
f3d51b0cfb
Fix Top, Left, and Right padding for fullscreen android apps. (#6282)
* Fix Top, Left, and Right padding for fullscreen apps.

* Fix minor nits and comments, simple logic inversion
2018-09-19 18:09:10 -07:00
Ryan Macnak
60bb5da33c
Reapply "Some cleanups enabled by removing support for Dart 1" (#6250)
Following fixes in dart-lang/sdk@91cbb57cd5
2018-09-14 09:36:13 -07:00
Jonah Williams
272be27f70
update live region to trigger on label change, remove manual trigger (#6248) 2018-09-14 09:10:59 -07:00
Jonah Williams
abd918eb61
Add scrollIndex and scrollChildren to semantics, add Android implementation (#6239) 2018-09-13 10:28:27 -07:00
Michael Goderbauer
6f459e2f10
Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (#6216)" (#6232)
This reverts commit e3133e0e3f7cbbd57fa930c11f3640561d691eba.
2018-09-12 12:07:20 +02:00
Ryan Macnak
e3133e0e3f
Reapply "Some cleanups enabled by removing support for Dart 1." (#6216)
- Add missing Dart 2 flags to gen_snapshot invocation.
 - Disable brittle service test.
2018-09-10 17:03:54 -07:00
Ryan Macnak
bf96dbed38
Revert "Some cleanups enabled by removing support for Dart. (#5621)" (#6205)
This reverts commit 4c2448d1591a5fab033de3885ad34d1fdf5474f1.
2018-09-07 17:39:51 -07:00
Ryan Macnak
4c2448d159
Some cleanups enabled by removing support for Dart. (#5621)
- Switch core snapshot to Dart 2 and remove support for loading platform.dill.
 - Remove support for loading script snapshots.
 - Remove support for loading source.
 - Remove settings and fix names to reflect the above.
 - Remove support for loading the service isolate from source.
2018-09-07 15:44:46 -07:00
Michael Klimushyn
108e0a64ef
Add transparency helpers to FlutterView.java (#6172)
Fixes #9627
2018-09-05 16:47:02 -07:00
Jason Simmons
e6d9b34a8c
Remove the old location of the ICU data asset (#6170)
The tools are now placing icudtl.dat in the flutter_shared directory.
It is no longer necessary to check for this asset at its previous path.
2018-09-05 12:22:27 -07:00
Simon Lightfoot
9f0ad8b794 Fixes negative end selection offset. (#6171) 2018-09-05 12:12:21 -07:00
Michael Klimushyn
0981731fd7
Enable transparent FlutterViews (#6163)
- Changes rasterizer to clear the canvas with `SkColor_TRANSPARENT`
- Removes the unused `backgroundColor` param from `FlutterView.java`
2018-09-05 10:44:02 -07:00
Jason Simmons
6af60d716a
Remove obsolete discovery mechanism from FlutterView (#6157) 2018-09-05 10:01:33 -07:00
Kirill Nikolaev
b0b8daa7b2 Unregister onFrameAvailable callbacks when a TextureEntry is released. (#6079)
Otherwise the callbacks may be called after FlutterNativeView is destroyed and is null.

Also defensively check for whether the texture is already released in the callback because the callback may be called from another thread by a stale reference (see the comment).

This closes https://github.com/flutter/flutter/issues/20951.
2018-09-04 06:31:01 -07:00
jslavitz
1c76824186
entering a character with a selection deletes the selection (#6113) 2018-08-30 10:29:04 -07:00
Amir Hardon
ad4e87d07d
Convert synthesized Android motion events to long and not to int. (#6103) 2018-08-28 12:12:47 -07:00