21369 Commits

Author SHA1 Message Date
Zachary Anderson
2bfd0d4aa4 Revert "Make no_lto in presubmit explicit in .ci.yaml (#40254)" (flutter/engine#40260)
Revert "Make no_lto in presubmit explicit in .ci.yaml"
2023-03-13 22:32:14 +00:00
Dan Field
91c580c261 Let local users specify malioc path via environment (flutter/engine#40256)
Let local users specify malioc path via environment
2023-03-13 22:16:24 +00:00
Zachary Anderson
46d7561128 Make no_lto in presubmit explicit in .ci.yaml (flutter/engine#40254) 2023-03-13 14:53:40 -07:00
Zachary Anderson
e5dc618c13 Revert "Roll Dart SDK from c766fffb626e to cfcbda5733ac (1 revision) (#40249)" (flutter/engine#40257)
This reverts commit 28a7b38492b9d49d2b007f051055906e1a7bd3fb.
2023-03-13 14:45:26 -07:00
skia-flutter-autoroll
7dbac936d8 Roll Skia from 88bdb0c778ed to 75e4b07cb82a (23 revisions) (flutter/engine#40252)
Roll Skia from 88bdb0c778ed to 75e4b07cb82a (23 revisions)
2023-03-13 20:14:05 +00:00
skia-flutter-autoroll
28a7b38492 Roll Dart SDK from c766fffb626e to cfcbda5733ac (1 revision) (flutter/engine#40249)
Roll Dart SDK from c766fffb626e to cfcbda5733ac (1 revision)
2023-03-13 19:04:24 +00:00
skia-flutter-autoroll
8d47e950f9 Roll Skia from 1c36c5c38ef4 to 88bdb0c778ed (1 revision) (flutter/engine#40227)
Roll Skia from 1c36c5c38ef4 to 88bdb0c778ed (1 revision)
2023-03-13 18:21:17 +00:00
Jackson Gardner
a2107a541a Use plain Uint32List objects with the fragmenter APIs. (flutter/engine#40239)
Use plain Uint32List objects with the fragmenter APIs.
2023-03-13 16:54:22 +00:00
Dan Field
a605a82116 [Impeller][Compute] Fix visual issues with heart (flutter/engine#40240) 2023-03-13 09:22:28 -07:00
Zachary Anderson
8c46471d24 Revert "[Impeller] More sundry fixes to the Vulkan backend. (#40244)" (flutter/engine#40247)
Revert "[Impeller] More sundry fixes to the Vulkan backend."
2023-03-13 15:45:38 +00:00
Jonah Williams
1f0234bd1a [Impeller] support for foreground shaders on text (flutter/engine#40193)
[Impeller] support for foreground shaders on text
2023-03-13 15:42:13 +00:00
Lasse R.H. Nielsen
f53ad85609 Change extends Iterator to using implements (flutter/engine#40175)
The Dart 3.0 libraries will mark Iterator with the interface class modifier, which prevents extends. It will do so because the class has no implementation to inherit, and is only intended as an interface, which it is now possible to express.

This should unblock relanding https://dart-review.googlesource.com/c/sdk/+/287760
(Also working on disabling the class-modifiers experiment for Flutter dart: libraries, which was enabled along with the Dart SDK libraries, until the experiment can be intentionally turned back on.)
2023-03-13 13:43:04 +01:00
dependabot[bot]
2035dc18ba Bump github/codeql-action from 2.2.5 to 2.2.6 (flutter/engine#40246)
Bump github/codeql-action from 2.2.5 to 2.2.6
2023-03-13 09:44:31 +00:00
Chinmay Garde
3ea71b3d11 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40244)
[Impeller] More sundry fixes to the Vulkan backend.
2023-03-13 06:49:22 +00:00
Zachary Anderson
46decf5844 Add GN arguments that disable building host artifacts (flutter/engine#40242) 2023-03-11 19:38:43 -08:00
Chris Bracken
761ba30bc7 [macOS] Forward mouseDown/Up to view controller (flutter/engine#40241)
This works around an AppKit bug in which mouseDown/mouseUp events are
not correctly forwarded up the responder chain for views nested inside
an NSPopover if (and only if) the macOS "Reduce Transparency"
accessibility setting is enabled in the System Settings.

When the above conditions are satisfied, the nested NSView receives the
mouseDown:/mouseUp: call but if it delegates to the default
implementation (implemented in NSResponder) mouseDown/mouseUp calls are
triggered on containing views (in our case FlutterViewWrapper) but not
triggered on the view controller and other responders in the responder
chain until we an _NSPopoverWindow class is hit.

A minimal AppKit-only (non-Flutter) repro shows this behaviour repros
with even a minimal NSViewController implementation and an unmodified NSView.
See: https://github.com/cbracken/PopoverRepro

A radar has been filed with Apple and a copy posted to OpenRadar.
See: http://www.openradar.me/FB12050037

In order to work around this bug, we override mouseDown/mouseUp in the
topmost containing view of FlutterView (in our case, FlutterViewWrapper)
to have the behaviour documented as the default behaviour in
NSResponder's mouseDown/mouseUp documentation. In otherwords, to simply
forward the call to self.nextResponder.
See: https://developer.apple.com/documentation/appkit/nsresponder/1524634-mousedown

Because replicating the exact configuration of a FlutterView contained
in an NSPopover and System Settings that have been modified to enable
the "Reduce Transparency" setting is difficult and likely error-prone in
infra, we instead simulate the bug by testing that even if NSResponder's
mouseDown/mouseUp method are swizzled to no-op, these calls are
correctly forwarded to the next responder in the chain.

If, in the future Apple does fix this issue, this workaround can be
removed once Flutter's minimum supported macOS SDK is at least the
version that contains the fix.

Issue: https://github.com/flutter/flutter/issues/115015
2023-03-11 12:49:59 -08:00
Dan Field
1de9bf9581 Make the context current before accessing GL in MakeSkiaGpuImage (flutter/engine#40208)
Make the context current before accessing GL in MakeSkiaGpuImage
2023-03-11 00:39:04 +00:00
LongCatIsLooong
6f18a0383a Revert "Make FlutterTest the default test font (#40188)" (flutter/engine#40237)
This reverts commit ab6696a9aebbe5b5b813b9f89169211e42888cac.
2023-03-10 15:42:18 -08:00
Yegor
e9abb22ba1 Revert "[web] Access engine version to get correct gstatic URL (#40194)" (flutter/engine#40235)
This reverts commit 46682951fe7f61296070c2fdfb673576628bbd89.
2023-03-10 14:46:06 -08:00
skia-flutter-autoroll
8d7fe73de3 Manual roll Dart SDK from 7240b35cc401 to c766fffb626e (9 revisions) (flutter/engine#40233)
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/7240b35cc401..c766fffb626e

2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-322.0.dev
2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-321.0.dev
2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-320.0.dev
2023-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-319.0.dev
2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-318.0.dev
2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-317.0.dev
2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-316.0.dev
2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-315.0.dev
2023-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-314.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,asiva@google.com,dart-vm-team@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-03-10 14:44:48 -08:00
Jim Graham
902e4686d8 Roll Fuchsia Linux SDK to 12.20230309.0.1 (flutter/engine#40231)
Roll Fuchsia Linux SDK to 12.20230309.0.1
2023-03-10 22:32:52 +00:00
Jonah Williams
b404bbf706 [Impeller] remove unused shader, format malioc diff (flutter/engine#40230)
[Impeller] remove unused shader, format malioc diff
2023-03-10 22:24:45 +00:00
LongCatIsLooong
ab6696a9ae Make FlutterTest the default test font (flutter/engine#40188)
Make FlutterTest the default test font
2023-03-10 20:00:24 +00:00
Harry Terkelsen
46682951fe [web] Access engine version to get correct gstatic URL (flutter/engine#40194) 2023-03-10 10:16:48 -08:00
skia-flutter-autoroll
b93c8aa8b5 Roll Skia from ca2798726315 to 0ec5c487291d (1 revision) (flutter/engine#40221)
Roll Skia from ca2798726315 to 0ec5c487291d (1 revision)
2023-03-10 15:35:15 +00:00
Jackson Gardner
299c8369a7 Find the emsdk by relative path so that this works with the monorepo. (flutter/engine#40207)
Find the emsdk by relative path so that this works with the monorepo.
2023-03-10 14:56:21 +00:00
skia-flutter-autoroll
a7f20d1cbd Roll Skia from af3cd5046449 to 5c8c19ec776a (1 revision) (flutter/engine#40212)
Roll Skia from af3cd5046449 to 5c8c19ec776a (1 revision)
2023-03-10 08:08:19 +00:00
Jim Graham
f7e95e3490 fix typo in LayerInfo::has_compatible_op (flutter/engine#40209)
fix typo in LayerInfo::has_compatible_op
2023-03-10 05:32:13 +00:00
Brandon DeRosier
9127bd4726 [Impeller] Build Impeller Vulkan backend on Windows (flutter/engine#40196) 2023-03-09 19:59:58 -08:00
Jackson Gardner
4dd18fa43f Use no_goma for the web framework tests. (flutter/engine#40197)
Use `no_goma` for the web framework tests.
2023-03-10 03:31:21 +00:00
Robert Ancell
5c4c343488 Add platform channel System.exitApplication and System.requestAppExit support (flutter/engine#40033)
Add platform channel System.exitApplication and System.requestAppExit support
2023-03-10 14:43:35 +13:00
Jackson Gardner
e35bbd1b89 Flip this flag to false, so that in-tree builds will not attempt to (flutter/engine#40195)
Do not include wasm-opt with in-tree dart sdk build
2023-03-10 01:03:01 +00:00
skia-flutter-autoroll
c133a2fe45 Roll Skia from 5054c9159afa to bd14d5f42db9 (3 revisions) (flutter/engine#40201)
Roll Skia from 5054c9159afa to bd14d5f42db9 (3 revisions)
2023-03-10 00:48:03 +00:00
godofredoc
0b0dac7833 Use 32 cores in Linux Host and Web Engine. (flutter/engine#40200)
Use 32 cores in Linux Host and Web Engine.
2023-03-10 00:29:42 +00:00
gaaclarke
a83570e7bf Fixed bug where images without specified colorspaces can crash wide gamut test. (flutter/engine#40097)
Fixed crash with images without specified colorspaces in wide gamut test
2023-03-09 23:07:22 +00:00
Adam Perry
e9942f8f52 Reland "[fuchsia] Remove component framework v1 support. (#39732)" (flutter/engine#40198)
Previously reverted in #40104, this should now be safe to reland as
the last dependency has been deleted internally.

This reverts commit 9369c1ed1f33cfdad25ebe9cb809d6b5d6941159.
2023-03-09 15:05:45 -08:00
Jonah Williams
726df65356 Reland: Move asset opening to background thread, fix dart persistent value destruction (flutter/engine#40183)
Reland: Move asset opening to background thread, fix dart persistent value destruction
2023-03-09 22:58:04 +00:00
gaaclarke
f2c8cd4b58 Switched floats to ints in gradient shaders for better performance (flutter/engine#40189)
Switched floats to ints in gradient shaders for better performance
2023-03-09 22:13:54 +00:00
skia-flutter-autoroll
821900ea22 Roll Skia from 0fbaf2cf8652 to 5054c9159afa (2 revisions) (flutter/engine#40191)
Roll Skia from 0fbaf2cf8652 to 5054c9159afa (2 revisions)
2023-03-09 21:42:50 +00:00
Chris Yang
bdcc4f6e95 [ios] refactor platform_message_handler_ios (flutter/engine#40182)
[ios] refactor platform_message_handler_ios
2023-03-09 21:27:37 +00:00
Michael Goderbauer
18b57833e8 Enable invalid_case_patterns lint (flutter/engine#40185)
Enable invalid_case_patterns lint
2023-03-09 21:22:54 +00:00
Loïc Sharma
89a738d1b7 [Embedder API] Lock nested structs to guarantee ABI (flutter/engine#40069)
[Embedder API] Lock nested structs for ABI stability
2023-03-09 21:09:50 +00:00
Mouad Debbar
c9d003f7b3 [web] Use CK's malloced array correctly (flutter/engine#40181)
[web] Use CK's malloced array correctly
2023-03-09 20:38:04 +00:00
godofredoc
67a40453d3 Add analyze_snapshot to android_aot builder. (flutter/engine#40169)
Add analyze_snapshot to android_aot builder.
2023-03-09 20:22:52 +00:00
Jason Simmons
d55465069a Apply the buffer offset when converting a vertex color Int32List to a Uint32List (flutter/engine#40066)
Apply the buffer offset when converting a vertex color Int32List to a Uint32List
2023-03-09 19:56:59 +00:00
Dan Field
b8ecad0c34 Render a compute generated stroke (flutter/engine#40184)
[Impeller] Render a compute generated stroke
2023-03-09 19:47:02 +00:00
Loïc Sharma
85065c29e9 [Desktop] Use references for semantics update (flutter/engine#40167)
[Desktop] Use references for semantics update
2023-03-09 19:44:17 +00:00
skia-flutter-autoroll
5ebc09089f Roll Skia from 529fb1efd882 to 0fbaf2cf8652 (5 revisions) (flutter/engine#40180)
Roll Skia from 529fb1efd882 to 0fbaf2cf8652 (5 revisions)
2023-03-09 19:40:31 +00:00
gaaclarke
9e0db60c6a Made sure we get the initial route from the intent. (flutter/engine#40148)
Android: Made sure we get the initial route from the intent.
2023-03-09 18:42:51 +00:00
Michael Goderbauer
51a00ac884 Remove single window assumption from testing/dart (flutter/engine#40160) 2023-03-09 10:10:00 -08:00