9897 Commits

Author SHA1 Message Date
Emmanuel Garcia
2bee676fe5 Refactor AndroidContextGL, AndroidSurface and AndroidSurfaceGL (flutter/engine#18670) 2020-06-05 09:18:03 -07:00
Yegor
f6b8e644c4 add nullability annotations to lib/web_ui painting.dart (flutter/engine#18395)
* add nullability annotations to lib/web_ui painting.dat
2020-06-05 08:20:55 -07:00
Yegor
84949bf44a add nullability annotations to ui/text.dart (flutter/engine#18400)
* add nullability annotations to ui/text.dart
2020-06-05 08:19:14 -07:00
David Reveman
9200e49b8a [fuchsia] Limit unnecessary layout transition to aarch64. (flutter/engine#18833)
This is causing rendering artifacts on intel.

Co-authored-by: David Reveman <reveman@google.com>
2020-06-04 22:29:40 -04:00
Robert Ancell
4ba8e1220f Don't call engine when not initialized. (flutter/engine#18810)
This stops events and platform messages generating errors when the engine has
failed to initialize.
2020-06-05 13:27:56 +12:00
Robert Ancell
06eaeaeb82 Fix braces style (flutter/engine#18837) 2020-06-05 13:26:54 +12:00
skia-flutter-autoroll
e49a886459 Roll Skia from cdc39bda9237 to 59f31b143ccd (1 revision) (flutter/engine#18839) 2020-06-04 18:18:03 -07:00
skia-flutter-autoroll
8ffd7d29df Roll Skia from 024d42fdd6bb to cdc39bda9237 (19 revisions) (flutter/engine#18835) 2020-06-04 16:43:06 -07:00
Dan Field
16681d7292 Record path memory usage in SkPictures (flutter/engine#18827) 2020-06-04 15:48:25 -07:00
Jason Simmons
1c8d0396ff Reset AndroidExternalViewEmbedder state when starting a new frame (flutter/engine#18831) 2020-06-04 15:08:04 -07:00
Yegor
b411311639 null annotate window.dart (flutter/engine#18789) 2020-06-04 14:31:08 -07:00
nturgut
0f62d15509 [web] Adding profile parameter to firefox (flutter/engine#18792)
* opening firefox with a given profile

* use .dart_tool for temporary directory. delete the directory if exits before creation
2020-06-04 13:22:13 -07:00
Chris Yang
b842ba72a6 Rework GLContextSwitch, get rid of RendererContextManager (flutter/engine#18601) 2020-06-04 11:37:51 -07:00
Yegor
ea849e7c04 null-annotate semantics.dart (flutter/engine#18791) 2020-06-04 11:35:24 -07:00
skia-flutter-autoroll
4f19e982e7 Roll Fuchsia Linux SDK from VXyRo... to 9-PNW... (flutter/engine#18796)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-06-04 11:17:26 -07:00
Yegor
43f11163e2 Minimize child DOM node moves in many-to-many update (flutter/engine#18648)
* minimize child DOM node moves in many-to-many update
2020-06-04 10:53:38 -07:00
Emmanuel Garcia
162a2c6370 Revert "onDisplayPlatformView JNI (#18786)" (flutter/engine#18826)
This reverts commit 24d7c5c16b1aa9bc263d1428cf228927e96da97b.
2020-06-04 09:42:51 -07:00
cg021
24d7c5c16b onDisplayPlatformView JNI (flutter/engine#18786)
* onDisplayPlatformView JNI

* format

* add todo in onDisplayPlatformView

Co-authored-by: Emmanuel Garcia <egarciad@google.com>

* move methods

* add platformViewsController setter

* remove unnecessary calls

* remove override and add unit test

* remove override

* test

* mockito

* fix formatting

Co-authored-by: Emmanuel Garcia <egarciad@google.com>
2020-06-04 11:20:45 -05:00
skia-flutter-autoroll
ff92a0e6f5 Roll Skia from 1adcac52d64b to 024d42fdd6bb (66 revisions) (flutter/engine#18823) 2020-06-04 09:13:04 -07:00
Robert Ancell
f029e6f88c Mark symbols that should be public (flutter/engine#18802) 2020-06-04 14:31:35 +12:00
Dan Field
305435e0a5 Live region announcements for iOS (flutter/engine#18798) 2020-06-03 19:13:04 -07:00
stuartmorgan
35814367f6 Don't export embedder API in desktop embeddings (flutter/engine#18735)
The embedder.h API layer is an implementation detail of the desktop
embeddings, not part of the public API surface, so should not be part of
the public symbol list for those libraries.
2020-06-03 18:13:59 -07:00
nturgut
4f1dd6a3b1 removing firefox tests from cirrus. since yesterday they are running on LUCI. (flutter/engine#18790) 2020-06-03 15:07:57 -07:00
gaaclarke
45318cefa6 ios accessibility: started ignoring route changes when presenting modal view controllers (flutter/engine#18544) 2020-06-03 14:49:56 -07:00
nturgut
b23e8e9f25 [web] Remove connection close on blur for desktop browsers (flutter/engine#18743)
* Do not close the text editing connection when an input text element is blurred (upon clicking another element on the page) on a desktop browser. keep the current behaviour for mobile browsers

* change the unit tests for blur

* refocus after blur so that the user can keep inputing text to the TextFormField

* skipping failing firefox check. active element didn't get updated in firefox in the automated test. manually checks working
2020-06-03 12:12:00 -07:00
Dan Field
0539f91b1e Implement GetAllocationSize for Vertices (flutter/engine#18756)
* Implement GetAllocationSize for Vertices

* Reflect vertex buffer size in pictures
2020-06-03 10:35:14 -07:00
stuartmorgan
d67aa8197f Revert "null-annotate SemanticsUpdateBuilder.updateNode (#18552)" (flutter/engine#18785)
This reverts commit c9085a90741aea65ff1479608f0e5d394e50ce72.
2020-06-03 09:54:06 -07:00
Emmanuel Garcia
61bc45b233 Pass SurfaceFrame to SubmitFrame (flutter/engine#18709) 2020-06-02 21:59:44 -07:00
Jason Simmons
d2912e8f56 Pin the analyzer version as a temporary workaround for https://github.com/dart-lang/sdk/issues/42163 (flutter/engine#18755)
A recent change to the analyzer package introduced an API incompatibility with
the build_resolvers package.  The analyzer package needs to be pinned to an
older version until this is resolved.
2020-06-02 16:15:15 -07:00
Dan Field
a96a8cc9ce Make images contribute to Picture allocation size, more aggressively release references when dispose is called (flutter/engine#18706)
SkImage references get held by both our Image and Picture objects. The GC has no idea about this, and so sometimes pictures look very small when they're actually holding a reference to a large chunk of memory. This patch helps make sure that the GC can more adequately catch the real size impact of Picture objects, and combined with an upstream patch in Dart allows for much more aggressive collection of unused image related memory.
2020-06-02 15:12:06 -07:00
Chris Bracken
c9085a9074 null-annotate SemanticsUpdateBuilder.updateNode (flutter/engine#18552)
The underlying _updateNode call requires that all parameters be set
non-null. There's a single call site in the framework in
lib/src/semantics/semantics.dart in SemanticsNode.updateWith(). At that
call site, all parameters are either asserted non-null in the
constructor of SemanticsData or defaulted to null, with the sole
exception of textDirection.

The ergonomics of this method are currently pretty ugly and we should
consider migrating most of the defaulting and assertions that we apply
at the call site up to the definition in dart:ui. That work is filed as
https://github.com/flutter/flutter/issues/57720.
2020-06-02 14:42:36 -07:00
xster
a0b2b71025 Add an engine PR template (flutter/engine#18721) 2020-06-02 12:05:59 -07:00
Robert Ancell
f7a846ef8e Add missing standard codec alignment bytes (flutter/engine#18724) 2020-06-03 06:22:52 +12:00
Robert Ancell
07ecd97754 Add braces around multi-line branches to match code style (flutter/engine#18719) 2020-06-03 06:22:24 +12:00
Robert Ancell
43de315eee Add missing full stops on the end of comments. (flutter/engine#18634) 2020-06-03 06:21:46 +12:00
bungeman
6282eb8094 Mark conditional SkParagraph include nogncheck. (flutter/engine#18741) 2020-06-02 11:18:03 -07:00
skia-flutter-autoroll
c77c9bd834 Roll Skia from a5ced794731b to 1adcac52d64b (6 revisions) (flutter/engine#18740) 2020-06-02 10:38:02 -07:00
Chris Bracken
e03feb13f7 null-annotate lib/ui/hooks.dart (flutter/engine#18555) 2020-06-02 09:49:50 -07:00
skia-flutter-autoroll
e53482bd98 Roll Skia from 502eab4fc913 to a5ced794731b (22 revisions) (flutter/engine#18737) 2020-06-02 08:43:03 -07:00
skia-flutter-autoroll
80794255c7 Roll Fuchsia Linux SDK from in0Aq... to VXyRo... (flutter/engine#18728) 2020-06-02 06:48:02 -07:00
nturgut
1c457a7a39 add driver for chrome 83 (flutter/engine#18722) 2020-06-01 19:07:25 -07:00
Tong Mu
75724a5657 System mouse cursor: Android (flutter/engine#18569)
Adds system mouse cursor to the Android engine.
2020-06-01 18:08:43 -07:00
nturgut
ce8fe9903d [web] runs ios unit tests (flutter/engine#18650)
* runs ios unit tests, if the simulator is already booted.

* address reviewer comments

* changing comments for the Safari desktop tests

* addressing reviewer comments. removing the timeout.

* change mobile browsers ver name for safari.dart

* removing then calback on browser exit, only leaving the exception callback
2020-06-01 16:52:27 -07:00
Robert Ancell
486f8e4886 Don't show warnings when removing handlers. (flutter/engine#18633)
These are removed in destructors.
2020-06-02 11:32:57 +12:00
chenjianguang
5a78bd2f4d Fix BM_ShellShutdown regression (flutter/engine#18676) 2020-06-01 16:13:02 -07:00
Dan Field
65afbec58a Make GetAllocationSize const (flutter/engine#18713) 2020-06-01 15:58:03 -07:00
Kaushik Iska
29a096bc85 [fuchsia] NNBD: Kernel libraries for Flutter, Dart runners (flutter/engine#18714)
This updates the references to `third_party/dart/sdk` to
`third_party/dart/sdk_nnbd`

Fixes: https://github.com/flutter/flutter/issues/58431
2020-06-01 15:28:10 -07:00
Robert Ancell
29a0d55666 Add tests for FlBinaryMessenger, FlBasicMessageChannel, FlMethodChannel (flutter/engine#18638) 2020-06-02 09:39:37 +12:00
Robert Ancell
61f0b14f9c Fix FlValue functions not marked for export (flutter/engine#18641) 2020-06-02 09:38:10 +12:00
skia-flutter-autoroll
7768f07086 Roll Skia from 8c5786622b4e to 502eab4fc913 (2 revisions) (flutter/engine#18707) 2020-06-01 12:58:02 -07:00