skia-flutter-autoroll
2bdf483ebd
Roll Skia from a47a68da8291 to 7e20e6679785 (1 revision) ( flutter/engine#42340 )
...
https://skia.googlesource.com/skia.git/+log/a47a68da8291..7e20e6679785
2023-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2b787917e4a3 to 9b8f1aed38ff (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-26 07:24:39 +00:00
Jackson Gardner
387666e22f
Proper memory management in Skwasm ( flutter/engine#42328 )
...
This fixes https://github.com/flutter/flutter/issues/127243 .
This ensures that native skwasm objects are cleaned up when their associated dart-side objects are garbage collected.
2023-05-26 03:46:26 +00:00
Jason Simmons
ff27c6d7a5
[Impeller] Disable the wide gamut settings flag on iOS simulators ( flutter/engine#42331 )
...
Wide gamut is not supported on the iOS simulator, and the iOS platform's FlutterView.isWideGamutSupported checked for this. However, the ImageDecoder decides whether to enable wide gamut based on the engine's settings, so the flag in the settings needs to be modified for the simulator.
2023-05-26 00:31:10 +00:00
Tong Mu
3a4bdfa370
[macOS] Multi-view thread synchronizer ( flutter/engine#41915 )
...
This PR adapts `FlutterThreadSynchronizer` to multi-view.
### Problem
The `FlutterThreadSynchronizer` is a macOS engine class to ensure that, if the current window is resized, nothing will not be presented until the layer tree is drawn with the up-to-date size.
This class is not compatible with multiview. A simple way to realize it is: while the class is owned by `FlutterView`, it blocks the _global_ platform thread and rasterizer thread - there is got to be some problems. Indeed, when I was testing with multiple windows (https://github.com/flutter/engine/pull/40399 ), the app freezes as soon as I resize a window.
The problem is because Flutter only have one rasterizer thread. When I'm resizing window A, A's synchronizer detects that the size mismatches, so it blocks the rasterizer thread to wait for an updated content with the updated size. However, window B is to be rendered next, and B's size matches and will try to rasterize, and will be blocked due to the blocked rasterizer thread, window A's updated content will never arrive, causing a deadlock.
### Changes
This PR removes the single-view assumption of `FlutterThreadSynchronizer` by making it created by `FlutterEngine` and shared by all `FlutterView`s, and that it prevents rasterization for all views if any view has a mismatched size.
The synchronizer is assigned to the view controller in the `attachToEngine:withId` method (now renamed to `setUpWithEngine:viewId:threadSynchronizer:`.
This PR also adds unit tests for `FlutterThreadSynchronizer`, which didn't have any unit tests at all.
* To achieve this, the `beginResizeForView:` method no longer checks whether is called on the main thread, but whether it's called on the main queue. These are equivalent for the real main queue, since the documentation promises that the main queue always executes on the main thread. However, this change allows substituting the queue with a custom one for unit tests.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-25 22:37:35 +00:00
Jim Graham
de4939288a
Move checkerboard unit tests onto DisplayList mechanism ( flutter/engine#41951 )
...
Part of an ongoing set of efforts to address https://github.com/flutter/flutter/issues/106448
Move the checkerboard layer unit tests onto the DisplayList version of the paint contexts and fix some bugs in the reusability of the DisplayListBuilder that this migration uncovered.
2023-05-25 21:56:25 +00:00
Jackson Gardner
8719978821
[Skwasm] Implement miscellaneous drawing APIs ( flutter/engine#42324 )
...
Implements `drawVertices`, `drawPoints`, and `drawAtlas`.
These are the last rendering APIs that are unimplemented in Skwasm! (Although we still need to add platform view support).
2023-05-25 21:53:23 +00:00
skia-flutter-autoroll
edd719200e
Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) ( flutter/engine#42325 )
...
https://skia.googlesource.com/skia.git/+log/e648bf802cd2..bd677c195886
2023-05-25 kjlubick@google.com Make test tags configurable
2023-05-25 michaelludwig@google.com [skif] Fix required input recursion for Runtime image filters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 21:11:05 +00:00
Tong Mu
3b00b85da8
[Rasterizer] Make resubmit information temporary ( flutter/engine#42001 )
...
This PR refactors `Rasterizer` so that the resubmit information is
returned as a temporary struct instead of stored permanently as class
member. This limits the lifetime of these values and reduces class
members.
Additionally, this benefits the multi-view project: if the rasterizer is
going to store multiple surfaces, what variables should be stored in a
map from view IDs? Should all surfaces have a to-be-submitted record?
The answer is "no", because these information is only temporary.
This PR should not need unit tests since it's only a refactor.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-05-25 13:11:23 -07:00
Jackson Gardner
23cd1255b9
Implement Web Codecs for Skwasm ( flutter/engine#42184 )
...
This implements making images from web browser codecs.
This implements a JS support library as well, which allows both the main thread and the background thread to keep a registry of JS objects that can be referenced by a numeric ID and transferred between each other.
2023-05-25 19:51:06 +00:00
godofredoc
c62ef76f75
Move linux clang tidy to engine_v2. ( flutter/engine#42112 )
...
This PR moves the v2 from staging to prod and it also moves linux android | host clang tidy to staging.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-25 19:35:18 +00:00
skia-flutter-autoroll
96c5092177
Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) ( flutter/engine#42323 )
...
https://skia.googlesource.com/skia.git/+log/69d0aa065992..e648bf802cd2
2023-05-25 robertphillips@google.com Improve units tests a little bit
2023-05-25 robertphillips@google.com Fix DMSAA RRectOp bug with skew matrices
2023-05-25 robertphillips@google.com [graphite] Move tiled image drawing utilities to their own file(s)
2023-05-25 drott@chromium.org [Fontations] Don't assert scaler understands all outlines
2023-05-25 brianosman@google.com Remove all ARM CPU feature detection
2023-05-25 nicolettep@google.com [graphite] Create & bind descriptor sets in VulkanCommandBuffer
2023-05-25 jvanverth@google.com [graphite] Add begin/endRenderPass for Vulkan backend.
2023-05-25 kjlubick@google.com Remove Ganesh code from SkBlenderBase and SkBlendModeBlender
2023-05-25 jvanverth@google.com [graphite] Patch up some Vulkan shader issues
2023-05-25 michaelludwig@google.com [skif] Simplify new input/output bounds recursion
2023-05-25 michaelludwig@google.com [skif] FilterResult::Builder can bind FilterResults to sksl shaders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 19:23:23 +00:00
Jackson Gardner
aa7b3fcf98
Only use 8 cores for web test compilation. ( flutter/engine#42321 )
2023-05-25 19:14:06 +00:00
skia-flutter-autoroll
d5faba4008
Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... ( flutter/engine#42322 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 19:08:08 +00:00
Valentin Hăloiu
7fa6d7123c
Dynamically link against system fontconfig ( flutter/engine#40725 )
...
This is the engine counterpart for https://github.com/flutter/buildroot/pull/701 . That pull-request contains more context and the main motivation for this change.
This should fix some startup performance issues related to font loading on desktop linux: https://github.com/flutter/flutter/issues/118911 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-25 18:43:06 +00:00
Matej Knopp
634c40bf03
[macOS] Fix FlutterViewController retain cycle ( flutter/engine#42317 )
...
Fixes https://github.com/flutter/flutter/issues/127572
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-25 16:49:05 +00:00
Dan Field
45c1fe4348
Implement PlatformDispatcher.displays on web ( flutter/engine#42297 )
...
I missed this before.
2023-05-25 16:46:58 +00:00
skia-flutter-autoroll
57fb0c0135
Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) ( flutter/engine#42319 )
...
https://skia.googlesource.com/skia.git/+log/b80e74dc4cda..69d0aa065992
2023-05-25 kjlubick@google.com Manually Roll Dawn from 028726497ad3 to 4b35f52f9b33 (32 revisions)
2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ad20521dc02 to 354eac3ca8c8 (2 revisions)
2023-05-25 michaelludwig@google.com [skif] Remove legacy Merge filter implementation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 16:37:47 +00:00
Brandon DeRosier
be73e88f17
[Impeller] Safely access snapshot in the pipeline blend filter ( flutter/engine#42314 )
...
Spotted by @zanderso.
2023-05-25 09:32:23 -07:00
Brandon DeRosier
273bb77b61
[Impeller] Add generic path for mask blurring ( flutter/engine#42308 )
...
Resolves https://github.com/flutter/flutter/issues/127013 .
Makes mask blurs work for most color source + geometry combinations.
Crucially, this doesn't interfere with the fast paths for solid color
RRect blurs (used for shadows).
I'll be addressing mask blurs for text in a follow-up.
2023-05-25 09:31:20 -07:00
skia-flutter-autoroll
fee0534882
Roll Skia from fbba25f66405 to b80e74dc4cda (2 revisions) ( flutter/engine#42316 )
...
https://skia.googlesource.com/skia.git/+log/fbba25f66405..b80e74dc4cda
2023-05-25 kjlubick@google.com Fix Bazel viewer build
2023-05-25 kjlubick@google.com Move SkJpegInfo impls to src/pdf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 14:39:15 +00:00
skia-flutter-autoroll
cdda3795e8
Roll Dart SDK from 96e29af6e0c6 to be01f9fdac37 (2 revisions) ( flutter/engine#42310 )
...
https://dart.googlesource.com/sdk.git/+log/96e29af6e0c6..be01f9fdac37
2023-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-145.0.dev
2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-144.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 07:42:20 +00:00
skia-flutter-autoroll
456de7c6fb
Roll Skia from 7ec172b433f1 to fbba25f66405 (2 revisions) ( flutter/engine#42309 )
...
https://skia.googlesource.com/skia.git/+log/7ec172b433f1..fbba25f66405
2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c74dae154363 to c18972fdef08 (13 revisions)
2023-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 881cfa15a343 to 2b787917e4a3 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 07:11:23 +00:00
Brandon DeRosier
810607e52c
[Impeller] Simplify CreateContentsForGeometry overloads ( flutter/engine#42306 )
...
Came across this while working on generic fallbacks for mask blurs. For
the unique_ptr case, we always capture ownership and convert to a
shared_ptr anyhow. For the shared_ptr case, we always need to capture a
copy, and so better to not take a const ref and allow the caller to move
if possible.
2023-05-24 20:54:45 -07:00
keyonghan
795a726b5f
Append $flutter/osx sdk property to existing platforms/targets relying on xcode ( flutter/engine#42299 )
...
Part of https://github.com/flutter/flutter/issues/127534
2023-05-25 01:37:29 +00:00
skia-flutter-autoroll
0fea388f04
Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) ( flutter/engine#42301 )
...
https://skia.googlesource.com/skia.git/+log/76bae143aded..150d534341a4
2023-05-24 michaelludwig@google.com [skif] Add max sample radius to SkImageFilters::RuntimeShader
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 84c82fea3f43 to 9ad20521dc02 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-25 00:46:18 +00:00
gaaclarke
dc22f5f572
[Impeller] Turn on vulkan tests for mac CI. ( flutter/engine#42225 )
...
This uses swiftshader to run the tests on mac.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-24 23:25:06 +00:00
Jonah Williams
32d648ec7f
[Impeller] fix UV and color blending. ( flutter/engine#42293 )
...
Fixes https://github.com/flutter/flutter/issues/127486
Combinations of UV mapping and color blending would cause us to double apply the UV mapping which rendered either nothing or garbage.
Before:
After:
2023-05-24 22:57:42 +00:00
godofredoc
a98191b4c0
Use engine_v2 builds on recipe testing. ( flutter/engine#42298 )
...
This is removing the legacy builds from recipes testing and adding the engine v2 ones.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-24 22:56:16 +00:00
Jason Simmons
1007f8bea6
[Impeller] Golden test for text with a shader and a transform ( flutter/engine#42291 )
...
See https://github.com/flutter/engine/pull/42142
2023-05-24 22:07:47 +00:00
skia-flutter-autoroll
81bab68c8f
Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) ( flutter/engine#42295 )
...
https://skia.googlesource.com/skia.git/+log/593ece8f74c7..76bae143aded
2023-05-24 herb@google.com Test for checking that FMA has at least 63 bits
2023-05-24 kjlubick@google.com Expose Paragraph.unresolvedCodepoints
2023-05-24 kjlubick@google.com Move gpu-specific methods off SkSurface
2023-05-24 robertphillips@google.com [graphite] Remove usage of GrClip in should_tile_image_id
2023-05-24 jvanverth@google.com [graphite] Set up VK_KHR_dynamic_rendering extension
2023-05-24 lovisolo@google.com Delete all Win8 tasks.
2023-05-24 robertphillips@google.com [graphite] Move the bicubic padding constant out of GrBicubicEffect
2023-05-24 drott@chromium.org [Fontations] Implement onOpenStream for SkTypeface_Fontations
2023-05-24 cmumford@google.com Update Skia milestone to 116
2023-05-24 cmumford@google.com Merge 13 release notes into RELEASE_NOTES.md
2023-05-24 fmalita@chromium.org Reland "[skottie] Don't revalidate during render()"
2023-05-24 brianosman@google.com Remove empty SkOpts files (crc32, sse42)
2023-05-24 jvanverth@google.com [graphite] Add VulkanImageView support to VulkanTexture.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 21:30:24 +00:00
Mouad Debbar
3784b3880f
[web] Remove comment about dart:html migration ( flutter/engine#42290 )
...
Migration has already happened in [this PR](https://github.com/flutter/engine/pull/33370/files#diff-30cfc07b03caec6d1c915b40a9e50a23d1f1a1c54c670d5996199d805b077daeR213 ) so the comment is not relevant anymore.
2023-05-24 20:35:15 +00:00
Mouad Debbar
04afaaf25e
[web] Hide JS types from dart:ui_web ( flutter/engine#42252 )
...
In order to use the exported `PlatformLocation` cross-platform, we need to remove any JS types from the interface. Namely, `DomEventListener`.
Required by https://github.com/flutter/flutter/pull/126851
2023-05-24 20:26:23 +00:00
Ashish Myles
a96b23fa7e
[web] Update a11y announcements to append divs instead of setting content. ( flutter/engine#42258 )
...
This also removes the appended divs after a short time so that screen readers don't navigate to it, especially when users are entering the DOM to enable accessiblity.
Fixes https://github.com/flutter/flutter/issues/127335 .
2023-05-24 20:08:21 +00:00
Jonah Williams
5fbc30881d
[Impeller] fix Xcode frame capture. ( flutter/engine#42289 )
...
This fixed things for me locally. Confirmed frame captures work and this block otherwise doesn't fire when running regularly
2023-05-24 19:32:06 +00:00
Jason Simmons
4c29368376
[Impeller] Create an autorelease pool for Impeller tests running on macOS. ( flutter/engine#42265 )
...
See https://github.com/flutter/flutter/issues/127358
2023-05-24 19:16:13 +00:00
skia-flutter-autoroll
a8f1d8d242
Roll Dart SDK from d46987001f76 to 9bea16a7dcbd (2 revisions) ( flutter/engine#42286 )
...
https://dart.googlesource.com/sdk.git/+log/d46987001f76..9bea16a7dcbd
2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-142.0.dev
2023-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-141.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 18:05:20 +00:00
Jason Simmons
a5f4c7ffba
[Impeller] Disable the offscreen layer checkerboard drawing function on Impeller. ( flutter/engine#42221 )
...
This function creates a Skia bitmap that can not be rendered by Impeller.
See https://github.com/flutter/flutter/issues/127080
2023-05-24 17:11:01 +00:00
skia-flutter-autoroll
072ef18be0
Roll Skia from 14e1667e8031 to 593ece8f74c7 (3 revisions) ( flutter/engine#42284 )
...
https://skia.googlesource.com/skia.git/+log/14e1667e8031..593ece8f74c7
2023-05-24 robertphillips@google.com [graphite] Use SkCanvas::QuadAAFlags more in the Ganesh Device (esp. drawImageQuad)
2023-05-24 kjlubick@google.com Reland "Remove legacy SkSurface factories"
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cd2d20c6e4a3 to 84c82fea3f43 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 17:05:53 +00:00
Brandon DeRosier
d6a717c958
[Impeller] Add 1 pixel border to snapshots of Contents ( flutter/engine#42277 )
...
Everything in Impeller is theoretically treated as if being drawn to
layers of infinite size. Without this change, there's a coverage leak
that occurs in some filters due to the customizable sampling mode. I
should be able to get rid of this 1 pixel padding by refactoring the way
we do sampling in the filter inputs (we already have most of this
infrastructure in place), but this is a correct, safe, and
not-that-expensive solution for the time being.
2023-05-24 09:46:46 -07:00
Mouad Debbar
3a4677a6d7
[web] Cleanup assertionsEnabled ( flutter/engine#41829 )
...
For consistency with the rest of the flutter code, this PR explores the possibility of removing our proprietary `assertionsEnabled`.
2023-05-24 15:08:50 +00:00
skia-flutter-autoroll
bb5340e0d1
Roll Fuchsia Linux SDK from -dXJ_pnUVwmjscIYm... to UYN_Tk7M6_5d2aGIj... ( flutter/engine#42280 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:07:11 +00:00
skia-flutter-autoroll
6ce9bd2fbf
Roll Skia from fbae152253ac to 14e1667e8031 (3 revisions) ( flutter/engine#42279 )
...
https://skia.googlesource.com/skia.git/+log/fbae152253ac..14e1667e8031
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3f633521356d to c74dae154363 (10 revisions)
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ddf59ec4e8fc to 881cfa15a343 (6 revisions)
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cd1fb6876701 to 028726497ad3 (19 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 15:03:05 +00:00
skia-flutter-autoroll
6b93a153d6
Roll Skia from 69f7860093b4 to fbae152253ac (3 revisions) ( flutter/engine#42276 )
...
https://skia.googlesource.com/skia.git/+log/69f7860093b4..fbae152253ac
2023-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a74d1a1b81a6 to 881cfa15a343
2023-05-23 sunnyps@chromium.org graphite: Change empty submit logs to debug level
2023-05-23 49699333+dependabot[bot]@users.noreply.github.com Bump socket.io-parser and socket.io in /modules/pathkit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-24 06:04:16 +00:00
Brandon DeRosier
6c9a9ab884
[Impeller] Add golden repro for mask blur issues ( flutter/engine#42275 )
...
Part of https://github.com/flutter/flutter/issues/127013 .
This is a repro to track the mask blur issues. If we accidentally
trigger the wrong kind of blur, this golden will make it obvious because
the gradient lines will become much more blurry.
Once this problem is fixed, the circle's mask should be fully blurred
and the rounded rectangle should have no edge clamping (the diagonal
lines should continue as the edges fade to black).
2023-05-23 22:53:53 -07:00
Brandon DeRosier
58ad391722
[Impeller] Start of Dart GPU prototype ( flutter/engine#42228 )
...
I've been slowly hacking on a prototype alongside a doc (public go link [imminent](https://github.com/flutter/website/pull/8716 )) for a while (the doc has been changing a lot as a result of prototyping) and I think it's time to start landing parts of this prototype/experiment in-tree.
This initial PR just sets up the main context singleton on the UI thread. After this, I'll land the shader management stuff.
I re-used the existing experimental 3D flag for this, since this is meant to replace what can be done with Impeller Scene anyway.
2023-05-24 04:22:42 +00:00
Brandon DeRosier
6828abffee
[Impeller] Set the coverage hint on everything ( flutter/engine#42264 )
...
Attaches a minimum coverage hint to all rendered entities. This makes ImageFilter blurs do less work when clipped. We can utilize this in a number of other filters as well.
The test I added also demonstrates a sampling issue in the gaussian blur that I'm trying to work out. Here it is without any clipping. This coverage hint change does not introduce the issue:
2023-05-24 02:06:19 +00:00
Brandon DeRosier
e9298a1d2a
[Impeller] Limit rrect blur kernel to 1000x1000 ( flutter/engine#42269 )
...
Impose the same large limit as the slower 2-pass blur.
Also renames "RRectShadow" to the much less ambiguous "SolidRRectBlur".
Before, a large enough blur sigma would result in nothing getting drawn. The Gaussian integral seems to be working fine against 16bit ops, so no adjustments were needed in the shader.
2023-05-24 01:59:17 +00:00
godofredoc
79407cfd52
Add builders for second level cache of builders. ( flutter/engine#42271 )
...
These builders will generate CAS caches to optimize engine checkouts.
Bug: https://github.com/flutter/flutter/issues/127433
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-24 01:33:06 +00:00
Jonah Williams
61c017d2f6
[Impeller] remove framebuffer blending from atlas, fix transform scale ( flutter/engine#42254 )
...
Fixes https://github.com/flutter/flutter/issues/127374
2023-05-24 00:01:33 +00:00
gaaclarke
9258309eed
Turned back on debug unit tests ( flutter/engine#42261 )
...
I refactored the `EXPECT_EXIT` tests since they are unsafe to execute in a process with multiple threads.
This leaves `flutter_desktop_darwin_unittests` disabled since it has existing issues.
fixes https://github.com/flutter/flutter/issues/103757
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-05-23 23:13:35 +00:00
