Yegor
2abe536ed8
[web] replace browser-related conditional logic with BrowserEnvironment ( flutter/engine#27084 )
...
* [web] replace browser-related conditional logic with BrowserEnvironment
2021-07-02 12:04:45 -07:00
Harry Terkelsen
203d76f26f
Update goldens test for Thai. ( flutter/engine#27144 )
...
The Noto Sans Thai UI font was recently updated on fonts.google.com
2021-07-02 12:02:07 -07:00
Yegor
fce4cc3d39
[web] collect macOS info only on bot; propagate errors ( flutter/engine#27089 )
2021-07-01 13:08:49 -07:00
Dan Field
72d7ac4ba4
Remove unnecessary experiment flag ( flutter/engine#27072 )
...
* Remove unnecessary experiment flag
* add explicit --no-sound-null-safety
2021-07-01 12:27:42 -07:00
Mouad Debbar
0ab11ab252
[web][felt] Fix stdout inheritance for sub-processes ( flutter/engine#27070 )
2021-06-30 12:26:02 -07:00
Mouad Debbar
d760a28918
[web] Render RTL text correctly ( flutter/engine#26811 )
2021-06-29 15:30:32 -07:00
Yegor
928b3ad5db
[web] felt --watch fixes ( flutter/engine#27009 )
...
* make processes interruptible
* make --watch compatible with Windows:
* add 'q' shortcut to quit (Ctrl + C on Windows is wonky)
* use package:path for cross-platform path processing
2021-06-29 12:58:01 -07:00
Yegor
d8df13fc74
[web] make analysis options delta of root options ( flutter/engine#26991 )
...
Import the root options and explicitly disable lints that our code
violates.
Fix several lint violations.
2021-06-28 18:59:30 -07:00
Harry Terkelsen
7645b70658
Roll CanvasKit to 0.28.1 ( flutter/engine#27013 )
2021-06-28 15:18:36 -07:00
Mouad Debbar
7cf398ef9e
[web] Honor background color when rendering text to dom ( flutter/engine#26908 )
2021-06-24 14:02:20 -07:00
Harry Terkelsen
d26b2539fc
[canvaskit] Fix bug where empty scene doesn't overwrite contentful scene ( flutter/engine#26820 )
2021-06-18 14:55:50 -07:00
Yegor
7a60f2fb7f
[web] text_editing_test.dart nnbd; bump test dep ( flutter/engine#26709 )
2021-06-11 12:31:51 -07:00
Yegor
51e23b9818
[web] test runner fixes: build, sourcemaps, Dart 1-isms ( flutter/engine#26696 )
2021-06-10 15:37:41 -07:00
Yegor
a62d2b337d
migrate the rest of dev/ to null safety ( flutter/engine#26668 )
...
* migrate the rest of dev/ to null safety
2021-06-09 22:12:27 -07:00
Yegor
3d93c2d50f
small clean-up of the license script ( flutter/engine#26659 )
...
* small clean-up of the license script
2021-06-09 16:22:35 -07:00
Yegor
1133396895
[web] migrate more felt code to null safety ( flutter/engine#26649 )
...
* [web] migrate more felt code to null safety
2021-06-09 13:19:14 -07:00
Yegor
339073d44b
[web] migrate some felt code to null safety ( flutter/engine#26644 )
...
* [web] migrate some felt code to null safety
2021-06-09 11:30:51 -07:00
Ferhat
fa7b61e7dc
Reland reverted #26384 ( flutter/engine#26566 )
2021-06-03 10:50:37 -07:00
Kaushik Iska
c1ae81f6e9
Revert "Implement ImageShader for html Canvas ( #26384 )" ( flutter/engine#26525 )
...
This reverts commit ed6e5fd3fb82b29822bac6a6fc9904b05f284a85.
See: https://github.com/flutter/flutter/issues/83753
2021-06-01 17:29:03 -07:00
Ferhat
ed6e5fd3fb
Implement ImageShader for html Canvas ( flutter/engine#26384 )
2021-06-01 15:52:56 -07:00
Yegor
f68d1a66cc
suppress output from intentionally failing tests ( flutter/engine#26253 )
...
* suppress output from intentionally failing tests
2021-06-01 10:46:06 -07:00
Yegor
a790ebce3b
web: improve engine dev cycle on Windows ( flutter/engine#25812 )
...
* felt.bat: simple incremental felt for Windows
2021-05-13 17:14:46 -07:00
LongCatIsLooong
177d73babf
add TextLeadingDistribution to webui TextStyle ( flutter/engine#25777 )
2021-05-13 15:29:02 -07:00
Ferhat
1c7f312d6a
Implement ColorFilter.matrix for html renderer ( flutter/engine#25769 )
2021-04-27 10:04:09 -07:00
Harry Terkelsen
db2fcff7cd
[canvaskit] Implement TextHeightBehavior ( flutter/engine#25734 )
...
* Add TextHeightBehavior
* Remove TODO
* Update goldens lock
* Update goldens_lock
2021-04-26 17:08:01 -07:00
Ferhat
508b6905cf
Add web ImageShader support for drawVertices. ( flutter/engine#25729 )
2021-04-23 14:15:17 -07:00
Harry Terkelsen
b1c0cf8ce2
Wire up paragraph font weight and font style in canvas golden test ( flutter/engine#25700 )
...
* Wire up paragraph font weight and font style in canvas golden test
* Update TODOs in test
* Update goldens lock
2021-04-22 13:06:36 -07:00
Harry Terkelsen
07eddf7b53
Include paragraph height in the top-level text style. ( flutter/engine#25659 )
...
* Include paragraph height in the top-level text style.
* Update test comment
* Update goldens lock
2021-04-21 12:45:51 -07:00
Ferhat
af075e03fd
Fix drawVertices when using indices for web_html ( flutter/engine#25614 )
2021-04-15 15:56:36 -07:00
Mouad Debbar
739cf598e2
[web] Render ellipsis for overflowing text in DOM mode ( flutter/engine#25556 )
2021-04-15 06:09:02 -07:00
Ferhat
9f8e235046
[web] Fix linear gradient transformation matrix ( flutter/engine#25545 )
2021-04-13 10:12:16 -07:00
Mouad Debbar
79e243761d
[web] Use greatest span font size on the parent paragraph ( flutter/engine#25513 )
2021-04-09 17:46:45 -07:00
Ferhat
e3c5c74009
[web] Fix shadermask rendering using CanvasKit ( flutter/engine#25456 )
2021-04-06 12:57:29 -07:00
Chris Bracken
9b4a0264d5
Correct typos throughout the engine/embedder ( flutter/engine#25346 )
...
Used the the `misspell` tool available at
https://github.com/client9/misspell , then applied hand-corrections. It's
possible we could adopt this as a presubmit, but there are still enough
false positives that it may not be worth the effort.
2021-04-01 11:08:19 -07:00
Mouad Debbar
f8d60eac0b
[web] More meaningful test for font features ( flutter/engine#25206 )
2021-03-25 14:59:05 -07:00
Ferhat
b9f5ee0604
[web] Fix drawImage colorFilter with dstATop blend mode ( flutter/engine#25165 )
2021-03-25 10:45:28 -07:00
Michael Goderbauer
265a223709
Remove ignores that are not ignoring anything ( flutter/engine#25128 )
2021-03-23 17:46:01 -07:00
Mouad Debbar
586df25fe1
[web] Implement font features in the html renderer ( flutter/engine#25088 )
2021-03-23 12:15:26 -07:00
Ferhat
3b6c8434cb
[web] Fix handling of ClipOp.none ( flutter/engine#25080 )
2021-03-18 15:58:26 -07:00
Yegor
5a5f326745
[web] Make window.locale(s) non-null; upgrade to null safe deps ( flutter/engine#24922 )
...
* Make window.locale(s) non-null
* upgrade deps to null-safe; migrate some test libs
2021-03-11 14:28:49 -08:00
Mouad Debbar
eea586c427
[web] Reland: Fix painting of last placeholder in paragraph ( flutter/engine#24905 )
2021-03-10 15:30:01 -08:00
Chris Bracken
13cf185e1c
Correct setup-related typos ( flutter/engine#24846 )
...
Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
forms of setup as 'setup'. Also settles on 'teardown' as opposed to
tear-down for consistency across the codebase.
A few other minor comment/wording corrections.
2021-03-08 17:31:10 -08:00
Chris Bracken
a15f44a9e2
Revert "[web] Fix painting of last placeholder in paragraph ( #24716 )" ( flutter/engine#24773 )
...
This broke the Linux Web Tests target in the framework tests.
Example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/11335/overview
Failure log:
```
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: WidgetSpan calculate correct intrinsic heights [E]
Test failed. See exception logs above.
The test description was: WidgetSpan calculate correct intrinsic heights
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
Assertion failed: file:///b/s/w/ir/k/flutter/packages/flutter/lib/src/rendering/box.dart:2237:16
!RenderObject.debugCheckingIntrinsics
is not true
The relevant error-causing widget was:
Text file:///b/s/w/ir/k/flutter/packages/flutter_test/lib/src/binding.dart:567:12
When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49 throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3 assertFailed
../packages/flutter/src/rendering/layer.dart.js 4485:79 <fn>
../packages/flutter/src/rendering/layer.dart.js 4551:26 debugAssertDoesMeetConstraints
../packages/flutter/src/rendering/layer.dart.js 4380:14 <fn>
../packages/flutter/src/rendering/layer.dart.js 4382:26 set size
../packages/flutter/src/rendering/paragraph.dart.js 786:17 performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14 layout
../packages/flutter/src/rendering/shifted_box.dart.js 451:36 performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14 layout
../packages/flutter/src/rendering/layer.dart.js 4875:58 performLayout
../packages/flutter/src/rendering/layer.dart.js 3279:14 [_layoutWithoutResize]
../packages/flutter/src/rendering/layer.dart.js 6876:107 flushLayout
../packages/flutter_test/src/_matchers_web.dart.js 3990:30 drawFrame
../packages/flutter/src/rendering/layer.dart.js 6128:12 [_handlePersistentFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 764:9 [_invokeFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 732:37 handleDrawFrame
../packages/flutter_test/src/_matchers_web.dart.js 3954:12 scheduleWarmUpFrame
../packages/flutter/src/widgets/widget_span.dart.js 52123:11 <fn>
../packages/flutter/src/widgets/widget_span.dart.js 52125:7 runApp
../packages/flutter_test/src/_matchers_web.dart.js 3647:18 _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5 _async
../packages/flutter_test/src/_matchers_web.dart.js 3644:20 [_runTestBody]
../dart-sdk/lib/async/zone.dart 1386:13 _rootRunBinary
../dart-sdk/lib/async/zone.dart 1272:19 runBinary
../packages/flutter_test/src/_matchers_web.dart.js 3636:16 [_runTest]
../packages/flutter_test/src/_matchers_web.dart.js 4072:44 <fn>
../packages/fake_async/fake_async.dart.js 141:96 <fn>
../dart-sdk/lib/async/zone.dart 1354:13 _rootRun
../dart-sdk/lib/async/zone.dart 1258:19 run
../dart-sdk/lib/async/zone.dart 1788:67 _runZoned
../dart-sdk/lib/async/zone.dart 1711:10 runZoned
../packages/clock/src/stopwatch.dart.js 364:18 withClock
../packages/fake_async/fake_async.dart.js 141:55 <fn>
../dart-sdk/lib/async/zone.dart 1354:13 _rootRun
../dart-sdk/lib/async/zone.dart 1258:19 run
../dart-sdk/lib/async/zone.dart 1788:67 _runZoned
../dart-sdk/lib/async/zone.dart 1711:10 runZoned
../packages/fake_async/fake_async.dart.js 141:20 run
../packages/flutter_test/src/_matchers_web.dart.js 4067:17 runTest
../packages/flutter_test/src/_matchers_web.dart.js 5312:24 <fn>
../packages/test_api/src/frontend/async_matcher.dart.js 862:17 <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 179:98 <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16 [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 179:80 <fn>
../dart-sdk/lib/async/zone.dart 1362:47 _rootRunUnary
../dart-sdk/lib/async/zone.dart 1265:19 runUnary
../dart-sdk/lib/async/future_impl.dart 155:18 handleValue
../dart-sdk/lib/async/future_impl.dart 707:44 handleValueCallback
../dart-sdk/lib/async/future_impl.dart 736:13 _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 406:9 <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16 [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 170:71 <fn>
../dart-sdk/lib/async/zone.dart 1354:13 _rootRun
../dart-sdk/lib/async/zone.dart 1258:19 run
../dart-sdk/lib/async/zone.dart 1162:7 runGuarded
../dart-sdk/lib/async/zone.dart 1202:23 callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11 _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5 _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15 <fn>
The following RenderObject was being processed when the exception was fired: RenderParagraph#e6e8f relayoutBoundary=up1 NEEDS-PAINT:
creator: RichText ← Text ← Center ← Container-[#9a020] ← [root]
parentData: offset=Offset(0.0, 0.0) (can use size)
constraints: BoxConstraints(0.0<=w<=800.0, 0.0<=h<=600.0)
size: Size(640.0, 40.0)
textAlign: start
textDirection: ltr
softWrap: wrapping at box width
overflow: clip
maxLines: unlimited
This RenderObject had the following child:
text: TextSpan
```
This reverts commit bcba78b6829849ffe7c4638bd69b3ceeb7631666.
2021-03-03 22:27:07 -08:00
Mouad Debbar
bcba78b682
[web] Fix painting of last placeholder in paragraph ( flutter/engine#24716 )
2021-03-02 10:30:21 -08:00
Ferhat
a3eec1815c
[web] Add xcode-symlinks flag to felt tool ( flutter/engine#24556 )
2021-02-25 14:26:41 -08:00
Ferhat
c694e1d965
[web] Implement Canvas.drawPicture ( flutter/engine#24574 )
2021-02-24 13:01:44 -08:00
Jim Graham
e3b2cc8ce9
backdrop filter layer should report cull_rect as its paint bounds ( flutter/engine#24489 )
2021-02-23 18:02:49 -08:00
Ferhat
f6c8fa6910
Refactor gradient renderer to produce image. Implement gradient based Shadermask ( flutter/engine#24029 )
2021-02-19 16:45:23 -08:00
Yegor
47a1f0571d
fix missing CJK and symbol glyphs, font precedence, fallback reset ( flutter/engine#24470 )
...
* fix missing CJK and symbol glyphs
* Cache known covered code units
Co-authored-by: Harry Terkelsen <het@google.com>
2021-02-19 13:49:16 -08:00
Harry Terkelsen
4954a033ec
Roll CanvasKit to 0.24. ( flutter/engine#24498 )
...
* Update tests for new API
* Update goldens and respond to comment
2021-02-18 16:53:49 -08:00