Jason Simmons
2831e61a9d
[Impeller] Terminate the fence waiter but do not reset it during ContextVK shutdown ( #173085 )
...
ContextVK::Shutdown was clearing the context's fence_waiter_. This could
cause crashes if a pending task such as image decoding is still holding
a reference to the context after ContextVK::Shutdown is called.
The image decode task will submit a command buffer through the context,
and CommandQueueVK::Submit will get a null pointer deference when it
tries to use the fence waiter.
This PR changes ContextVK::Shutdown to terminate the fence waiter
instead of clearing it. FenceWaiterVK::Terminate will now stop the
waiter thread and wait for the thread to exit.
This ensures that the fence waiter thread is stopped in
ContextVK::Shutdown even if something else is holding a reference to the
FenceWaiterVK. Tasks like image decoding will now get an error result
instead of a crash when submitting a command buffer after context
shutdown.
2025-08-04 17:58:57 +00:00
gaaclarke
bd542bb687
licenses_cpp: reland switch 4 ( #173139 )
...
Let's give this one more go, otherwise we'll have to switch to
downloading a prebuilt binary.
## whats new since revert
I've added `is_minimal_linux` flag which removes targets that can't be
processed by GN on the autoroller image. The linux bot has been changed
to use that flag too.
## testing
I got access to the docker image of the autoroller bots and manually
tested that this works.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-08-04 17:37:29 +00:00
engine-flutter-autoroll
82a2c28688
Roll Skia from edf0f8a5bba6 to 763bba9c33fd (1 revision) ( #173213 )
...
https://skia.googlesource.com/skia.git/+log/edf0f8a5bba6..763bba9c33fd
2025-08-04 kjlubick@google.com Reland "Roll Skia Infra from d032ed5ea841
to 57b81f6717e0 (12 revisions)"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 14:37:21 +00:00
Kostia Sokolovskyi
a128ccbe94
[web] Add Intl.Locale to parse browser languages. ( #172964 )
...
Closes https://github.com/flutter/flutter/issues/130174
### Description
- Adds `DomLocale` extension type for
[`Intl.Locale`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale )
- Replaces manual browser language parsing with `DomLocale` usage
- Adds tests to cover new functionality
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-04 14:28:20 +00:00
engine-flutter-autoroll
fe07188bf3
Roll Skia from 439f80973f4a to edf0f8a5bba6 (2 revisions) ( #173204 )
...
https://skia.googlesource.com/skia.git/+log/439f80973f4a..edf0f8a5bba6
2025-08-04 greengrape@google.com Revert "Roll Skia Infra from
d032ed5ea841 to 57b81f6717e0 (12 revisions)"
2025-08-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 2ef85c2418f4 to b6b2f380814e (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 11:43:27 +00:00
engine-flutter-autoroll
977ecb16f9
Roll Skia from 39c70f883c0e to 9d30cc96a3b2 (1 revision) ( #173197 )
...
https://skia.googlesource.com/skia.git/+log/39c70f883c0e..9d30cc96a3b2
2025-08-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from d032ed5ea841 to 57b81f6717e0 (12 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,bungeman@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-04 06:47:01 +00:00
engine-flutter-autoroll
d9824ea638
Roll Fuchsia Linux SDK from wZuA8Dqty4scQkZuV... to ufssK8EgJ_9RpLFgu... ( #173190 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-03 23:00:38 +00:00
John "codefu" McDole
ed1215221e
fix: tag fuchsia package after uploading ( #173140 )
...
fixes : #173137
tests: there are none;
engine/src/flutter/tools/fuchsia/build_fuchsia_artifacts_test.py is a
hollow shell.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
2025-08-03 05:23:08 +00:00
engine-flutter-autoroll
3dee438b1d
Roll Fuchsia Linux SDK from yFLr81lLXmSX7n11D... to wZuA8Dqty4scQkZuV... ( #173166 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-02 20:51:42 +00:00
engine-flutter-autoroll
cc4f1a09f1
Roll Skia from 81dd6aa516b0 to af6d6eb383a6 (2 revisions) ( #173144 )
...
https://skia.googlesource.com/skia.git/+log/81dd6aa516b0..af6d6eb383a6
2025-08-01 michaelludwig@google.com [graphite] Fix erroneous edit to
kMaxBruteForceN
2025-08-01 bungeman@google.com Make SkFontMgr_AndroidNDK find names in
fonts.xml
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-02 05:10:10 +00:00
engine-flutter-autoroll
0420eee2d4
Roll Dart SDK from 6e1bb159c860 to 3f1307d72d6f (2 revisions) ( #173136 )
...
https://dart.googlesource.com/sdk.git/+log/6e1bb159c860..3f1307d72d6f
2025-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-59.0.dev
2025-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-58.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-01 23:09:26 +00:00
engine-flutter-autoroll
e13dd5384c
Roll Skia from 9e2c59634961 to 81dd6aa516b0 (1 revision) ( #173135 )
...
https://skia.googlesource.com/skia.git/+log/9e2c59634961..81dd6aa516b0
2025-08-01 michaelludwig@google.com Revert "New way to scale RRect"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-01 22:28:32 +00:00
bungeman
cdc0994b1b
Add skia_ports_fontmgr_android_parser_sources ( #172979 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
The `skia_ports_fontmgr_android_sources` file list is being split. Add
the new (currently empty) list so that the build is prepared for when
the sources are moved.
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
This is a trivial build change to prevent build breakage when Skia moves
some files around.
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-01 20:21:36 +00:00
engine-flutter-autoroll
01ca422fd9
Roll Skia from 49e39cd3cf18 to 9e2c59634961 (10 revisions) ( #173125 )
...
https://skia.googlesource.com/skia.git/+log/49e39cd3cf18..9e2c59634961
2025-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from fb70194bdda2 to 4fa34a4d8e50 (3 revisions)
2025-08-01 mike@reedtribe.org New way to scale RRect
2025-08-01 kjlubick@google.com Set up scripts for louhi flows for
binary-size and cmake-release
2025-08-01 mike@reedtribe.org Add optional form for SkRRect::transform()
2025-08-01 kjlubick@google.com Remove alignment constraint on
SkMemoryCtxPatch
2025-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d94f5aa38f2a to 2ef85c2418f4 (8 revisions)
2025-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from e4cf17db6917 to d032ed5ea841 (8 revisions)
2025-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 0f93cd5124d8 to abde297cd9e8 (13 revisions)
2025-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7cc0f6d3a219 to fb70194bdda2 (4 revisions)
2025-08-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-01 20:07:31 +00:00
engine-flutter-autoroll
872579e119
Roll Fuchsia Linux SDK from xo_bqOoFuBKFmgKxn... to yFLr81lLXmSX7n11D... ( #173117 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-01 18:41:58 +00:00
engine-flutter-autoroll
871849e4b6
Roll Dart SDK from 6832e04cf2f9 to 6e1bb159c860 (8 revisions) ( #173119 )
...
https://dart.googlesource.com/sdk.git/+log/6832e04cf2f9..6e1bb159c860
2025-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-57.0.dev
2025-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-56.0.dev
2025-08-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-55.0.dev
2025-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-54.0.dev
2025-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-53.0.dev
2025-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-52.0.dev
2025-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-51.0.dev
2025-07-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-50.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-01 17:56:42 +00:00
Jamil Saadeh
6feaa2c632
[engine] Null aware elements clean-ups ( #173075 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Converted more null checks to null aware elements.
Part of #172188
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-01 16:19:22 +00:00
auto-submit[bot]
a1dda4fe8b
Reverts "Reland licenses cpp switch 3 ( #173063 )" ( #173113 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#173063
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Again failing out because pkg-config is not
present on the host machine.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jtmcdole, jason-simmons}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
reland of https://github.com/flutter/flutter/pull/173059
Unfortunately we don't have the ability to test the changes on the
autoroller bots beforehand, so we have to resort to landing new
attempts.
## changes since last revert
- Removed usage of `et`. That was doing a `gn desc` call which forced GN
to look for x11 for glfw which relies on `pkg-config` which doesn't
exist on those machines.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-08-01 15:49:26 +00:00
Chinmay Garde
ab27dd6c0e
Upload the linux arm64 embedder to cloud buckets. ( #173068 )
...
Fixes https://github.com/flutter/flutter/issues/173067
2025-07-31 22:44:28 +00:00
gaaclarke
909c69811d
Reland licenses cpp switch 3 ( #173063 )
...
reland of https://github.com/flutter/flutter/pull/173059
Unfortunately we don't have the ability to test the changes on the
autoroller bots beforehand, so we have to resort to landing new
attempts.
## changes since last revert
- Removed usage of `et`. That was doing a `gn desc` call which forced GN
to look for x11 for glfw which relies on `pkg-config` which doesn't
exist on those machines.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-07-31 21:41:52 +00:00
bufffun
a13bb6d13e
[macOS] Remove duplicate object initialization ( #171767 )
...
another initialization at line 526
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-31 21:19:08 +00:00
engine-flutter-autoroll
60184bfbc1
Roll Skia from 42e3bed42110 to 49e39cd3cf18 (7 revisions) ( #173069 )
...
https://skia.googlesource.com/skia.git/+log/42e3bed42110..49e39cd3cf18
2025-07-31 nicolettep@google.com Reland "[graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support"
2025-07-31
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-31 borenet@google.com [SkPathBuilder] Add rMoveTo
2025-07-31 bungeman@google.com Fix limits in fontmgr_bounds gm
2025-07-31 mike@reedtribe.org Fix pathkit build
2025-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b2f40c904dad to 7cc0f6d3a219 (1 revision)
2025-07-31 mike@reedtribe.org More conversions of verbs from uint8_t to
SkPathVerb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-31 20:21:04 +00:00
gaaclarke
9358b7cee3
licenses_cpp: Switched to lexically_relative for 2x speed boost. ( #173048 )
...
rework of https://github.com/flutter/flutter/pull/172701
test: no logical change, just performance change
On my machine this takes us from ~35s to 19s.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-07-31 19:42:06 +00:00
Siva
40fe519aad
Add dartvm to the dart_sdk_entitlement_config list. ( #173044 )
...
Add dartvm to the dart_sdk_entitlement_config list.
2025-07-31 18:57:15 +00:00
Mouad Debbar
b20149bf11
[web] ClickDebouncer workaround for iOS Safari click behavior ( #172995 )
...
It turns out iOS Safari in some cases tracks timers that are scheduled
from within a `pointerdown` listener, and it delays the `click` event
until those timers have expired (with a max waiting time of 350ms or
so).
The `ClickDebouncer` sets a timer of 200ms to see if a `click` event is
received by then. But because of the Safari behavior explained above,
the `click` event will always arrive right after the `ClickDebouncer`'s
timer, so we always misattribute the `click` event.
Fixes https://github.com/flutter/flutter/issues/172180
2025-07-31 18:47:25 +00:00
auto-submit[bot]
016143afde
Reverts "Reland licenses cpp switch 2 ( #172996 )" ( #173059 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#172996
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: autoroller script failure, no pkg-config
```
Failed to transition from "idle" to "active": failed pre-upload step: Command exited with exit status 127: /data/flutter/.autoroller-preupload.sh; Stdout+Stderr:
ERROR at //build/config/linux/pkg_config.gni:103:17: Script returned non-zero exit code.
pkgresult = exec_script(pkg_config_script, args, "value")
^----------
Curren
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Differences since last land:
1) `gn gen` is now called in the script (see https://github.com/flutter/flutter/pull/172904 )
1) The licenses are now simpatico with google's lint (https://github.com/flutter/flutter/pull/172991 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-07-31 18:07:48 +00:00
Mouad Debbar
5b78ecca51
[web] Text editing test accepts both behaviors in Firefox ( #172767 )
...
Fixes https://github.com/flutter/flutter/issues/172713
2025-07-31 17:01:09 +00:00
gaaclarke
2a391acbc8
Reland licenses cpp switch 2 ( #172996 )
...
Differences since last land:
1) `gn gen` is now called in the script (see
https://github.com/flutter/flutter/pull/172904 )
1) The licenses are now simpatico with google's lint
(https://github.com/flutter/flutter/pull/172991 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-31 16:42:13 +00:00
gaaclarke
0e49f1a807
impeller: Shrink Command 40 bytes ( #173004 )
...
The allocation of all the Command instances in the past has shown up in
profiles. On macos arm64 this change removes 40 bytes from the class.
This is accomplished by shrinking the datasize of fields that are bigger
than they need to be and sorting the smaller fields at the end to reduce
packing.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-31 15:24:34 +00:00
Mouad Debbar
7a5d1ab2e2
[web] Remove outdated comment about HTML renderer ( #172877 )
2025-07-31 15:07:08 +00:00
engine-flutter-autoroll
2c21273bfd
Roll Skia from 7d468a4868cb to ff4da49305c5 (3 revisions) ( #173028 )
...
https://skia.googlesource.com/skia.git/+log/7d468a4868cb..ff4da49305c5
2025-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from e286ef784996 to d94f5aa38f2a (11 revisions)
2025-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 7cd1022cdc50 to 681d07e76d8e (1 revision)
2025-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from baf909de57f0 to e4cf17db6917 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-31 09:12:43 +00:00
Siva
5f6fbe2275
Manual roll of Dart from 14ea8d342149 to 6832e04cf2f9 ( #173015 )
...
https://dart.googlesource.com/sdk.git/+log/14ea8d342149..6832e04cf2f9
2025-07-30
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-49.0.dev
2025-07-30
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-48.0.dev
2025-07-30
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-47.0.dev
2025-07-30
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-46.0.dev
2025-07-29
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-45.0.dev
2025-07-29
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-44.0.dev
2025-07-29
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-43.0.dev
2025-07-29
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-42.0.dev
2025-07-29
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-41.0.dev
2025-07-28
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-40.0.dev
2025-07-28
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-39.0.dev
2025-07-28
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-38.0.dev
2025-07-27
[dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com ](mailto:dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com)
Version 3.10.0-37.0.dev
2025-07-31 05:21:26 +00:00
engine-flutter-autoroll
ef02330b56
Roll Fuchsia Linux SDK from bQVQlLssTxxLjoDU0... to xo_bqOoFuBKFmgKxn... ( #173021 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-31 03:43:27 +00:00
engine-flutter-autoroll
74d0ca2143
Roll Skia from a3347cee2d73 to 8bdf4cdcf4ed (3 revisions) ( #173013 )
...
https://skia.googlesource.com/skia.git/+log/a3347cee2d73..8bdf4cdcf4ed
2025-07-30 mike@reedtribe.org Return optional from Path iters
2025-07-30 kjlubick@google.com Try different way to copy index.d.ts into
debugger app
2025-07-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-31 01:20:35 +00:00
Jamil Saadeh
d6a4ace891
Migrate to null aware elements - Part 4 ( #172322 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Replace null checks with null aware elements - part 4
Part of #172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-30 20:45:02 +00:00
gaaclarke
3042b87457
Made licenses_cpp simpatico with google licenses ( #172991 )
...
fixes https://github.com/flutter/flutter/issues/172920
successful run at go/paste/6412196653039616
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-30 20:28:43 +00:00
engine-flutter-autoroll
76dccd3ef1
Roll Skia from d579722d65c6 to a3347cee2d73 (6 revisions) ( #172989 )
...
https://skia.googlesource.com/skia.git/+log/d579722d65c6..a3347cee2d73
2025-07-30 michaelludwig@google.com [graphite] Add option to use raster
atlas for small paths
2025-07-30 kjlubick@google.com Remove direct dependency on GL from
Android EGL build
2025-07-30 kjlubick@google.com Fix compile error in SkPathRawShapes
2025-07-30 borenet@google.com [SkPath] Re-arrange public/private
sections in SkPath.h
2025-07-30 mike@reedtribe.org Migrate SkPathRef to use SkPathVerb
2025-07-30 borenet@google.com [SkPathBuilder] Expose SkPath::ArcSize and
SkPath::AddpathMode
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-30 19:48:23 +00:00
Ricardo Dalarme
56d5389456
Migrate to null aware elements - Part 5 ( #172418 )
...
## Description
Continuing the work from @jamilsaadeh97 to replace verbose null checks
with modern
[null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements )
syntax.
This PR cleans up the remaining files not covered in the previous parts,
making the code more concise.
## Related PRs
- https://github.com/flutter/flutter/pull/172198
- https://github.com/flutter/flutter/pull/172306
- https://github.com/flutter/flutter/pull/172307
- https://github.com/flutter/flutter/pull/172322
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-07-30 18:40:09 +00:00
Siva
5143f4333c
Reland - Manual roll of Dart from 5ede85aff798 to 14ea8d342149 ( #172947 )
...
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
2025-07-30 16:37:17 +00:00
gaaclarke
230b2e5aa9
Impeller gemini md ( #172724 )
...
Added gemini.md file for impeller and tweaked the root gemini.md.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-30 16:37:00 +00:00
gaaclarke
50e951f05b
Defensive get local coverage limit ( #172888 )
...
issue: #168210
The issue doesn't have reproduction steps. We could potentially make
that code not crash but that would probably just result in bad draws.
This is an attempt to gather more information to decide how to address
that issue.
test exempt: no new logic, just adds asserts.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-30 16:36:48 +00:00
gaaclarke
45d112f127
Made the view controller weak for the accessibility bridge. ( #172871 )
...
fixes: https://github.com/flutter/flutter/issues/172105
The migration to ARC accidentally changes the semantics for this ivar.
[It was previously a weak
ptr](3038239932/engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.h (L91)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-07-30 16:36:35 +00:00
engine-flutter-autoroll
cb9e7b10ec
Roll Skia from da5a6704f8a3 to d579722d65c6 (2 revisions) ( #172969 )
...
https://skia.googlesource.com/skia.git/+log/da5a6704f8a3..d579722d65c6
2025-07-30 bungeman@google.com Add empty skia_fontmgr_android_parser
target
2025-07-30 michaelludwig@google.com [graphite] Avoid discard for float
formats w/ opaque src-over
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-30 14:54:27 +00:00
Derek Xu
f4b9249d60
Add --profile-startup switch ( #172879 )
...
This PR adds a switch that can be used to set [the Dart VM's
`profile_startup`
flag](21ce423b26/runtime/vm/profiler.cc (L68)
2025-07-30 14:39:37 +00:00
engine-flutter-autoroll
c9b1fa8bb9
Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) ( #172955 )
...
https://skia.googlesource.com/skia.git/+log/62476cd444d2..00765f238077
2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c8209fec9a5f to e286ef784996 (19 revisions)
2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 4bd5bd8d51e4 to 7cd1022cdc50 (1 revision)
2025-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 4695e6b7d184 to baf909de57f0 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-30 10:10:30 +00:00
engine-flutter-autoroll
1cf0494e69
Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) ( #172944 )
...
https://skia.googlesource.com/skia.git/+log/a42898e5d622..f72bd01a49b1
2025-07-30 nicolettep@google.com Revert "[graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support"
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 03166deacb9d to c98f4a016f37 (6 revisions)
2025-07-29 michaelludwig@google.com [graphite] Preserve rounded corners
for stroke bounds in ClipStack
2025-07-29 kjlubick@google.com Fix RustPNG build
2025-07-29 kjlubick@google.com Update -base versions of
shaders/skottie/fiddler/debugger
2025-07-29 michaelludwig@google.com [graphite] Optimize drawDRRect and
nested rect contours
2025-07-29 nicolettep@google.com [graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support
2025-07-29 bungeman@google.com Remove unused
SkTypeface_AndroidSystem::fAxes
2025-07-29 fmalita@google.com [videodecoder] Forward-declare
GrRecordingContext
2025-07-29 kjlubick@google.com Update pinned jsfiddle-base
2025-07-29 mike@reedtribe.org Add RRect to raw-shapes
2025-07-29 mike@reedtribe.org Use optional for PathRef queries
2025-07-29 michaelludwig@google.com Fix cusp detection for linear cubics
in FindCubicConvex180Chops
2025-07-29 kjlubick@google.com Temporarily remove RustPNG from CQ
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from aef5b0045b59 to 03166deacb9d (8 revisions)
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 2fa5446206bd to fcda4f3d4b8c (12 revisions)
2025-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 8802b4ec130b to 4bd5bd8d51e4 (1 revision)
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-07-28 ccameron@chromium.org identify_transfer_fn: Return C string
for PQ and HLG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,jmbetancourt@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-30 02:47:29 +00:00
Robert Ancell
636b3c70f8
Fix documentation for FlutterEngineRunTask ( #172889 )
...
The engine provides the tasks to the embedder, which then runs them
using FlutterEngineRunTask. The existing docs suggest the tasks are
given to the engine (i.e. are sourced in the embedder).
2025-07-29 23:39:33 +00:00
engine-flutter-autoroll
4a798c0a4f
Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0... ( #172925 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-07-29 22:03:27 +00:00
Gray Mackall
5f9b9ab498
Refactor Android platform view code in advance of enabling HCPP on existing PV widgets (behind a flag) ( #170553 )
...
Should introduce no behavior changes. Refactors the android platform
view code so that
1. The delegator is ready to delegate between PlatformViewsController
(PVC) 1 and 2, and implements a
`PlatformViewsChannel.PlatformViewsHandler`.
2. The `PlatformViewCreationRequest` and `PlatformViewTouch` are fully
shared between the two platform view modes
3. Introduces new factory constructors for the different types of
`PlatformViewCreationRequest`s, corresponding to the modes.
Making the flag work on existing widgets will be done in a follow up PR
here
67262d9240/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java (L95)https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
2025-07-29 20:49:12 +00:00
gaaclarke
963218189b
Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) ( #172906 )
...
manual land of https://github.com/flutter/flutter/pull/172881
https://skia.googlesource.com/skia.git/+log/409e1c7ba09b..a42898e5d622
2025-07-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial). 2025-07-28 michaelludwig@google.com
Revert "[graphite] Add option to avoid clear load op conversion"
2025-07-28 mike@reedtribe.org Defer drawOval to SkDraw 2025-07-28
mike@reedtribe.org Factor out rrect deducer, so it can be used outside
of pathref 2025-07-28
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial). 2025-07-28 mike@reedtribe.org
Refactor IsRectContour for other clients 2025-07-28 mike@reedtribe.org
Share code from PathRawShapes 2025-07-28 drott@chromium.org [Fontations]
Roll Fontations 2025-07-28 robertphillips@google.com [graphite] Fix
thread race in Dawn backend 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
dfe81c21c267 to aef5b0045b59 (1 revision) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from
d38531e82fd8 to c8209fec9a5f (6 revisions) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from
a84d1801cf7b to 8802b4ec130b (1 revision) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from
8aa65434c8ed to 4695e6b7d184 (7 revisions) 2025-07-28
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from
3d2423f23524 to 2fa5446206bd (15 revisions) 2025-07-27
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP
version 2025-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com
Roll vulkan-deps from 1e5f8fd67984 to dfe81c21c267 (1 revision)
2025-07-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f4b5d4a14233 to 1e5f8fd67984 (1 revision) 2025-07-26
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
75a29db5e706 to f4b5d4a14233 (3 revisions) 2025-07-25
ccameron@chromium.org HDR v2: Make more paths robust to new version
2025-07-25 robertphillips@google.com [graphite] Fix bug(s) in
PipelineKey serialization 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from
b16be89ea18d to 75a29db5e706 (3 revisions) 2025-07-25 mike@reedtribe.org
Reapply "Add defaults for path enums, declare as 8-bit" 2025-07-25
mike@reedtribe.org Update Matrix PolyToPoly to take spans 2025-07-25
michaelludwig@google.com Stick to 1/2 scale for final blur decimation
step 2025-07-25 kjlubick@google.com Remove old docker images related to
fiddler 2025-07-25 mike@reedtribe.org skscan to take pathraw 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from
f94510ab8d9e to d38531e82fd8 (13 revisions) 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from
2fdfa81e82dc to 8aa65434c8ed (8 revisions) 2025-07-25
skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from
b6b32cb6d1a1 to 3d2423f23524 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jmbetancourt@google.com ,jsimmons@google.com,kjlubick@google.com on the
revert to ensure that a human is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
2025-07-29 20:02:04 +00:00
