15626 Commits

Author SHA1 Message Date
skia-flutter-autoroll
26d3a4e685 Roll Skia from 22960eb7b2a6 to 4898ac10f0ac (4 revisions) (flutter/engine#30225) 2021-12-08 16:54:05 -08:00
skia-flutter-autoroll
c0d93da7d5 Roll Skia from c307c5566d11 to 22960eb7b2a6 (1 revision) (flutter/engine#30218) 2021-12-08 14:14:01 -08:00
skia-flutter-autoroll
d98820943e Roll Skia from 3856a5854e20 to c307c5566d11 (2 revisions) (flutter/engine#30216) 2021-12-08 12:54:05 -08:00
skia-flutter-autoroll
83dc551688 Roll Skia from 21b8ccb7393c to 3856a5854e20 (6 revisions) (flutter/engine#30214) 2021-12-08 11:34:02 -08:00
Chris Bracken
0d41ebed6a Implement GetUniqueId on Windows node delegates (flutter/engine#30204)
`AXPlatformNodeDelegate` provides a default implementation of
`GetUniqueId()` which returns the same value (1) for all nodes.
`AXPlatformNodeWin` relies on a unique ID being returned from this
method in its `GetTargetFromChildID` method.

In the world MSAA accessibility, each `HWND` may have a root
`IAccessible` object associated with it. Events are fired by calling the
`NotifyWinEvent` Win32 call and specifying:

1. The `HWND` (in our case, the one associated with our `WindowWin32`)
2. The target object (`OBJID_CLIENT` for the root `IAccessible`
   associated with that `HWND`)
3. A child identifier that uniquely identifies the target node in the
   tree

This child identifier can be one of:

* `CHILDID_SELF` for events targeting the root `IAccessible`.
* A positive integer that specifies the index of a direct child of the
  root.
* A negative integer which, when negated, specifies the unique ID of a
  child within the tree.

On receipt of an accessibility event, `AXPlatformWin` (our `IAccessible`
implementation) looks up the target `IAccessible` from the child ID
specified on the event using its `GetTargetFromChildID` method and
delegates the appropriate method call to that object.

So, why is this implemented on our `AXPlatformNodeDelegate` subclass and
not on `AXPlatformNodeWin` itself? Because the implementation of
`AXPlatformNode::GetUniqueId()` delegates this lookup to the node
delegate.

As background, `AXUniqueId` automatically assigns itself a
globally-unique value in its constructor; it tracks all used values in
an internal static pool.

Issue: https://github.com/flutter/flutter/issues/77838
2021-12-08 09:41:46 -08:00
skia-flutter-autoroll
7720146b12 Roll Skia from 00edeefab7f4 to 21b8ccb7393c (3 revisions) (flutter/engine#30206) 2021-12-08 02:44:02 -08:00
skia-flutter-autoroll
f24e5bf2ce Roll Skia from 543b8681c7f2 to 00edeefab7f4 (1 revision) (flutter/engine#30200) 2021-12-07 21:54:01 -08:00
keyonghan
dc16a5ebbb renew cirrus key (flutter/engine#30186) 2021-12-07 20:51:23 -08:00
Chris Yang
22693e2599 [ios platform view] fix overlay zPosition (flutter/engine#29930) 2021-12-07 16:04:01 -08:00
skia-flutter-autoroll
670277d11c Roll Skia from 1c4cf27965bd to 543b8681c7f2 (1 revision) (flutter/engine#30198) 2021-12-07 15:54:00 -08:00
Chris Bracken
4fd686f454 Document rationale for Dart VM flag prefix match (flutter/engine#30195)
Dart VM flags are passed to Flutter via an fml::CommandLine::Option that
looks something like:

   {"dart-flags, "--max_profile_depth 1,--trace_service"}

We perform a prefix match to handle cases where Dart VM options take
arguments.

Adding the comment since in a recent review I found myself wondering why
we're using a prefix match to begin with. While the original author had
forgotten, the good news is, he wrote a test that covers this exact
case. This comment just removes one level of indirection for future
readers.
2021-12-07 14:36:33 -08:00
skia-flutter-autoroll
5c27f5db99 Roll Skia from 06f3d68627c2 to 1c4cf27965bd (2 revisions) (flutter/engine#30194) 2021-12-07 14:29:01 -08:00
Brandon DeRosier
68fde39542 Add length guard to fix Windows build with VS2019 16.11.7 headers (flutter/engine#30189)
The shell tests are failing on Windows against the latest VS2019 headers due to a new safety assert.
2021-12-07 13:28:39 -08:00
skia-flutter-autoroll
cbb1fce944 Roll Skia from f333f5614a9b to 06f3d68627c2 (24 revisions) (flutter/engine#30192) 2021-12-07 13:04:02 -08:00
skia-flutter-autoroll
7fe64f4895 Roll Fuchsia Linux SDK from WGMjaVH60... to s03VQc7lX... (flutter/engine#30191) 2021-12-07 12:59:01 -08:00
Chinmay Garde
35a2ccb79a Add unconditional waits on fml::Semaphore. (flutter/engine#30165) 2021-12-07 12:49:01 -08:00
Jenn Magder
99c86eecb5 Revert "Run iOS scenario apps on iPhone 11 and iOS 14 (#30104)" (flutter/engine#30193)
This reverts commit be166e754a8e430d26aa16dea4619186867e2181.
2021-12-07 12:42:21 -08:00
Chris Bracken
0189aaaca1 Win32: Implement DispatchAccessibilityAction (flutter/engine#30187)
Implements DispatchAccessibilityAction: a pass-through method that
forwards to the engine, which calls through the Embedder API back to the
framework.

Issue: https://github.com/flutter/flutter/issues/77838
2021-12-07 11:07:45 -08:00
Chris Bracken
74e90fc817 Don't run curl in verbose mode when --verbose set (flutter/engine#30170)
In download_dart_sdk.py, we previously ran curl with the --verbose flag
when the --verbose flag was passed to the script. This generates vast
quantities of output that is unlikely to be valuable except if we're
attempting to debug a curl download issue. In such a case we could
perhaps pass a separate --verbose-download flag as well.

Issue: https://github.com/flutter/flutter/issues/94492
2021-12-07 11:06:58 -08:00
Chris Bracken
018966313c Add error handler for os.rmtree calls (flutter/engine#30169)
In cases wher rmtree encounters an error, attempt to fix file
permissions and re-run the failing operation.

Issue: https://github.com/flutter/flutter/issues/94492
2021-12-07 11:06:50 -08:00
Jenn Magder
be166e754a Run iOS scenario apps on iPhone 11 and iOS 14 (flutter/engine#30104) 2021-12-07 10:59:01 -08:00
Yegor
e7c4fcc17d [web] consolidate JS interop code (attempt 2) (flutter/engine#30161)
The original https://github.com/flutter/engine/pull/30007 was reverted
because it broke the framework. Turns out the framework still used the
WebExperiments code, which has been cleaned up in https://github.com/flutter/flutter/pull/94739.

This PR must land after https://github.com/flutter/flutter/pull/94739.

This reverts commit ae31d5a5d82c8091d859c27922e5f52e3a264286.
2021-12-07 09:27:06 -08:00
Jenn Magder
f134ae9ac4 Remove implicit copy assignment operator for 'EmbeddedViewParams' (flutter/engine#30094) 2021-12-06 09:34:01 -08:00
Chris Bracken
334a0c6ff9 Use MallocMapping for DispatchSemanticsAction data (flutter/engine#30149)
In the Windows embedder, the data parameter of
FlutterWindowsEngine::DispatchSemanticsAction was a vector of bytes.
Here, we switch it to use MallocMapping since that is the type of the
data paramater on the DispatchAccessibilityAction method of
AccessibilityBridgeDelegate, which calls this method. This avoids an
extra type conversion.
2021-12-06 08:44:41 -08:00
skia-flutter-autoroll
6d57e4cc33 Roll Skia from 05de3735b723 to f333f5614a9b (3 revisions) (flutter/engine#30156) 2021-12-06 06:19:02 -08:00
skia-flutter-autoroll
53253cd07d Roll Fuchsia Linux SDK from gWYa9KhIK... to WGMjaVH60... (flutter/engine#30153) 2021-12-06 00:19:01 -08:00
skia-flutter-autoroll
41d2b5320d Roll Skia from 493d7910a7f5 to 05de3735b723 (1 revision) (flutter/engine#30150) 2021-12-05 21:59:01 -08:00
skia-flutter-autoroll
316b6fb41e Roll Fuchsia Linux SDK from eH__OFZVQ... to gWYa9KhIK... (flutter/engine#30146) 2021-12-05 10:59:01 -08:00
eggfly
fdfdd6dccb Fix embedder_->EndFrame() not called in case of DrawLastLayerTree() (flutter/engine#29979) 2021-12-05 06:59:01 -08:00
skia-flutter-autoroll
7a8a4357ac Roll Skia from 62553ae6feb8 to 493d7910a7f5 (1 revision) (flutter/engine#30144) 2021-12-05 01:34:01 -08:00
skia-flutter-autoroll
55de073f63 Roll Skia from 40ba900d2e94 to 62553ae6feb8 (1 revision) (flutter/engine#30143) 2021-12-04 23:19:02 -08:00
skia-flutter-autoroll
8b724f63b1 Roll Fuchsia Linux SDK from uNU00yZsG... to eH__OFZVQ... (flutter/engine#30141) 2021-12-04 21:39:02 -08:00
Jim Graham
ae31d5a5d8 Revert "[web] consolidate JS interop code (#30007)" (flutter/engine#30137)
This reverts commit 01a91d484eab5fae50381ab7c94fcdca9fbb56a9.
2021-12-04 18:54:31 -08:00
Mouad Debbar
5b1f788998 Update general_golden_test.dart (flutter/engine#30134) 2021-12-04 16:34:02 -08:00
Alexander Belokon
1c2fed029f [web] Fixing text foreground paint / stroke for HTML web-renderer (flutter/engine#29888) 2021-12-04 06:09:01 -08:00
skia-flutter-autoroll
6eb100c29e Roll Fuchsia Linux SDK from gc6NLk09G... to uNU00yZsG... (flutter/engine#30129) 2021-12-04 03:29:01 -08:00
skia-flutter-autoroll
f3a2444644 Roll Skia from 94f726ae62f0 to 40ba900d2e94 (1 revision) (flutter/engine#30124) 2021-12-03 18:39:01 -08:00
Emmanuel Garcia
0849c0ecd7 Fix cast in FlutterView (flutter/engine#30106) 2021-12-03 15:54:01 -08:00
Yegor
01a91d484e [web] consolidate JS interop code (flutter/engine#30007)
* Consolidate and check JavaScript access
* Remove all `ignore: implicit_dynamic_function`
* Add `js_access_test.dart` that validates JS access
* Make `engine.dart` an exports-only library
* Fix `sdk_rewriter_test.dart` and `ci/analyze.sh` (they skipped some tests)
2021-12-03 15:46:03 -08:00
skia-flutter-autoroll
28d20a282c Roll Dart SDK from ba5e72e4b2d7 to a31c331ed648 (5 revisions) (flutter/engine#30121) 2021-12-03 15:14:02 -08:00
skia-flutter-autoroll
d943eadb6b Roll Skia from 29af7d59714b to 94f726ae62f0 (2 revisions) (flutter/engine#30120) 2021-12-03 14:59:01 -08:00
skia-flutter-autoroll
aef07412a5 Roll Fuchsia Linux SDK from RyloAtJNT... to gc6NLk09G... (flutter/engine#30118) 2021-12-03 14:09:01 -08:00
skia-flutter-autoroll
d08c749312 Roll Skia from 672062da97da to 29af7d59714b (4 revisions) (flutter/engine#30117) 2021-12-03 13:39:02 -08:00
skia-flutter-autoroll
8ce1dc3e4a Roll Skia from f278a8058eaa to 672062da97da (8 revisions) (flutter/engine#30115) 2021-12-03 12:19:01 -08:00
Jenn Magder
cb6cd0a3e8 Update IosUnitTests to use iPhone 11 simulator (flutter/engine#30090) 2021-12-03 10:49:02 -08:00
Siva
315f7b888f Revert "Enable compressed pointers on iOS for 64 bit architectures." (flutter/engine#30096) 2021-12-03 08:25:10 -08:00
skia-flutter-autoroll
848d1fd293 Roll Fuchsia Linux SDK from NJK-w4N99... to RyloAtJNT... (flutter/engine#30105) 2021-12-03 00:49:01 -08:00
Gary Qian
23f9f49662 Fix platform env variable not registering with sdk_manager (flutter/engine#30107) 2021-12-03 00:37:17 -08:00
godofredoc
f4e2e010c8 Fail loudly with verbose logs when failing to download dart sdk. (flutter/engine#30093)
* Fail loudly with verbose logs when failing to download dart sdk.

Bug: https://github.com/flutter/flutter/issues/94492

* Add jazzy property to mac builders.
2021-12-02 23:38:55 -08:00
godofredoc
060f0b9f39 Revert "[ci.yaml] Remove default properties (#29694)" (flutter/engine#30100)
This reverts commit 20c7e5f75c68ca41fa278af82da89e31439aab6f.

Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
2021-12-02 22:39:42 -08:00