7472 Commits

Author SHA1 Message Date
Gary Qian
263ff39303 Check for index bounds in RTL handling for trailing whitespace runs. (flutter/engine#12336)
* Check for special case index out of bounds condition for leading space

* Add TODO

* Rework to pass tests

* More robust check for leading

* Minor adjustment

* Fix order bug

* Do not modify for leading space

* Fix test value

* Condition
2019-09-24 04:21:35 +08:00
skia-flutter-autoroll
173889c1ae Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5... (flutter/engine#12407)
Roll fuchsia/sdk/core/linux-amd64 from F-g18... to NY2A5...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-23 16:21:20 -04:00
Nurhan Turgut
4ecc884e50 Updating text field location in IOS as a pre-work for spellcheck (flutter/engine#12192)
* enabling spellcheck for text editing

* Finalize location changes in IOS. IOS is ready for spellcheck now. Disable spellcheck since we realized some tag/autocomplete transfer from Framework is necessary for complete spellcheck implementation.

* Remove todo since this PR fixes the updated location issue for IOS too. All browsers are supported now.

* Adding boolean flags to make conditions more readable. Fixing typos.

* Fixing unit tests. Addressing github PR comments.
2019-09-23 12:36:39 -07:00
Chinmay Garde
9145088731 Roll buildroot and remove toolchain prefix. (flutter/engine#12324) 2019-09-23 11:29:13 -07:00
skia-flutter-autoroll
6c36b9541a Roll src/third_party/skia ab52a7a53db6..57ef68077574 (3 commits) (flutter/engine#12396)
https://skia.googlesource.com/skia.git/+log/ab52a7a53db6..57ef68077574

git log ab52a7a53db6..57ef68077574 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 robertphillips@google.com Create a GrGpu::createBackendTexture choke point
2019-09-23 bsalomon@google.com Remove a few GrSurfaceProxy::config() usages
2019-09-23 brianosman@google.com Roll third_party/externals/angle2 6c4ff5ddab07..8be7a4c7f738 (12 commits)

Created with:
  gclient setdep -r src/third_party/skia@57ef68077574

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-23 12:52:10 -04:00
Jaime Blasco
06914655b3 [Web] Implement dark mode support for web (flutter/engine#12335) 2019-09-23 09:42:20 -07:00
skia-flutter-autoroll
f602b7bbc0 Roll src/third_party/skia 776d81525e7c..ab52a7a53db6 (1 commits) (flutter/engine#12393)
https://skia.googlesource.com/skia.git/+log/776d81525e7c..ab52a7a53db6

git log 776d81525e7c..ab52a7a53db6 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@ab52a7a53db6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-23 09:04:02 -04:00
skia-flutter-autoroll
9e8512ef11 Roll src/third_party/skia 5b4c0ee19b74..776d81525e7c (1 commits) (flutter/engine#12392)
https://skia.googlesource.com/skia.git/+log/5b4c0ee19b74..776d81525e7c

git log 5b4c0ee19b74..776d81525e7c --date=short --no-merges --format='%ad %ae %s'
2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3243c3b11405..82de2e611e32 (463 commits)

Created with:
  gclient setdep -r src/third_party/skia@776d81525e7c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-23 05:11:06 -04:00
skia-flutter-autoroll
ad64c063ac Roll src/third_party/skia b4d60b5eda31..5b4c0ee19b74 (1 commits) (flutter/engine#12390)
https://skia.googlesource.com/skia.git/+log/b4d60b5eda31..5b4c0ee19b74

git log b4d60b5eda31..5b4c0ee19b74 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b6fa949c4539..1f89f58faeb8 (5 commits)

Created with:
  gclient setdep -r src/third_party/skia@5b4c0ee19b74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-23 01:23:00 -04:00
skia-flutter-autoroll
0e451754f5 Roll src/third_party/skia bd67d0035a80..b4d60b5eda31 (7 commits) (flutter/engine#12389)
https://skia.googlesource.com/skia.git/+log/bd67d0035a80..b4d60b5eda31

git log bd67d0035a80..b4d60b5eda31 --date=short --no-merges --format='%ad %ae %s'
2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@b4d60b5eda31

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=bungeman@google.com
2019-09-22 21:08:08 -04:00
skia-flutter-autoroll
166afd3755 Roll src/third_party/skia 942d69fa9d5f..bd67d0035a80 (1 commits) (flutter/engine#12382)
https://skia.googlesource.com/skia.git/+log/942d69fa9d5f..bd67d0035a80

git log 942d69fa9d5f..bd67d0035a80 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@bd67d0035a80

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-22 15:40:45 -04:00
Yegor
064ca6bfb5 Add macOS testing support (flutter/engine#12383)
- Add support for macOS in `felt test`
- Set viewport so it does not depend on real device pixel density
2019-09-22 11:49:44 -07:00
skia-flutter-autoroll
d66d7632dd Roll src/third_party/skia 2e29ab5b03aa..942d69fa9d5f (6 commits) (flutter/engine#12378)
https://skia.googlesource.com/skia.git/+log/2e29ab5b03aa..942d69fa9d5f

git log 2e29ab5b03aa..942d69fa9d5f --date=short --no-merges --format='%ad %ae %s'
2019-09-20 ethannicholas@google.com Revert "Fixed GLSL ES compilation error in GLTestAtlasTextRenderer"
2019-09-20 ethannicholas@google.com Fixed GLSL ES compilation error in GLTestAtlasTextRenderer
2019-09-20 bsalomon@google.com Check for scratch textures in GrResourceProvider.
2019-09-20 kjlubick@google.com [canvaskit] add support for SkAnimatedImage
2019-09-20 brianosman@google.com Use makeRenderTargetContextWithFallback when creating devices for layers
2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@942d69fa9d5f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 15:33:45 -07:00
Yegor
e08ce018a4 Store screenshot test output as Cirrus artifacts; do fuzzy comparison of non-matching screenshot pixels (flutter/engine#12274)
- Store screenshot test output as Cirrus artifacts
- Do fuzzy comparison of non-matching screenshot pixels
- Make screenshot tests fail on Cirrus
2019-09-20 14:46:00 -07:00
gaaclarke
1cad708800 Added unit tests for method channels. (flutter/engine#12373)
Added unit tests for method channels.
2019-09-20 14:25:56 -07:00
Dan Field
128398be60 Sync dart_runner (flutter/engine#12375) 2019-09-20 12:58:08 -07:00
skia-flutter-autoroll
bef7c8f84d Roll src/third_party/skia ffdc3e668061..2e29ab5b03aa (12 commits) (flutter/engine#12374)
https://skia.googlesource.com/skia.git/+log/ffdc3e668061..2e29ab5b03aa

git log ffdc3e668061..2e29ab5b03aa --date=short --no-merges --format='%ad %ae %s'
2019-09-20 brianosman@google.com added support for user-defined functions to GrSKSLFP
2019-09-20 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur (take 2)
2019-09-20 ethannicholas@google.com Revert "added support for SkSL unpremul function"
2019-09-20 vasilyt@chromium.org Added missed ETC2 case to GrVkFormatColorTypePairIsValid
2019-09-20 reed@google.com call Graphics Init() to get faster asm
2019-09-20 brianosman@google.com Reland "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice"
2019-09-20 ethannicholas@google.com regenerated fragment processors to make bot happy
2019-09-20 brianosman@google.com Revert "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice"
2019-09-20 nifong@google.com Added functions supporting a resource view for images in the debugger.
2019-09-20 brianosman@google.com Use saveLayer-determined CT in SkGpuDevice::onCreateDevice
2019-09-20 brianosman@google.com Run gn format
2019-09-20 brianosman@google.com Use 64 bit shift to make MSVC happy

Created with:
  gclient setdep -r src/third_party/skia@2e29ab5b03aa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 14:10:16 -04:00
David Iglesias
0c2c7cfd15 Add web engine screenshot (scuba) tests (flutter/engine#12353)
* Import all golden files and tests from internal repo.
* Adapt test files to new screenshot API, and tweak some settings.

(Check PR to see individual changes to each file)

Fixes https://github.com/flutter/flutter/issues/40975
2019-09-20 09:00:55 -07:00
skia-flutter-autoroll
f6081ed304 Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369)
https://skia.googlesource.com/skia.git/+log/9a9841178078..ffdc3e668061

git log 9a9841178078..ffdc3e668061 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 ethannicholas@google.com added support for SkSL unpremul function

Created with:
  gclient setdep -r src/third_party/skia@ffdc3e668061

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 10:23:54 -04:00
skia-flutter-autoroll
406558f67b Roll src/third_party/skia be0d7dfa6194..9a9841178078 (2 commits) (flutter/engine#12368)
https://skia.googlesource.com/skia.git/+log/be0d7dfa6194..9a9841178078

git log be0d7dfa6194..9a9841178078 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bf4268a3963b..6c4ff5ddab07 (8 commits)
2019-09-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@9a9841178078

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 05:24:42 -04:00
skia-flutter-autoroll
07acdaab94 Roll src/third_party/skia e5b65d212bca..be0d7dfa6194 (3 commits) (flutter/engine#12367)
https://skia.googlesource.com/skia.git/+log/e5b65d212bca..be0d7dfa6194

git log e5b65d212bca..be0d7dfa6194 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b8149cbe28ad..3243c3b11405 (453 commits)
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e9b6f28fdd71..b6fa949c4539 (2 commits)
2019-09-20 mtklein@google.com raster 8888 pow2 samples hack

Created with:
  gclient setdep -r src/third_party/skia@be0d7dfa6194

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-20 01:35:57 -04:00
liyuqian
56bb40c017 Revert "Reland "Smooth out iOS irregular input events delivery (#11817)" (#12280)" (flutter/engine#12364)
This reverts commit dedf24e797d6257f9bb776cdf0d7525a16610321.

Reason: flutter/flutter#40863

TBR: chinmaygarde, iskakaushik
2019-09-19 19:39:36 -07:00
skia-flutter-autoroll
4054ea63df Roll src/third_party/skia f47717ad8cc7..e5b65d212bca (4 commits) (flutter/engine#12366)
https://skia.googlesource.com/skia.git/+log/f47717ad8cc7..e5b65d212bca

git log f47717ad8cc7..e5b65d212bca --date=short --no-merges --format='%ad %ae %s'
2019-09-19 halcanary@google.com pdf-comparison and image_diff_metric tools
2019-09-19 robertphillips@google.com New proposed syntax for SkColorTypes
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@e5b65d212bca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 21:49:03 -04:00
Matt Carroll
fce67bf3a8 Fixes race condition that was reported internally. (flutter/engine#12362) 2019-09-19 16:36:17 -07:00
Siva
c5ac59ebee  Roll src/third_party/dart 7c1821c4aa...ea969c358e (flutter/engine#12339)
* Roll src/third_party/dart 7c1821c4aa...ea969c358e (6 commits)

dart-lang/sdk@7c1821c4aa [NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
dart-lang/sdk@0c23664c8f [vm/fuzzer] Reduce number of methods per class
dart-lang/sdk@3135eb569d [vm/bytecode] Fix initial scope in field initializers
dart-lang/sdk@1345fb80ac Use TypeParameterElement instead of TypeParameterType in inference.
dart-lang/sdk@430ff6d649 Migration: fix "matching" functionality of edge testing infrastructure.
dart-lang/sdk@f1bff1b512 Add option to run ddb with observatory
2019-09-19 16:07:34 -07:00
skia-flutter-autoroll
bed1fcbc51 Roll src/third_party/skia 9a8b846baf43..f47717ad8cc7 (7 commits) (flutter/engine#12361)
https://skia.googlesource.com/skia.git/+log/9a8b846baf43..f47717ad8cc7

git log 9a8b846baf43..f47717ad8cc7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 robertphillips@google.com Alter wacky_yuv_formats GM to skip rows if the required backing GPU format(s) aren't supported
2019-09-19 robertphillips@google.com Remove "experimental" comments regarding RG_F16 and RGBA_16161616
2019-09-19 mtklein@google.com stifle warning in tValue2Scalar()
2019-09-19 jvanverth@google.com Set up prototype interface for MakeFromCAMetalLayer
2019-09-19 robertphillips@google.com Revert "Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur"
2019-09-19 csmartdalton@google.com Use GrResourceProvider::MakeApprox for mask filter proxy sizes
2019-09-19 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur

Created with:
  gclient setdep -r src/third_party/skia@f47717ad8cc7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 15:03:42 -07:00
skia-flutter-autoroll
aee3d67a28 Roll src/third_party/skia 18531cde2ab7..9a8b846baf43 (1 commits) (flutter/engine#12360)
https://skia.googlesource.com/skia.git/+log/18531cde2ab7..9a8b846baf43

git log 18531cde2ab7..9a8b846baf43 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 brianosman@google.com Particles: Sub-effect spawning and some slight refactoring

Created with:
  gclient setdep -r src/third_party/skia@9a8b846baf43

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 12:02:03 -04:00
skia-flutter-autoroll
ddd6c46f76 Roll src/third_party/skia 6344cbd1df76..18531cde2ab7 (2 commits) (flutter/engine#12358)
https://skia.googlesource.com/skia.git/+log/6344cbd1df76..18531cde2ab7

git log 6344cbd1df76..18531cde2ab7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7003d5fc306..bf4268a3963b (7 commits)
2019-09-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@18531cde2ab7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 05:27:48 -04:00
skia-flutter-autoroll
5a9ac4bfc7 Roll src/third_party/skia e2a903e18b59..6344cbd1df76 (3 commits) (flutter/engine#12357)
https://skia.googlesource.com/skia.git/+log/e2a903e18b59..6344cbd1df76

git log e2a903e18b59..6344cbd1df76 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b1c1d2844bd1..b8149cbe28ad (423 commits)
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 61a2765940a7..e9b6f28fdd71 (3 commits)
2019-09-19 mtklein@google.com fold srcover coverage with SkVMBlitter

Created with:
  gclient setdep -r src/third_party/skia@6344cbd1df76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-19 01:39:03 -04:00
Dan Field
e4a8130bc6 skip flaky test (flutter/engine#12355) 2019-09-18 21:43:11 -07:00
Dan Field
0b33917787 java lints (flutter/engine#12354) 2019-09-18 21:20:04 -07:00
Kaushik Iska
4d6b95ebdc [flutter_runner] Port vulkan surface changes (flutter/engine#12350)
[flutter_runner] use dedicated allocation info

    This informs the vulkan driver that we're allocating memory
    dedicated to a single image. This is required for aemu and
    might also allow future drivers to make optimizations currently
    not possible.

    No change in behavior. Existing tests (modular_tests,
    scenic_tests, etc.) are sufficient and regressions will be
    prevented by running these tests on aemu.

    DX-939 #comment

    Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
    Change-Id: If4ecd9aaa09f12f94654a68e8e9fe979748f44af

    [flutter_runner] use external image create info

    DX-939 #progress
    MA-394 #progress

    This informs the vulkan driver that we're creating an image
    that will be backed by external memory. The driver driver can
    decide to use different memory requirements based on the if
    memory for the image can be exported or not.

    No change in behavior. Existing tests (modular_tests,
    scenic_tests, etc.) are sufficient and regressions will be
    prevented by running these tests on aemu.

    Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
    Change-Id: I489318c2e31f752f76c80a81245e203861d44d94
2019-09-18 19:06:12 -07:00
skia-flutter-autoroll
51c7eb7711 Roll src/third_party/skia f19f9caab2b4..e2a903e18b59 (1 commits) (flutter/engine#12351)
https://skia.googlesource.com/skia.git/+log/f19f9caab2b4..e2a903e18b59

git log f19f9caab2b4..e2a903e18b59 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 csmartdalton@google.com Reland "Reorder msaa and mipmap resolves to happen all at once"

Created with:
  gclient setdep -r src/third_party/skia@e2a903e18b59

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 21:53:53 -04:00
Kaushik Iska
5bdd5ec96c [flutter_runner] Explicitly set |trace_skia| to false (flutter/engine#12349)
Explicitly set |Application|'s |flutter::Settings| |trace_skia| field to
false (it currently defaults to false), in order to slightly simplify
the enabling skia trace events workflow.

PT-145 #comment-patch

Change-Id: Ib40f9ed3dc6f824056465db2cd45309c78b7e3b4
2019-09-18 18:02:43 -07:00
Kaushik Iska
51fc8e108d [flutter_runner] Port the new compilation trace from topaz (flutter/engine#12348) 2019-09-18 18:02:34 -07:00
Kaushik Iska
b198248b55 [flutter_runner][async] Migrate dart/flutter to new async-loop APIs (flutter/engine#12347)
Change-Id: I11ca124878d2652798ed49958c42aa10ae019ef9
2019-09-18 17:45:53 -07:00
Kaushik Iska
555f0b2506 [flutter_runner] Move from runner context to component context (flutter/engine#12346)
* [flutter_runner] Move from runner context to component context

* remove the file references
2019-09-18 17:45:46 -07:00
Kaushik Iska
4063939bd8 [flutter_runner] Port over the tuning advice (flutter/engine#12345) 2019-09-18 17:32:08 -07:00
Kaushik Iska
9e522b13b1 [flutter_runner] Remove usages of shared snapshots from CC sources (flutter/engine#12343)
Build rules still reference creating share snapshot data and instructions. This makes the engine to always pass them as empty to the dart vm. To be followed up with a change to alter the build rules to stop referencing the shared snapshots.

This is not being used currently and the fact that the runner will be built outside of the flutter tree means that the apps will not have much to gain via shared snapshots. The rationale behind this change is to partially make migrating the runner out of topaz tree easier.

Change-Id: Ibc4dd6a298d65082416af753522f5a17c88a750a
2019-09-18 17:31:54 -07:00
Kaushik Iska
2c1b30a4f2 [flutter_runner] Do not use prebuilts just yet (flutter/engine#12340) 2019-09-18 15:31:57 -07:00
Dan Field
a8cfcfc78d Add missing CL, fix targets for Fuchsia (flutter/engine#12338) 2019-09-18 15:06:50 -07:00
David Iglesias
25d2d2a47a More controls for Screenshot tests (for web) (flutter/engine#12284)
New features for golden tests (for web):

* Height/width of headless browser instance extracted to constants
* Remove border from the host iframe
* Added 'region' to matchGoldenFile, so screenshots can capture only
a subset of the viewport
* Added image-format-awareness (png) to screenshot comparison, so it
doesn't only look at raw bytes
* When a test fails, output a diff image alongside the unexpected
output.
2019-09-18 14:58:30 -07:00
skia-flutter-autoroll
2772d80a9f Roll src/third_party/skia 8391bac5c6f0..f19f9caab2b4 (8 commits) (flutter/engine#12341)
https://skia.googlesource.com/skia.git/+log/8391bac5c6f0..f19f9caab2b4

git log 8391bac5c6f0..f19f9caab2b4 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Handle F16Norm clamping in SkPaint->GrPaint conversion.
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 mtklein@google.com move skvm debug tools back to core
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 herb@google.com Reland "SkZip - synchronized indexing of several pointers"
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 robertphillips@google.com Last tranche of new SkColorTypes
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@f19f9caab2b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 17:38:06 -04:00
Tamir Duberstein
8156de6820 [fuchsia] add fuchsia.netstack.Netstack (flutter/engine#12325)
Needed in preparation for
https://dart-review.googlesource.com/c/sdk/+/117620.

Test:
  git grep -l -E '(socket\.Provider|NameLookup)' | \
  xargs grep -L fuchsia.netstack.Netstack
2019-09-18 12:01:49 -07:00
skia-flutter-autoroll
ddcb802813 Roll src/third_party/skia dd0dff1c35d2..8391bac5c6f0 (8 commits) (flutter/engine#12337)
https://skia.googlesource.com/skia.git/+log/dd0dff1c35d2..8391bac5c6f0

git log dd0dff1c35d2..8391bac5c6f0 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Add F16Norm mode to viewer
2019-09-18 bsalomon@google.com blurrect_compare GM: draw "masks" in white for RGBA fallback.
2019-09-18 csmartdalton@google.com Weed out duplicates from the proxy version of addDependency
2019-09-18 mtklein@google.com faster PNG encoding in skottie_tool
2019-09-18 csmartdalton@google.com Revert "Use a "decal" domain for filterMaskGPU"
2019-09-18 csmartdalton@google.com Revert "Abolish absClear"
2019-09-18 bsalomon@google.com Use mipmapping/protected to lookup scratch textures.
2019-09-18 jvanverth@google.com Reland "Add ETC2 support to Metal backend."

Created with:
  gclient setdep -r src/third_party/skia@8391bac5c6f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 13:53:16 -04:00
David Iglesias
c9f422f6eb Ensure DRRects without corners also draw. (flutter/engine#12330)
Uncovered this bug running some additional engine tests. Backported the
test here, and fixed the recording_canvas code.
2019-09-18 10:45:43 -07:00
Amir Hardon
f105e44be5 Update ExternalViewEmbedder class comment. (flutter/engine#11063) 2019-09-18 11:18:38 -06:00
skia-flutter-autoroll
0304798fe7 Roll src/third_party/skia d545bfbb94ca..dd0dff1c35d2 (25 commits) (flutter/engine#12334)
https://skia.googlesource.com/skia.git/+log/d545bfbb94ca..dd0dff1c35d2

git log d545bfbb94ca..dd0dff1c35d2 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 kjlubick@google.com [canvaskit] roll to 0.7.0
2019-09-18 csmartdalton@google.com Abolish absClear
2019-09-18 csmartdalton@google.com Revert "Reorder msaa and mipmap resolves to happen all at once"
2019-09-18 csmartdalton@google.com Reorder msaa and mipmap resolves to happen all at once
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d32dae1bb37c..a7003d5fc306 (11 commits)
2019-09-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c6edebc270af..b1c1d2844bd1 (382 commits)
2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30847688f059..61a2765940a7 (7 commits)
2019-09-18 herb@google.com Revert "SkZip - synchronized indexing of several pointers"
2019-09-18 csmartdalton@google.com Use a "decal" domain for filterMaskGPU
2019-09-17 herb@google.com SkZip - synchronized indexing of several pointers
2019-09-17 ethannicholas@google.com fixed an SkSL parse issue
2019-09-17 bungeman@google.com Properly subset the run in ShapeThenWrap.
2019-09-17 csmartdalton@google.com Reland "Use "clamp" when reexpanding gaussian blurs"
2019-09-17 ethannicholas@google.com Additional SkSL swizzle optimizations
2019-09-17 brianosman@google.com Update SkParticleEffect comments based on review feedback
2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-17 bsalomon@google.com Respect ImageSetEntry alpha in one-at-a-time code path
2019-09-17 brianosman@google.com Fix standalone SkSL build after adding SkOnce to SkSLByteCode
2019-09-17 herb@google.com A fix and unit test for jagged characters
2019-09-17 brianosman@google.com Move raster hack for color type on layers with image filters to device
2019-09-17 halcanary@google.com experimental/minimal_ios_mtl_skia_app
2019-09-17 brianosman@google.com Make SkSL::ByteCodeFunction::preprocess thread-safe
2019-09-17 bsalomon@google.com Pass color types when creating texture with initial data.
2019-09-17 bsalomon@google.com Fix bug where coverage on interior of stroked rects is applied twice

Created with:
  gclient setdep -r src/third_party/skia@dd0dff1c35d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=brianosman@google.com
2019-09-18 10:07:12 -04:00
Matt Carroll
8b3ca2b9c9 Added javadoc comments to FlutterActivity and FlutterFragmentActivity. (flutter/engine#12328) 2019-09-17 16:22:13 -07:00
Kaushik Iska
65d96ebd6f Revert "Provide dart vm initalize isolate callback so that children isolates belong to parent's isolate group. (#9888)" (flutter/engine#12327)
This reverts commit 41241f202f74a576f5d568bdb73ecff688ac3962.
2019-09-17 15:57:37 -07:00