This adds a check for the presence of dart2js in the engine build.
Felt relies on an engine build with `--full-dart-sdk` set. Previously,
we checked for the presence of pub, but not for the presence of
web-specific tooling such as dart2js that felt relies on. Pub is built
as part of the default Dart SDK build when `--full-dart-sdk` is not set,
so its presence is insufficient to prove that other required tooling is
present.
Without this check, we get the following error on run:
Unhandled exception:
ProcessException: No such file or directory
Command: /Users/cbracken/src/flutter/engine/src/out/host_debug_unopt/dart-sdk/bin/dart2js --no-minify --disable-inlining --enable-asserts --enable-experiment=non-nullable --no-sound-null-safety -O2 -o test/paragraph_builder_test.dart.browser_test.dart.js test/paragraph_builder_test.dart
* update chrome version, should be merged after recipe changes
* changing directory to use chrome driver in LUCI
* changing directory path's order
* add cipd packages's chrome version for mac
* addressing reviewer comments
* more documentation. update readme
* remove late since it didn't build. remove distinction in paths for local and LUCI.
* addressing reviewer comments. (non-null fields needs rechanging)
* addressing reviewer comments. adding 2.6 on files missing the notation
* change from build_runner to dart2js
* add internalBootstrapBrowserTest to some of the tests
* add internalBootstrapBrowserTest to all remaining tests
* make tests build in paralel. Total time dropped from 586 to 177 seconds for 8 core MacBook
* change isolates with pool
* fixing analysis errors
* skipping canvaskit tests for ios-safari
* copy image files to the build directory
* adding internalBootstrapBrowserTest to newly added tests
* add internalBootstrapBrowserTest to faling path iterator test
* necessary changes to make chrome windows work
* in windows test in chrome instead of edge. our edge code was for legacy edge
* do not run golden unit tests on Windows LUCI bots for now
* addressing reviewer comments. Adding a method for deciding when to run integration tests.
* remove lines that I forgot to remove
* fixing analysis error. add issue for todo
* add bootstap to a test file
* adding bootstrap to another test
* add internalBootstrapBrowserTest to a golden test
* return test result in bat file. use archieve package to unzip
* fixing logs for chrome_installer
* use archieve and archieve entity instead of dynamic
* adding comments for windows platform archieve part
* addressing reviewer comments
* change readme file
* skip ios safari tests on felt level
* instead of skipping use the new web_installers repo
* re-skip the test. led run failed with another error
* remove led json
* change the version of simulator. luci bots only has 13.0
* skip failing pointer binding tests
* skip path_metrics (canvaskit) and a method from surface_test
* fix analyzer errors
* remove extra added touch event context test
* removing left overs for screenshot debugging
* apply reviewers suggestion for skipping tests
* running ios unit tests from felt by booting/shutingdown simulators. create simulator with felt
* changing the readme file for ios,mac,xcode spellings
* addressing reviewer comments
* fix analyse error
* fixing cleanup issue. solution: adding and await and using for loop instead of foreach
* runs ios unit tests, if the simulator is already booted.
* address reviewer comments
* changing comments for the Safari desktop tests
* addressing reviewer comments. removing the timeout.
* change mobile browsers ver name for safari.dart
* removing then calback on browser exit, only leaving the exception callback
* try to run integration tests on luci
* adds extra logs to check if chrome is on lUCI
* use the cipd chrome package for integration tests in LUCI
* add driver version for chrome 83.(cipd package has 83 now)
* no headless mode didn't worked on the bots. try the other option
* On LUCI also use chrome driver as a cipd package
* change the directory name to fit the cpid package
* adding blacklist functionality
* remove logs added for troubleshooting. remove the check that blocks int-test runs on LUCI
* add more comments to blacklists
* also use CIPD package chrome for unit tests
* addressing reviewer comments
* run integration tests first, upon reviewer request
* fix bug. keep running integration tests after unit tests
* update the logs for LUCI
* fix todo comments
* changes for getting the configuration
* running autofill
* simplifications, remove unused map
* more changes
* make single autofill fields work. remove print messages
* remove an extra line
* remove extra file. also update chrome version
* addressing reviewers comments
* addressing reviewer comments
* addressing reviewer comments
* addressing reviewer comments
* changing comments
* changing comments
* adding a comment on subscriptions lifecycle
* fixing a bug which was failing the existing unit tests
* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea
* add unit tests for method channels
* remove json from the end of the file
* do not change the input type for the focused element
* check name instead of autocomplete for firefox
* check name instead of autocomplete for firefox in other methods as well
* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values
* fix the breaking unit test
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test