DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,560 Commits 882 Branches 1,069 Tags
Commit Graph

24675 Commits

Author SHA1 Message Date
skia-flutter-autoroll
2487dc7a72 Roll Skia from 77aeee3b81a5 to 2b218381e226 (1 revision) (flutter/engine#47715) 
https://skia.googlesource.com/skia.git/+log/77aeee3b81a5..2b218381e226

2023-11-06 egdaniel@google.com Check for failed buffer creation before removing scratch key.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-06 21:14:16 +00:00
gaaclarke
441b71872c [Impeller] scales blur coverage to match rendered output (flutter/engine#47621) 
in pursuit of: https://github.com/flutter/flutter/issues/131580

I'm starting to write tests for the new blur, but I wanted to make tests for the old blur to make sure I understood the coverage rules.  I decided to check this in separately while I work on the other blur.

Even though the goal is to delete this class eventually.  Most of this work transfers over to the new blur.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-06 19:56:30 +00:00
Jonah Williams
f821ed1550 [Impeller] Fix EntityPassTarget::Flip with implict MSAA. (flutter/engine#47701) 
This allows backdrop filters to work with GLES and MSAA.

The swap implementation was only swapping out the resolve texture. But with implicit msaa resolve, the resolve texture and msaa texture are the same - so both need to be swapped.

Fixes https://github.com/flutter/flutter/issues/137301
 2023-11-06 18:56:07 +00:00
Jonah Williams
5d563c9e54 [Impeller] fix drawVertices dest fast path to apply alpha. (flutter/engine#47695) 
Part of https://github.com/flutter/flutter/issues/118914

When drawing vertices with a destination blend mode, we need to make sure to forward any alpha component. I introduced some test helpers to allow verification of recorded cmds without goldens.
 2023-11-06 16:26:04 +00:00
Zachary Anderson
2431498922 Move some Dart packages to //flutter/third_party/pkg (flutter/engine#47654) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-11-06 06:59:27 -08:00
Martin Kustermann
4455e224e9 Fix FFI-based tonic layer to use proper C++ static_cast<>()s (flutter/engine#47644) 
Flutter makes use of C++ multiple inheritence in it's C++ classes that
have corresponding Dart objects attached. An example is e.g.
```
  class Canvas : public RefCountedDartWrappable<Canvas>, DisplayListOpFlags { }

  template <typename T>
  class RefCountedDartWrappable : public fml::RefCountedThreadSafe<T>,
                                  public tonic::DartWrappable { }
```
When a C++ class has multiple base classes, the C++ compiler has the
liberty to decide the order in which they get layed out in memory. (It
doesn't necessarily follow declaration order, in fact it has a
preference for having classes with
vtables before classes without vtables.)

Two casts to consider (with multiple inheritance in mind):

* upcasts: Those are done by C++ automatically but can modify the actual
address (i.e. pointer value)

* downcasts: Those have to be done with `static_cast<>()`, which can
also modify the address (i.e. pointer value) - using
`reinterpret_cast<>()` is incorrect (as it doesn't modify the address)

Now the Dart objects that refer to C++ objects have a native field in
them. The value of that field is a `tonic::DartWrappable*`. That means
whenever we convert between the C++ object pointer (e.g.
`flutter::Canvas*`) and the value of the native field
(`tonic::Wrappable*`) the actual address / pointer may need
modification.

There were bugs in the C FFI based tonic layer: Pointer values coming
from Dart (via C FFI) are `dart::Wrappable*` and not pointers to
subtypes.

=> For methods we type the first parameter in tonic trampolines as
    `dart::Wrappable*` and `static_cast<Class*>()` that value

=> Similarly for arguments, the parameter has to be typed as
    `dart::Wrappable*` and `static_cast<Class*>()` that value

How did it ever work? Well it happens to be that the C++ compiler
decided to layout `tonic::DartWrappable` before
`fml::RefCountedThreadSafe`, making the `tonic::DartWrappable*` and the
`flutter::Canvas*` (and other classes) have the same pointer value.

=> This worked due to implementation choice of C++ compiler.
=> This breaks immediately if one decided to add another base class
(with virtual methods) to `RefCountedDartWrappable`
 2023-11-06 11:07:55 +01:00
skia-flutter-autoroll
04491eb694 Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47692) 
https://dart.googlesource.com/sdk.git/+log/b9ae53ac4663..96664852accc

2023-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-97.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-05 01:59:13 +00:00
auto-submit[bot]
5b54ce8022 Reverts "Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision)" (flutter/engine#47687) 
Reverts flutter/engine#47679
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:

https://dart.googlesource.com/sdk.git/+log/b9ae53ac4663..96664852accc

2023-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-97.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-04 17:26:17 +00:00
godofredoc
fa9ccec742 Fix symbols upload (flutter/engine#47669) 
There were a couple of issues with the script. The first one is it was always trying to upload the entire .buil_id folder rather than individual files and the second one is that it could not find depot_tools on path.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-04 16:25:24 +00:00
skia-flutter-autoroll
70a29048d8 Roll Fuchsia Linux SDK from 8tJt8KJzTzbwwQlUE... to SmJ_8HFjjm55T4ijL... (flutter/engine#47682) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-04 09:00:05 +00:00
skia-flutter-autoroll
de517972c0 Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47679) 
https://dart.googlesource.com/sdk.git/+log/b9ae53ac4663..96664852accc

2023-11-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-97.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-04 04:16:13 +00:00
Martin Kustermann
3a49ea0b85 Fix incorrect C++ return value of PictureRecorder::endRecording() (flutter/engine#47645) 
The Dart code has the following declaration:

```dart
  @Native<Void Function(Pointer<Void>, Handle)>(symbol: 'PictureRecorder::endRecording')
  external void _endRecording(_NativePicture outPicture);
```

=> Dart doesn't expect to get a return value, so C++ shouldn't return
anything.
 2023-11-03 23:44:19 +01:00
Jackson Gardner
9549a0fbe2 Bundle flutter.js via esbuild (flutter/engine#47573) 
* Roll esbuild as a CIPD package along with the browser roller. I renamed `browser_lock`/`browser_roller` etc to `package_lock` and `package_roller` since it will handle more than just browsers now.
* Download the esbuild CIPD package via DEPS.
* Have a build rule for running esbuild on some JavaScript or TypeScript
* Bundle and minify `flutter.js` using esbuild.
* Include in `flutter_web_sdk` the original `flutter.js` source, the minified `flutter.js`, and a sourcemap file to map between thnm.
* Also slightly changed the structure to put the `flutter.js` stuff in `flutter_web_sdk/flutter_js` instead of just at the root level of `flutter_web_sdk`. This should be fine because I haven't merged the change that has the flutter tool consume this yet.
 2023-11-03 20:24:29 +00:00
skia-flutter-autoroll
75f09ca525 Roll Fuchsia Linux SDK from ho9FqsUD0hxh0b8to... to 8tJt8KJzTzbwwQlUE... (flutter/engine#47666) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 20:14:55 +00:00
skia-flutter-autoroll
9ba21ec06d Roll Skia from c0ca9f2fd828 to 77aeee3b81a5 (1 revision) (flutter/engine#47663) 
https://skia.googlesource.com/skia.git/+log/c0ca9f2fd828..77aeee3b81a5

2023-11-03 jvanverth@google.com [graphite] Remove legacy quad rendering flag

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 19:15:11 +00:00
Jim Graham
1da6a8c854 [Impeller] Remove Rect field accesses from aiks subdirectory (flutter/engine#47628) 
These changes move any code in `impeller/aiks` that accessed the internal fields of `Rect` to using either the appropriate convenience methods for the operation or the getters for those properties.

This is a simple code refactoring and should be covered by existing tests.
 2023-11-03 19:09:42 +00:00
skia-flutter-autoroll
a52a8fe4a4 Roll Skia from ee6dbb4e2592 to c0ca9f2fd828 (1 revision) (flutter/engine#47660) 
https://skia.googlesource.com/skia.git/+log/ee6dbb4e2592..c0ca9f2fd828

2023-11-03 brianosman@google.com Fix SkRasterPipeline member function naming for coding style

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 18:17:05 +00:00
Zachary Anderson
8f629f2ee0 Move //third_party/benchmark to //flutter/third_party/benchmark (flutter/engine#47652) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.
 2023-11-03 10:59:49 -07:00
skia-flutter-autoroll
34921698ec Roll Skia from 75507da748f9 to ee6dbb4e2592 (1 revision) (flutter/engine#47659) 
https://skia.googlesource.com/skia.git/+log/75507da748f9..ee6dbb4e2592

2023-11-03 kjlubick@google.com Reland "Decouple SVG from SkFontMgr::RefDefault()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 17:22:08 +00:00
gaaclarke
28cab3b275 [Impeller] removed operator overload (c++ style violation) (flutter/engine#47658) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-03 17:22:05 +00:00
Jonah Williams
7ea3e185b0 [Impeller] add example of testing entity with "real" HAL instead of mocking. (flutter/engine#47631) 
As a response to my comments in https://github.com/flutter/engine/pull/47621
 2023-11-03 16:37:53 +00:00
skia-flutter-autoroll
c3e67f7f2b Roll Dart SDK from 3c45f68cd7c2 to 529fcd5bdffc (3 revisions) (flutter/engine#47655) 
https://dart.googlesource.com/sdk.git/+log/3c45f68cd7c2..529fcd5bdffc

2023-11-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-94.0.dev
2023-11-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-93.0.dev
2023-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-92.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 16:37:50 +00:00
Zachary Anderson
69ee734333 Reverts specialization constant PR and one change that used it (flutter/engine#47650) 
Reverts
e914c1d207
and
c8d04e64dc
 2023-11-03 09:03:01 -07:00
godofredoc
b816d9c61f Upload debug symbols in engine v2 fuchsia build. (flutter/engine#47626) 
This is the last missing piece to migrate fuchsia to engine v2 and will allow us to remove more of the old recipe versions.

Bug: https://github.com/flutter/flutter/issues/135189

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-03 16:01:54 +00:00
skia-flutter-autoroll
48c67b062a Roll Skia from b173066e6f15 to 75507da748f9 (2 revisions) (flutter/engine#47653) 
https://skia.googlesource.com/skia.git/+log/b173066e6f15..75507da748f9

2023-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f5ec22dbb9a4 to 122ddb782c61 (2 revisions)
2023-11-03 herb@google.com Find Segments that round to the same point

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 16:01:52 +00:00
skia-flutter-autoroll
eda533a0d0 Roll Skia from e5a6f9e79b0a to b173066e6f15 (1 revision) (flutter/engine#47648) 
https://skia.googlesource.com/skia.git/+log/e5a6f9e79b0a..b173066e6f15

2023-11-03 johnstiles@google.com Add placeholder files to skcms module.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 15:16:43 +00:00
Matej Knopp
b2eced8b39 Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099) 
This PR relands https://github.com/flutter/engine/pull/46829, which got
reverted in https://github.com/flutter/engine/pull/47086 because of
https://github.com/flutter/flutter/issues/136857.

There are no changes in the PR compared to the reverted one. The issue
are missing `keyup` events in the integration test, which triggers
assertion in `KeyboardBindings` and which should be fixed by
https://github.com/flutter/flutter/pull/136874.

Changes:
- Raw keyboard event is handled during capture phase. This is to ensure
that the framework processes the event before reaching to IME text area
and raw keyboard can stop the propagation for handled events.
- `RawKeyboard` event handler is invoked from `KeyboardBinding` event
handler. This is to prevent race condition because both handlers now run
in capture phase and `KeyboardBinding` needs to process the event first.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-03 15:50:40 +01:00
skia-flutter-autoroll
ef663bd741 Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 04:07:20 +00:00
skia-flutter-autoroll
ccd6910c4b Roll Skia from 5b6d295cc39b to 9f6022736b14 (1 revision) (flutter/engine#47633) 
https://skia.googlesource.com/skia.git/+log/5b6d295cc39b..9f6022736b14

2023-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 7c271ce5dd45 to d0d3db899486 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 02:16:16 +00:00
Jonah Williams
e914c1d207 [Impeller] Use specialization constant for blur pipelines decal feature. (flutter/engine#47617) 
Minor specialization constant cleanup
 2023-11-03 00:56:59 +00:00
skia-flutter-autoroll
da55f0c57d Roll Skia from 3b8e2b391d03 to 5b6d295cc39b (1 revision) (flutter/engine#47630) 
https://skia.googlesource.com/skia.git/+log/3b8e2b391d03..5b6d295cc39b

2023-11-02 bungeman@google.com Remove SkStream "synchronous" comment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-03 00:29:09 +00:00
skia-flutter-autoroll
51c27f95b9 Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627) 
https://skia.googlesource.com/skia.git/+log/86d15e651ae0..3b8e2b391d03

2023-11-02 lovisolo@google.com Upgrade Skia repository to Go 1.19.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 23:34:30 +00:00
LongCatIsLooong
ef6aba043c Reland "Expose more methods on ui.Paragraph: lines" (#47584) (flutter/engine#47623) 
The diff is in [this commit](305d930fe1).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 23:16:16 +00:00
Jim Graham
80a1a1d5ec [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592) 
The exposed Rect fields prevent future optimizations which will depend on changing the internal storage format.
 2023-11-02 22:00:58 +00:00
skia-flutter-autoroll
4c13e2a321 Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/e6df03a57636..3c45f68cd7c2

2023-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-91.0.dev
2023-11-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-90.0.dev
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-89.0.dev
2023-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-88.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 21:51:04 +00:00
skia-flutter-autoroll
cc61e6c8a6 Roll Skia from 66e06117294e to 86d15e651ae0 (1 revision) (flutter/engine#47619) 
https://skia.googlesource.com/skia.git/+log/66e06117294e..86d15e651ae0

2023-11-02 kjlubick@google.com Remove deprecated SkFontID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 21:38:48 +00:00
skia-flutter-autoroll
b860e7584d Roll Skia from 94000281b7d6 to 66e06117294e (1 revision) (flutter/engine#47616) 
https://skia.googlesource.com/skia.git/+log/94000281b7d6..66e06117294e

2023-11-02 johnstiles@google.com Fix fuzzer-discovered assertion with duplicate symbols.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 20:46:05 +00:00
skia-flutter-autoroll
6ffefaf1f0 Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614) 
https://skia.googlesource.com/skia.git/+log/306543797674..94000281b7d6

2023-11-02 lehoangquyen@chromium.org Graphite: calculate UBO/SSBO's binding size in DrawPass::writeUniforms.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 19:48:52 +00:00
godofredoc
835041d0ec Remove mirroring workflow from engine. (flutter/engine#47603) 
Master branch is about to be archived and there is no need to keep mirroring main branch to master.

Bug: https://github.com/flutter/flutter/issues/121564

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 18:59:26 +00:00
Alexander Thomas
c45478aba6 Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598) 
In https://dart-review.googlesource.com/c/sdk/+/332963, I'm merging the runtime/third_party directory into the SDK's top level third_party directory. This updates the script so that both the old and the new location are supported to avoid breaking the the rolls from Dart SDK to Flutter engine when the change above gets submitted.
 2023-11-02 18:49:01 +00:00
skia-flutter-autoroll
98d4718ee2 Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610) 
https://skia.googlesource.com/skia.git/+log/2b3472da9888..306543797674

2023-11-02 borenet@google.com [infra] Add alias for Go
2023-11-02 nicolettep@google.com [graphite] Small misc. comment doc fixes
2023-11-02 kjlubick@google.com Revert "Decouple SVG from SkFontMgr::RefDefault()"
2023-11-02 jvanverth@google.com [graphite] Simplify PerEdgeAAQuadRenderStep frag shader and varyings.
2023-11-02 johnstiles@google.com Treat non-side-effecting prefix expressions as trivial.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 18:46:41 +00:00
Victoria Ashworth
0f94842122 Run tests on either macOS 12 or 13 (flutter/engine#47606) 
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ

Note: I'm leaving subtests of `Linux linux_web_engine` on Mac-12 since they're currently incompatible with MacOS 13.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 18:37:10 +00:00
Dan Field
23b2847379 [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066) 
This removes skips for the golden tests in `//testing/dart/canvas_test.dart` and instead passes them up to Skia gold.

Adds a utility class for dealing with Skia gold from these tests, as well as the existing fuzzy identical image comparison for tests that just want to do in memory comparison of images generated from the same test.

Removes the old golden files that were in tree.

Part of https://github.com/flutter/flutter/issues/53784
 2023-11-02 17:48:28 +00:00
skia-flutter-autoroll
205f99e82f Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608) 
https://skia.googlesource.com/skia.git/+log/70634da5c783..2b3472da9888

2023-11-02 hitawala@chromium.org Graphite: Store wgpu::TextureAspect and create plane WGPUTextureView
2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 7096daca8739 to 7c271ce5dd45 (1 revision)
2023-11-02 briansalomon@gmail.com Make Graphite-Dawn compile against emsdk.
2023-11-02 kjlubick@google.com Add SkFontMgr to SkFontConfigInterface::makeTypeface
2023-11-02 kjlubick@google.com Revert "Remove modules/skplaintexteditor"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 17:45:49 +00:00
Jonah Williams
c8d04e64dc [Impeller] add support for specialization constants. (flutter/engine#47432) 
Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes https://github.com/flutter/flutter/issues/136210
Fixes https://github.com/flutter/flutter/issues/119357
 2023-11-02 17:32:08 +00:00
skia-flutter-autoroll
d6b5a87f11 Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604) 
https://skia.googlesource.com/skia.git/+log/8299245af8a8..70634da5c783

2023-11-02 johnstiles@google.com Use WGSL select for trivial ternary expressions only.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 16:50:02 +00:00
Victoria Ashworth
88bfe1a6da Fix race condition in Platform View Scenario tests (flutter/engine#47575) 
Fixes race condition in Platform View Scenario tests, see https://github.com/flutter/flutter/issues/126627 for description of issue.

Fixes https://github.com/flutter/flutter/issues/137547 and https://github.com/flutter/flutter/issues/126627.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-02 15:16:46 +00:00
skia-flutter-autoroll
936eb5a66e Roll Fuchsia Linux SDK from pvAbHwPJtOuEpHJN7... to YS7vrarYI-cHvhuBT... (flutter/engine#47602) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 15:09:02 +00:00
Jason Simmons
cd32fb6c82 Update DisplayList tests to explicitly select the Roboto font (flutter/engine#47493) 
Skia is removing the API for constructing a default typeface (see https://issues.skia.org/issues/305780908)

Fixes https://github.com/flutter/flutter/issues/137565
 2023-11-02 14:42:00 +00:00
skia-flutter-autoroll
2abeacb556 Roll Skia from 54be0f6f205b to 8299245af8a8 (2 revisions) (flutter/engine#47601) 
https://skia.googlesource.com/skia.git/+log/54be0f6f205b..8299245af8a8

2023-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2b199b522ce to c604e04c8136 (3 revisions)
2023-11-02 egdaniel@google.com [Graphite] Add query for resourceType to graphite Resources

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-02 14:34:56 +00:00